Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Fri, 21 May 2004, Tom Lane wrote: > Also, the new setup where the subject line is the first line of the > commit message seems cool to me, but if we're going to feed multiple > projects' commit messages into the same list then we'd better add the > project name to the subject. Done Marc

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Neil Conway
Marc G. Fournier wrote: Tom appears to be against, everyone else seems to be for ... should we try it and see how it works out? Sure, although I personally think Andrew's suggestion of creating a separate (non-archived) list that includes the full diff is the best solution. That satisfies both of

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Fri, 21 May 2004, Neil Conway wrote: > Marc G. Fournier wrote: > > Tom appears to be against, everyone else seems to be for ... should we try > > it and see how it works out? > > Sure, although I personally think Andrew's suggestion of creating a > separate (non-archived) list that includes the

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > I can enable the diff attachment for commit messages ... I just fear the > size of the email going out for some of the large patches that are applied That's my problem too. Someone suggested creating two mail lists, one non-archived with the full d

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Joe Conway wrote: > Marc G. Fournier wrote: > > On Thu, 20 May 2004, Bruce Momjian wrote: > >>My point is that for any non-trivial patch, you need to see all the > >>files modified in a single view, rather than poke around to see > >>different changes made to different files.

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Joe Conway
Marc G. Fournier wrote: On Thu, 20 May 2004, Bruce Momjian wrote: My point is that for any non-trivial patch, you need to see all the files modified in a single view, rather than poke around to see different changes made to different files. Tom appears to be against, everyone else seems to be for .

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Bruce Momjian wrote: > Andrew Dunstan wrote: > > >>Why would the URL only be temporarily valid? > > >> > > >> > > > > > >If Marc needed to save disk space or something. If we could > > >auto-generate on the fly via a URL, even better. > > > > > > > That's what cvsweb does ...

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Bruce Momjian
Andrew Dunstan wrote: > >>Why would the URL only be temporarily valid? > >> > >> > > > >If Marc needed to save disk space or something. If we could > >auto-generate on the fly via a URL, even better. > > > > That's what cvsweb does ... it will generate a diff between any 2 > arbitrary versio

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Christopher Kings-Lynne
'k, let me look into it when I get back ... but some of those diffs would be humongous, no? Ah well, let me look, I can try it out and if nobody likes it, can always disable the diffs again afterwards ... Showing diffs will also allow more eyes to find little bugs in the patches. Chris ---

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Neil Conway wrote: > Marc G. Fournier wrote: > > k, hasn't come through yet, but looked in the archives and the message > > looks good ... missed a / for cvsweb, so fixed that ... > > Looks good, but one minor quibble: the URL is to the cvsweb page for the > file in question,

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
Nope, was wrong ... adding the -V does add teh revision to the end of the URL ... On Thu, 20 May 2004, Marc G. Fournier wrote: > On Thu, 20 May 2004, Tom Lane wrote: > > > Neil Conway <[EMAIL PROTECTED]> writes: > > > Marc G. Fournier wrote: > > >> k, hasn't come through yet, but looked in the a

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > Marc G. Fournier wrote: > >> k, hasn't come through yet, but looked in the archives and the message > >> looks good ... missed a / for cvsweb, so fixed that ... > > > Looks good, but one minor quibble: the URL is to

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Marc G. Fournier wrote: >> k, hasn't come through yet, but looked in the archives and the message >> looks good ... missed a / for cvsweb, so fixed that ... > Looks good, but one minor quibble: the URL is to the cvsweb page for the > file in question, not

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Andrew Dunstan
Bruce Momjian wrote: Neil Conway wrote: Bruce Momjian wrote: Agreed, even if the URL is only valid for a week or so. Why would the URL only be temporarily valid? If Marc needed to save disk space or something. If we could auto-generate on the fly via a URL, even better. That's

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Neil Conway
Marc G. Fournier wrote: k, hasn't come through yet, but looked in the archives and the message looks good ... missed a / for cvsweb, so fixed that ... Looks good, but one minor quibble: the URL is to the cvsweb page for the file in question, not the diff for the change to the file described by th

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Alvaro Herrera
On Thu, May 20, 2004 at 06:07:15PM -0400, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > Personally I'd prefer the entire diff to be attached to each -committers > > mail, which would circumvent this problem. Would others find that > > objectionable? > > Yes --- way too bulky, not

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
k, hasn't come through yet, but looked in the archives and the message looks good ... missed a / for cvsweb, so fixed that ... the Subject line uses the first line of the log message (up to the first . or 72 characters, so the subjects can actually tell a message in itself if you build your log m

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Bruce Momjian wrote: > Neil Conway wrote: > > Bruce Momjian wrote: > > > Agreed, even if the URL is only valid for a week or so. > > > > Why would the URL only be temporarily valid? > > If Marc needed to save disk space or something. If we could > auto-generate on the fly via

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Bruce Momjian
Neil Conway wrote: > Bruce Momjian wrote: > > Agreed, even if the URL is only valid for a week or so. > > Why would the URL only be temporarily valid? If Marc needed to save disk space or something. If we could auto-generate on the fly via a URL, even better. -- Bruce Momjian

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Neil Conway
Bruce Momjian wrote: Agreed, even if the URL is only valid for a week or so. Why would the URL only be temporarily valid? -Neil ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Bruce Momjian
Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > Personally I'd prefer the entire diff to be attached to each -committers > > mail, which would circumvent this problem. Would others find that > > objectionable? > > Yes --- way too bulky, not to mention it turns the list archive into

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Personally I'd prefer the entire diff to be attached to each -committers > mail, which would circumvent this problem. Would others find that > objectionable? Yes --- way too bulky, not to mention it turns the list archive into a duplicate of the CVS stor

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Joe Conway
Neil Conway wrote: Personally I'd prefer the entire diff to be attached to each -committers mail, which would circumvent this problem. Would others find that objectionable? Not me -- I have often wished for exactly that myself. Joe ---(end of broadcast)

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Andrew Dunstan
Marc G. Fournier wrote: Personally I'd prefer the entire diff to be attached to each -committers mail, which would circumvent this problem. Would others find that objectionable? 'k, let me look into it when I get back ... but some of those diffs would be humongous, no? Ah well, let me look, I

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Neil Conway wrote: > Marc G. Fournier wrote: > > I can't see this really being possible ... have you seen this on another > > project? > > Sure, it's quite common. There's a list of scripts that support this > kind of functionality at the bottom of this page: > > http://www.ba

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Alvaro Herrera
On Thu, May 20, 2004 at 08:07:34PM +, Jon Jensen wrote: > On Thu, 20 May 2004, Neil Conway wrote: > > > Personally I'd prefer the entire diff to be attached to each -committers > > mail, which would circumvent this problem. Would others find that > > objectionable? > > I would really like t

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Jon Jensen
On Thu, 20 May 2004, Neil Conway wrote: > Personally I'd prefer the entire diff to be attached to each -committers > mail, which would circumvent this problem. Would others find that > objectionable? I would really like that. It'd be a lot easier to see what's going on. Jon --

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Neil Conway
Marc G. Fournier wrote: I can't see this really being possible ... have you seen this on another project? Sure, it's quite common. There's a list of scripts that support this kind of functionality at the bottom of this page: http://www.badgers-in-foil.co.uk/projects/cvsspam/ So there are plenty o

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Neil Conway wrote: > Tom Lane wrote: > > BTW, while you're messing with it, can you fix the random one-character > > lossage that so frequently happens in the list of file names? > > While we're asking for improvements to pgsql-committers, would it be > possible for you to mak

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Neil Conway
Tom Lane wrote: BTW, while you're messing with it, can you fix the random one-character lossage that so frequently happens in the list of file names? While we're asking for improvements to pgsql-committers, would it be possible for you to make it easier to view the "diff" for a particular CVS com

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Marc G. Fournier
On Thu, 20 May 2004, Tom Lane wrote: > "Marc G. Fournier" <[EMAIL PROTECTED]> writes: > > One of the comments I saw over the past few days on how to make things on > > pgFoundry more visible was to have the commit messages for its projects > > sent out through pgsql-committers as well ... > > > Ho

Re: [HACKERS] commit messages from gforge -> pgsql-committers

2004-05-20 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > One of the comments I saw over the past few days on how to make things on > pgFoundry more visible was to have the commit messages for its projects > sent out through pgsql-committers as well ... > How many objections would there be to setting this