Re: [HACKERS] dropdb/contrib-regression

2004-12-14 Thread Tom Lane
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > Tom Lane said: >> At the moment I think a "sleep" in the contrib makefile is sufficient >> (though note I intended to apply it only to installcheck not the other >> actions ;-)) > If you're going to make a separate rule for installcheck (which I agree

Re: [HACKERS] dropdb/contrib-regression

2004-12-13 Thread Andrew Dunstan
Tom Lane said: . > > At the moment I think a "sleep" in the contrib makefile is sufficient > (though note I intended to apply it only to installcheck not the other > actions ;-)) If you're going to make a separate rule for installcheck (which I agree is a good idea), please also consider making it

Re: [HACKERS] dropdb/contrib-regression

2004-12-13 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Mon, 2004-12-13 at 19:29 -0500, Tom Lane wrote: >> A more radical solution would be to tweak libpq's PQfinish() to be a >> synchronous close, > I can see this being useful in some situations, but I think the current > behavior is preferable for most cli

Re: [HACKERS] dropdb/contrib-regression

2004-12-13 Thread Neil Conway
On Mon, 2004-12-13 at 19:29 -0500, Tom Lane wrote: > A more radical solution would be to tweak libpq's PQfinish() to be a > synchronous close, ie, wait for the backend to exit before returning. > I think we've speculated about doing that in the past, but never been > fully convinced that it's worth

Re: [HACKERS] dropdb/contrib-regression

2004-12-13 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: I guess we could put a small sleep before dropdb in pg_regress.sh to I'd prefer to put it in contrib/Makefile's installcheck rule, so that we don't pay the price in contexts where it's not needed. tiny patch attached. For reaso

Re: [HACKERS] dropdb/contrib-regression

2004-12-13 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > We still seem to have occasional problems with dropdb while running > contrib installcheck. The symptoms look like this: I see this regularly on some platforms, and seldom/never on others. I've also seen it happen when scripting a tight loop around the