Re: [HACKERS] ecpg regression test failures caused by window functions patch

2008-12-29 Thread Michael Meskes
On Mon, Dec 29, 2008 at 11:39:16AM -0500, Tom Lane wrote: > I just tried that and it seems you'd need to make another couple of > changes --- the "fetch" test fails for instance, probably because > something somewhere isn't recognizing a fetch command. Actually this was a test that expected the bl

Re: [HACKERS] ecpg regression test failures caused by window functions patch

2008-12-29 Thread Tom Lane
Michael Meskes writes: > On Sun, Dec 28, 2008 at 03:21:16PM -0500, Tom Lane wrote: >> It strikes me that it might be a good idea to change cat2_str to not >> insert a space when obviously not necessary, perhaps along the lines >> of > Hey, good idea, will add this too. I just tried that and it s

Re: [HACKERS] ecpg regression test failures caused by window functions patch

2008-12-29 Thread Michael Meskes
[Sorry, have essantially be offline since yesterday. My server didn't ocme up again. Sight. ] On Sun, Dec 28, 2008 at 03:21:16PM -0500, Tom Lane wrote: > It hadn't occurred to me to try the ecpg tests before committing the > window functions patch :-(. It looks like those grammar additions have