Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-28 Thread Jan Wieck
Joshua D. Drake wrote: Hello, Don't know if my vote counts here, but ANYTHING that makes pg_dump more correct should be backpatched. It is one thing to have index bloat, it is entirely another to not be able to correctly backup and restore. Patch applied to REL7_3_STABLE. Jan Tom Lane wrote:

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-27 Thread Joshua D. Drake
Hello, Don't know if my vote counts here, but ANYTHING that makes pg_dump more correct should be backpatched. It is one thing to have index bloat, it is entirely another to not be able to correctly backup and restore. Also did you guys patch the create schema bug? I have a patch I can submit

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-27 Thread Tom Lane
Jan Wieck <[EMAIL PROTECTED]> writes: > I have more precisely defined "builtin" as "belongs to a schema who's > name starts with pg_", as that is how we distinguish what namespaces get > dumped in the first place. Check. > The patch is applied to 7.4 according to being a bug. The same patch >

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-27 Thread Jan Wieck
Tom Lane wrote: Jan Wieck <[EMAIL PROTECTED]> writes: That eliminated, a cast should be dumped if one or more of the three objects (source, target and function) are not builtin AND all the non-builtin objects belong to namespaces included in the dump. Where "builtin" is defined as "belongs to p

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-24 Thread Greg Stark
"Matthew T. O'Connor" <[EMAIL PROTECTED]> writes: > On Tue, 2003-09-23 at 22:40, Greg Stark wrote: > > [But then I'm not a fan of treating pg_dump files as if they were backups.] > > If you don't use pg_dump for backups what do you use? Stop the database > and copy the data directory? That is n

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-24 Thread Matthew T. O'Connor
On Tue, 2003-09-23 at 22:40, Greg Stark wrote: > [But then I'm not a fan of treating pg_dump files as if they were backups.] If you don't use pg_dump for backups what do you use? Stop the database and copy the data directory? That is not a valid choice for most people. -

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-23 Thread Greg Stark
Jan Wieck <[EMAIL PROTECTED]> writes: > braking the application with every dump+restore to remind the programmer > that there's still something he has to fix is the _right thing_. I would hate to be the sysadmin restoring a database after a hardware failure scratching my head to try to figure ou

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-23 Thread Tom Lane
Jan Wieck <[EMAIL PROTECTED]> writes: > That eliminated, a cast should be dumped if one or more of the three > objects (source, target and function) are not builtin AND all the > non-builtin objects belong to namespaces included in the dump. Where "builtin" is defined as "belongs to pg_catalog s

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-23 Thread Jan Wieck
Tom Lane wrote: Jan Wieck <[EMAIL PROTECTED]> writes: I classify this problem as a bug. Objections? The question is not whether it is a bug, the question is what is correct behavior instead. Not yet, but when we have a decision and a fix it'll be the criterium for applying it to 7.4 and maybe b

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

2003-09-23 Thread Tom Lane
Jan Wieck <[EMAIL PROTECTED]> writes: > I classify this problem as a bug. Objections? The question is not whether it is a bug, the question is what is correct behavior instead. > IMHO a binary compatible cast should be dumped if one or both namespaces > of the underlying data types is included i