Re: [HACKERS] pgmonitor patch for query string

2001-03-16 Thread Bruce Momjian
> > I don't understand the attraction of the UDP stuff. If we have the > > stuff in shared memory, we can add a collector program that gathers info > > from shared memory and allows others to access it, right? > > There are a couple of problems with shared memory. First you > have to de

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread Bruce Momjian
> > This doesn't tell you whether the query is still running, but ps tells you > > that. In fact, it might be an idea to add a logging option that prints > > something like "query finished in xxx ms". We actually have something > > similar hidden under show_query_stats, but the formatting needs

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread The Hermit Hacker
On Wed, 14 Mar 2001, Peter Eisentraut wrote: > Bruce Momjian writes: > > > It does this by creating a global variable 'debug_query_string' and > > assigning it when the query begins and clearing it when the query ends. > > You can find out the current query for a given backend by configuring the

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread Tom Lane
The Hermit Hacker <[EMAIL PROTECTED]> writes: > I'm saying no because it doesn't fix any known bugs, it *adds* another > feature ... we are *months* too late in the cycle for that ... I thought it was a pretty good idea even without any consideration for Bruce's monitor program. The advantage is

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread Peter Eisentraut
Bruce Momjian writes: > It does this by creating a global variable 'debug_query_string' and > assigning it when the query begins and clearing it when the query ends. You can find out the current query for a given backend by configuring the server with "debug_print_query on" and "log_pids on" and

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread Bruce Momjian
> Bruce Momjian writes: > > > It does this by creating a global variable 'debug_query_string' and > > assigning it when the query begins and clearing it when the query ends. > > You can find out the current query for a given backend by configuring the > server with "debug_print_query on" and "lo

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread Bruce Momjian
> On Wed, 14 Mar 2001, Bruce Momjian wrote: > > > > > > > not with me it isn't ... it doesn't fix a bug, it doesn't go in ... save > > > it for after v7.1 is released ... > > > > You are saying save it for 7.2, right? That will certainly be months > > away. Without this patch, pgmonitor's 'quer

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread The Hermit Hacker
On Wed, 14 Mar 2001, Bruce Momjian wrote: > > > > not with me it isn't ... it doesn't fix a bug, it doesn't go in ... save > > it for after v7.1 is released ... > > You are saying save it for 7.2, right? That will certainly be months > away. Without this patch, pgmonitor's 'query' button will o

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread Bruce Momjian
> > not with me it isn't ... it doesn't fix a bug, it doesn't go in ... save > it for after v7.1 is released ... You are saying save it for 7.2, right? That will certainly be months away. Without this patch, pgmonitor's 'query' button will only work if the postgres binary was compiled with deb

Re: [HACKERS] pgmonitor patch for query string

2001-03-14 Thread The Hermit Hacker
not with me it isn't ... it doesn't fix a bug, it doesn't go in ... save it for after v7.1 is released ... On Wed, 14 Mar 2001, Bruce Momjian wrote: > I would like to apply the following patch to the CVS tree. It allows > pgmonitor to show query strings even if the backend is not compiled wit