Peter Eisentraut writes:
> Right, we need to keep libpq in CPPFLAGS, but we can remove it from
> SHLIB_LINK.
Buildfarm member anole says otherwise. I suspected something like that
might happen --- if memory serves, there are platforms where you have to
list all required libraries on the link lin
Peter Eisentraut writes:
> So here is my updated patch, with the ecpg business changed as explained
> above, and the extra magic removed from the Cflags lines.
No objections to this version.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgr
On Wed, 2013-03-27 at 17:06 -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > On 3/24/13 1:55 PM, Tom Lane wrote:
> >> I experimented a bit with this version of the patch. The hunk that
> >> removes -I$(libpq_srcdir) and $(libpq) from the ecpg/compatlib build
> >> breaks the build for me, so
Peter Eisentraut writes:
> On 3/24/13 1:55 PM, Tom Lane wrote:
>> I experimented a bit with this version of the patch. The hunk that
>> removes -I$(libpq_srcdir) and $(libpq) from the ecpg/compatlib build
>> breaks the build for me, so I took it out.
> What was the error message? Probably not i
On 3/24/13 1:55 PM, Tom Lane wrote:
> I experimented a bit with this version of the patch. The hunk that
> removes -I$(libpq_srcdir) and $(libpq) from the ecpg/compatlib build
> breaks the build for me, so I took it out.
What was the error message? Probably not important, but curious.
> With th
Peter Eisentraut writes:
> On 1/15/13 6:53 PM, Tom Lane wrote:
>> This bit:
>>> + echo 'Libs.private: $(filter-out
>>> $(PKG_CONFIG_REQUIRES_PRIVATE:lib%=-l%),$(filter-out -L..%,
>>> $(SHLIB_LINK)))' >>$@
>> appears to assume that SHLIB_LINK contains nothing except -L and -l
>> switches.
> Up
On 1/15/13 6:53 PM, Tom Lane wrote:
> Peter Eisentraut writes:
>> I'll take another stab at providing pkg-config files for the client-side
>> libraries.
>
> This bit:
>
>> +echo 'Libs.private: $(filter-out
>> $(PKG_CONFIG_REQUIRES_PRIVATE:lib%=-l%),$(filter-out -L..%, $(SHLIB_LINK)))'
>> >
On Tue, Jan 15, 2013 at 02:16:01PM -0500, Peter Eisentraut wrote:
> A side issue that arose: libecpg_compat is linked with libpq, but
> doesn't seem to use it. This was added many years ago in
> cd75f94dafd43358305811b7576ad75d889097e3, but it doesn't appear to be
> required anymore. Needs some c
Peter Eisentraut writes:
> I'll take another stab at providing pkg-config files for the client-side
> libraries.
This bit:
> + echo 'Libs.private: $(filter-out
> $(PKG_CONFIG_REQUIRES_PRIVATE:lib%=-l%),$(filter-out -L..%, $(SHLIB_LINK)))'
> >>$@
appears to assume that SHLIB_LINK contains
