Re: [HACKERS] plpgsql is not translate-aware

2008-09-15 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Actually this is wrong -- since the library is going to run with postgres text domain, we need to add the files to the backend's nls.mk: Can't we give it its own text domain? It seems fundamentally wrong for a plug-in language to

Re: [HACKERS] plpgsql is not translate-aware

2008-09-15 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: Can't we give it its own text domain? It seems fundamentally wrong for a plug-in language to require core support for its messages. Another idea would be to redefine errmsg() and friends within the plpgsql sources, but that seems

Re: [HACKERS] plpgsql is not translate-aware

2008-09-05 Thread Alvaro Herrera
Alvaro Herrera wrote: It doesn't seem hard to add; I just had to create a nls.mk file and things seem ready to go. Obviously, we'll need to add plpgsql to the pgtranslation files in pgfoundry. Actually this is wrong -- since the library is going to run with postgres text domain, we need to

Re: [HACKERS] plpgsql is not translate-aware

2008-09-05 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: In reviewing Volkan Yazici's (sorry for the dots) patch to improve plpgsql's error messages, I noticed that we have no PO files for plpgsql at all! Ugh. Yeah, we should fix that. Does it actually just work, seeing that plpgsql is a loadable library?

Re: [HACKERS] plpgsql is not translate-aware

2008-09-05 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: In reviewing Volkan Yazici's (sorry for the dots) patch to improve plpgsql's error messages, I noticed that we have no PO files for plpgsql at all! Ugh. Yeah, we should fix that. Does it actually just work, seeing that plpgsql

Re: [HACKERS] plpgsql is not translate-aware

2008-09-05 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Actually this is wrong -- since the library is going to run with postgres text domain, we need to add the files to the backend's nls.mk: Can't we give it its own text domain? It seems fundamentally wrong for a plug-in language to require core support

Re: [HACKERS] plpgsql is not translate-aware

2008-09-05 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Actually this is wrong -- since the library is going to run with postgres text domain, we need to add the files to the backend's nls.mk: Can't we give it its own text domain? It seems fundamentally wrong for a plug-in language to

Re: [HACKERS] plpgsql is not translate-aware

2008-09-05 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: The vices in the error message are not the translator's fault: missing quotes and plpgsql instead of PL/pgSQL: It's been message style policy for quite some time to not quote the output of format_type. I think this is because format_type sometimes puts