Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-31 Thread Michael Paquier
On Sat, Apr 1, 2017 at 4:55 AM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Mar 31, 2017 at 3:31 PM, Andres Freund wrote: >>> Hm. Wonder if something like that shouldn't be backpatched - because >>> otherwise using postgres_fdw from an old server against a newer one will >>> do weird stuff.

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-31 Thread Tom Lane
Robert Haas writes: > On Fri, Mar 31, 2017 at 3:31 PM, Andres Freund wrote: >> Hm. Wonder if something like that shouldn't be backpatched - because >> otherwise using postgres_fdw from an old server against a newer one will >> do weird stuff. I don't know what kind of policy we've committed to >

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-31 Thread Robert Haas
On Fri, Mar 31, 2017 at 3:31 PM, Andres Freund wrote: >> Committed after rewording the documentation. > > Hm. Wonder if something like that shouldn't be backpatched - because > otherwise using postgres_fdw from an old server against a newer one will > do weird stuff. I don't know what kind of pol

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-31 Thread Andres Freund
On 2017-03-31 15:25:19 -0400, Robert Haas wrote: > On Fri, Mar 31, 2017 at 12:51 AM, Amit Langote > wrote: > > Thanks, no more comments from my side. > > Committed after rewording the documentation. Hm. Wonder if something like that shouldn't be backpatched - because otherwise using postgres_fdw

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-31 Thread Robert Haas
On Fri, Mar 31, 2017 at 12:51 AM, Amit Langote wrote: > Thanks, no more comments from my side. Committed after rewording the documentation. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-30 Thread Amit Langote
On 2017/03/31 13:46, Michael Paquier wrote: > On Fri, Mar 31, 2017 at 1:37 PM, Amit Langote > wrote: >> + >> +For partitioned tables, partitions are automatically excluded from the >> +schema data imported. Only the definition of partitioned tables is >> included >> +to give access

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-30 Thread Michael Paquier
On Fri, Mar 31, 2017 at 1:37 PM, Amit Langote wrote: > + > +For partitioned tables, partitions are automatically excluded from the > +schema data imported. Only the definition of partitioned tables is > included > +to give access to the full data set of all partitions present remote

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-30 Thread Amit Langote
On 2017/03/31 13:23, Michael Paquier wrote: > On Wed, Mar 29, 2017 at 12:30 PM, Michael Paquier > wrote: >> Users like things that are friendly, and we are most likely going to >> piss them off when using postgres_fdw if they need to list manually >> each parent table from the IMPORT FOREIGN SCHEM

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-30 Thread Michael Paquier
On Wed, Mar 29, 2017 at 12:30 PM, Michael Paquier wrote: > Users like things that are friendly, and we are most likely going to > piss them off when using postgres_fdw if they need to list manually > each parent table from the IMPORT FOREIGN SCHEMA command. > >> However, if we're going to do somet

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-28 Thread Michael Paquier
On Wed, Mar 29, 2017 at 12:22 PM, Robert Haas wrote: > On Thu, Mar 9, 2017 at 8:47 PM, Amit Langote > wrote: >>> It is not as straight-forward as it seems. A foreign table can be >>> defined as a child (use of PARTITION OF), but not as a parent (use >>> PARTITION BY), and IMPORT SCHEMA has to iss

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-28 Thread Robert Haas
On Thu, Mar 9, 2017 at 8:47 PM, Amit Langote wrote: >> It is not as straight-forward as it seems. A foreign table can be >> defined as a child (use of PARTITION OF), but not as a parent (use >> PARTITION BY), and IMPORT SCHEMA has to issue queries to create >> foreign tables. It seems to me that t

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-09 Thread Amit Langote
On 2017/03/10 10:26, Michael Paquier wrote: > On Thu, Mar 9, 2017 at 11:15 PM, Stephen Frost wrote: >> While reviewing Amit Langote's patch to handle partitioned tables >> properly in various contrib modules (mostly by throwing an error since >> things like pageinspect aren't going to work on the

Re: [HACKERS] postgres_fdw IMPORT SCHEMA and partitioned tables

2017-03-09 Thread Michael Paquier
On Thu, Mar 9, 2017 at 11:15 PM, Stephen Frost wrote: > While reviewing Amit Langote's patch to handle partitioned tables > properly in various contrib modules (mostly by throwing an error since > things like pageinspect aren't going to work on the empty 'parent' > table), I went looking through c