Re: [HACKERS] problems on Solaris

2015-06-24 Thread Robert Haas
On Wed, Jun 24, 2015 at 8:42 AM, Andres Freund wrote: > I'm wondering wether we should add a #warning to atomic.c if either the > fallback memory or compiler barrier is used? Might be annoying to people > using -Werror, but I doubt that's possible anyway on such old systems. #warning isn't totall

Re: [HACKERS] problems on Solaris

2015-06-24 Thread Andres Freund
On 2015-05-31 01:09:18 +0200, Andres Freund wrote: > On 2015-05-27 21:23:34 -0400, Robert Haas wrote: > > > Oh wow, that's bad, and could explain a couple of the problems we're > > > seing. One possible way to fix is to replace the sequence with if > > > (!TAS(spin)) S_UNLOCK();. But that'd mean TA

Re: [HACKERS] problems on Solaris

2015-06-01 Thread Andres Freund
On 2015-05-31 08:00:44 -0400, Robert Haas wrote: > On Sat, May 30, 2015 at 7:09 PM, Andres Freund wrote: > > On 2015-05-27 21:23:34 -0400, Robert Haas wrote: > >> > Oh wow, that's bad, and could explain a couple of the problems we're > >> > seing. One possible way to fix is to replace the sequence

Re: [HACKERS] problems on Solaris

2015-05-31 Thread Robert Haas
On Sat, May 30, 2015 at 7:09 PM, Andres Freund wrote: > On 2015-05-27 21:23:34 -0400, Robert Haas wrote: >> > Oh wow, that's bad, and could explain a couple of the problems we're >> > seing. One possible way to fix is to replace the sequence with if >> > (!TAS(spin)) S_UNLOCK();. But that'd mean T

Re: [HACKERS] problems on Solaris

2015-05-30 Thread Andres Freund
On 2015-05-27 21:23:34 -0400, Robert Haas wrote: > > Oh wow, that's bad, and could explain a couple of the problems we're > > seing. One possible way to fix is to replace the sequence with if > > (!TAS(spin)) S_UNLOCK();. But that'd mean TAS() has to be a barrier, > > even if the lock isn't free -

Re: [HACKERS] problems on Solaris

2015-05-27 Thread Robert Haas
On Wed, May 27, 2015 at 6:55 PM, Andres Freund wrote: > On 2015-05-27 15:39:14 -0400, Robert Haas wrote: >> On Mon, May 25, 2015 at 10:05 PM, Andres Freund wrote: >> > Hm. So we have a *occasional* stack size exceeded failure and an >> > occasional spinlock error in test_shm_mq. I'm inclined to t

Re: [HACKERS] problems on Solaris

2015-05-27 Thread Andres Freund
On 2015-05-27 15:39:14 -0400, Robert Haas wrote: > On Mon, May 25, 2015 at 10:05 PM, Andres Freund wrote: > > Hm. So we have a *occasional* stack size exceeded failure and an > > occasional spinlock error in test_shm_mq. I'm inclined to think that > > this is a shm_mq problem, and not a more gener

Re: [HACKERS] problems on Solaris

2015-05-27 Thread Robert Haas
On Mon, May 25, 2015 at 10:05 PM, Andres Freund wrote: > Hm. So we have a *occasional* stack size exceeded failure and an > occasional spinlock error in test_shm_mq. I'm inclined to think that > this is a shm_mq problem, and not a more general locking problem - it > seems likely, but not guarantee

Re: [HACKERS] problems on Solaris

2015-05-26 Thread Dave Page
On Mon, May 25, 2015 at 1:07 AM, Andres Freund wrote: > On 2015-05-24 19:44:37 -0400, Andrew Dunstan wrote: >> >> Buildfarm members casteroides and protosciurus have been having some >> problems that seem puzzling. These animals both run on the same machine, but >> with different compilers. >> >>

Re: [HACKERS] problems on Solaris

2015-05-25 Thread Andres Freund
On 2015-05-25 09:12:35 +0200, Stefan Kaltenbrunner wrote: > On 05/25/2015 03:17 AM, Andres Freund wrote: > > On 2015-05-24 21:01:54 -0400, Andrew Dunstan wrote: > >> Yes, but it wasn't running these tests until a few days ago when its > >> buildfarm software was upgraded. > > > > But barriers are

Re: [HACKERS] problems on Solaris

2015-05-25 Thread Stefan Kaltenbrunner
On 05/25/2015 03:17 AM, Andres Freund wrote: > On 2015-05-24 21:01:54 -0400, Andrew Dunstan wrote: >> Yes, but it wasn't running these tests until a few days ago when its >> buildfarm software was upgraded. > > But barriers are used in other places too... fwiw: spoonbill just failed in the same p

Re: [HACKERS] problems on Solaris

2015-05-24 Thread Andres Freund
On 2015-05-24 21:01:54 -0400, Andrew Dunstan wrote: > Yes, but it wasn't running these tests until a few days ago when its > buildfarm software was upgraded. But barriers are used in other places too... -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to you

Re: [HACKERS] problems on Solaris

2015-05-24 Thread Andrew Dunstan
On 05/24/2015 08:07 PM, Andres Freund wrote: On 2015-05-24 19:44:37 -0400, Andrew Dunstan wrote: Buildfarm members casteroides and protosciurus have been having some problems that seem puzzling. These animals both run on the same machine, but with different compilers. casteroides runs with the

Re: [HACKERS] problems on Solaris

2015-05-24 Thread Andres Freund
On 2015-05-24 19:44:37 -0400, Andrew Dunstan wrote: > > Buildfarm members casteroides and protosciurus have been having some > problems that seem puzzling. These animals both run on the same machine, but > with different compilers. > > casteroides runs with the Sun Studio 12 compiler, and has twi