Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread Tom Lane
Stefan Kaltenbrunner writes: > really? there are provisions withing genbki.pl that are supposed to > provide a proper error message(and would have likely helped to find the > issue in that case as well): > die "Version not specified or wrong format.\n" if !defined $major_version; > however due t

Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread Stefan Kaltenbrunner
Tom Lane wrote: John Naylor writes: Here's a fix. Sorry, I didn't realize it was ever called without a version number. It's not supposed to be. If it fails to put the correct version number into the .bki file, initdb will spit up. This is really a makefile bug, not genbki's fault. really?

Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread Tom Lane
John Naylor writes: > Here's a fix. Sorry, I didn't realize it was ever called without a > version number. It's not supposed to be. If it fails to put the correct version number into the .bki file, initdb will spit up. This is really a makefile bug, not genbki's fault.

Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread Tom Lane
Stefan Kaltenbrunner writes: > Tom Lane wrote: >> [ scratches head... ] "make dist" works for me. Can you get a >> trace indicating what command was used to call genbki.pl? > heh that's a nice one the snapshot generation script uses " > gmake -s VERSION=snapshot dist" and that leads to getting

Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread John Naylor
Here's a fix. Sorry, I didn't realize it was ever called without a version number. On Wed, Jan 6, 2010 at 11:18 AM, Stefan Kaltenbrunner > heh that's a nice one the snapshot generation script uses " > gmake -s VERSION=snapshot dist" and that leads to getting " > --set-version=snapshot" passed to g

Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread Stefan Kaltenbrunner
Tom Lane wrote: Stefan Kaltenbrunner writes: Looks like somebody broke the snapshot generation script again: [ scratches head... ] "make dist" works for me. Can you get a trace indicating what command was used to call genbki.pl? heh that's a nice one the snapshot generation script uses "

Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread Tom Lane
Stefan Kaltenbrunner writes: > Looks like somebody broke the snapshot generation script again: [ scratches head... ] "make dist" works for me. Can you get a trace indicating what command was used to call genbki.pl? regards, tom lane -- Sent via pgsql-hackers mailing l