Re: [HACKERS] split postmaster's checkDataDir to src/common

2013-08-28 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> What exactly is the argument for pushing this into 9.3? Since we >> are past rc1, we should treat that branch as released. If you wouldn't >> back-patch into all supported branches, you shouldn't be patching 9.3 >> either. > This is to fix the stats_t

Re: [HACKERS] split postmaster's checkDataDir to src/common

2013-08-28 Thread Alvaro Herrera
Tom Lane wrote: > What exactly is the argument for pushing this into 9.3? Since we > are past rc1, we should treat that branch as released. If you wouldn't > back-patch into all supported branches, you shouldn't be patching 9.3 > either. This is to fix the stats_temp_directory issue that the di

Re: [HACKERS] split postmaster's checkDataDir to src/common

2013-08-27 Thread Tom Lane
Alvaro Herrera writes: > Here's a patch to move src/port/pgcheckdir.c to src/common/checkdir.c > and add the shareable part of postmaster's current checkDataDir code > into it, as pg_check_dir_permissions. This is in the spirit of using it > in pgstat to check the directory defined by stats_temp_