Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-02 Thread Simon Riggs
On Sat, 2010-05-01 at 09:05 -0500, Jaime Casanova wrote: maybe we should be using the tables that exists in the regression database or adding hs_setup_primary in installcheck to prepare the regression database to run standbycheck in the standby server This can definitely use some improvement

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Simon Riggs
On Mon, 2010-04-26 at 02:45 -0500, Jaime Casanova wrote: On Mon, Apr 26, 2010 at 2:32 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: How many of the tests in the regular regression suite do anything useful when run against a standby server? They all have to set up a

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Jaime Casanova
On Sat, May 1, 2010 at 7:22 AM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-04-26 at 02:45 -0500, Jaime Casanova wrote: On Mon, Apr 26, 2010 at 2:32 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: How many of the tests in the regular regression suite do anything

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Simon Riggs
On Sat, 2010-05-01 at 09:05 -0500, Jaime Casanova wrote: maybe we should be using the tables that exists in the regression database or adding hs_setup_primary in installcheck to prepare the regression database to run standbycheck in the standby server That's part of the procedure already. We

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Sat, 2010-05-01 at 09:05 -0500, Jaime Casanova wrote: maybe we should be using the tables that exists in the regression database or adding hs_setup_primary in installcheck to prepare the regression database to run standbycheck in the standby server

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Simon Riggs
On Sat, 2010-05-01 at 12:37 -0400, Tom Lane wrote: Simon Riggs si...@2ndquadrant.com writes: On Sat, 2010-05-01 at 09:05 -0500, Jaime Casanova wrote: maybe we should be using the tables that exists in the regression database or adding hs_setup_primary in installcheck to prepare the

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Sat, 2010-05-01 at 12:37 -0400, Tom Lane wrote: Where is this test procedure documented? In src/test/regress/standby_schedule That's a good way to ensure nobody knows it's there :-( If you want users to run this, document it in cookbook fashion in

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-05-01 Thread Simon Riggs
On Sat, 2010-05-01 at 13:12 -0400, Tom Lane wrote: Simon Riggs si...@2ndquadrant.com writes: On Sat, 2010-05-01 at 12:37 -0400, Tom Lane wrote: Where is this test procedure documented? In src/test/regress/standby_schedule That's a good way to ensure nobody knows it's there :-( If

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-04-26 Thread Jaime Casanova
On Wed, Apr 14, 2010 at 9:16 AM, Jaime Casanova jcasa...@systemguards.com.ec wrote: On Sat, Apr 10, 2010 at 12:23 AM, Jaime Casanova jcasa...@systemguards.com.ec wrote: On Fri, Apr 9, 2010 at 3:39 PM, Jaime Casanova jcasa...@systemguards.com.ec wrote: i think make standbycheck needs a

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-04-26 Thread Heikki Linnakangas
Jaime Casanova wrote: On Wed, Apr 14, 2010 at 9:16 AM, Jaime Casanova jcasa...@systemguards.com.ec wrote: 3) it should execute the existing set of tests (the ones installcheck execute) but with a new set of expected results, that way we can be sure that what should be disallowed is disallowed

Re: [HACKERS] standbycheck was:(Re: [HACKERS] testing hot standby

2010-04-26 Thread Jaime Casanova
On Mon, Apr 26, 2010 at 2:32 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: How many of the tests in the regular regression suite do anything useful when run against a standby server? They all have to set up a bunch of objects before they run queries, so you just get a lot