Tom Lane wrote:
J Smith dark.panda+li...@gmail.com writes:
I've attached a patch against master for unaccent.c that uses swscanf
along with char2wchar and wchar2char instead of sscanf directly to
initialize the unaccent extension and it appears to fix the problem in
both the master and
Bruce Momjian br...@momjian.us writes:
Tom Lane wrote:
However, the bigger picture is that OS X's UTF8 locales are broken
through-and-through, and most of their other problems are not feasible
to work around.
If Apple's low-level code came from FreeBSD and NetBSD, how did they get
so
J Smith dark.panda+li...@gmail.com writes:
Alright, I wrote up another patch that uses strchr to parse out the
lines of the unaccent.rules file, foregoing sscanf completely.
Hopefully this looks a bit better than using swscanf.
I looked at this a bit and realized that sscanf is actually doing
On Nov7, 2011, at 17:46 , J Smith wrote:
On Mon, Nov 7, 2011 at 11:12 AM, Tom Lane t...@sss.pgh.pa.us wrote:
If OS X's UTF8 locales weren't so thoroughly broken (eg sorting does not
work), I might be tempted to try to do it that way, but I still fail
to see the point. After reviewing the code
On Mon, Nov 7, 2011 at 11:12 AM, Tom Lane t...@sss.pgh.pa.us wrote:
I looked at this a bit and realized that sscanf is actually doing a
couple of critical things for us, which are lost in translation when
doing it like this:
1. It ignores whitespace other than the dividing tab. If we don't
J Smith dark.panda+li...@gmail.com writes:
Anyways, lemme know if there's anything else I could help with or
could test and whatnot. Cheers.
If you have time to check that the patch I just committed fixes your
problem, it'd be worth doing. I did not test it on OS X ...
On Mon, Nov 7, 2011 at 11:59 AM, Tom Lane t...@sss.pgh.pa.us wrote:
If you have time to check that the patch I just committed fixes your
problem, it'd be worth doing. I did not test it on OS X ...
Looks good to me, thanks.
Would it even really be worth it to look into any of the other locale
J Smith dark.panda+li...@gmail.com writes:
Would it even really be worth it to look into any of the other locale
issues on OSX, given that PostgreSQL is now included in their default
installs starting with 10.7, or would this really be more of a case of
hoping Apple some day fixes the issue
On Mon, Nov 7, 2011 at 11:53 AM, Florian Pflug f...@phlo.org wrote:
Various issues with OSX and UTF-8 locales seems to come up quite often, yet
we're not really in a position to do anything about them.
Thus, I think we should warn about these issues and save people the trouble
of finding out
Gah! Accidentally hit Send. Let me finish that last message before
sending this time!
G'day list.
I've been messing around with the unaccent extension and I've noticed
that some of the characters listed in the unaccent.rules file aren't
actually being unaccented on my system.
Here are the
On Nov6, 2011, at 18:43 , J Smith wrote:
I put some elog debugging lines into unaccent.c and found that sscanf
sometimes reads the scanned line by finding only one byte for the for
the source character rather than the two required for the complete
UTF-8 code point. It appears that the
On Sun, Nov 6, 2011 at 1:18 PM, Florian Pflug f...@phlo.org wrote:
What's the locale of the database you're seeing this in, and which charset
does it use?
I think scanf() uses isspace() and friends, and last time I looked the
locale definitions where all pretty bogus on OSX. So maybe scanf()
J Smith dark.panda+li...@gmail.com writes:
I've attached a patch against master for unaccent.c that uses swscanf
along with char2wchar and wchar2char instead of sscanf directly to
initialize the unaccent extension and it appears to fix the problem in
both the master and 9.1 branches.
swscanf
On 2011-11-06, at 7:15 PM, Tom Lane t...@sss.pgh.pa.us wrote:
swscanf doesn't seem like an acceptable approach: it's a function that
is relied on nowhere else in PG, so it adds new portability risks of its
own. It doesn't exist on some platforms that we support (like the one
I'm typing this
Alright, I wrote up another patch that uses strchr to parse out the
lines of the unaccent.rules file, foregoing sscanf completely.
Hopefully this looks a bit better than using swscanf.
As for the other problems with isspace and such on OSX, it might be
worth looking at the python portability
15 matches
Mail list logo
