Re: [HACKERS] uninitialized values in revised prepared xact code

2014-10-24 Thread Heikki Linnakangas
On 10/24/2014 05:40 PM, Andres Freund wrote: On 2014-10-24 17:13:49 +0300, Heikki Linnakangas wrote: Yeah. The padding bytes in TwoPhaseFileHeader were not initialized. That's simple enough to fix, but when I run valgrind, I get a lot whole bunch of similar messages. A few are from pgstat: the

Re: [HACKERS] uninitialized values in revised prepared xact code

2014-10-24 Thread Andres Freund
On 2014-10-24 17:13:49 +0300, Heikki Linnakangas wrote: > Yeah. The padding bytes in TwoPhaseFileHeader were not initialized. > > That's simple enough to fix, but when I run valgrind, I get a lot whole > bunch of similar messages. A few are from pgstat: the padding bytes in the > pgstat messages a

Re: [HACKERS] uninitialized values in revised prepared xact code

2014-10-24 Thread Heikki Linnakangas
On 10/11/2014 10:20 PM, Bruce Momjian wrote: Uh, was this fixed. I see a cleanup commit for this C file, but this report is from June: commit 07a4a93a0e35a778c77ffbbbc18de29e859e18f0 Author: Heikki Linnakangas Date: Fri May 16 09:47:50 2014 +0300

Re: [HACKERS] uninitialized values in revised prepared xact code

2014-10-11 Thread Bruce Momjian
Uh, was this fixed. I see a cleanup commit for this C file, but this report is from June: commit 07a4a93a0e35a778c77ffbbbc18de29e859e18f0 Author: Heikki Linnakangas Date: Fri May 16 09:47:50 2014 +0300 Initialize tsId and dbId fields in WAL record