Re: [HACKERS] DBSize backend integration

2005-06-25 Thread Andreas Pflug
Dave Page wrote: -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: 24 June 2005 21:07 To: Dave Page Cc: PostgreSQL-development Subject: Re: [HACKERS] DBSize backend integration So drop total_relation_size(), relation_size_components(), and wh

Re: [HACKERS] pl/pgsql: END verbosity

2005-06-25 Thread Peter Eisentraut
Am Mittwoch, 22. Juni 2005 04:17 schrieb Neil Conway: > In PL/PgSQL, "END LOOP" is used to terminate loop blocks, and "END IF" > is used to terminate IF blocks. This is needlessly verbose: It is required by the SQL standard. ---(end of broadcast)---

Re: [HACKERS] DBSize backend integration

2005-06-25 Thread Bruce Momjian
Andreas Pflug wrote: > > > > > > > [from memory] the relation_components function adds components in a > questionable way, e.g. counting on index on the toast table as index. To > me, that's internal implementation detail, and should be counted as > toast table size too. Agreed. The user doe

Re: [HACKERS] #ifdef NOT_USED

2005-06-25 Thread Bruce Momjian
Jaime Casanova wrote: > Hi, i have found several #ifdef NOT_USED marked code... i guess this > is dead code... is safe to remove it? there is some reason you just > hide it and not remove the code? We keep such blocks of code around in case we might need to use it some day. It can be removed it t

Re: [HACKERS] get_rel_* functions in lsyscache.c

2005-06-25 Thread Tom Lane
Jaime Casanova <[EMAIL PROTECTED]> writes: > Hi, i have a doubt... > it seems to me that the get_rel_* functions in lsyscache do the same as doing > heap_open(); > Calling the appropiate macro Relation* > heap_close(); > is there any difference between them? in wich situation is one better > tha

[HACKERS] autovacuum bootstrap

2005-06-25 Thread Alvaro Herrera
Hackers, There's one problem with autovacuum and it's how to bootstrap it. My current approach is to connect to a default hardcoded database :-) so it has to be changed to be useful. I added two new fields to the pg_database flatfile and table, datstats and datautovac. They respectively signa

[HACKERS] Fundamental error in "no WAL log" index/file creation stuff

2005-06-25 Thread Tom Lane
I believe I have figured out the problem behind the recent reports we've been seeing of "index is not a btree" errors. Here's how to reproduce it (in 8.0 or HEAD): -- drop database test if present checkpoint; create database test; \c test create table t1 ( name varchar(20) primary key ); -- kill

Re: [HACKERS] autovacuum bootstrap

2005-06-25 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I added two new fields to the pg_database flatfile and table, datstats > and datautovac. They respectively signal the stat collector and > autovacuum daemon to run for that database. Why? I can't see a particularly good reason to be able to suppress t

Re: [HACKERS] autovacuum bootstrap

2005-06-25 Thread Alvaro Herrera
On Sat, Jun 25, 2005 at 03:52:08PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I added two new fields to the pg_database flatfile and table, datstats > > and datautovac. They respectively signal the stat collector and > > autovacuum daemon to run for that database. > >

Re: [HACKERS] Fundamental error in "no WAL log" index/file creation stuff

2005-06-25 Thread Tom Lane
I wrote: > It seems our choices are (a) somehow fix things so CREATE DATABASE > replay doesn't have to zap the whole directory, (b) force a checkpoint > immediately after any CREATE DATABASE, so that we never have to replay > one except in a PITR situation, or (c) abandon non-WAL-logged index > and

[HACKERS] Open items

2005-06-25 Thread Bruce Momjian
Here are the open items. Feature freeze is Friday, July 1. --- PostgreSQL 8.1 Open Items = Current version at http://candle.pha.pa.us/cg

Re: [HACKERS] Open items

2005-06-25 Thread Alvaro Herrera
On Sat, Jun 25, 2005 at 11:24:56PM -0400, Bruce Momjian wrote: > Changes > --- > integrated auto-vacuum (Alvaro) Working on it. > Roles? (Stephen Frost) Additionally, my shared dependencies patch :-) I'm not sure if I'll be able to do both autovacuum and shared dependencies before freeze,

Re: [HACKERS] Open items

2005-06-25 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: >> Roles? (Stephen Frost) > Additionally, my shared dependencies patch :-) I'm not sure if I'll be > able to do both autovacuum and shared dependencies before freeze, but > I'll try. I'm not sure if anybody is working on roles though; I'll try to finis

Re: [HACKERS] Fundamental error in "no WAL log" index/file creation stuff

2005-06-25 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > > (b) force a checkpoint > > immediately after any CREATE DATABASE, so that we never have to replay > > one except in a PITR situation So wouldn't this mean that any CREATE DATABASE won't work properly in PITR? -- greg ---(end of