[HACKERS] TODO questions

2005-08-24 Thread Jim C. Nasby
While marking up TODO for potential new-hacker items I've run across some items that probably need more explanation: o Allow commenting of variables in postgresql.conf to restore them to defaults This doesn't work already? * Allow triggers to be disabled [trigger] Isn't this going to

Re: [HACKERS] beginning hackers

2005-08-24 Thread Jim C. Nasby
On Mon, Aug 22, 2005 at 07:09:10PM -0400, Bruce Momjian wrote: Jim C. Nasby wrote: Can someone turn these items into a beginning hacker's TODO as has been discussed before? Or find a way to mark them on the main TODO? If someone wants to tell me how this should be done and give me

Re: [HACKERS] 8.1 release notes

2005-08-24 Thread Jim C. Nasby
On Wed, Aug 24, 2005 at 12:26:21AM -0400, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: Is the intention that standard_conforming_strings will always be read-only? For the moment it's read-only false; the long-term goal is that it will be read-only true. In between we will have

Re: [HACKERS] ECPG and escape strings

2005-08-24 Thread Michael Meskes
On Wed, Aug 03, 2005 at 08:31:25AM -0600, Michael Fuhr wrote: ECPG seems to be a little overzealous with the new escape string syntax: This comes from starting the string constant with ESCAPE_STRING_SYNTAX in case there is '\' inside the string. Actually I have no idea at the moment how that

Re: [HACKERS] beginning hackers

2005-08-24 Thread Meir Maor
IMHO (as a wanbe pgsql hacker) it is more important to mark tasks as suitable for beginners, if they do not require in depth knowledge of the pgsql codebase, and not according to how easy they are in other terms. for example If a task requires a significant amount of new non trivial code which

Re: VACUUM/t_ctid bug (was Re: [HACKERS] GiST concurrency commited)

2005-08-24 Thread Teodor Sigaev
Further I'm going to increase concurrency up to 12 parallel threads. All is ok, test is passed with approximatly 40 millions statements -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/

Re: [HACKERS] 8.1 release notes

2005-08-24 Thread Robert Treat
On Wednesday 24 August 2005 02:01, Jim C. Nasby wrote: On Wed, Aug 24, 2005 at 12:26:21AM -0400, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: Is the intention that standard_conforming_strings will always be read-only? For the moment it's read-only false; the long-term goal

Re: [HACKERS] Must be owner to truncate?

2005-08-24 Thread Manfred Koizar
On Wed, 24 Aug 2005 07:01:00 +0200, Andreas Seltenreich [EMAIL PROTECTED] wrote: However, a question arose quickly: According to the standard, revoking INSERT, UPDATE and DELETE after GRANT ALL PRIVILEGES would leave the relation read-only, but with the TRUNCATE privilege lying around, this would

Re: [HACKERS] Must be owner to truncate?

2005-08-24 Thread Stephen Frost
* Andreas Seltenreich ([EMAIL PROTECTED]) wrote: Bruce Momjian schrob: Added to TODO: * Add TRUNCATE permission Currently only the owner can TRUNCATE a table because triggers are not called, and the table is locked in exclusive mode. Is anyone working on this

Re: [HACKERS] Must be owner to truncate?

2005-08-24 Thread Stephen Frost
* Manfred Koizar ([EMAIL PROTECTED]) wrote: On Wed, 24 Aug 2005 07:01:00 +0200, Andreas Seltenreich [EMAIL PROTECTED] wrote: However, a question arose quickly: According to the standard, revoking INSERT, UPDATE and DELETE after GRANT ALL PRIVILEGES would leave the relation read-only, but with

Re: [HACKERS] ECPG and escape strings

2005-08-24 Thread Bruce Momjian
Michael Meskes wrote: On Wed, Aug 03, 2005 at 08:31:25AM -0600, Michael Fuhr wrote: ECPG seems to be a little overzealous with the new escape string syntax: This comes from starting the string constant with ESCAPE_STRING_SYNTAX in case there is '\' inside the string. Actually I have no idea

Re: [HACKERS] 8.1 release notes

2005-08-24 Thread Bruce Momjian
Robert Treat wrote: On Wednesday 24 August 2005 02:01, Jim C. Nasby wrote: On Wed, Aug 24, 2005 at 12:26:21AM -0400, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: Is the intention that standard_conforming_strings will always be read-only? For the moment it's read-only

Re: [HACKERS] Pre-allocated free space for row updating (like PCTFREE)

2005-08-24 Thread Satoshi Nagayasu
Satoshi Nagayasu wrote: Josh Berkus wrote: Satoshi, if you can package up a patch on current CVS, I'll throw it at DBT2. Ok. I'll do it. I've created a new patch which can be applied to the current cvs tree. http://dpsql.sourceforge.net/pctfree.cvs.diff -- NAGAYASU Satoshi [EMAIL

Re: [HACKERS] TODO questions

2005-08-24 Thread Bruce Momjian
Jim C. Nasby wrote: While marking up TODO for potential new-hacker items I've run across some items that probably need more explanation: o Allow commenting of variables in postgresql.conf to restore them to defaults This doesn't work already? The idea here is the when you

Re: [HACKERS] beginning hackers

2005-08-24 Thread Bruce Momjian
Thanks, added. I think numbering them is too complicated. --- Jim C. Nasby wrote: On Mon, Aug 22, 2005 at 07:09:10PM -0400, Bruce Momjian wrote: Jim C. Nasby wrote: Can someone turn these items into a beginning

Re: [HACKERS] TODO questions

2005-08-24 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The idea here is the when you comment something out, it should restore its default. Right now it keeps the previously uncommented out value, which confuses people. I think it will continue to confuse people. I will bring up the idea again here

[HACKERS] FYI: 8.1beta1 today

2005-08-24 Thread Tom Lane
Barring any unpleasant surprises, we'll wrap 8.1beta1 this evening (North American east coast time) and announce its availability tomorrow. There are still loose ends and open issues, of course, but nothing that looks like it will get in the way of general beta testing.

[HACKERS] Fwd: Re: [GENERAL] Where to get 8.1 beta test version?

2005-08-24 Thread Kevin Grittner
Per the notes for this list: If people in the other lists don't know the answer to a question and it is likely that only a developer will know the answer, you may re-post that question here. You must try elsewhere first! So here are my questions regarding 8.1. Anybody? ---BeginMessage---

Re: [HACKERS] CREATE USER and pg_user

2005-08-24 Thread William ZHANG
- Original Message - From: Jim C. Nasby [EMAIL PROTECTED] To: William ZHANG [EMAIL PROTECTED] Cc: pgsql-hackers@postgresql.org Sent: Wednesday, August 24, 2005 3:27 AM Subject: Re: [HACKERS] CREATE USER and pg_user skipped You should take a look at

Re: [HACKERS] TODO questions

2005-08-24 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Jim C. Nasby wrote: o Allow commenting of variables in postgresql.conf to restore them to defaults This doesn't work already? The idea here is the when you comment something out, it should restore its default. Right now it keeps the previously

Re: VACUUM/t_ctid bug (was Re: [HACKERS] GiST concurrency commited)

2005-08-24 Thread Hannu Krosing
On K, 2005-08-24 at 15:52 +0400, Teodor Sigaev wrote: Further I'm going to increase concurrency up to 12 parallel threads. All is ok, test is passed with approximatly 40 millions statements I have sent a patch to patches list enabling concurrent vacuums to actually reclaim space while

Re: [HACKERS] TODO questions

2005-08-24 Thread Joshua D. Drake
The idea here is the when you comment something out, it should restore its default. Right now it keeps the previously uncommented out value, which confuses people. But the contrary position is that a comment is a comment, not something that should act to change the state of the

[HACKERS] FreeBSD ICU was Win32 unicode vs ICU

2005-08-24 Thread Kevin McArthur
I was reviewing this thread about its lack of collation support in freebsd. As some of you may or may not know the PHP project is also currently working heavily on unicode support. (For PHP6) I had the chance to ask Andrei Zmievski of the php project about their support for unicode. The key

Re: [HACKERS] Sleep functions

2005-08-24 Thread Bruce Momjian
Added to TODO: o Add sleep() to PL/PgSQL --- Robert Treat wrote: On Monday 22 August 2005 11:53, Tom Lane wrote: Robert Treat [EMAIL PROTECTED] writes: On Aug 22, 2005, at 12:40 AM, Michael Fuhr wrote: To

Re: [HACKERS] Sleep functions

2005-08-24 Thread Bruce Momjian
Michael Fuhr wrote: On Wed, Aug 24, 2005 at 12:49:57PM -0400, Bruce Momjian wrote: Added to TODO: o Add sleep() to PL/PgSQL Just to PL/pgSQL? If we're going to add it (which doesn't seem to be decided yet), why not as an ordinary function that could be called from SQL as

Re: [HACKERS] Sleep functions

2005-08-24 Thread Michael Fuhr
On Wed, Aug 24, 2005 at 12:49:57PM -0400, Bruce Momjian wrote: Added to TODO: o Add sleep() to PL/PgSQL Just to PL/pgSQL? If we're going to add it (which doesn't seem to be decided yet), why not as an ordinary function that could be called from SQL as well? -- Michael Fuhr

Re: [HACKERS] TODO questions

2005-08-24 Thread Andrew Dunstan
Tom Lane wrote: But the contrary position is that a comment is a comment, not something that should act to change the state of the postmaster. I think that's a mis-statement of the issue, as I understand it, which seems to me to be this: Should the absence of an explicit setting in

Re: [HACKERS] TODO questions

2005-08-24 Thread Jeff Davis
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Jim C. Nasby wrote: o Allow commenting of variables in postgresql.conf to restore them to defaults This doesn't work already? The idea here is the when you comment something out, it should restore its default. Right now it

Re: [HACKERS] TODO questions

2005-08-24 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Bruce Momjian pgman@candle.pha.pa.us writes: The idea here is the when you comment something out, it should restore its default. Right now it keeps the previously uncommented out value, which confuses people. But the contrary position is that a

Re: [HACKERS] FreeBSD ICU was Win32 unicode vs ICU

2005-08-24 Thread John Hansen
Kevin McArthur Wrote: Should the postgresql project also be looking at CLDR for cross-platform unicode support? Afaict, from the ICU website, ICU too uses CLDR. Why reinvent the wheel? ... John ---(end of broadcast)--- TIP 1: if

Re: [HACKERS] TODO questions

2005-08-24 Thread Jim C. Nasby
On Wed, Aug 24, 2005 at 03:11:31PM -0400, Greg Stark wrote: In every other system I've seen, when you reload a config file the system goes through the exact same process (semantically at least) that it does when starting up. Ie, it start with a fresh slate of defaults and loads the config file

Re: [HACKERS] TODO questions

2005-08-24 Thread Bruce Momjian
OK, TODO updated: o %Allow commenting of variables in postgresql.conf to restore them to defaults Currently, if a variable is commented out, it keeps the previous uncommented value until a server restarted. Logically, a reload should set the same

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support IPv6 on Windows

2005-08-24 Thread Bruce Momjian
Context diff, please, diff -c. --- Chuck McDevitt wrote: I'm proposing this change to /src/port/getaddrinfo.c to support IPv6 under windows. 10a11,14 * Windows may or may not have these routines, so we handle

[HACKERS] Beta1 release notes

2005-08-24 Thread Bruce Momjian
I have updated the release notes to be current so they are ready for beta1. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.

Re: [HACKERS] TODO questions

2005-08-24 Thread Bruce Momjian
Robert Treat wrote: I've always been of the impression that this idea just wont work. For example, if I set shared_buffers to some number, start my database, then comment the line out and reload my conf file, it just isnt going to reset to the default. (Or at least to make it do so

Re: [HACKERS] TODO questions

2005-08-24 Thread Robert Treat
I've always been of the impression that this idea just wont work. For example, if I set shared_buffers to some number, start my database, then comment the line out and reload my conf file, it just isnt going to reset to the default. (Or at least to make it do so requires a *lot* more work than

Re: [HACKERS] TODO questions

2005-08-24 Thread Bruce Momjian
OK, additional sentence removed. --- Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: OK, TODO updated: o %Allow commenting of variables in postgresql.conf to restore them to defaults

Re: [HACKERS] static libperl?

2005-08-24 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Earlier today I noticed these lines in this buildfarm log http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=platypusdt=2005-08-16%2002:05:00 /usr/bin/ld: /usr/local/lib/perl5/5.6.1/mach/CORE/libperl.a(perl.o): relocation R_X86_64_32S can not be used

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Andrew Dunstan
Bruce Momjian wrote: Context diff, please, diff -c. It needed dos2unix and pgindent as well. Here's a cleaned patch. Thanks to Chuck for doing this work. cheers andrew *** src/port/getaddrinfo.c 2005-07-28 00:03:14.0 -0400 --- /home/andrew/getaddrinfo.c 2005-08-24

Re: [HACKERS] TODO questions

2005-08-24 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: OK, TODO updated: o %Allow commenting of variables in postgresql.conf to restore them to defaults Currently, if a variable is commented out, it keeps the previous uncommented value until a server restarted.

[HACKERS] Win32 Thread safetyness

2005-08-24 Thread Dave Page
Unfortunately I just found that we still cannot build in thread safety mode on Windows, due to an error on my part - specifically, I concentrated on libpq, not realising that ecpglib is also thread aware. It seems that ecpglib uses far more of pthreads than libpq does, so our mini implementation

Re: [HACKERS] TODO questions

2005-08-24 Thread Jim Nasby
-Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Wednesday, August 24, 2005 3:40 PM To: Robert Treat Cc: pgsql-hackers@postgresql.org; Jim Nasby; Greg Stark; Tom Lane Subject: Re: [HACKERS] TODO questions Robert Treat wrote: I've always been of the

Re: [HACKERS] TODO questions

2005-08-24 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: That all sounds nice, but unless you intend to fix all the constraints that force some values to be set-only-at-postmaster-start, it's never going to be possible to promise that a reload has the same effect as restarting the server. We could do this for

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Bruce Momjian
Does this fix IPv6 on Win32? --- Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Context diff, please, diff -c. It needed dos2unix and pgindent as well. Here's a cleaned patch. Thanks to Chuck for doing

Re: [HACKERS] Pre-allocated free space for row updating (like PCTFREE)

2005-08-24 Thread Josh Berkus
Satoshi, I've created a new patch which can be applied to the current cvs tree. http://dpsql.sourceforge.net/pctfree.cvs.diff Hmmm ... I don't see where I set the GUC. How am I supposed to vary the PCTFREE amount? -- --Josh Josh Berkus Aglio Database Solutions San Francisco

[HACKERS] Followup on the UnixWare Optimizer bug.

2005-08-24 Thread Larry Rosenman
The following is from my SCO Internal contact about the bug. It's definitely their bug. Towards the end of the Exact diagnosis, is a suggested work-around for now, as well as a (possible) memory leak. - Dave and I were convinced that the CSE optimization was correct and manufactured data

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Context diff, please, diff -c. It needed dos2unix and pgindent as well. Here's a cleaned patch. Thanks to Chuck for doing this work. Applied, thanks. regards, tom lane ---(end of

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Andrew Dunstan
Bruce Momjian said: OK, we need text for the release notes. What would it be? How about this?: . Support for connections over IPv6 on Windows platforms capable of it. (Chuck McDevitt, Petr Jelinek, Magnus Hagander, Andrew Dunstan). cheers andrew ---(end of

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Bruce Momjian
OK, we need text for the release notes. What would it be? --- Andrew Dunstan wrote: I believe so, yes, although I think that we should remove the HAVE_GETADDRINFO compile time test that Tom built into initdb.c the

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Andrew Dunstan
I believe so, yes, although I think that we should remove the HAVE_GETADDRINFO compile time test that Tom built into initdb.c the other day, so that it can fall through to this code. cheers andrew Bruce Momjian said: Does this fix IPv6 on Win32?

Re: [HACKERS] Stuff running slooow

2005-08-24 Thread Marc G. Fournier
tom pointed it out to me a little while ago ... am looking into why, but I'm also just finishing putting together a new server to speed things up some more yet ... On Wed, 24 Aug 2005, Jim C. Nasby wrote: Don't know if anyone else has noticed, but cvsweb is a bit slow right now and mailing

[HACKERS] TODO list comments

2005-08-24 Thread Tom Lane
I made a pass over the TODO list to see what was out of date. * Allow administrators to safely terminate individual sessions either via an SQL function or SIGTERM Currently SIGTERM of a backend can lead to lock table corruption. This comment may be out of date. Suggest Lock

Re: [HACKERS] TODO list comments

2005-08-24 Thread Kris Jurka
On Wed, 24 Aug 2005, Tom Lane wrote: * Fetch heap pages matching index entries in sequential order Rather than randomly accessing heap pages based on index entries, mark heap pages needing access in a bitmap and do the lookups in sequential order. Another method would be to sort heap

Re: [HACKERS] TODO list comments

2005-08-24 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: On Wed, 24 Aug 2005, Tom Lane wrote: This is done (see bitmap index scans). Will the optimizer ever choose this plan when dealing with only one index? Certainly. It's actually likely to prefer a bitmap scan whenever the query is estimated to fetch more

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Bruce Momjian
Thanks, added. --- Andrew Dunstan wrote: Bruce Momjian said: OK, we need text for the release notes. What would it be? How about this?: . Support for connections over IPv6 on Windows platforms capable of it.

Re: [HACKERS] [PATCHES] Proposed patch to getaddrinfo.c to support

2005-08-24 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I believe so, yes, although I think that we should remove the HAVE_GETADDRINFO compile time test that Tom built into initdb.c the other day, so that it can fall through to this code. Will do. BTW, when we are using getaddrinfo.c, is the gai_strerror

Re: [HACKERS] Followup on the UnixWare Optimizer bug.

2005-08-24 Thread Tom Lane
Larry Rosenman ler@lerctr.org forwards: Also note that there appears to be a memory leak in the interval_ routines. For example interval_div() allocates a result Interval. It eventually passes this result through to interval_justify_hours() which allocates another Interval result and that

Re: [HACKERS] TODO questions

2005-08-24 Thread Ron Mayer
Joshua D. Drake wrote: ...when you comment something out, it should restore ...the contrary position is that a comment is a comment... ...If I comment out a parameter I expect... The most unambiguous behavior would be to not have commented out values in the config file at all. If someone

Re: [HACKERS] Followup on the UnixWare Optimizer bug.

2005-08-24 Thread Tom Lane
Larry Rosenman ler@lerctr.org forwards: As I said, this will take us some time to work up the fix and revalidate the compiler. Since you have release coming up, I want to suggest the follow work-around for a Common Subexpression Elimination (CSE) bug in some compiler... Done. I think

Re: [HACKERS] TODO questions

2005-08-24 Thread Jim C. Nasby
On Wed, Aug 24, 2005 at 10:03:28PM -0700, Ron Mayer wrote: Joshua D. Drake wrote: ...when you comment something out, it should restore ...the contrary position is that a comment is a comment... ...If I comment out a parameter I expect... The most unambiguous behavior would be to not have

Re: [HACKERS] Stuff running slooow

2005-08-24 Thread Jim C. Nasby
Well, if hardware or bandwidth becomes an issue I suspect we could easily get donations to improve things. On Wed, Aug 24, 2005 at 10:39:23PM -0300, Marc G. Fournier wrote: tom pointed it out to me a little while ago ... am looking into why, but I'm also just finishing putting together a new

Re: [HACKERS] TODO questions

2005-08-24 Thread Tom Lane
Ron Mayer [EMAIL PROTECTED] writes: The most unambiguous behavior would be to not have commented out values in the config file at all. Yeah, Robert Treat suggested that upthread, and I think it's been pushed by others too. The only argument I can see against it is that it'll take longer for