Re: [HACKERS] [WIP] In-place upgrade

2008-11-06 Thread Greg Smith
On Thu, 6 Nov 2008, Tom Lane wrote: -Is it worth considering making CRCs an optional compile-time feature, and that (for now at least) you couldn't get them and the in-place upgrade at the same time? Hmm ... might be better than not offering them in 8.4 at all, but the thing is that then you a

Re: [HACKERS] Final /contrib cleanup -- yes/no?

2008-11-06 Thread Robert Treat
On Thursday 06 November 2008 17:35:58 Josh Berkus wrote: > Joshua D. Drake wrote: > > On Thu, 2008-11-06 at 17:24 -0500, Tom Lane wrote: > >> Josh Berkus <[EMAIL PROTECTED]> writes: > >>> The way the SQL scripts currently work, there is no way to manage what > >>> schema the contrib modules get bui

Re: [HACKERS] The suppress_redundant_updates_trigger() works incorrectly

2008-11-06 Thread KaiGai Kohei
Tom Lane wrote: > KaiGai Kohei <[EMAIL PROTECTED]> writes: >> However, I wonder if the oid field should be also preserved at same >> place, not inside a specific trigger function. > > Possibly. I wasn't planning to mess with it now; but if you've fixed > the other problems with assigning to a sys

Re: [HACKERS] array_length()

2008-11-06 Thread Robert Haas
>> There is a tiny problem with this implementation: It returns null for an >> empty array, not zero. This is because array_lower and/or array_upper >> return null for an empty array, which makes sense for those cases. We >> could fix this by putting a coalesce around the expression, but since >>

Re: [HACKERS] array_length()

2008-11-06 Thread Robert Haas
> Hmm... the problem is that an empty array is really zero-dimensional. > So for what values of the second argument ought we to return 0? > > It certainly seems inconsistent to say that array_length({}, 6) = 0 > and array_length({1}, 6) is null. Ugh. I meant rather: It certainly seems inconsiste

<    1   2