Tom Lane wrote:
This is not only really ugly, but 100% toast-specific. The
qualified-name approach (toast.autovacuum_enabled) has at least
a chance of being good for something else. Or just make it
toast_autovacuum_enabled and do the translation magic at some low
level in the statement
I wrote:
The good thing about using debug_query_string is that the current
client query is well-defined and easy to explain. I'm worried
whether using ActivePortal isn't likely to result in a rather
implementation-dependent behavior that changes from release to release.
In fact, it *is*
Tom Lane wrote:
Alvaro Herrera alvhe...@commandprompt.com writes:
Oh, the patch also removes a bunch of continue statements that, as far
as I can tell, no longer work after the macros were wrapped in
do { ... } while (0) :-( I don't see any nice way to put the facility
back.
Hmm ... I
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
Tom Lane wrote:
Well, hold on a minute. I said that was an alternative to look at,
not that it was necessarily better. Can you define in words of one
syllable which queries will be exposed this way? I don't believe
it's all of
Alvaro Herrera alvhe...@commandprompt.com writes:
Tom Lane wrote:
What you seem to be supposing is that the only possible use pattern
for these macros is a for-loop containing nothing but calls to one
or another of the macros.
You're right. I initially wrote these macros to reduce the
Andrew Dunstan and...@dunslane.net writes:
Now, we could decide that we always want to do a safe truncate in a
parallel restore (i.e. if we have created the table in the same
restore), even if archive_mode is on. Then this switch would be
redundant, and we might avoid some confusion. I'm
Added to TODO:
Improve CLUSTER performance by sorting to reduce random I/O
* http://archives.postgresql.org/pgsql-hackers/2008-08/msg01371.php
---
Gregory Stark wrote:
One thing that's been
Stephen Frost wrote:
KaiGai,
* KaiGai Kohei (kai...@ak.jp.nec.com) wrote:
Is it possible to implement a walker function to pick up appeared
columns and to chain them on rte-cols_sel/cols_mod?
In this idea, columns in Query-targetList should be chained on
rte-cols_mod, and others should be
Alvaro Herrera wrote:
Agreed, it seems better. The attached patch adds that, a macro you
originally requested and another one, and it also fixes an off-by-one
bug I discovered while testing all of this. I also attach the testing
patch I play with to check that this all works nicely.
| ***
Has this been completed? TODO item?
---
Lawrence, Ramon wrote:
From: Tom Lane [mailto:t...@sss.pgh.pa.us]
I was intending to do it the other way, actually. An extra field in
HashPath hardly costs anything. The
Uh, where are we on this? I see the same output in CVS HEAD as Heikki,
and I assume he thought at least one of them was wrong. ;-)
---
Heikki Linnakangas wrote:
Sushant Sinha wrote:
Patch #2. I think this is a straigt
KaiGai,
* KaiGai Kohei (kai...@ak.jp.nec.com) wrote:
In addition, please note that expression_tree_walker() invokes
check_stack_depth() to prevent unexpected stack overflow.
Ah, that's the part I was looking for and somehow overlooked. As long
as we're checking at some point then I worry alot
KaiGai Kohei wrote:
Could you deliver bool validate to the validate_string_relopt callback?
In this specification, invoked callback cannot know whether it should
really raise an error for invalid reloption, or not.
Hmm, would it be better to not call the validation callback at all if
validate
The default headline generation function is complicated. It checks a lot
of cases to determine the best headline to be displayed. So Heikki's
examples just say that headline generation function may not be very
intuitive. However, his examples were not affected by the bug.
Because of the bug,
Sushant Sinha wrote:
The default headline generation function is complicated. It checks a lot
of cases to determine the best headline to be displayed. So Heikki's
examples just say that headline generation function may not be very
intuitive. However, his examples were not affected by the bug.
Magnus Hagander mag...@hagander.net wrote:
ITAGAKI Takahiro wrote:
Ok, wcsftime() requries both LC_TIME and LC_CTYPE are the same setting
(at least encoding) on Windows.
Hmm. Is this actually cleaner than using the original method as
suggested? Because if I understand things right,
Alvaro Herrera wrote:
KaiGai Kohei wrote:
Could you deliver bool validate to the validate_string_relopt callback?
In this specification, invoked callback cannot know whether it should
really raise an error for invalid reloption, or not.
Hmm, would it be better to not call the validation
Is this a TODO?
---
Bjorn Munch wrote:
On 02/10 17.29, Peter Eisentraut wrote:
Tom Lane wrote:
I think the right fix would be to convert those .sql files to
input/*.source files and have pg_regress substitute the
I assume this is a TODO, right?
---
Tom Lane wrote:
I looked a bit at the bug report here:
http://archives.postgresql.org/pgsql-bugs/2008-09/msg00164.php
ISTM that the fundamental problem is that plpgsql doesn't
Brendan Jurd wrote:
On Thu, Jan 8, 2009 at 2:10 PM, Bruce Momjian br...@momjian.us wrote:
Brendan, did you ever complete this patch?
I didn't, no. I still intend on doing work in this area, but
obviously it will have to be in the 8.5 cycle.
OK, what is the TODO? It is more than AM/PM,
On Thu, Jan 8, 2009 at 2:10 PM, Bruce Momjian br...@momjian.us wrote:
Brendan, did you ever complete this patch?
I didn't, no. I still intend on doing work in this area, but
obviously it will have to be in the 8.5 cycle.
Cheers,
BJ
--
Sent via pgsql-hackers mailing list
Brendan Jurd wrote:
On Sat, Sep 27, 2008 at 4:08 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
However that still leaves the original complaint around (at least IMHO):
select to_timestamp('AN', 'AM');
ERROR: invalid AM/PM string
select
Jaime Casanova jcasa...@systemguards.com.ec writes:
what i still doesn't understand is why we need a third value at all?
There are cases for wanting all three.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
Has this been completed? TODO item?
I'd be more inclined to deal with the issue by trying to establish
a
safety margin in the estimate of whether the hash will go
multi-batch.
IOW we should disuse_physical_tlist if the hash is estimated to be
close to but still within one batch.
I
Bruce Momjian br...@momjian.us writes:
Is this a TODO?
I'm inclined to leave it as-is, at least till we get some field
feedback about how people want it to behave.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
Bruce Momjian br...@momjian.us writes:
I assume this is a TODO, right?
Yah.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Is this a TODO?
---
Tom Lane wrote:
[ back to the when-to-inline-WITHs discussion ]
Gregory Stark st...@enterprisedb.com writes:
Tom Lane wrote:
Any thoughts on what to do? One possibility is to flatten only
if
On Wed, Jan 7, 2009 at 5:46 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Bruce Momjian br...@momjian.us writes:
* Simon Riggs (si...@2ndquadrant.com) wrote:
I don't really understand this. Who can set up an inherited table
structure but can't remember to turn on constraint_exclusion?
This new
On Wed, Jan 7, 2009 at 1:46 AM, KaiGai Kohei kai...@ak.jp.nec.com wrote:
The attached patch is a proof of the concept.
It walks on a given query tree to append accessed columns on
rte-cols_sel and rte-cols_mod.
When aliasvar of JOIN'ed relation is accesses, its source is
appended on the
On Thu, Jan 8, 2009 at 2:20 PM, Bruce Momjian br...@momjian.us wrote:
OK, what is the TODO? It is more than AM/PM, right?
I see it happening in two stages.
Stage 1 is updating the AM/PM parse code to use the seq_search
technique, which may involve some minor refactoring around seq_search
Jaime Casanova wrote:
On Wed, Jan 7, 2009 at 1:46 AM, KaiGai Kohei kai...@ak.jp.nec.com wrote:
The attached patch is a proof of the concept.
It walks on a given query tree to append accessed columns on
rte-cols_sel and rte-cols_mod.
When aliasvar of JOIN'ed relation is accesses, its source is
Bruce Momjian wrote:
Sushant Sinha wrote:
The default headline generation function is complicated. It checks a lot
of cases to determine the best headline to be displayed. So Heikki's
examples just say that headline generation function may not be very
intuitive. However, his examples were not
101 - 132 of 132 matches
Mail list logo
