Re: [HACKERS] Synchronous replication

2010-07-25 Thread Fujii Masao
On Thu, Jul 22, 2010 at 5:37 PM, Yeb Havinga wrote: > Fujii Masao wrote: >> >> How should the synchronous replication behave when the number of connected >> standby servers is less than quorum? >> >> 1. Ignore quorum. The current patch adopts this. If the ACKs from all >>   connected standbys have

Re: [HACKERS] bg worker: overview

2010-07-25 Thread Markus Wanner
Hey Dimitri, On 07/24/2010 07:26 PM, Dimitri Fontaine wrote: Trying to figure out how it would fit the PGQ and pgagent needs. But maybe user defined daemons should be sub-coordinators (I used to think about them as "supervisors") able to talk to the coordinator to get a backend connected to some

Re: [HACKERS] multibyte-character aware support for function "downcase_truncate_identifier()"

2010-07-25 Thread Rajanikant Chirmade
Since discussion stopped in discussion thread http://archives.postgresql.org/pgsql-bugs/2006-09/msg00128.php Are there any implications of this change in handling identifiers ? Thanks & Regards, Rajanikant Chirmade On Tue, Jul 13, 2010 at 12:10 AM, Rajanikant Chirmade < rajanikant.chirm...@ente

Re: [HACKERS] patch (for 9.1) string functions

2010-07-25 Thread Pavel Stehule
2010/7/26 Itagaki Takahiro : > 2010/7/26 Pavel Stehule : >> sprintf has some issue based on common sprintf implementation and >> expecting too. For example a precision is used very dynamically - it >> has a different sense for integers and for floats, so I wouldn't have >> a sprintf in core. > > Wh

Re: [HACKERS] patch (for 9.1) string functions

2010-07-25 Thread Itagaki Takahiro
2010/7/26 Pavel Stehule : > sprintf has some issue based on common sprintf implementation and > expecting too. For example a precision is used very dynamically - it > has a different sense for integers and for floats, so I wouldn't have > a sprintf in core. Why do we need to have similar functions

Re: [HACKERS] patch (for 9.1) string functions

2010-07-25 Thread Pavel Stehule
2010/7/26 Itagaki Takahiro : > I merged and enhanced some part of your patch: >  - contrib/stringfunc are merged in the core patch >  - Old format() is replaced with sprintf(), but the function name is > still format(). >  - Support %q as alias for %iq. > > 2010/7/25 Pavel Stehule : >> fixed - it d

Re: [HACKERS] patch (for 9.1) string functions

2010-07-25 Thread Itagaki Takahiro
I merged and enhanced some part of your patch: - contrib/stringfunc are merged in the core patch - Old format() is replaced with sprintf(), but the function name is still format(). - Support %q as alias for %iq. 2010/7/25 Pavel Stehule : > fixed - it depends on INT64_FORMAT now. I modified the

Re: [HACKERS] TwoPO: experimental join order algorithm

2010-07-25 Thread Adriano Lange
Em 25-07-2010 19:17, Robert Haas escreveu: > On Sun, Jul 25, 2010 at 6:45 PM, Adriano Lange wrote: >> Yes, I know. This is only a notice, not a patch. >> As I said, this algorithm is experimental, which do not match with the >> CommitFest life cycle. > > It matches just fine - you just want a rev

Re: [HACKERS] Add column if not exists (CINE)

2010-07-25 Thread Robert Haas
On Thu, Jul 22, 2010 at 4:34 PM, Kjell Rune Skaaraas wrote: > At least from a performance point of view CINE should never cause a table > rewrite, it should either execute as a plain CREATE or as "nothing". I don't > mind if the CINE fails if the column already exists but with a different > def

Re: [HACKERS] Add column if not exists (CINE)

2010-07-25 Thread Robert Haas
On Fri, Jul 23, 2010 at 2:46 AM, Bernd Helmle wrote: > Yes, i agree. I would like to mark this patch "Ready for Committer", if > that's okay for you (since you are a committer you might want to commit it > yourself). I see that it is so marked, so, committed, with a minor correction to my origina

Re: [HACKERS] TwoPO: experimental join order algorithm

2010-07-25 Thread Robert Haas
On Sun, Jul 25, 2010 at 6:45 PM, Adriano Lange wrote: > Yes, I know. This is only a notice, not a patch. > As I said, this algorithm is experimental, which do not match with the > CommitFest life cycle. It matches just fine - you just want a review and some good feedback, rather than an actual co

Re: [HACKERS] non-overlapping, consecutive partitions

2010-07-25 Thread Robert Haas
On Sun, Jul 25, 2010 at 6:40 PM, Greg Stark wrote: > 2010/7/25 Robert Haas : >> 2010/7/25 PostgreSQL - Hans-Jürgen Schönig : >>> >>> On Jul 25, 2010, at 11:56 AM, Martijn van Oosterhout wrote: >>> I think the right way to approach this is to teach the planner about merge sorts. > > For w

Re: [HACKERS] TwoPO: experimental join order algorithm

2010-07-25 Thread Adriano Lange
Em 25-07-2010 17:44, Robert Haas escreveu: > On Sat, Jul 24, 2010 at 9:20 AM, Adriano Lange wrote: >> I'd like to release the last version of my experimental join order >> algorithm (TwoPO - Two Phase Optimization [1]): >> >> http://git.c3sl.ufpr.br/gitweb?p=lbd/ljqo.git;a=summary >> >> This algor

Re: [HACKERS] non-overlapping, consecutive partitions

2010-07-25 Thread Greg Stark
2010/7/25 Robert Haas : > 2010/7/25 PostgreSQL - Hans-Jürgen Schönig : >> >> On Jul 25, 2010, at 11:56 AM, Martijn van Oosterhout wrote: >> >>> I think the right way to approach this is to teach the planner about >>> merge sorts. For what it's worth I think this is a belt-and-suspenders type of si

Re: [HACKERS] TwoPO: experimental join order algorithm

2010-07-25 Thread Robert Haas
On Sat, Jul 24, 2010 at 9:20 AM, Adriano Lange wrote: > I'd like to release the last version of my experimental join order > algorithm (TwoPO - Two Phase Optimization [1]): > > http://git.c3sl.ufpr.br/gitweb?p=lbd/ljqo.git;a=summary > > This algorithm is not production-ready, but an experimental s

Re: [HACKERS] psql \timing output supressed in quiet mode

2010-07-25 Thread Robert Haas
On Sun, Jul 25, 2010 at 5:58 AM, Peter Eisentraut wrote: > In psql's quiet mode, the output of the \timing option is suppressed, > except in the \copy command.  That inconsistency should be fixed in any > case.  It seems to me that if I explicitly turn on timing, then that > should be unaffected b

Re: [HACKERS] gincostestimate

2010-07-25 Thread Jan Urbański
On 02/07/10 14:33, Teodor Sigaev wrote: > Patch implements much more accuracy estimation of cost for GIN index > scan than generic cost estimation function. Hi, I'm reviewing this patch, and to begin with it I tried to reproduce the problem that originally came up on -performance in http://archiv

Re: [HACKERS] non-overlapping, consecutive partitions

2010-07-25 Thread Robert Haas
2010/7/25 PostgreSQL - Hans-Jürgen Schönig : > > On Jul 25, 2010, at 11:56 AM, Martijn van Oosterhout wrote: > >> On Fri, Jul 23, 2010 at 10:04:00PM +0200, Hans-Jürgen Schönig wrote: >>>      create table foo ( x date ); >>>      create table foo_2010 () INHERITS (foo) >>>      create table foo_200

Re: [HACKERS] including backend ID in relpath of temp rels - updated patch

2010-07-25 Thread Robert Haas
On Sun, Jul 25, 2010 at 2:37 AM, Jaime Casanova wrote: > but i have a few questions, maybe is right what you did i only want to > understand it: > - you added this in include/storage/smgr.h, so why is safe to assume > that if the backend != InvalidBackendId it must be a temp relation? > > +#define

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-07-25 Thread Pavel Stehule
2010/7/25 Jan Urbański : > On 23/07/10 20:55, Pavel Stehule wrote: >> Hello >> >> 2010/7/23 Jan Urbański : >>> On 21/07/10 14:43, Pavel Stehule wrote: Hello I am sending a actualised patch. > > OK, thanks. This time the only thing I'm not happy about is the error > message from doing

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-07-25 Thread Jan Urbański
On 23/07/10 20:55, Pavel Stehule wrote: > Hello > > 2010/7/23 Jan Urbański : >> On 21/07/10 14:43, Pavel Stehule wrote: >>> Hello >>> >>> I am sending a actualised patch. OK, thanks. This time the only thing I'm not happy about is the error message from doing: \ef func 0 \e /etc/passwd xxx whic

Re: [HACKERS] [JDBC] Trouble with COPY IN

2010-07-25 Thread Kris Jurka
On Sat, 24 Jul 2010, James William Pye wrote: On Jul 23, 2010, at 7:11 AM, Tom Lane wrote: I can't help thinking that the JDBC driver must be being overly cute if this breaks it ... I was wondering the same thing when I first saw Kris' message. However, iff I understand what JDBC is trying

Re: [HACKERS] non-overlapping, consecutive partitions

2010-07-25 Thread PostgreSQL - Hans-Jürgen Schönig
On Jul 25, 2010, at 11:56 AM, Martijn van Oosterhout wrote: > On Fri, Jul 23, 2010 at 10:04:00PM +0200, Hans-Jürgen Schönig wrote: >> create table foo ( x date ); >> create table foo_2010 () INHERITS (foo) >> create table foo_2009 () INHERITS (foo) >> create table foo_2008 ()

[HACKERS] psql \timing output supressed in quiet mode

2010-07-25 Thread Peter Eisentraut
In psql's quiet mode, the output of the \timing option is suppressed, except in the \copy command. That inconsistency should be fixed in any case. It seems to me that if I explicitly turn on timing, then that should be unaffected by the quiet mode. Comments? -- Sent via pgsql-hackers mailing

Re: [HACKERS] non-overlapping, consecutive partitions

2010-07-25 Thread Martijn van Oosterhout
On Fri, Jul 23, 2010 at 10:04:00PM +0200, Hans-Jürgen Schönig wrote: > create table foo ( x date ); > create table foo_2010 () INHERITS (foo) > create table foo_2009 () INHERITS (foo) > create table foo_2008 () INHERITS (foo) > > now we add constraints to make sure that dat