Re: [HACKERS] W3C Specs: Web SQL

2010-11-10 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Nov 09, 2010 at 12:14:06PM -0800, Charles Pritchard wrote: [...] as it reflects the current state of security. Which is... well, I haven't a word for *that*. Regards - -- tomás -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6

Re: [HACKERS] TODO Alter Table Rename Constraint

2010-11-10 Thread Viktor Valy
Thanks for your answer! I'm not really familiar with inheritance, but I wonder how this issue is handled in other cases, for instance renaming an index, which invokes internal a constraint rename too. Is that relevant or is the renaming of constraints so special? Is there a solution for the

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Alvaro Herrera
Hmm, the second for loop in gseg_picksplit uses i maxoff whereas the other one uses =. The first is probably correct; if the second is also correct it merits a comment on the discrepancy (To be honest, I'd get rid of the -1 in computing maxoff and use in both places, given that offsets are

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Kevin Grittner
Peter Eisentraut wrote: On tis, 2010-11-09 at 14:00 -0800, David E. Wheeler wrote: I've been talking to Nasby and Dunstan about adding a Test::More/pgTAP-based test suite to the core. It wouldn't run with the usual core suite used by developers, which would continue to use pg_regress.

Re: [HACKERS] security hooks on object creation

2010-11-10 Thread KaiGai Kohei
(2010/11/10 13:06), Robert Haas wrote: In this patch, we put InvokeObjectAccessHook0 on the following functions. - heap_create_with_catalog() for relations/attributes - ATExecAddColumn() for attributes - NamespaceCreate() for schemas - ProcedureCreate() for aggregates/functions - TypeCreate()

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Alexander Korotkov
Hmm, the second for loop in gseg_picksplit uses i maxoff whereas the other one uses =. The first is probably correct; if the second is also correct it merits a comment on the discrepancy (To be honest, I'd get rid of the -1 in computing maxoff and use in both places, given that offsets

[HACKERS] ECPG question about PREPARE and EXECUTE

2010-11-10 Thread Boszormenyi Zoltan
Hi, a question came to us in the form of a code example, which I shortened. Say, we have this structure: EXEC SQL BEGIN DECLARE SECTION; struct t1 { int id; chart[80]; }; typedef struct t1 t1_t; t1_tt1; EXEC SQL END DECLARE SECTION;

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Alexander Korotkov
On Wed, Nov 10, 2010 at 4:53 PM, Alexander Korotkov aekorot...@gmail.comwrote: Hmm, the second for loop in gseg_picksplit uses i maxoff whereas the other one uses =. The first is probably correct; if the second is also correct it merits a comment on the discrepancy (To be honest, I'd get

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Yeb Havinga
On 2010-11-10 14:27, Alvaro Herrera wrote: Hmm, the second for loop in gseg_picksplit uses i maxoff whereas the other one uses=. The first is probably correct; if the second is also correct it merits a comment on the discrepancy (To be honest, I'd get rid of the -1 in computing maxoff and use

[HACKERS] Re: [COMMITTERS] pgsql: Don't unblock SIGQUIT in the SIGQUIT handler This was possibly

2010-11-10 Thread Fujii Masao
On Thu, Dec 17, 2009 at 8:05 AM, Peter Eisentraut pet...@postgresql.org wrote: Log Message: --- Don't unblock SIGQUIT in the SIGQUIT handler This was possibly linked to a deadlock-like situation in glibc syslog code invoked by the ereport call in quickdie().  In any case, a signal

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Alexander Korotkov
On Wed, Nov 10, 2010 at 5:37 PM, Yeb Havinga yebhavi...@gmail.com wrote: They are necessary and it is code untouched by this patch, and the same line occurs in other picksplit functions as well. The gbt_num_picksplit function shows that it can be avoided, by rewriting in the second loop

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Yeb Havinga
On 2010-11-10 15:46, Alexander Korotkov wrote: On Wed, Nov 10, 2010 at 5:37 PM, Yeb Havinga yebhavi...@gmail.com mailto:yebhavi...@gmail.com wrote: They are necessary and it is code untouched by this patch, and the same line occurs in other picksplit functions as well. The

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Alexander Korotkov
On Wed, Nov 10, 2010 at 6:05 PM, Yeb Havinga yebhavi...@gmail.com wrote: On 2010-11-10 15:46, Alexander Korotkov wrote: On Wed, Nov 10, 2010 at 5:37 PM, Yeb Havinga yebhavi...@gmail.com wrote: They are necessary and it is code untouched by this patch, and the same line occurs in other

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: On Wed, Nov 10, 2010 at 4:53 PM, Alexander Korotkov aekorot...@gmail.comwrote: Actually I can't understand the purpose of FirstOffsetNumber and OffsetNumberNext macros. For example, if we assume, that OffsetNumberNext can do something other

Re: [HACKERS] Fix for seg picksplit function

2010-11-10 Thread Yeb Havinga
On 2010-11-10 14:53, Alexander Korotkov wrote: Actually I can't understand the purpose of FirstOffsetNumber and OffsetNumberNext macros. When I wrote the patch I though about sortItems as about clean from all these strange things array, that's why I didn't use OffsetNumberNext there. :) I

Re: [HACKERS] improved parallel make support

2010-11-10 Thread Peter Eisentraut
On tis, 2010-11-09 at 03:54 -0800, Dave Page wrote: Narwhal should be OK now. The build has issues now, possibly related to the make upgrade. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread David E. Wheeler
On Nov 10, 2010, at 5:31 AM, Kevin Grittner wrote: For the Serializable Snapshot Isolation (SSI) patch I needed a test suite which would handle concurrent sessions which interleaved statements in predictable ways. I was told pgTAP wasn't a good choice for that and went with Markus Wanner's

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread David Fetter
On Wed, Nov 10, 2010 at 08:33:13AM -0800, David Wheeler wrote: On Nov 10, 2010, at 5:31 AM, Kevin Grittner wrote: For the Serializable Snapshot Isolation (SSI) patch I needed a test suite which would handle concurrent sessions which interleaved statements in predictable ways. I was told

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Andrew Dunstan
On 11/10/2010 08:31 AM, Kevin Grittner wrote: I don't know if dtester meets the other needs people have, or whether this is a complementary approach, but it seemed worth mentioning. Where is this available? Is it self-contained? And what does it require? cheers andrew -- Sent via

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread David E. Wheeler
On Nov 10, 2010, at 9:48 AM, Andrew Dunstan wrote: I don't know if dtester meets the other needs people have, or whether this is a complementary approach, but it seemed worth mentioning. Where is this available? Is it self-contained? And what does it require? Python.

Re: [HACKERS] security hooks on object creation

2010-11-10 Thread Robert Haas
On Wed, Nov 10, 2010 at 8:33 AM, KaiGai Kohei kai...@kaigai.gr.jp wrote: (2010/11/10 13:06), Robert Haas wrote: In this patch, we put InvokeObjectAccessHook0 on the following functions. - heap_create_with_catalog() for relations/attributes - ATExecAddColumn() for attributes -

Re: [HACKERS] improved parallel make support

2010-11-10 Thread Andrew Dunstan
On 11/10/2010 10:32 AM, Peter Eisentraut wrote: On tis, 2010-11-09 at 03:54 -0800, Dave Page wrote: Narwhal should be OK now. The build has issues now, possibly related to the make upgrade. Yeah, it's complaining about not finding bison, but configure managed to find bison just fine.

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Kevin Grittner
David E. Wheeler da...@kineticode.com wrote: On Nov 10, 2010, at 9:48 AM, Andrew Dunstan wrote: Where is this available? Is it self-contained? And what does it require? Python. And some optional python packages, like twisted. http://www.bluegap.ch/projects/dtester/ It looks like I

Re: [HACKERS] B-tree parent pointer and checkpoints

2010-11-10 Thread Heikki Linnakangas
On 08.11.2010 15:40, Heikki Linnakangas wrote: Here's a first draft of this, using the inCommit flag as is. It works, but suffers from starvation if you have a lot of concurrent multi-WAL-record actions. I tested that by running INSERTs to a table with tsvector field with a GiST index on it from

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Marti Raudsepp
On Wed, Nov 10, 2010 at 15:31, Kevin Grittner kevin.gritt...@wicourts.gov wrote: For the Serializable Snapshot Isolation (SSI) patch I needed a test suite which would handle concurrent sessions which interleaved statements in predictable ways.  I was told pgTAP wasn't a good choice for that

Re: [HACKERS] TODO Alter Table Rename Constraint

2010-11-10 Thread Robert Haas
On Wed, Nov 10, 2010 at 6:32 AM, Viktor Valy vili0...@gmail.com wrote: Thanks for your answer! I'm not really familiar with inheritance, but I wonder how this issue is handled in other cases, for instance renaming an index, which invokes internal a constraint rename too. Is that relevant or is

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Markus Wanner
Hi, On 11/10/2010 07:28 PM, Kevin Grittner wrote: It looks like I may have raised the issue at a particularly inopportune time -- it looks like maybe Markus is reloading his git repo based on the new official git repo for PostgreSQL. Thanks for noticing me. The dtester repository should be

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Peter Eisentraut
On ons, 2010-11-10 at 07:31 -0600, Kevin Grittner wrote: I don't know if dtester meets the other needs people have, or whether this is a complementary approach, but it seemed worth mentioning. The right tool for the right job, I'd say. One thing to aim for, perhaps, would be to make all tools

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Kevin Grittner
Marti Raudsepp ma...@juffo.org wrote: Sounds like you could use pgTAP with dblink to do the same? :) I had never read through the docs for dblink until you posted this. In fact, it appears that some testing of proper SSI behavior can be added to standard regression tests with dblink (without

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Andrew Dunstan
On 11/10/2010 05:06 PM, Kevin Grittner wrote: Marti Raudseppma...@juffo.org wrote: Sounds like you could use pgTAP with dblink to do the same? :) I had never read through the docs for dblink until you posted this. In fact, it appears that some testing of proper SSI behavior can be added

Re: [HACKERS] B-tree parent pointer and checkpoints

2010-11-10 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: The new rule is that before you start a multi-WAL-record operation that needs to be completed at end of recovery if you crash in the middle, you call HoldCheckpoint(), and once you're finished, ResumeCheckpoint(). What happens

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread David E. Wheeler
On Nov 10, 2010, at 2:15 PM, Andrew Dunstan wrote: We already use some contrib stuff in the regression tests. (It really is time we stopped calling it contrib.) Call them core extensions. Works well considering Dimitri's work, which explicitly makes them extensions. So maybe change the

Re: [HACKERS] security hooks on object creation

2010-11-10 Thread KaiGai Kohei
(2010/11/11 3:00), Robert Haas wrote: On Wed, Nov 10, 2010 at 8:33 AM, KaiGai Koheikai...@kaigai.gr.jp wrote: (2010/11/10 13:06), Robert Haas wrote: In this patch, we put InvokeObjectAccessHook0 on the following functions. - heap_create_with_catalog() for relations/attributes -

Re: [HACKERS] B-tree parent pointer and checkpoints

2010-11-10 Thread Tom Lane
I wrote: What happens if you error out in between? Or is it assumed that the *entire* sequence is a critical section? If it has to be that way, one might wonder what's the point of trying to split it into multiple WAL records. Or, to be more concrete: I'm wondering if this *entire*

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Nov 10, 2010, at 2:15 PM, Andrew Dunstan wrote: We already use some contrib stuff in the regression tests. (It really is time we stopped calling it contrib.) Call them core extensions. Works well considering Dimitri's work, which explicitly

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread David E. Wheeler
On Nov 10, 2010, at 3:17 PM, Tom Lane wrote: We've been calling it contrib for a dozen years, so that name is pretty well baked in by now. IMO renaming it is pointless and will accomplish little beyond creating confusion and making back-patches harder. *Shrug*. Just change the name in the

Re: [HACKERS] renaming contrib. (was multi-platform, multi-locale regression tests)

2010-11-10 Thread Andrew Dunstan
On 11/10/2010 06:17 PM, Tom Lane wrote: David E. Wheelerda...@kineticode.com writes: On Nov 10, 2010, at 2:15 PM, Andrew Dunstan wrote: We already use some contrib stuff in the regression tests. (It really is time we stopped calling it contrib.) Call them core extensions. Works well

Re: [HACKERS] multi-platform, multi-locale regression tests

2010-11-10 Thread Robert Haas
On Wed, Nov 10, 2010 at 6:39 PM, David E. Wheeler da...@kineticode.com wrote: On Nov 10, 2010, at 3:17 PM, Tom Lane wrote: We've been calling it contrib for a dozen years, so that name is pretty well baked in by now.  IMO renaming it is pointless and will accomplish little beyond creating

Re: [HACKERS] renaming contrib. (was multi-platform, multi-locale regression tests)

2010-11-10 Thread Robert Haas
On Wed, Nov 10, 2010 at 8:05 PM, Andrew Dunstan and...@dunslane.net wrote: On 11/10/2010 07:51 PM, Robert Haas wrote: On Wed, Nov 10, 2010 at 7:01 PM, Andrew Dunstanand...@dunslane.net  wrote: The current name causes constant confusion. It's a significant misnomer, and leads people to

Re: [HACKERS] Which file does the SELECT?

2010-11-10 Thread Vaibhav Kaushal
Yeah that is what seems to be the best way. The thing is that I am looking in the PostgreSQL code for the first time and I am not fully aware of the data structures or the methods / algos implemented in the project. This makes the work of finding out whats and whys much more difficult. So I asked

[HACKERS] wCTE behaviour

2010-11-10 Thread Marko Tiikkaja
Hi all, The discussion around wCTE during the last week or so has brought to my attention that we don't actually have a consensus on how exactly wCTEs should behave. The question seems to be whether or not a statement should see the modifications of statements ran before it. While I think

Re: [HACKERS] renaming contrib. (was multi-platform, multi-locale regression tests)

2010-11-10 Thread Andrew Dunstan
On 11/10/2010 07:51 PM, Robert Haas wrote: On Wed, Nov 10, 2010 at 7:01 PM, Andrew Dunstanand...@dunslane.net wrote: The current name causes constant confusion. It's a significant misnomer, and leads people to distrust the code. There might be reasons not to change, but you should at least

Re: [HACKERS] renaming contrib. (was multi-platform, multi-locale regression tests)

2010-11-10 Thread Robert Haas
On Wed, Nov 10, 2010 at 7:01 PM, Andrew Dunstan and...@dunslane.net wrote: The current name causes constant confusion. It's a significant misnomer, and leads people to distrust the code. There might be reasons not to change, but you should at least recognize why the suggestion is being made.

Re: [HACKERS] Exposing an installation's default value of unix_socket_directory

2010-11-10 Thread Peter Eisentraut
On tor, 2010-10-21 at 16:59 -0400, Tom Lane wrote: Actually, the only reason this is even up for discussion is that there's no configure option to set DEFAULT_PGSOCKET_DIR. If there were, and debian were using it, then pg_config --configure would tell what I wish to know. I thought for a