Re: [HACKERS] ALTER TABLE ... REPLACE WITH

2010-12-14 Thread Josh Berkus
I have; the above would hold the lock window open while the SELECT runs and that is explicitly something we are trying to avoid. Not necessarily. You could copy into a temp table first, and then swap. -- -- Josh Berkus

Re: [HACKERS] Per-column collation

2010-12-14 Thread Robert Haas
On Sun, Dec 12, 2010 at 5:15 PM, Peter Eisentraut pete...@gmx.net wrote: On lör, 2010-12-04 at 18:04 +0200, Peter Eisentraut wrote: Here is an updated patch to address the issues discussed during this commitfest. And another one, that fixes the problems pointed out since. I don't really have

Re: [HACKERS] pg_execute_from_file, patch v10

2010-12-14 Thread Itagaki Takahiro
On Wed, Dec 15, 2010 at 03:42, Robert Haas robertmh...@gmail.com wrote: I think #2 might be a nice thing to have, but I'm not sure what it has to do with extensions. Agreed.  There might be some use for #4 in connection with extensions, but I don't see that #2 is related. BTW, it appears to

Re: [HACKERS] pg_execute_from_file, patch v10

2010-12-14 Thread Robert Haas
On Tue, Dec 14, 2010 at 9:25 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Wed, Dec 15, 2010 at 03:42, Robert Haas robertmh...@gmail.com wrote: I think #2 might be a nice thing to have, but I'm not sure what it has to do with extensions. Agreed.  There might be some use for #4 in

Re: [HACKERS] CommitFest wrap-up

2010-12-14 Thread Robert Haas
On Mon, Dec 13, 2010 at 12:37 PM, Robert Haas robertmh...@gmail.com wrote: - fix for seg picksplit function - I don't have confidence this change is for the best and can't take responsibility for it. It needs review by a committer who understands this stuff better than me and can determine

Re: [HACKERS] pg_execute_from_file, patch v10

2010-12-14 Thread Itagaki Takahiro
On Wed, Dec 15, 2010 at 12:20, Robert Haas robertmh...@gmail.com wrote: It seems like pg_read_binary_file() is good to have regardless of whatever else we decide to do here.  Should we pull that part out and commit it separately? OK, I'll do that, but I have some questions: #1 Should we add

Re: [HACKERS] Getting ERROR: no unpinned buffers available on HEAD, should I investigate?

2010-12-14 Thread Alvaro Herrera
Excerpts from Florian Pflug's message of mar dic 14 21:51:47 -0300 2010: Hi When I run my FK concurrency test suite on an unpatched HEAD, I'm getting quite a lot of no unpinned buffers available errors. Increasing shared_buffers from 32MB (the default) to 64MB makes the errors go away,

[HACKERS] bug in SignalSomeChildren

2010-12-14 Thread Fujii Masao
Hi, I found a bug which always prevents SignalSomeChildren with BACKEND_TYPE_WALSND from sending a signal to walsender. Though currently SignalSomeChildren with BACKEND_TYPE_WALSND has not been called anywhere, it's not hard to believe that will be called in the future. So we should apply the

Re: [HACKERS] pg_execute_from_file, patch v10

2010-12-14 Thread Robert Haas
On Tue, Dec 14, 2010 at 10:43 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Wed, Dec 15, 2010 at 12:20, Robert Haas robertmh...@gmail.com wrote: It seems like pg_read_binary_file() is good to have regardless of whatever else we decide to do here.  Should we pull that part out and

Re: [HACKERS] Complier warnings on mingw gcc 4.5.0

2010-12-14 Thread Andrew Dunstan
On 12/14/2010 12:42 PM, Tom Lane wrote: Another line of attack is that we know from the response packet that the failure is being reported at guc.c:4794. It would be really useful to know what the call stack is there. Could you change that elog to an elog(PANIC) and get a stack trace from

Re: [HACKERS] unlogged tables

2010-12-14 Thread Heikki Linnakangas
On 14.11.2010 02:16, Robert Haas wrote: 3. The third patch (relax-sync-commit-v1) allows asynchronous commit even when synchronous_commit=on if the transaction has not written WAL. Of course, a read-only transaction won't even have an XID and therefore won't need a commit record, so what this

<    1   2