On Mon, Jan 17, 2011 at 1:57 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Magnus Hagander mag...@hagander.net writes:
On Mon, Jan 17, 2011 at 17:46, Tom Lane t...@sss.pgh.pa.us wrote:
I think it'd make more sense just to say that replication connections
are subject to the same log_connections rule
On Mon, Jan 17, 2011 at 1:43 PM, Chris Browne cbbro...@acm.org wrote:
(I observe that it wasn't all that obvious that hash_search()
*adds* elements that are missing. I got confused and went
looking for hash_add() or similar. It's permissible to say dumb
Chris.)
I didn't
On mån, 2011-01-17 at 07:55 -0500, Robert Haas wrote:
There is, however, some desire to loosen this. Possible
applications
are case-insensitive comparison and Unicode normalization. It's not
going to happen soon, but it may be worth considering not putting in
an
optimization that we'll
On mån, 2011-01-17 at 14:59 +0100, Susanne Ebrecht wrote:
I didn't thought about pg_dump dump files here.
I more thought about files that came out of editors using mad encoding
and maybe then also were created on Windows and then copied to
Unix for import.
Written on little endian, copied
On mån, 2011-01-17 at 10:05 -0500, Robert Haas wrote:
On Mon, Jan 17, 2011 at 9:41 AM, Peter Eisentraut pete...@gmx.net wrote:
On fre, 2011-01-14 at 18:45 -0500, Robert Haas wrote:
On Fri, Jan 14, 2011 at 3:45 PM, Marti Raudsepp ma...@juffo.org
wrote:
There's a similar case with CREATE
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 9:41 AM, Peter Eisentraut pete...@gmx.net wrote:
Maybe instead of the proposed patch, a notice could be added:
NOTICE: existing object was replaced
Well, that would eliminate the backward-compatibility hazard, pretty
much, but
Magnus Hagander mag...@hagander.net writes:
Until we get integrated WAL streaming while the base backup is ongoing.
We don't know when that is (9.1 or future), but that's what we're aiming
to now, right?
Yeah, it does sound like a plan. But to still allow both - streaming
it in parallell
Magnus Hagander mag...@hagander.net writes:
Actually, after some IM chats, I think pg_streamrecv should be
renamed, probably to pg_walstream (or pg_logstream, but pg_walstream
is a lot more specific than that)
What I like about streamrecv is it's fairly clear which end of the
connection it's
On Mon, Jan 17, 2011 at 20:31, Tom Lane t...@sss.pgh.pa.us wrote:
Magnus Hagander mag...@hagander.net writes:
Actually, after some IM chats, I think pg_streamrecv should be
renamed, probably to pg_walstream (or pg_logstream, but pg_walstream
is a lot more specific than that)
What I like
On Mon, Jan 17, 2011 at 09:23:07PM +0200, Peter Eisentraut wrote:
On mån, 2011-01-17 at 10:05 -0500, Robert Haas wrote:
On Mon, Jan 17, 2011 at 9:41 AM, Peter Eisentraut pete...@gmx.net wrote:
On fre, 2011-01-14 at 18:45 -0500, Robert Haas wrote:
On Fri, Jan 14, 2011 at 3:45 PM, Marti
Josh Berkus j...@agliodbs.com writes:
However, we'd want a separate lock timeout for autovac, of course. I'm
not at all keen on a *statement* timeout on autovacuum; as long as
autovacuum is doing work, I don't want to cancel it. Also, WTF would we
set it to?
Yeah --- in the presence of
On sön, 2011-01-02 at 12:41 +0100, Jan Urbański wrote:
Here they are. There are 16 patches in total. They amount to what's
currently in my refactor branch (and almost to what I've sent as the
complete refactor patch, while doing the splitting I discovered a few
useless hunks that I've
On Mon, Jan 17, 2011 at 2:25 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 9:41 AM, Peter Eisentraut pete...@gmx.net wrote:
Maybe instead of the proposed patch, a notice could be added:
NOTICE: existing object was replaced
Well, that
On 15.01.2011 01:54, Kevin Grittner wrote:
/*
* for r/o transactions: list of concurrent r/w transactions that we
could
* potentially have conflicts with, and vice versa for r/w transactions
*/
TransactionId topXid; /* top level xid for the
Robert Haas robertmh...@gmail.com writes:
2011/1/13 Pavel Golub pa...@microolap.com:
pg_dump.c: In function 'dumpSequence':
pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format
pg_dump.c:11449:2: warning: too many arguments for format
It seems like
On Mon, 2011-01-17 at 14:46 -0500, Tom Lane wrote:
Josh Berkus j...@agliodbs.com writes:
However, we'd want a separate lock timeout for autovac, of course. I'm
not at all keen on a *statement* timeout on autovacuum; as long as
autovacuum is doing work, I don't want to cancel it. Also, WTF
Peter Eisentraut pete...@gmx.net writes:
On mån, 2011-01-17 at 07:35 +0100, Magnus Hagander wrote:
In fact, aren't there cases where the *length test* also fails?
Currently, two text values are only equal of strcoll() considers them
equal and the bits are the same. So this patch is safe in
On Jan 17, 2011, at 9:22 AM, Noah Misch wrote:
On Mon, Jan 17, 2011 at 07:35:52AM +0100, Magnus Hagander wrote:
On Mon, Jan 17, 2011 at 06:51, Itagaki Takahiro
itagaki.takah...@gmail.com wrote:
On Mon, Jan 17, 2011 at 04:05, Andy Colson a...@squeakycode.net wrote:
This is a review of:
On Mon, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
Yeah. Procedural langauges may strictly be wrong, but people aren't
likely to misunderstand it.
That was idea when suggesting we call it procedural languages. It is
short and I do not think it can be misunderstood.
Regards,
Andreas
Magnus Hagander mag...@hagander.net writes:
I wonder if we can trust the *equality* test, but not the inequality?
E.g. if compressed(A) == compressed(B) we know they're the same, but
if compressed(A) != compressed(B) we don't know they're not they still
might be.
I haven't looked at this
Excerpts from Peter Eisentraut's message of sáb ene 15 13:15:45 -0300 2011:
Here is a patch that adds a client_hostname field to pg_stat_activity.
It takes the hostname if it is available either by having log_hostname
set or if the pg_hba.conf processing resolved it. So I think for most
Joel Jacobson j...@gluefinance.com writes:
a) pg_describe_object should always include the schema in the name,
even for object in public and pg_catalog.
I knew you were going to demand that next, as soon as you figured out
that it was an obstacle for using pg_describe_object output as a
On Sun, 2011-01-16 at 22:32 -0500, Josh Kupershmidt wrote:
On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson andr...@proxel.se wrote:
Should we include a column in \dL+ for the laninline function (DO
blocks)?
Hrm, I guess that could be useful for the verbose output at least.
Magnus
Andrew Dunstan and...@dunslane.net writes:
On 01/17/2011 07:18 AM, Pavel Golub wrote:
So you think I should just ignore these warnings? Because I can't
remember the same behaviour on 8.x branches...
We've had them all along, as I said. See
On Sun, 2011-01-16 at 14:28 -0500, Tom Lane wrote:
One other point here is that I find messages like this a mite
unreadable:
function 1 (oidvector[], oidvector[]) btoidvectorcmp(oidvector,oidvector) of
operator family array_ops for access method gin
If we were to go with this, I'd be
Tom Lane t...@sss.pgh.pa.us writes:
Joel Jacobson j...@gluefinance.com writes:
a) pg_describe_object should always include the schema in the name,
even for object in public and pg_catalog.
I knew you were going to demand that next, as soon as you figured out
that it was an obstacle for
Simon Riggs si...@2ndquadrant.com writes:
On Mon, 2011-01-17 at 14:46 -0500, Tom Lane wrote:
Do we actually need a lock timeout either? The patch that was being
discussed just involved failing if you couldn't get it immediately.
I suspect that's sufficient for AV. At least, nobody's made a
2011/1/17 Tom Lane t...@sss.pgh.pa.us:
Joel Jacobson j...@gluefinance.com writes:
a) pg_describe_object should always include the schema in the name,
even for object in public and pg_catalog.
I knew you were going to demand that next, as soon as you figured out
that it was an obstacle for
When defining generic range functions, there is quite a bit of extra
complexity needed to handle special cases.
The special cases are due to:
* empty ranges
* ranges with infinite boundaries
* ranges with NULL boundaries
* ranges with exclusive bounds (e.g. ( or )).
Infinite bounds, and
On Mon, Jan 17, 2011 at 02:36:56PM -0600, Jim Nasby wrote:
On Jan 17, 2011, at 9:22 AM, Noah Misch wrote:
Just to be clear, the code already has these length tests today. This patch
just moves them before the detoast.
Any reason we can't do this for other varlena? I'm wondering if it
On Mon, Jan 17, 2011 at 01:09:26PM -0800, Jeff Davis wrote:
When defining generic range functions, there is quite a bit of extra
complexity needed to handle special cases.
The special cases are due to:
* empty ranges
* ranges with infinite boundaries
* ranges with NULL boundaries
*
On Mon, Jan 17, 2011 at 09:58:44PM +0200, Heikki Linnakangas wrote:
What does that comment about list of concurrent r/w transactions refer
to? I don't see any list there. Does it refer to
possibleUnsafeConflicts, which is above that comment?
Yes, that comment was supposed to be attached to
On 01/17/2011 03:51 PM, Tom Lane wrote:
Andrew Dunstanand...@dunslane.net writes:
On 01/17/2011 07:18 AM, Pavel Golub wrote:
So you think I should just ignore these warnings? Because I can't
remember the same behaviour on 8.x branches...
We've had them all along, as I said. See
On Fri, Jan 7, 2011 at 3:18 PM, Joachim Wieland j...@mcknight.de wrote:
Here's a new series of patches for the parallel dump/restore. They need to be
applied on top of each other.
This one is the last version of this patch? if so, commitfest app
should be updated to reflect that
--
Jaime
Hi,
I initially considered this patch as a primer to start off some basic
VS2010 support and not as something to be commited within the next few
commitfests.
As there seems to be at least some interest in this patch I refactored
the code and did some more testing (actually found some weird
On Jan 15, 2011, at 8:15 AM, Robert Haas wrote:
Well, the point of this is not to save time in the bgwriter - I'm not
surprised to hear that wasn't noticeable. The point is that when the
fsync request queue fills up, backends start performing an fsync *for
every block they write*, and that's
On Tue, 18 Jan 2011 00:06:10 +0100, Brar Piening b...@gmx.de wrote:
So there is now a third version of this patch at
http://www.piening.info/VS2010v3.patch
Forgot to run perltidy on it - fixed in
http://www.piening.info/VS2010v4.patch
Sorry!
Brar
--
Sent via pgsql-hackers mailing list
Jeff Davis pg...@j-davis.com writes:
I feel like I'm making this too complicated. Should I just scope out
NULL range boundaries for the first cut, and leave room in the
representation so that it can be added when there is a more thorough
proposal for NULL range boundaries?
+1. I'm far from
On 1/17/11 1:09 PM, Jeff Davis wrote:
I feel like I'm making this too complicated. Should I just scope out
NULL range boundaries for the first cut, and leave room in the
representation so that it can be added when there is a more thorough
proposal for NULL range boundaries?
Well, NULL range
Also, it's not going to get packaged at all unless it gets renamed to
something less generic, maybe pg_test_fsync; I'm not going to risk the
oppobrium of sticking something named test_fsync into /usr/bin.
Moving to contrib would be a good opportunity to fix the name.
+1.
It would be a lot
On Mon, Jan 17, 2011 at 6:07 PM, Jim Nasby j...@nasby.net wrote:
On Jan 15, 2011, at 8:15 AM, Robert Haas wrote:
Well, the point of this is not to save time in the bgwriter - I'm not
surprised to hear that wasn't noticeable. The point is that when the
fsync request queue fills up, backends
Itagaki Takahiro wrote:
Shigeru HANADA wrote:
Attached patch would avoid this leak by adding per-copy context to
CopyState. This would be overkill, and ResetCopyFrom() might be
reasonable though.
Good catch. I merged your fix into the attached patch.
Review for CF:
While there is a
Jim Nasby wrote:
Wow, that's the kind of thing that would be incredibly difficult to figure out,
especially while your production system is in flames... Can we change ereport
that happens in that case from DEBUG1 to WARNING? Or provide some other means
to track it
That's why we already
Dne 9.1.2011 13:58, Jim Nasby napsal(a):
A resource fork? Not sure what you mean, could you describe it in more
detail?
Ooops, resource forks are a filesystem thing; we call them relation forks.
From src/backend/storage/smgr/README:
OK, I think using relation forks seems like a good
Dan Ports wrote:
Yes, that comment was supposed to be attached to
possibleUnsafeConflicts.
Actually, I think that other hash no longer exists
The comment above SERIALIZABLEXACT also needs to be updated since
it refers to said hash table. And if I'm not mistaken (Kevin?), we
can
On 17/01/11 09:26, Jan Urbański wrote:
On 17/01/11 01:02, Hitoshi Harada wrote:
This is a review for the patch sent as
https://commitfest.postgresql.org/action/patch_view?id=456
It includes adequate amount of test. I found regression test failure
in plpython_error.
My environment is CentOS
On Jan 17, 2011, at 6:36 PM, Tomas Vondra wrote:
1) Forks are 'per relation' but the distinct estimators are 'per
column' (or 'per group of columns') so I'm not sure whether the file
should contain all the estimators for the table, or if there should
be one fork for each estimator. The
On Mon, Jan 17, 2011 at 06:52:09PM -0600, Kevin Grittner wrote:
I think we still need the vxid. It shows in the pg_locks view, and
we might possibly need it to find the right process to cancel once we
have some way to do that. But there's no point with having the tag
level anymore.
Oh,
Heikki Linnakangas wrote:
Setting the high bit in OldSetXidAdd() seems a bit weird. How about
just using UINT64_MAX instead of 0 to mean no conflicts? Or 1, and
start the sequence counter from 2.
Sure. I think I like reserving 1 and starting at 2 better. Will do.
Chris Browne wrote:
It was a little troublesome inducing it. I did so by cutting
shared memory to minimum (128kB)...
With higher shared memory, I couldn't readily induce compaction,
which is probably a concurrency matter of not having enough volume
of concurrent
On Mon, Jan 17, 2011 at 07:20:20PM -0600, Kevin Grittner wrote:
OK. I may need to bounce some questions off the list to resolve some
of them. The biggest, in my mind, is whether MySerializableXact
needs to be declared volatile. I don't have my head around the
issues on that as well as I
On 1/17/11 11:46 AM, Tom Lane wrote:
Do we actually need a lock timeout either? The patch that was being
discussed just involved failing if you couldn't get it immediately.
I suspect that's sufficient for AV. At least, nobody's made a
compelling argument why we need to expend a very
Bruce Momjian wrote:
Is there a value to this test_fsync test?
Compare open_sync with different sizes:
(This is designed to compare the cost of one large
sync'ed write and two smaller sync'ed writes.)
open_sync 16k write 242.563 ops/sec
Alvaro Herrera wrote:
I don't understand why it would be overkill. Are you saying people
would complain because you installed a 25 kB executable that they might
not want to use? Just for fun I checked /usr/bin and noticed that I
have a pandoc executable, weighing 17 MB, that I have never used
Hi all,
I've updated the patch to address the following points:
* help string now says list procedural languages (no parentheses now)
* the language name column is now titled Name
* added another column in verbose mode for 9.0+ showing whether DO
blocks are possible with the language. I named
Bruce Momjian wrote:
Should we be writing until 2:30 then sleep 30 seconds and fsync at 3:00?
The idea of having a dead period doing no work at all between write
phase and sync phase may have some merit. I don't have enough test data
yet on some more fundamental issues in this area to
On Mon, Jan 17, 2011 at 7:56 PM, Jim Nasby j...@nasby.net wrote:
- Forks are very possibly a more efficient way to deal with TOAST than having
separate tables. There's a fair amount of overhead we pay for the current
setup.
That seems like an interesting idea, but I actually don't see why it
On Mon, Jan 17, 2011 at 8:26 PM, Josh Berkus j...@agliodbs.com wrote:
On 1/17/11 11:46 AM, Tom Lane wrote:
Do we actually need a lock timeout either? The patch that was being
discussed just involved failing if you couldn't get it immediately.
I suspect that's sufficient for AV. At least,
On Mon, Jan 17, 2011 at 10:50 PM, Magnus Hagander mag...@hagander.net wrote:
+ printf(_( -D, --pgdata=directory receive base backup into
directory\n));
+ printf(_( -T, --tardir=directory receive base backup into tar
files\n
+
I've gotten permission to move pg_filedump from its former home at
sources.redhat.com to pgfoundry. You can find the historical release
tarballs as well as current sources at
http://pgfoundry.org/projects/pgfiledump/
One advantage of doing this is it will be a lot easier to let other
Josh Berkus j...@agliodbs.com writes:
On 1/17/11 11:46 AM, Tom Lane wrote:
Do we actually need a lock timeout either? The patch that was being
discussed just involved failing if you couldn't get it immediately.
I suspect that's sufficient for AV. At least, nobody's made a
compelling
On Jan 14, 2011, at 7:24 PM, Josh Berkus wrote:
On 1/14/11 11:51 AM, Tom Lane wrote:
The people whose tables are mostly insert-only complain about it, but
that's not the majority of our userbase IMO. We just happen to have a
couple of particularly vocal ones, like Berkus.
It might or might
On mån, 2011-01-17 at 15:33 -0500, Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
On mån, 2011-01-17 at 07:35 +0100, Magnus Hagander wrote:
In fact, aren't there cases where the *length test* also fails?
Currently, two text values are only equal of strcoll() considers them
Dan Ports wrote:
On Mon, Jan 17, 2011 at 07:20:20PM -0600, Kevin Grittner wrote:
OK. I may need to bounce some questions off the list to resolve
some of them. The biggest, in my mind, is whether
MySerializableXact needs to be declared volatile. I don't have my
head around the issues on that
On Mon, Jan 17, 2011 at 09:48:58PM -0500, Tom Lane wrote:
I've gotten permission to move pg_filedump from its former home at
sources.redhat.com to pgfoundry. You can find the historical release
tarballs as well as current sources at
http://pgfoundry.org/projects/pgfiledump/
One
David Fetter da...@fetter.org writes:
On Mon, Jan 17, 2011 at 09:48:58PM -0500, Tom Lane wrote:
(Before someone suggests folding it into contrib/: we can't because
of license issues. pg_filedump is GPL, per Red Hat company policy,
and that's not going to change.)
Who's the copyright
Kevin Grittner kevin.gritt...@wicourts.gov writes:
Dan Ports wrote:
The biggest, in my mind, is whether
MySerializableXact needs to be declared volatile.
The problem is that I don't have a very clear sense of what it really
does, which is not helped much by having done a few years of
Shouldn't the comment read If first time through?
/*
* If not first time through, get workspace to remember main XIDs in. We
* malloc it permanently to avoid repeated palloc/pfree overhead.
*/
if (xids == NULL)
{
...
xids =
I'm compiling postgresql 9.0.2 using msys + mingw + gcc 4.5.2 (latest
official release from mingw). This is on Windows 7 64-bit.
Unfortunately the built dlls, at least libpq.dll, crash if they need to
be relocated. This happens to me when loading libpq.dll into a project
that has a number
On Sat, Jan 15, 2011 at 08:35, Shigeru HANADA han...@metrosystems.co.jp wrote:
Interface of NextCopyFrom() is fixed to return HeapTuple, to support
tableoid without any change to TupleTableSlot.
3) 20110114-copy_export_HeapTupe.patch
This patch fixes interface of NextCopyFrom() to return
On mån, 2011-01-17 at 17:26 -0800, Josh Berkus wrote:
However, it's hard for me to imagine a real-world situation where a
table would be under repeated full-table-locks from multiple
connections. Can anyone else?
If you want to do assertion-type checks at the end of transactions in
the
On 17.01.2011 21:04, Robert Haas wrote:
On Mon, Jan 17, 2011 at 1:57 PM, Tom Lanet...@sss.pgh.pa.us wrote:
I'm of the opinion that the correct way of lowering in later releases
is to make the messages obey Log_connections. The needed for debug
argument seems mighty weak to me even for the
Followup on System Table Index clustering ToDo -
It looks like to implement this I need to do the following:
1 - Add statements to indexing.h to cluster the selected indexes.
A do-nothing define at the top to suppress warnings and then
lines below for perl to
On Tue, Jan 18, 2011 at 4:15 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
I also find it weird that incoming replication connections are logged by
default. In the standby, we also log streaming replication successfully
connected to primary, which serves much of the same
101 - 174 of 174 matches
Mail list logo
