Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Darren Duncan
Jeff Davis wrote: On Sun, 2011-06-26 at 00:57 -0700, Darren Duncan wrote: I believe that the best general solution here is for every ordered base type to just have a single total order, which is always used with that type in any generic order-sensitive operation, including any ranges defined

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-27 Thread Dean Rasheed
On 27 June 2011 03:31, Robert Haas robertmh...@gmail.com wrote: On Sat, Jun 25, 2011 at 2:15 AM, Dean Rasheed dean.a.rash...@gmail.com wrote: Really? I would expect the reverse, namely that the not-nullness is part of the PK constraint and dropping the PK *would* then start allowing NULLs.

Re: [HACKERS] silent_mode and LINUX_OOM_ADJ

2011-06-27 Thread Magnus Hagander
On Fri, Jun 24, 2011 at 16:37, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Heikki Linnakangas's message of vie jun 24 07:01:57 -0400 2011: While reviewing Peter Geoghegan's postmaster death patch, I noticed that if you turn on silent_mode, the LINUX_OOM_ADJ code in

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2011-06-27 Thread Simon Riggs
On Fri, Jun 17, 2011 at 8:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Department of second thoughts: I think I see a problem. Um, yeah, so that doesn't really work any better than my idea. On further reflection, there's a problem at a higher level than

Re: [HACKERS] Another issue with invalid XML values

2011-06-27 Thread Noah Misch
On Mon, Jun 27, 2011 at 12:45:02AM +0200, Florian Pflug wrote: Updated patch attached. Do you think this is Ready for Committer? Thanks. Yes; I have just marked it that way. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2011-06-27 Thread Simon Riggs
On Fri, Jun 17, 2011 at 6:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jun 16, 2011 at 6:54 PM, Tom Lane t...@sss.pgh.pa.us wrote: I believe that this is fundamentally unavoidable so long as we use SnapshotNow to read catalogs --- which is

Re: [HACKERS] silent_mode and LINUX_OOM_ADJ

2011-06-27 Thread Heikki Linnakangas
On 27.06.2011 10:23, Magnus Hagander wrote: On Fri, Jun 24, 2011 at 16:37, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Heikki Linnakangas's message of vie jun 24 07:01:57 -0400 2011: While reviewing Peter Geoghegan's postmaster death patch, I noticed that if you turn on

Re: [HACKERS] silent_mode and LINUX_OOM_ADJ

2011-06-27 Thread Reinhard Max
Hi Heikki, On Mon, 27 Jun 2011 at 12:10, Heikki Linnakangas wrote: Max, you're the maintainer of the PostgreSQL SuSE RPMs, right? my first name is Reinhard, but aside from that, you are right. ;) Can you comment on the above? I enabled it many years ago when (IIRC) it was needed in

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Florian Pflug
On Jun27, 2011, at 02:48 , Jeff Davis wrote: On Mon, 2011-06-27 at 00:56 +0200, Florian Pflug wrote: Well, there actually *is* some precedence for that kind of top-down (form a syntactic perspective) type inference. We *enforce* the cast in array[]::arraytype and actually for a very

Re: [HACKERS] Range Types and length function

2011-06-27 Thread Florian Pflug
On Jun27, 2011, at 03:12 , Jeff Davis wrote: But I think you're right, it shouldn't be the responsibility of range types. Perhaps I should leave length() as some inlinable SQL functions like I mentioned, or perhaps I should remove them completely. Does the current definition of length(range),

Re: [HACKERS] WIP: Fast GiST index build

2011-06-27 Thread Alexander Korotkov
I've added information about testing on some real-life dataset to wiki page. This dataset have a speciality: data is ordered inside it. In this case tradeoff was inverse in comparison with expectations about fast build algrorithm. Index built is longer but index quality is significantly better. I

Optimizing box_penalty (Re: [HACKERS] WIP: Fast GiST index build)

2011-06-27 Thread Heikki Linnakangas
On 27.06.2011 13:45, Alexander Korotkov wrote: I've added information about testing on some real-life dataset to wiki page. This dataset have a speciality: data is ordered inside it. In this case tradeoff was inverse in comparison with expectations about fast build algrorithm. Index built is

Re: [HACKERS] libpq SSL with non-blocking sockets

2011-06-27 Thread Robert Haas
On Fri, Jun 24, 2011 at 5:14 PM, Steve Singer ssinger...@sympatico.ca wrote: A few things I noticed (that you might be aware of since you mentioned it needs cleanup) -The patch doesn't compile with non-ssl builds,  the debug at the bottom of PQSendSome isn't in an #ifdef -I don't think your

Re: [HACKERS] heap_hot_search_buffer refactoring

2011-06-27 Thread Robert Haas
On Sat, Jun 25, 2011 at 6:24 AM, Jeff Davis pg...@j-davis.com wrote: On Fri, 2011-06-24 at 15:32 -0400, Robert Haas wrote: On Sun, Jun 19, 2011 at 2:16 PM, Robert Haas robertmh...@gmail.com wrote: New patch attached, with that one-line change. Jeff, are you planning to review this further?  

Re: [HACKERS] WIP: Fast GiST index build

2011-06-27 Thread Heikki Linnakangas
On 27.06.2011 13:45, Alexander Korotkov wrote: I've added information about testing on some real-life dataset to wiki page. This dataset have a speciality: data is ordered inside it. In this case tradeoff was inverse in comparison with expectations about fast build algrorithm. Index built is

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 3:08 AM, Dean Rasheed dean.a.rash...@gmail.com wrote: On 27 June 2011 03:31, Robert Haas robertmh...@gmail.com wrote: On Sat, Jun 25, 2011 at 2:15 AM, Dean Rasheed dean.a.rash...@gmail.com wrote: Really? I would expect the reverse, namely that the not-nullness is part

Re: [HACKERS] Small 9.1 documentation fix (SSPI auth)

2011-06-27 Thread Robert Haas
On Fri, Jun 24, 2011 at 6:07 PM, Christian Ullrich ch...@chrullrich.net wrote: When Magnus fixed and applied my SSPI-via-GSS patch in January, we forgot to fix to the documentation. Suggested patch attached; should I also put that four-liner into any CFs? I have committed a slightly different

Re: [HACKERS] spinlock contention

2011-06-27 Thread Robert Haas
On Sat, Jun 25, 2011 at 8:26 PM, Greg Stark st...@mit.edu wrote: On Thu, Jun 23, 2011 at 4:42 PM, Robert Haas robertmh...@gmail.com wrote: ProcArrayLock looks like a tougher nut to crack - there's simply no way, with the system we have right now, that you can take a snapshot without locking

Re: [HACKERS] Deriving release notes from git commit messages

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 11:49 AM, Jonathan Corbet cor...@lwn.net wrote: On Fri, 24 Jun 2011 13:42:04 -0400 Robert Haas robertmh...@gmail.com wrote: As for annotating the commit messages, I think something like: Reporter: Sam Jones Author: Beverly Smith Author: Jim Davids Reviewer: Fred

Re: [HACKERS] Word-smithing doc changes

2011-06-27 Thread Robert Haas
On Sat, Jun 25, 2011 at 9:01 PM, Greg Stark st...@mit.edu wrote: I think this commit was ill-advised: http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a03feb9354bda5084f19cc952bc52ba7be89f372     In a concurrent index build, the index is actually entered into the     system

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Sun, Jun 26, 2011 at 10:33 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of vie jun 24 22:22:55 -0400 2011: On Fri, Jun 24, 2011 at 7:47 PM, Bruce Momjian br...@momjian.us wrote: You want the environment variable support removed? I don't.  It's

Re: [HACKERS] Deriving release notes from git commit messages

2011-06-27 Thread Jonathan Corbet
On Fri, 24 Jun 2011 13:42:04 -0400 Robert Haas robertmh...@gmail.com wrote: As for annotating the commit messages, I think something like: Reporter: Sam Jones Author: Beverly Smith Author: Jim Davids Reviewer: Fred Block Reviewer: Pauline Andrews Can I just toss in one little note from

Re: [HACKERS] Small 9.1 documentation fix (SSPI auth)

2011-06-27 Thread Christian Ullrich
* Robert Haas wrote: On Fri, Jun 24, 2011 at 6:07 PM, Christian Ullrichch...@chrullrich.net wrote: When Magnus fixed and applied my SSPI-via-GSS patch in January, we forgot to fix to the documentation. Suggested patch attached; should I also put that four-liner into any CFs? I have

Re: [HACKERS] Range Types and length function

2011-06-27 Thread Jeff Davis
On Mon, 2011-06-27 at 12:25 +0200, Florian Pflug wrote: Does the current definition of length(range), i.e. upper(range) - lower(range) deal correctly with open vs. closed ranges and unbounded ranges? I'm thinking that it probably doesn't - what would be the results of

[HACKERS] beta3?

2011-06-27 Thread Robert Haas
We have a couple of open items outstanding right now, but I'm wondering if it's about time we should be thinking about a date for beta3. We tagged beta1 on April 27th, and beta2 on June 9th, so about six weeks apart. But perhaps we shouldn't wait quite so long before putting out beta3? --

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Jeff Davis
On Mon, 2011-06-27 at 12:16 +0200, Florian Pflug wrote: I wouldn't take it that far. What I had in mind was to *only* support the case where the cast directly follows the function call, i.e. the case f(...)::type OK, so instead of writing:

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Jeff Davis
On Sun, 2011-06-26 at 22:29 -0700, Darren Duncan wrote: Tom Lane wrote: Darren Duncan dar...@darrenduncan.net writes: I believe that the best general solution here is for every ordered base type to just have a single total order, which is always used with that type in any generic

Re: [HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-27 Thread Robert Haas
On Wed, Jun 22, 2011 at 1:36 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jun 22, 2011 at 12:51 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of mié jun 22 08:56:02 -0400 2011: Another option might be to leave heap_openrv() and

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Bruce Momjian
Robert Haas wrote: On Sun, Jun 26, 2011 at 10:33 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of vie jun 24 22:22:55 -0400 2011: On Fri, Jun 24, 2011 at 7:47 PM, Bruce Momjian br...@momjian.us wrote: You want the environment variable support

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 1:39 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Sun, Jun 26, 2011 at 10:33 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of vie jun 24 22:22:55 -0400 2011: On Fri, Jun 24, 2011 at 7:47 PM, Bruce Momjian

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Bruce Momjian
\Robert Haas wrote: On Mon, Jun 27, 2011 at 1:39 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Sun, Jun 26, 2011 at 10:33 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of vie jun 24 22:22:55 -0400 2011: On Fri, Jun 24, 2011

[HACKERS] generate_series() Interpretation

2011-06-27 Thread David E. Wheeler
Hackers, I'm curious about behavior such as this: bric=# select generate_series('2011-05-31'::timestamp , '2012-04-01'::timestamp, '1 month'); generate_series - 2011-05-31 00:00:00 2011-06-30 00:00:00 2011-07-30 00:00:00 2011-08-30 00:00:00 2011-09-30 00:00:00

Re: [HACKERS] beta3?

2011-06-27 Thread Josh Berkus
On 6/27/11 9:45 AM, Robert Haas wrote: We have a couple of open items outstanding right now, but I'm wondering if it's about time we should be thinking about a date for beta3. We tagged beta1 on April 27th, and beta2 on June 9th, so about six weeks apart. But perhaps we shouldn't wait

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian br...@momjian.us wrote: OK, fair enough.  Should I apply my ports patch to Postgres 9.2? I'm not sure which patch you are referring to. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [HACKERS] beta3?

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 1:51 PM, Josh Berkus j...@agliodbs.com wrote: On 6/27/11 9:45 AM, Robert Haas wrote: We have a couple of open items outstanding right now, but I'm wondering if it's about time we should be thinking about a date for beta3. We tagged beta1 on April 27th, and beta2 on

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Steve Crawford
On 06/27/2011 10:49 AM, David E. Wheeler wrote: Hackers, I'm curious about behavior such as this: bric=# select generate_series('2011-05-31'::timestamp , '2012-04-01'::timestamp, '1 month'); generate_series - 2011-05-31 00:00:00 2011-06-30 00:00:00 2011-07-30

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread David E. Wheeler
On Jun 27, 2011, at 10:54 AM, Steve Crawford wrote: That's just how intervals that represent varying periods of time work. You would need to write your own. But a series of end-of-month dates is pretty easy: select generate_series('2011-06-01'::timestamp , '2012-04-01'::timestamp, '1

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Bruce Momjian
Robert Haas wrote: On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian br...@momjian.us wrote: OK, fair enough. ?Should I apply my ports patch to Postgres 9.2? I'm not sure which patch you are referring to. This one which makes 50432 the default port. -- Bruce Momjian br...@momjian.us

Re: [HACKERS] [COMMITTERS] pgsql: Make the visibility map crash-safe.

2011-06-27 Thread Robert Haas
On Thu, Jun 23, 2011 at 9:22 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jun 22, 2011 at 10:23 PM, Robert Haas robertmh...@gmail.com wrote: Well, it seems I didn't put nearly enough thought into heap_update(). The fix for the immediate problem looks simple enough - all the code has

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Kevin Grittner
David E. Wheeler da...@kineticode.com wrote: generate_series - 2011-05-31 00:00:00 2011-06-30 00:00:00 2011-07-31 00:00:00 2011-08-31 00:00:00 2011-09-30 00:00:00 2011-10-31 00:00:00 2011-11-30 00:00:00 2011-12-31 00:00:00 2012-01-31 00:00:00

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian br...@momjian.us wrote: OK, fair enough. ?Should I apply my ports patch to Postgres 9.2? I'm not sure which patch you are referring to. This one which

Re: [HACKERS] per-column generic option

2011-06-27 Thread Robert Haas
2011/6/27 Shigeru Hanada shigeru.han...@gmail.com: * It might be an option to extend attreloptions, instead of the new attfdwoptions. Although I didn't track the discussion when pg_foreign_table catalog that provides relation level fdw-options, was it impossible or unreasonable to extend

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread David E. Wheeler
On Jun 27, 2011, at 11:03 AM, Kevin Grittner wrote: It is precisely to support such fancy things that some products support a more abstract date type which allows 31 days in any month, and then normalizes to real dates as needed. The PostgreSQL developer community has generally not been

[HACKERS] Commitfest 2001-06: 10 days in

2011-06-27 Thread Josh Berkus
All, So we're supposedly 1/3 of the way through CF1. Here's the good news: - Almost all patches have reviewers assigned. - 9 patches have been committed - 8 more are ready for a committer - 9 have been returned This means that 1/4 of the patches have been dealt with and another 1/8 should be

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Darren Duncan
Jeff Davis wrote: On Sun, 2011-06-26 at 22:29 -0700, Darren Duncan wrote: Tom Lane wrote: Darren Duncan dar...@darrenduncan.net writes: I believe that the best general solution here is for every ordered base type to just have a single total order, which is always used with that type in any

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Bruce Momjian
Robert Haas wrote: On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian br...@momjian.us wrote: OK, fair enough. ?Should I apply my ports patch to Postgres 9.2? I'm not sure which patch you are

[HACKERS] SSI modularity questions

2011-06-27 Thread Kevin Grittner
There are two outstanding patches for SSI which involve questions about modularity. In particular, they involve calls to predicate locking and conflict detection from executor source files rather than AM source files (where most such calls exist). (1) Dan submitted this patch:

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 2:19 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian br...@momjian.us wrote: OK, fair enough. ?Should I apply my

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Bruce Momjian
Robert Haas wrote: On Mon, Jun 27, 2011 at 2:19 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian br...@momjian.us wrote: OK, fair

Re: [HACKERS] WIP: Fast GiST index build

2011-06-27 Thread Alexander Korotkov
On Mon, Jun 27, 2011 at 6:34 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: The penalty function is called whenever a tuple is routed to the next level down, and the final tree has the same depth with and without the patch, so I would expect the number of penalty calls to

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 2:27 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 2:19 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27,

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Bruce Momjian
Bruce Momjian wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 2:19 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 2:34 PM, Bruce Momjian br...@momjian.us wrote: Bruce Momjian wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 2:19 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Steve Crawford
On 06/27/2011 10:56 AM, David E. Wheeler wrote: On Jun 27, 2011, at 10:54 AM, Steve Crawford wrote: That's just how intervals that represent varying periods of time work. You would need to write your own. But a series of end-of-month dates is pretty easy: select

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread David E. Wheeler
On Jun 27, 2011, at 11:36 AM, Steve Crawford wrote: The query is marginally trickier. But the better calendaring apps give a variety of options when selecting repeat: A user who selects June 30, 2011 and wants a monthly repeat might want: 30th of every month - skip months without a 30th

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Robert Haas
On Sat, Jun 25, 2011 at 6:29 PM, Jeff Davis pg...@j-davis.com wrote: Different ranges over the same subtype make sense when using different total orders for the subtype. This is most apparent with text collation, but makes sense (at least mathematically, if not practically) for any subtype.

Re: [HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-27 Thread Noah Misch
On Mon, Jun 27, 2011 at 01:28:30PM -0400, Robert Haas wrote: On Wed, Jun 22, 2011 at 1:36 PM, Robert Haas robertmh...@gmail.com wrote: I agree with you. ?If we had a whole pile of options it might be worth having heap_openrv() and heap_openrv_extended() so as not to complicate the simple

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Michael Nolan
On Mon, Jun 27, 2011 at 1:38 PM, David E. Wheeler da...@kineticode.comwrote: Yeah, which is why I said it was subject to interpretation. Of course there's no way to tell generate_series() which to use, which is what I figured. generate_series() is doing exactly what it was designed to do,

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Steve Crawford
Yeah, which is why I said it was subject to interpretation. Of course there's no way to tell generate_series() which to use, which is what I figured. Fortunately PostgreSQL uses the same interpretation for '1 month' when used in generate_series that it does everywhere else - to do otherwise

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Christopher Browne
On Mon, Jun 27, 2011 at 1:49 PM, David E. Wheeler da...@kineticode.com wrote: Hackers, I'm curious about behavior such as this: bric=# select generate_series('2011-05-31'::timestamp , '2012-04-01'::timestamp, '1 month');   generate_series -  2011-05-31 00:00:00  

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread Christopher Browne
On Mon, Jun 27, 2011 at 2:36 PM, Steve Crawford scrawf...@pinpointresearch.com wrote: On 06/27/2011 10:56 AM, David E. Wheeler wrote: On Jun 27, 2011, at 10:54 AM, Steve Crawford wrote: That's just how intervals that represent varying periods of time work. You would need to write your own.

Re: [HACKERS] Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE

2011-06-27 Thread Robert Haas
On Wed, Jun 15, 2011 at 1:03 AM, Noah Misch n...@leadboat.com wrote: [patch to avoid index rebuilds] With respect to the documentation hunks, it seems to me that the first hunk might be made clearer by leaving the paragraph of which it is a part as-is, and adding another paragraph afterwards

Re: [HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 2:59 PM, Noah Misch n...@leadboat.com wrote: On Mon, Jun 27, 2011 at 01:28:30PM -0400, Robert Haas wrote: On Wed, Jun 22, 2011 at 1:36 PM, Robert Haas robertmh...@gmail.com wrote: I agree with you. ?If we had a whole pile of options it might be worth having

Re: [HACKERS] generate_series() Interpretation

2011-06-27 Thread David E. Wheeler
On Jun 27, 2011, at 12:36 PM, Christopher Browne wrote: I wrote something on this on pgsql-general about 5 years ago that still seems pretty relevant. http://archives.postgresql.org/pgsql-general/2006-02/msg00159.php iwantsandy.com (now defunct) originally had a solution like this. However

Re: [HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-27 Thread Kohei KaiGai
The attached patch is rebased one towards the latest tree, using relation_openrv_extended(). Although it is not a matter in this patch itself, I found a problem on the upcoming patch that consolidate routines associated with DropStmt. Existing RemoveRelations() acquires a lock on the table owning

[HACKERS] Dry Run mode for pg_archivecleanup

2011-06-27 Thread Gabriele Bartolini
Hi guys, I have added the '-n' option to pg_archivecleanup which performs a dry-run and outputs the names of the files to be removed to stdout (making possible to pass the list via pipe to another process). Please find attached the small patch. Thanks, Gabriele -- Gabriele Bartolini -

Re: [HACKERS] pg_upgrade defaulting to port 25432

2011-06-27 Thread Peter Eisentraut
On mån, 2011-06-27 at 14:34 -0400, Bruce Momjian wrote: Bruce Momjian wrote: Robert Haas wrote: It's easier to read the patches if you do separate changes in separate patches. Anyway, I'm a bit nervous about this hunk: + if (old_cluster.port == DEF_PGUPORT) +

[HACKERS] add support for logging current role (what to review?)

2011-06-27 Thread Alex Hunsaker
Ive been holding off because its marked as Waiting on Author, am now thinking thats a mistake. =) It links to this patch: http://archives.postgresql.org/message-id/20110215135131.gx4...@tamriel.snowman.net Which is older than the latest patch in that thread posted by Robert:

Re: [HACKERS] per-column generic option

2011-06-27 Thread David Fetter
On Fri, Jun 17, 2011 at 05:59:31AM -0700, David Fetter wrote: On Fri, Jun 17, 2011 at 07:19:39PM +0900, Shigeru Hanada wrote: Here's an example of a non-trivial mapping. Database type: MySQL Foreign data type: datetime PostgreSQL data type: timestamptz

Re: [HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-27 Thread Robert Haas
On Mon, Jun 27, 2011 at 4:40 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The attached patch is rebased one towards the latest tree, using relation_openrv_extended(). Committed. Although it is not a matter in this patch itself, I found a problem on the upcoming patch that consolidate

Re: [HACKERS] minor patch submission: CREATE CAST ... AS EXPLICIT

2011-06-27 Thread Brendan Jurd
On 18 June 2011 09:49, Brendan Jurd dire...@gmail.com wrote: Hi Fabien, I'm taking a look at this patch for the commitfest.  On first reading of the patch, it looked pretty sensible to me, but I had some trouble applying it to HEAD: error: patch failed: doc/src/sgml/ref/create_cast.sgml:20

Re: [HACKERS] Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE

2011-06-27 Thread Noah Misch
On Mon, Jun 27, 2011 at 03:45:43PM -0400, Robert Haas wrote: On Wed, Jun 15, 2011 at 1:03 AM, Noah Misch n...@leadboat.com wrote: [patch to avoid index rebuilds] With respect to the documentation hunks, it seems to me that the first hunk might be made clearer by leaving the paragraph of

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-27 Thread Jeff Davis
On Mon, 2011-06-27 at 14:50 -0400, Robert Haas wrote: Couldn't we also do neither of these things? I mean, presumably '[1,10]'::int8range had better work. I think that if we combine this idea with Florian's PAIR suggestion here:

[HACKERS] [Hackers]Backend quey plan process

2011-06-27 Thread HuangQi
Hi, I've been tracing the data structure in the query plan process for a while. But then I found the data structure manipulation is really so confusing. Could some guy tell me where could I find any guide on how to figure out the process and data structure usage? Is there any good resource

Re: [HACKERS] [Hackers]Backend quey plan process

2011-06-27 Thread Jaime Casanova
HuangQi huangq...@gmail.com writes: Hi,       I've been tracing the data structure in the query plan process for a while. But then I found the data structure manipulation is really so confusing. Could some guy tell me where could I find any guide on how to figure out the process and data

[HACKERS] how to call the function--pqCatenateResultError()

2011-06-27 Thread _石头
Hello!~ Now i encounter a function call problem in PostgreSQL's psql module! The situation is as follow: In ./src/bin/psql/common.c, I want to call the function pqCatenateResultError(). Function pqCatenateResultError() is declared in

Re: [HACKERS] Online base backup from the hot-standby

2011-06-27 Thread Jun Ishiduka
Considering everything that has been discussed on this thread so far. Do you still think your patch is the best way to accomplish base backups from standby servers? If not what changes do you think should be made? I reconsider the way to not use pg_stop_backup(). Process of online base