Patch (https://commitfest.postgresql.org/action/patch_view?id=1161) is already
committed by Commit
http://git.postgresql.org/pg/commitdiff/b23160889c963dfe23d8cf1f9be64fb3c535a2d6
It should be marked as Committed in CF.
With Regards,
Amit Kapila.
--
Sent via pgsql-hackers mailing list
On 23 June 2013 03:16, Stephen Frost sfr...@snowman.net wrote:
Still doesn't really address the issue of dups though.
Checking for duplicates in all cases would be wasteful, since often we
are joining to the PK of a smaller table.
If duplicates are possible at all for a join, then it would
So my argumented conclusion is that the issue is somewhere within PQfinish(),
possibly in interaction with pgbench doings, but is *NOT* related in any way
to the throttling patch, as it is preexisting it. Gregs stumbled upon it
because he looked at latencies.
An additional thought:
The
On 06/23/2013 04:03 AM, ian link wrote:
Looks like my community login is still not working. No rush, just wanted
to let you know. Thanks!
have you tried to log in once to the main website per:
I just tried it and my
account works now. Thanks!
Ian
Stefan Kaltenbrunner
Sunday, June 23,
2013 2:05 AM
have you tried
to log in once to the main website per:http://www.postgresql.org/message-id/CABUevEyt9tQfcF7T2Uzcr8WeF9M=s8qSACuCmN5L2Et26=r...@mail.gmail.com?Stefan
On 23 June 2013 03:16, Stephen Frost sfr...@snowman.net wrote:
Will think on it more.
Some other thoughts related to this...
* Why are we building a special kind of hash table? Why don't we just
use the hash table code that we in every other place in the backend.
If that code is so bad why do
Hi, after studying ITERVAL and having a long chat with RhoidumToad and
StuckMojo on #postgresql, I am presenting you 3 bugs regarding INTERVAL.
As far as I understand, the Interval struct (binary internal
representation) consists of:
int32 months
int32 days
int64 microseconds
1. OUTPUT ERRORS:
On Sunday, June 23, 2013, Simon Riggs wrote:
On 23 June 2013 03:16, Stephen Frost sfr...@snowman.net javascript:;
wrote:
Still doesn't really address the issue of dups though.
Checking for duplicates in all cases would be wasteful, since often we
are joining to the PK of a smaller table.
On Sunday, June 23, 2013, Simon Riggs wrote:
On 23 June 2013 03:16, Stephen Frost sfr...@snowman.net javascript:;
wrote:
Will think on it more.
Some other thoughts related to this...
* Why are we building a special kind of hash table? Why don't we just
use the hash table code that we in
On 21 June 2013 10:02, Dean Rasheed dean.a.rash...@gmail.com wrote:
On 21 June 2013 06:16, David Fetter da...@fetter.org wrote:
On Fri, Jun 21, 2013 at 12:10:25AM -0400, Alvaro Herrera wrote:
David Fetter escribió:
On Thu, Jun 20, 2013 at 08:59:27PM +0100, Dean Rasheed wrote:
In my
On 21 June 2013 21:04, David Fetter da...@fetter.org wrote:
On Fri, Jun 21, 2013 at 10:48:35AM -0700, David Fetter wrote:
On Mon, Jun 17, 2013 at 11:34:52AM +0100, Dean Rasheed wrote:
On 15 June 2013 10:22, Dean Rasheed dean.a.rash...@gmail.com wrote:
There seem to be 2 separate directions
Amit kapila amit.kap...@huawei.com wrote:
Patch (https://commitfest.postgresql.org/action/patch_view?id=1161) is already
committed by Commit
http://git.postgresql.org/pg/commitdiff/b23160889c963dfe23d8cf1f9be64fb3c535a2d6
It should be marked as Committed in CF.
Done. Thanks!
--
Kevin
Andres Freund and...@2ndquadrant.com wrote:
The git tree is at:
git://git.postgresql.org/git/users/andresfreund/postgres.git branch
xlog-decoding-rebasing-cf4
http://git.postgresql.org/gitweb/?p=users/andresfreund/postgres.git;a=shortlog;h=refs/heads/xlog-decoding-rebasing-cf4
On 2013-06-15
Dean Rasheed dean.a.rash...@gmail.com wrote:
I'm still not happy that this patch is making FILTER a new reserved
keyword, because I think it is a common enough English word (and an
obscure enough SQL keyword) that people may well have used it for
table names or aliases, and so their code will
On 23.06.2013 01:48, Simon Riggs wrote:
On 22 June 2013 21:40, Stephen Frostsfr...@snowman.net wrote:
I'm actually not a huge fan of this as it's certainly not cheap to do. If it
can be shown to be better than an improved heuristic then perhaps it would
work but I'm not convinced.
We need
Kevin Grittner kgri...@ymail.com wrote:
Confirmed that all 17 patch files now apply cleanly, and that `make
check-world` builds cleanly after each patch in turn.
Just to be paranoid, I did one last build with all 17 patch files
applied to 7dfd5cd21c0091e467b16b31a10e20bbedd0a836 using this
Kevin Grittner kgri...@ymail.com wrote:
uninstall:
rm -f '$(DESTDIR)$(bindir)/pg_basebackup$(X)'
rm -f '$(DESTDIR)$(bindir)/pg_receivexlog$(X)'
+ rm -f '$(DESTDIR)$(bindir)/pg_receivellog$(X)'
Oops. That part is not needed.
clean distclean maintainer-clean:
- rm -f
On Wed, Feb 20, 2013 at 04:00:00PM +0400, Alexander Law wrote:
15.02.2013 02:59, Noah Misch wrote:
With your proposed change, the problem will resurface in an actual
SQL_ASCII
database. At the problem's root is write_console()'s assumption that
messages
are in the database encoding.
Andres Freund and...@2ndquadrant.com wrote:
Pushed and attached.
The contrib/test_logical_decoding/sql/ddl.sql script is generating
unexpected results. For both table_with_pkey and
table_with_unique_not_null, updates of the primary key column are
showing:
old-pkey: id[int4]:0
... instead of
On Sun, Jun 23, 2013 at 01:55:19PM +0900, MauMau wrote:
From: Robert Haas robertmh...@gmail.com
On Fri, Jun 21, 2013 at 10:02 PM, MauMau maumau...@gmail.com wrote:
I'm comfortable with 5 seconds. We are talking about the interval
between
sending SIGQUIT to the children and then sending
On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote:
Kevin Grittner kgri...@ymail.com wrote:
Confirmed that all 17 patch files now apply cleanly, and that `make
check-world` builds cleanly after each patch in turn.
Just to be paranoid, I did one last build with all 17 patch files
applied
On 06/13/2013 09:27 PM, Peter Eisentraut wrote:
I think the suggested emacs configuration snippets in
src/tools/editors/emacs.samples no longer represent current best
practices. I have come up with some newer things that I'd like to
propose for review.
First, I propose adding a .dir-locals.el
On Thu, Jun 13, 2013 at 09:27:07PM -0400, Peter Eisentraut wrote:
I think the suggested emacs configuration snippets in
src/tools/editors/emacs.samples no longer represent current best
practices. I have come up with some newer things that I'd like to
propose for review.
((c-mode .
An additional thought:
Yet another thought, hopefully final on this subject.
I think that the probability of a context switch is higher when calling
PQfinish than in other parts of pgbench because it contains system calls
(e.g. closing the network connection) where the kernel is likely to
On 06/23/2013 03:43 PM, Andrew Dunstan wrote:
The idea is a very good one in principle, but my short experiment with
the provided .dir-locals.el didn't give me BSD style brace
indentation. It works if we can do those unsafe things, but then we
surely don't want to have a user prompted to
Andrew Dunstan and...@dunslane.net writes:
The idea is a very good one in principle, but my short experiment with
the provided .dir-locals.el didn't give me BSD style brace indentation.
It works if we can do those unsafe things, but then we surely don't
want to have a user prompted to
On 2013-06-23 10:32:05 -0700, Kevin Grittner wrote:
Andres Freund and...@2ndquadrant.com wrote:
Pushed and attached.
The contrib/test_logical_decoding/sql/ddl.sql script is generating
unexpected results. For both table_with_pkey and
table_with_unique_not_null, updates of the primary key
Andres Freund and...@2ndquadrant.com writes:
On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote:
gcc: error: pg_receivellog.o: No such file or directory
make[3]: *** [pg_receivellog] Error 1
I have seen that once as well. It's really rather strange since
pg_receivellog.o is a clear
On 2013-06-23 16:48:41 -0400, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote:
gcc: error: pg_receivellog.o: No such file or directory
make[3]: *** [pg_receivellog] Error 1
I have seen that once as well. It's really rather
On Wed, Apr 3, 2013 at 8:29 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote:
Hi,
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
Documentation doesn't build, multiple errors. In addition to the reference
pages, there should be a section in the main docs about these templates.
I'm now
Jaime Casanova ja...@2ndquadrant.com writes:
just tried to build this one, but it doesn't apply cleanly anymore...
specially the ColId_or_Sconst contruct in gram.y
Will rebase tomorrow, thanks for the notice!
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et
On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote:
Dean Rasheed dean.a.rash...@gmail.com wrote:
I'm still not happy that this patch is making FILTER a new reserved
keyword, because I think it is a common enough English word (and an
obscure enough SQL keyword) that people may
On Wed, Jun 19, 2013 at 9:50 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Wed, Jun 19, 2013 at 12:36 AM, Fujii Masao masao.fu...@gmail.com wrote:
On Tue, Jun 18, 2013 at 10:53 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
An updated patch for the toast part is attached.
On
On Sun, Jun 23, 2013 at 3:34 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
OK. Please find an updated patch for the toast part.
On Sat, Jun 22, 2013 at 10:48 PM, Andres Freund and...@2ndquadrant.com
wrote:
On 2013-06-22 22:45:26 +0900, Michael Paquier wrote:
On Sat, Jun 22, 2013 at
David Fetter da...@fetter.org writes:
On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote:
I think it is OK if that gets a syntax error. If that's the worst
case I like this approach.
I think reducing the usefulness of error messages is something we need
to think extremely hard
OK, let's try to cover all the bases here in one go.
First, the spec definition of WITH ORDINALITY simply says that the
column name in the result is not equivalent to any other identifier in
the same table primary (including the correlation name). It is
clear that the intention of the spec is
On 06/23/2013 08:00 PM, Andrew Gierth wrote:
OK, let's try to cover all the bases here in one go.
1. Stick with ?column? as a warning flag that you're not supposed to
be using this without aliasing it to something.
How do I actually supply an alias which covers both columns? What does
that
At 2013-06-08 21:45:24 +0100, si...@2ndquadrant.com wrote:
ALTER TABLE foo
ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE;
I read the patch (looks good), applied it on HEAD (fine), ran make check
(fine), and played with it in a test database. It looks great, and from
previous
Current Stats:
Needs Review: 61, Waiting on Author: 19, Ready for Committer: 11,
Committed: 11, Returned with Feedback: 3, Rejected: 1
34 Patches are awaiting review, and do not have a reviewer assigned.
In the last week, 3 patches have moved to Ready for Committer and 3
patches have been
Folks,
For 9.2, we adopted it as policy that anyone submitting a patch to a
commitfest is expected to review at least one patch submitted by someone
else. And that failure to do so would affect the attention your patches
received in the future. For that reason, I'm publishing the list below
of
(Cc: to pgsql-performance dropped, pgsql-hackers added.)
At 2013-05-06 09:14:01 +0100, si...@2ndquadrant.com wrote:
New version of patch attached which fixes a few bugs.
I read the patch, but only skimmed the earlier discussion about it. In
isolation, I can say that the patch applies cleanly
41 matches
Mail list logo
