[HACKERS] warning in code while building on windows

2013-08-17 Thread Amit Kapila
1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: 'isnull' : unreferenced local variable It seems this variable is used only under macro USE_ASSERT_CHECKING, so it is better to declare under this macro only. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -

Re: [HACKERS] [PATCH] pg_sleep(interval)

2013-08-17 Thread Robert Haas
On Fri, Aug 16, 2013 at 4:16 PM, Peter Eisentraut wrote: > That example can be used as an argument against almost any kind of > overloading. Yep. And that may be justified. We don't handle overloading particularly well. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise P

Re: [HACKERS] Feature Request on Extensions

2013-08-17 Thread Peter Eisentraut
On Sat, 2013-08-17 at 17:53 -0400, Steven Citron-Pousty wrote: > What we need is the ability for Postgresql to load extensions from a > users file space. Sure, that would be useful for a number of reasons. I think there was a proposed patch for that a while ago that some people objected to, so th

[HACKERS] Feature Request on Extensions

2013-08-17 Thread Steven Citron-Pousty
Greetings all: I spoke to Josh B and company at OSCON about a feature we really need for PostgreSQL extensions on OpenShift (Red Hat's Platform as a Service). What we need is the ability for Postgresql to load extensions from a users file space. For example, if, as a developer on a machine, I

Re: [HACKERS] psql missing tab completion for extensions

2013-08-17 Thread Dimitri Fontaine
Magnus Hagander writes: >>> Magnus Hagander writes: >>> > psql is missing tab completion for \dx (or more usfully, for \dx+). >>> > Attached patch fixes this. > Done. Thanks! Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsq

Re: [HACKERS] Fix Windows socket error checking for MinGW

2013-08-17 Thread Noah Misch
On Sat, Aug 17, 2013 at 02:04:24PM -0400, Andrew Dunstan wrote: >> On Fri, Aug 16, 2013 at 06:56:45PM -0500, Michael Cronenworth wrote: >>> +#ifndef WIN32 >>> if (SOCK_ERRNO == EWOULDBLOCK) >>> +#else >>> + if (SOCK_ERRNO == WSAEWOULDBLOCK) >>> +#endif > We don't seem to have

Re: [HACKERS] Chinese in Postgres

2013-08-17 Thread Peter Geoghegan
On Fri, Aug 16, 2013 at 4:25 AM, ciifrance...@tiscali.it wrote: > If I insert the data using a C++ program I have empty squares, in this > format: ��� (3 empty squares for each chinese ideogram as that is the length > in UTF-8) > If the string contains chinese mixed with ASCII, the ASCII is OK but

Re: [HACKERS] Fix Windows socket error checking for MinGW

2013-08-17 Thread Andrew Dunstan
On 08/17/2013 01:16 AM, Noah Misch wrote: On Fri, Aug 16, 2013 at 06:56:45PM -0500, Michael Cronenworth wrote: I started a thread on the general list so read that for more info. http://www.postgresql.org/message-id/520a6e55.40...@cchtml.com I'm also going to submit the patch to CommitFest. +#

Re: [HACKERS] dynamic background workers, round two

2013-08-17 Thread Robert Haas
On Sun, Aug 11, 2013 at 1:31 AM, Andres Freund wrote: > So, I'd suggest something like: > > typedef enum BgwHandleStatus { >BGWH_SUCCESS, /* sucessfully got status */ >BGWH_NOT_YET, /* worker hasn't started yet */ >BGWH_GONE, /* worker had been started, but shut down already */ >BG

Re: [HACKERS] StrategyGetBuffer optimization, take 2

2013-08-17 Thread Robert Haas
On Mon, Aug 5, 2013 at 11:49 AM, Merlin Moncure wrote: > *) What I think is happening: > I think we are again getting burned by getting de-scheduled while > holding the free list lock. I've been chasing this problem for a long > time now (for example, see: > http://postgresql.1045698.n5.nabble.com

Re: [HACKERS] libpq thread locking during SSL connection start

2013-08-17 Thread Peter Eisentraut
On Mon, 2013-08-12 at 10:49 -0400, Stephen Frost wrote: > > Alternatively, if we want to just print an error message and > proceed, we > > should put the strerror based on the return value into the message. > > That could certainly be added. Here is a patch for that. I also adjusted the message

Re: [HACKERS] [pgsql-zh-general] Chinese in Postgres

2013-08-17 Thread Huang Bambo
Hi, Francesco, As I mentioned that you said "If I insert the data using a C++ program I have empty squares", I guess you forget to convert you string to UTF-8 before insert. Bambo On Fri, Aug 16, 2013 at 7:25 PM, ciifrance...@tiscali.it < ciifrance...@tiscali.it> wrote: > Hello all, > before wr

New ECPG idea, was: Re: [HACKERS] ECPG FETCH readahead

2013-08-17 Thread Boszormenyi Zoltan
2013-08-17 12:08 keltezéssel, Boszormenyi Zoltan írta: Hi, I am restarting this old thread... :-) 2012-04-24 10:17 keltezéssel, Michael Meskes írta: OK, I will implement #2. Another question popped up: what to do with FETCH ALL? The current readahead window size or temporarily bumping it to sa