Re: [HACKERS] updated emacs configuration

2014-01-30 Thread Bruce Momjian
On Thu, Jan 30, 2014 at 03:36:48PM -0500, Bruce Momjian wrote: > On Thu, Jan 30, 2014 at 03:32:27PM -0500, Robert Haas wrote: > > Or this: > > > > - mp_int_copy(a, b); /* ok: 0 <= r < b */ > > - mp_int_copy(&q, a); /* ok: q <= a */ > > + mp_int_copy(a, b); /* ok: 0 <= r < b */ > > + mp_int_copy

Re: [HACKERS] Review: tests for client programs

2014-01-30 Thread Craig Ringer
On 01/31/2014 02:50 AM, Pavel Stehule wrote: > > 5. I didn't test it on windows I guess that's my cue. I'll be home later today, and will take a look at it on my Windows test setup. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &

Re: [HACKERS] pgindent behavior we could do without

2014-01-30 Thread Tom Lane
Bruce Momjian writes: > OK, seven hours later, I have fixed pg_bsd_indent to no longer insert > blank lines above #elif/#else/#endif, and therefore removed the special > case code from pgindent. > You will need to download version 1.3 of pg_bsd_indent for this to work, > and pgindent will complai

Re: [HACKERS] Making strxfrm() blobs in indexes work

2014-01-30 Thread Peter Geoghegan
On Thu, Jan 30, 2014 at 5:05 PM, Peter Geoghegan wrote: > On Thu, Jan 30, 2014 at 5:04 PM, Tom Lane wrote: >>> That's not hard to prevent. If that should happen, we don't go with >>> the strxfrm() datum. We have a spare IndexTuple bit we could use to >>> mark when the optimization was applied. >>

Re: [HACKERS] Backup throttling

2014-01-30 Thread Fujii Masao
On Tue, Jan 21, 2014 at 1:10 AM, Antonin Houska wrote: > On 01/15/2014 10:52 PM, Alvaro Herrera wrote: >> I gave this patch a look. There was a bug that the final bounds check >> for int32 range was not done when there was no suffix, so in effect you >> could pass numbers larger than UINT_MAX and

[HACKERS] Prefix compression of B-Tree keys

2014-01-30 Thread Claudio Freire
On Thu, Jan 30, 2014 at 9:34 PM, Tom Lane wrote: > Peter Geoghegan writes: >> On more occasions than I care to recall, someone has suggested that it >> would be valuable to do something with strxfrm() blobs in order to >> have cheaper locale-aware text comparisons. One obvious place to do so >> w

Re: [HACKERS] [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR

2014-01-30 Thread Craig Ringer
On 01/30/2014 08:14 PM, MauMau wrote: >> Does this issue also occur on 9.3.2, or in 9.4 HEAD, when tested on >> Win2k12? > > I'm sure it should. The release note doesn't have any reference to this > issue. Another user who reported this issue in pgsql-general > experienced this with 9.2.4. > In

Re: [HACKERS] Prefix compression of B-Tree keys

2014-01-30 Thread Peter Geoghegan
On Thu, Jan 30, 2014 at 9:26 PM, Claudio Freire wrote: > Maybe not TOAST compression, but prefix compression. I've thought about it as well. It's totally feasible, and likely worthwhile, but a little more tricky. > I've been wondering lately, whether a format change in the B-Tree > could be wort

Re: [HACKERS] Regression tests failing if not launched on db "regression"

2014-01-30 Thread Michael Paquier
On Fri, Jan 31, 2014 at 6:09 AM, Robert Haas wrote: > On Thu, Jan 30, 2014 at 3:32 AM, Christian Kruse > wrote: >>> For the documentation patch, I propose the attached to avoid future >>> confusions. Comments? It might make sense to back-patch as well. >> >> Compiles, didn't find any typos and I

<    1   2