Re: [HACKERS] PDF builds broken again

2014-07-25 Thread Devrim Gündüz
Hi, On Wed, 2014-07-23 at 15:53 +0200, Magnus Hagander wrote: I ended up splitting the paragraph in two in order to get the PDFs to build. I've applied a patch for this to 9.0 only so we can keep building PDFs. Thanks for looking at this -- you saved my time. Regards, -- Devrim GÜNDÜZ

Re: [HACKERS] Use unique index for longer pathkeys.

2014-07-25 Thread Kyotaro HORIGUCHI
Hello. I've been cooled off and convinced that this patch has become quite useless by itself. It improves almost only UNIONs with ORDER BY on tables that have unioform primary keys, and needs my another patch to work. I'll try to reintegrate this patch into my 'another patch' as mentioned below

Re: [HACKERS] WAL replay bugs

2014-07-25 Thread Kyotaro HORIGUCHI
Hi, I'm not so confident whether it's the time to do this... I mark this as 'Ready for Committer' since no additional comment or objection was put by others on this patch. After all, I have no more comment about this patch. I will mark this as 'Ready for committer' unless no comment comes

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2014-07-25 Thread Etsuro Fujita
(2014/07/24 18:30), Shigeru Hanada wrote: My coworker Takaaki EITOKU reviewed the patch, and here are some comments from him. Thank you for the review, Eitoku-san! 2014-07-08 16:07 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp: In the patch postgresPlanForeignModify has been modified

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2014-07-25 Thread Albe Laurenz
Shigeru Hanada wrote: * Naming of new behavior You named this optimization Direct Update, but I'm not sure that this is intuitive enough to express this behavior. I would like to hear opinions of native speakers. How about batch foreign update or batch foreign modification? (Disclaimer: I'm

[HACKERS] Introducing coarse grain parallelism by postgres_fdw.

2014-07-25 Thread Kyotaro HORIGUCHI
Hello, I noticed that postgresql_fdw can run in parallel by very small change. The attached patch let scans by postgres_fdws on different foreign servers run sumiltaneously. This seems a convenient entry point to parallel execution. For the testing configuration which the attched sql script

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-25 Thread Emre Hasegeli
Well, I think the number of tabs that makes them look best depends on your tab-stop setting. At present, I find that with 8-space tabs things seem to line up pretty well, whereas with your patch, 4-space tabs line up well. Either way, I have no idea what the picture is supposed to mean,

Re: refactoring allpaths.c (was Re: [HACKERS] Suppressing unused subquery output columns)

2014-07-25 Thread Etsuro Fujita
(2014/06/13 1:37), Tom Lane wrote: I wrote: We have a couple votes for this patch and no one has spoken against it, so I'll go ahead and push it into HEAD. BTW, I forgot to mention that while working on this patch I was thinking it's past time to separate out the subquery support in

Re: [HACKERS] pg_receivexlog add synchronous mode

2014-07-25 Thread furuyao
This patch was made by the following process. 1. post patch for additional pg_receivexlog synchronous mode. 2. In response to comment for the flush frequency, I revise the patch to do flush every consecutive message in reference to walreceiver. 3. The synchronization mode was necessary to

[HACKERS] sendLong in custom communication doesn't work

2014-07-25 Thread Krystian Piećko
Hi, I’m implementing the functionality that will pass all the queries native to postgresql (that asks about structures and versions) to the hidden postgresql and other queries I would like to parse myself. I have a big problem with outputing PG_TYPE_INT[248] value. I’m doing it because in my

Re: [HACKERS] Introducing coarse grain parallelism by postgres_fdw.

2014-07-25 Thread Ashutosh Bapat
Hi Kyotaro, fetch_more_rows() always runs FETCH 100 FROM cursor_name on the foreign server to get the next set of rows. The changes you have made seem to run only the first FETCHes from all the nodes but not the subsequent ones. The optimization will be helpful only when there are less than 100

Re: [HACKERS] Introducing coarse grain parallelism by postgres_fdw.

2014-07-25 Thread Ashutosh Bapat
In order to minimize the impact, what can be done is to execute fetch_more_data() in asynchronous mode every time, when there only few rows left to be consumed. So in current code below 1019 /* 1020 * Get some more tuples, if we've run out. 1021 */ 1022 if (fsstate-next_tuple =

Re: [HACKERS] postgresql.auto.conf and reload

2014-07-25 Thread Fujii Masao
On Wed, Jul 9, 2014 at 11:05 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Jul 9, 2014 at 10:14 AM, Tom Lane t...@sss.pgh.pa.us wrote: Amit Kapila amit.kapil...@gmail.com writes: On Wed, Jul 9, 2014 at 6:40 AM, Mark Kirkwood mark.kirkw...@catalyst.net.nz wrote: Yes, but even

[HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Marco Nenciarini
0. Introduction: = This is a proposal for adding incremental backup support to streaming protocol and hence to pg_basebackup command. 1. Proposal = Our proposal is to introduce the concept of a backup profile. The backup profile

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-25 Thread Tom Lane
Emre Hasegeli e...@hasegeli.com writes: Well, I think the number of tabs that makes them look best depends on your tab-stop setting. At present, I find that with 8-space tabs things seem to line up pretty well, whereas with your patch, 4-space tabs line up well. 4 space tab-stop is not the

Re: [HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Michael Paquier
On Fri, Jul 25, 2014 at 10:14 PM, Marco Nenciarini marco.nenciar...@2ndquadrant.it wrote: 0. Introduction: = This is a proposal for adding incremental backup support to streaming protocol and hence to pg_basebackup command. Not sure that incremental is a right

[HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Alexey Klyukin
Greetings, I'd like to propose a patch for checking subject alternative names entry in the SSL certificate for DNS names during SSL authentication. When the client PGSSLMODE is set to verify-full, the common name (CN) of the PostgreSQL server in the certificate is matched against the actual

Re: [HACKERS] gaussian distribution pgbench -- splits Bv6

2014-07-25 Thread Mitsumasa KONDO
Thanks for your modify the patch! I confirmed that It seems to be fine. I think that our latest patch fill all community comment. So it is really ready for committer now. Best regards, -- Mitsumasa KONDO

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Magnus Hagander
On Fri, Jul 25, 2014 at 6:10 PM, Alexey Klyukin al...@hintbits.com wrote: Greetings, I'd like to propose a patch for checking subject alternative names entry in the SSL certificate for DNS names during SSL authentication. When the client PGSSLMODE is set to verify-full, the common name (CN)

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Alexey Klyukin
On Fri, Jul 25, 2014 at 6:34 PM, Magnus Hagander mag...@hagander.net wrote: I just took a very quick look at the code, and just noticed one thing: Why keep looping once you've found a match? When you set result=true you should break; from the loop I think. Not necessarily for performance,

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Magnus Hagander
On Fri, Jul 25, 2014 at 7:15 PM, Alexey Klyukin al...@hintbits.com wrote: On Fri, Jul 25, 2014 at 6:34 PM, Magnus Hagander mag...@hagander.net wrote: I just took a very quick look at the code, and just noticed one thing: Why keep looping once you've found a match? When you set result=true

Re: [HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Claudio Freire
On Fri, Jul 25, 2014 at 10:14 AM, Marco Nenciarini marco.nenciar...@2ndquadrant.it wrote: 1. Proposal = Our proposal is to introduce the concept of a backup profile. The backup profile consists of a file with one line per file detailing tablespace, path,

Re: [HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Robert Haas
On Fri, Jul 25, 2014 at 2:21 PM, Claudio Freire klaussfre...@gmail.com wrote: On Fri, Jul 25, 2014 at 10:14 AM, Marco Nenciarini marco.nenciar...@2ndquadrant.it wrote: 1. Proposal = Our proposal is to introduce the concept of a backup profile. The backup

Re: [HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Claudio Freire
On Fri, Jul 25, 2014 at 3:44 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 25, 2014 at 2:21 PM, Claudio Freire klaussfre...@gmail.com wrote: On Fri, Jul 25, 2014 at 10:14 AM, Marco Nenciarini marco.nenciar...@2ndquadrant.it wrote: 1. Proposal =

[HACKERS] [w32] test_shm_mq test suite permanently burns connections slots

2014-07-25 Thread Noah Misch
On a Windows or other EXEC_BACKEND build, the following eventually gets failures because all, or all but one, max_connections slot is consumed: for run in `seq 1 100`; do make -C contrib/test_shm_mq installcheck; done When I use max_connections=40, it fails on the sixth iteration. Only the

[HACKERS] Performance issue in pg_dump's dependency loop searching

2014-07-25 Thread Tom Lane
I looked into the performance issue Joe Van Dyk reported in bug #11033. It turns out this is basically a consequence of the section boundary pseudo-objects I added in commit a1ef01fe163b304760088e3e30eb22036910a495. (I'd worried about performance consequences at the time, but hadn't seen any

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Fri, Jul 25, 2014 at 7:15 PM, Alexey Klyukin al...@hintbits.com wrote: On Fri, Jul 25, 2014 at 6:34 PM, Magnus Hagander mag...@hagander.net Why keep looping once you've found a match? When you set result=true you should break; from the loop I

[HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-07-25 Thread Baker, Keith [OCDUS Non-JJ]
I propose that a QNX 6.5 port be introduced to PostgreSQL. I am new to PostgreSQL development, so please bear with me. I have made good progress (with 1 outstanding issue, details below): * I created a QNX 6.5 port of PostgreSQL 9.3.4 which passes regression tests. * I merged

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-07-25 Thread Tom Lane
Baker, Keith [OCDUS Non-JJ] kbak...@its.jnj.com writes: I propose that a QNX 6.5 port be introduced to PostgreSQL. Hmm ... you're aware that there used to be a QNX port? We removed it back in 2006 for lack of interest and maintainers, and AFAIR you're the first person to show any interest in

Re: [HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Josh Berkus
On 07/25/2014 11:49 AM, Claudio Freire wrote: I agree with much of that. However, I'd question whether we can really seriously expect to rely on file modification times for critical data-integrity operations. I wouldn't like it if somebody ran ntpdate to fix the time while the base backup

Re: [HACKERS] Proposal: Incremental Backup

2014-07-25 Thread Claudio Freire
On Fri, Jul 25, 2014 at 7:38 PM, Josh Berkus j...@agliodbs.com wrote: On 07/25/2014 11:49 AM, Claudio Freire wrote: I agree with much of that. However, I'd question whether we can really seriously expect to rely on file modification times for critical data-integrity operations. I wouldn't

Re: [HACKERS] pg_background (and more parallelism infrastructure patches)

2014-07-25 Thread Alvaro Herrera
On Fri, Jul 25, 2014 at 02:11:32PM -0400, Robert Haas wrote: + pq_mq_busy = true; + + iov[0].data = msgtype; + iov[0].len = 1; + iov[1].data = s; + iov[1].len = len; + + Assert(pq_mq_handle != NULL); + result = shm_mq_sendv(pq_mq_handle, iov, 2, false); + +

[HACKERS] pg_background (and more parallelism infrastructure patches)

2014-07-25 Thread Robert Haas
Attached is a contrib module that lets you launch arbitrary command in a background worker, and supporting infrastructure patches for core. You can launch queries and fetch the results back, much as you could do with a dblink connection back to the local database but without the hassles of dealing

Re: [HACKERS] PDF builds broken again

2014-07-25 Thread Peter Eisentraut
On Wed, 2014-07-23 at 12:31 +0200, Magnus Hagander wrote: Do we actually have any buildfarm boxes building the PDFs? And if so, any idea why they didn't catch it? My jenkins does that, and I reported the problem here

Re: [HACKERS] postgresql.auto.conf and reload

2014-07-25 Thread Amit Kapila
On Fri, Jul 25, 2014 at 6:11 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jul 9, 2014 at 11:05 PM, Amit Kapila amit.kapil...@gmail.com wrote: Okay. As mentioned upthread, I have fixed by ensuring that for duplicate config params, retain only which comes later during parsing. I think