Re: [HACKERS] Portability issues in TAP tests

2014-10-28 Thread Peter Eisentraut
On 7/21/14 10:06 AM, Christoph Berg wrote: 6. The tests fail if your $LANG isn't en_something: This was fixed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-28 Thread Peter Eisentraut
On 10/7/14 1:57 PM, Tom Lane wrote: Peter had a patch to eliminate the overhead of multiple subinstalls; not sure where that stands, but presumably it would address your issue. It will need some cleverness to sort out the parallel make issues that were brought up in the review thread. --

Re: [HACKERS] pg_basebackup fails with long tablespace paths

2014-10-28 Thread Peter Eisentraut
On 10/20/14 2:59 PM, Tom Lane wrote: My Salesforce colleague Thomas Fanghaenel observed that the TAP tests for pg_basebackup fail when run in a sufficiently deeply-nested directory tree. As for the test, we can do something like the attached to mark the test as TODO. diff --git

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-28 Thread Peter Eisentraut
On 10/27/14 11:41 AM, Robert Haas wrote: Beyond all that, I have serious doubts about whether, even if we eventually get these tests mostly working in most places, whether they will actually catch any bugs. Well, they caught the fact that pg_basebackup can't back up tablespaces with names

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-28 Thread Peter Eisentraut
On 10/28/14 12:46 AM, Noah Misch wrote: Agreed. Having this framework when the pg_upgrade test suite originated would have prevented acquiring parallel implementations in Perl and shell. Yes, that was certainly a motivation, and I would like to continue work on pg_upgrade testing.

Re: [HACKERS] how to handle missing prove

2014-10-28 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Here is a patch to use missing to handle the case when prove is not present. Wouldn't it be easier to do what we do for Perl, viz in Makefile.global.in ifneq (@PERL@,) # quoted to protect pathname with spaces PERL= '@PERL@' else

Re: [HACKERS] Directory/File Access Permissions for COPY and Generic File Access Functions

2014-10-28 Thread Peter Eisentraut
On 10/27/14 7:36 PM, Stephen Frost wrote: MySQL: http://dev.mysql.com/doc/refman/5.1/en/privileges-provided.html#priv_file (note they provide a way to limit access also, via secure_file_priv) They have a single privilege to allow the user to read or write any file. I think that feature

Re: [HACKERS] how to handle missing prove

2014-10-28 Thread Peter Eisentraut
On 10/28/14 9:16 PM, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Here is a patch to use missing to handle the case when prove is not present. Wouldn't it be easier to do what we do for Perl, viz in Makefile.global.in ifneq (@PERL@,) # quoted to protect pathname with

Re: [HACKERS] how to handle missing prove

2014-10-28 Thread Andrew Dunstan
On 10/28/2014 09:16 PM, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Here is a patch to use missing to handle the case when prove is not present. Wouldn't it be easier to do what we do for Perl, viz in Makefile.global.in ifneq (@PERL@,) # quoted to protect pathname with

[HACKERS] Allow peer/ident to fall back to md5?

2014-10-28 Thread Craig Ringer
Hi all At pgconf-eu Álvaro and I were discussing the idea of allowing 'peer' and 'ident' authentication to fall back to md5 if the peer/ident check failed. This can be done backwards compatibly and without protocol changes. A client won't be able to tell that the pg_hba.conf line wasn't 'md5'.

Re: [HACKERS] logical decoding - reading a user catalog table

2014-10-28 Thread Steve Singer
On 10/28/2014 01:31 PM, Andres Freund wrote: On 2014-10-25 18:18:07 -0400, Steve Singer wrote: My logical decoding plugin is occasionally getting this error could not resolve cmin/cmax of catalog tuple I get this when my output plugin is trying to read one of the user defined catalog tables

Re: [HACKERS] Allow peer/ident to fall back to md5?

2014-10-28 Thread Tom Lane
Craig Ringer cr...@2ndquadrant.com writes: At pgconf-eu Álvaro and I were discussing the idea of allowing 'peer' and 'ident' authentication to fall back to md5 if the peer/ident check failed. I think it would be acceptable to define *new* auth modes that work that way. I'm violently against

Re: [HACKERS] Allow peer/ident to fall back to md5?

2014-10-28 Thread Craig Ringer
On 10/29/2014 10:45 AM, Tom Lane wrote: Craig Ringer cr...@2ndquadrant.com writes: At pgconf-eu Álvaro and I were discussing the idea of allowing 'peer' and 'ident' authentication to fall back to md5 if the peer/ident check failed. I think it would be acceptable to define *new* auth modes

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-28 Thread Tom Lane
I wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: [Some more code and git-log reading later] I see that the %z is a very recent addition: it only got there as of commit ad5d46a449, of September 5th ... and now I also see that hamerkop's last green run before the failure, on Oct 13rd,

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-10-28 Thread Amit Kapila
On Tue, Oct 28, 2014 at 9:27 AM, Dilip kumar dilip.ku...@huawei.com wrote: On 28 October 2014 09:18, Amit Kapila Wrote, I am worried about the case if after setting the inAbort flag, PQCancel() fails (returns error). If select(maxFd + 1, workerset, NULL, NULL, tv); come out, we can know

<    1   2