Hi,
Amit pinged me about my opinion of this patch. I don't really have
time/energy for an in-depth review right now, but since I'd looked
enough to see some troublesome points, I thought I'd write those.
On 2015-06-30 08:02:25 +0100, Simon Riggs wrote:
> Proposal for improving this is to acquire
On 07/08/2015 01:15 PM, Дмитрий Воронин wrote:
07.07.2015, 18:34, "Michael Paquier" :
Speaking of which, I have rewritten the patch as attached. This looks
way cleaner than the previous version submitted. Dmitry, does that
look fine for you?
I am switching this patch as "Waiting on Auth
Hi,
On 08/22/2015 08:39 AM, Fabien COELHO wrote:
Hello Tomas,
from time to time I need to correlate PostgreSQL logs to other logs,
containing numeric timestamps - a prime example of that is pgbench. With
%t and %m that's not quite trivial, because of timezones etc.
I propose adding two new l
Tomas Vondra writes:
> On 08/21/2015 08:37 PM, Tom Lane wrote:
>> ... But suppose we add a parameter to memory context stats
>> collection that is the maximum number of child contexts to print *per
>> parent context*. If there are more than that, summarize the rest as per
>> your suggestion.
>>
Greg Stark writes:
> On Thu, Aug 20, 2015 at 3:29 PM, Tom Lane wrote:
>> That seems worth poking into.
> Mea culpa. Not a planner crash but rather an overflow from exp(). It
> turns out exp() and other math library functions on Vax do not signal
> FPE but rather have a curious api that lets us c
On 08/22/2015 06:06 PM, Tom Lane wrote:
Tomas Vondra writes:
Couldn't we make it a bit smarter to handle even cases like this? For
example we might first count/sum the child contexts, and then print
either all child contexts (if there are only a few of them) or just
those that are >5% of the
Tomas Vondra writes:
> One question regarding the proposed patch though - if I get it right
> (just looking at the diff), it simply limits the output to first 100
> child contexts at each level independently. So if each of those 100
> child contexts has >100 child contexts on it's own, we get 1
On Tue, Aug 18, 2015 at 8:59 AM, Robert Haas wrote:
> On Mon, Aug 17, 2015 at 5:41 PM, Jeff Janes wrote:
> > User backends attempt to take the lock conditionally, because otherwise
> they
> > would cause an autovacuum already holding the lock to cancel itself,
> which
> > seems quite bad.
> >
>
On Tue, Aug 18, 2015 at 3:32 PM, David Fetter wrote:
> On Tue, Aug 18, 2015 at 04:54:07PM +0100, Greg Stark wrote:
> > On Tue, Aug 18, 2015 at 2:16 PM, David Fetter wrote:
> > > I'm given to understand that this tight coupling is necessary for
> > > performance. Are you saying that it could be
Hi all,
attached is a v2 of the patch, reworked based on the comments.
1) fix the docs (explicitly say that it's a Unix epoch)
2) handle 'padding' properly
3) get rid of timestamp_str - use appendString* methods directly
4) support just the "with milliseconds" using '%n' escape sequence
All
I had a few second thoughts about the wording of the error messages
in this area.
First, consider
create or replace function foo() returns void language plpgsql as $$
begin
<>
loop
exit lab1; -- ok
end loop;
loop
exit lab1; -- not so ok
end loop;
end$$;
ERROR: label "lab1" d
Hello Tomas,
Review of v2:
attached is a v2 of the patch, reworked based on the comments.
The patch applies cleanly to head, it compiles, I tested it and it mostly
work as expected, see below.
1) fix the docs (explicitly say that it's a Unix epoch)
I would add the word "numeric" in fro
On 22 Aug 2015 18:02, "Tom Lane" wrote:
>
> Why not define infnan() and make it do the same thing as
> FloatExceptionHandler? Or was that what you meant?
That's exactly what I meant, instead of my quick hack to add a signal
handler for sigill.
> > The hang is actually in the groupingset tests i
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/20/2015 07:54 AM, Joe Conway wrote:
> On 08/20/2015 06:59 AM, Andrew Dunstan wrote:
>> I was a bit interested in pg_config information, for this reason:
>> I had a report of someone who had configured using --with-libxml
>> but the xml tests actu
On 08/22/2015 09:54 PM, Fabien COELHO wrote:
Hello Tomas,
Review of v2:
attached is a v2 of the patch, reworked based on the comments.
The patch applies cleanly to head, it compiles, I tested it and it
mostly work as expected, see below.
1) fix the docs (explicitly say that it's a Unix
On 8/20/15 3:50 PM, Andres Freund wrote:
>> But, under any scheme to set wal_level automatically, how will the
>> primary know whether it needs to use level archive or hot_standby?
>
> I'd have said archive_mode triggered archive and everything else
> hot_standby.
That might be a decent heuristic
On Wed, Aug 19, 2015 at 12:13 PM, Fabien COELHO wrote:
>
> Sure, I think what can help here is a testcase/'s (in form of script file
>> or some other form, to test this behaviour of patch) which you can write
>> and post here, so that others can use that to get the data and share it.
>>
>
> Sure.
Greg Stark writes:
> Hmm. The backtrace is here but I think it's lying about the specific line.
> #0 convert_one_string_to_scalar (value=0x7f20e9a3 " ",
> rangelo=32, rangehi=122, 2132863395, 32, 122)
> at selfuncs.c:3873
> #1 0x00435880 in convert_string_to_scalar (
> value=0x7f20
18 matches
Mail list logo
