Re: [HACKERS] extend pgbench expressions with functions

2016-01-28 Thread Robert Haas
On Thu, Jan 28, 2016 at 1:36 AM, Fabien COELHO wrote: > So I'm arguing that exiting, with an error message, is better than handling > user errors. I'm not objecting to exiting with an error message, but I think letting ourselves be killed by a signal is no good. -- Robert

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Robert Haas
On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra wrote: >> How about >> User-Interface-Bikeshedded-By: >> ? > > +1 That's sort of implicitly pejorative. Maybe we could find another way to phrase that, like "Design-suggestions-by" or maybe a more general

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2016-01-28 Thread Robert Haas
On Thu, Jan 28, 2016 at 8:41 AM, Amit Langote wrote: > Or keep scanned_heap_pages as is and add a skipped_pages (or > skipped_heap_pages). I guess the latter would be updated not only for > all visible skipped pages but also pin skipped pages. That is, > updating its

Re: [HACKERS] New committer

2016-01-28 Thread Etsuro Fujita
On 2016/01/29 9:01, Michael Paquier wrote: On Fri, Jan 29, 2016 at 1:42 AM, Peter Geoghegan wrote: On Thu, Jan 28, 2016 at 6:37 AM, Magnus Hagander wrote: The PostgreSQL core team would like to welcome Dean Rasheed as a new committer for the PostgreSQL

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2016-01-28 Thread Thomas Munro
On Thu, Dec 3, 2015 at 1:00 PM, Craig Ringer wrote: > On 3 December 2015 at 04:22, Julian Schauder > wrote: > >> >> I suggest adding a new state to pg_stat_activity.state for backends that >> are >> >> waiting for their synchronous commit to be

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-28 Thread Fujii Masao
On Thu, Jan 28, 2016 at 6:08 PM, Shulgin, Oleksandr wrote: > On Thu, Jan 28, 2016 at 9:42 AM, Craig Ringer wrote: >> >> >> On 28 January 2016 at 16:36, Shulgin, Oleksandr >> wrote: >>> >>> On Thu, Jan 28, 2016 at

[HACKERS] Trigger.sgml

2016-01-28 Thread Tatsuo Ishii
I am working as a volunteer to translate docs to Japanese. I have been having hard time to parse the following sentence in doc/src/sgml/trigger.sgml. The possibility of surprising outcomes should be considered when there are

Re: [HACKERS] tiny doc patch

2016-01-28 Thread Filip Rembiałkowski
right. On Thu, Jan 14, 2016 at 5:46 PM, Robert Haas wrote: > On Thu, Jan 14, 2016 at 8:40 AM, Filip Rembiałkowski > wrote: > > (include RLS option in CREATE USER doc) > > > > should go into HEAD and REL9_5_STABLE > > Doesn't ALTER USER

Re: [HACKERS] [PATCH] better systemd integration

2016-01-28 Thread Peter Eisentraut
On 1/28/16 4:00 AM, Pavel Stehule wrote: > Hi > > 2016-01-28 3:50 GMT+01:00 Peter Eisentraut >: > > On 1/27/16 7:02 AM, Pavel Stehule wrote: > > The issues: > > > > 1. configure missing systemd integration test, compilation fails: >

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Robert Haas
On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra wrote: > On 01/28/2016 01:57 PM, Robert Haas wrote: >> One of the things I like about the current free-form approach is that >> you can indicate nuances, like: >> >> Person X reviewed an earlier version of this patch that

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2016-01-28 Thread Anastasia Lubennikova
31.08.2015 10:41, Anastasia Lubennikova: Hi, hackers! I'm going to begin work on effective storage of duplicate keys in B-tree index. The main idea is to implement posting lists and posting trees for B-tree index pages as it's already done for GIN. In a nutshell, effective storing of

Re: [HACKERS] New committer

2016-01-28 Thread David Fetter
On Thu, Jan 28, 2016 at 03:37:33PM +0100, Magnus Hagander wrote: > Hello! > > The PostgreSQL core team would like to welcome Dean Rasheed as a new > committer for the PostgreSQL project. > > Dean - welcome! Now let's see how quickly you can break the > buildfarm! Kudos! Cheers, David. --

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Joshua D. Drake
On 01/28/2016 06:57 AM, Robert Haas wrote: I'm on board with Bruce's template as being a checklist of points to be sure to cover when composing a commit message. I'm not sure we need fixed-format rules. Well, I think what people are asking for is precisely a fixed format, and I do think

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Stephen Frost
* Joshua D. Drake (j...@commandprompt.com) wrote: > On 01/28/2016 06:57 AM, Robert Haas wrote: > > >>I'm on board with Bruce's template as being a checklist of points to be > >>sure to cover when composing a commit message. I'm not sure we need > >>fixed-format rules. > > > >Well, I think what

[HACKERS] insufficient qualification of some objects in dump files

2016-01-28 Thread Peter Eisentraut
Some dump objects whose names are not unique on a schema level have insufficient details in the dump TOC. For example, a column default might have a TOC entry like this: 2153; 2604 39696 DEFAULT public a rolename Note that this only contains the schema name and the column name, but not the

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2016-01-28 Thread Thom Brown
On 28 January 2016 at 16:12, Anastasia Lubennikova < a.lubennik...@postgrespro.ru> wrote: > > 28.01.2016 18:12, Thom Brown: > > On 28 January 2016 at 14:06, Anastasia Lubennikova < > a.lubennik...@postgrespro.ru> wrote: > >> >> 31.08.2015 10:41, Anastasia Lubennikova: >> >> Hi, hackers! >> I'm

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Robert Haas
On Thu, Jan 28, 2016 at 9:52 AM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra >> wrote: >>> Why can't we do both? That is, have a free-form text with the nuances, and >>> then

[HACKERS] HEADSUP: gitmaster.postgresql.org - upgrade NOW

2016-01-28 Thread Stefan Kaltenbrunner
Hi all! Per discussion in the afternoon break at FOSDEM/PGDay 2016 Developer Meeting we are going to upgrade gemulon.postgresql.org aka "gitmaster" today (the upgrade was originally scheduled end of last year but due to release and other constraints was never executed). The upgrade is going to

Re: [HACKERS] [PATCH] better systemd integration

2016-01-28 Thread Alvaro Herrera
I wonder if instead of HAVE_SYSTEMD at each callsite we shouldn't instead have a pg_sd_notify() call that's a no-op when not systemd. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers

Re: [HACKERS] New committer

2016-01-28 Thread Amit Kapila
On Thu, Jan 28, 2016 at 8:07 PM, Magnus Hagander wrote: > Hello! > > The PostgreSQL core team would like to welcome Dean Rasheed as a new > committer for the PostgreSQL project. > > Many Congratulation Dean! With Regards, Amit Kapila. EnterpriseDB:

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2016-01-28 Thread Thom Brown
On 28 January 2016 at 14:06, Anastasia Lubennikova < a.lubennik...@postgrespro.ru> wrote: > > 31.08.2015 10:41, Anastasia Lubennikova: > > Hi, hackers! > I'm going to begin work on effective storage of duplicate keys in B-tree > index. > The main idea is to implement posting lists and posting

Re: [HACKERS] Additional role attributes && superuser review

2016-01-28 Thread Michael Paquier
On Fri, Jan 29, 2016 at 6:37 AM, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: >> On Thu, Jan 28, 2016 at 11:04 AM, Stephen Frost wrote: >> > Personally, I don't have any particular issue having both, but the >> > desire was stated

<    1   2