Re: [HACKERS] psql: tab completion for \l

Gerdan Santos writes: > I did some tests and found nothing special. The stated resource is > implemented correctly. > He passes all regression tests and enables the use of the new features > specified. > The new status of this patch is: Ready for Committer Pushed, thanks.

Re: [HACKERS] tab completion for alter extension

Gerdan Santos writes: > I did some tests and found nothing special. The stated resource is > implemented correctly. > He passes all regression tests and enables the use of the new features > specified. > The new status of this patch is: Ready for Committer Pushed, thanks.

Re: [HACKERS] Pluggable storage

On August 18, 2016 7:44:50 AM PDT, Ants Aasma wrote: >On Tue, Aug 16, 2016 at 9:46 PM, Andres Freund >wrote: >> On 2016-08-15 12:02:18 -0400, Robert Haas wrote: >>> I am somewhat inclined to >>> believe that we need to restructure the executor in a

Re: [HACKERS] [Patch] New psql prompt substitution %r (m = master, r = replica)

Aleksander Alekseev wrote: > Peter has a good point that in general case it's more complicated than > just master or replica. I also agree with David that what actually > would be nice to have is a some syntax that allows user to execute > arbitrary commands before displaying a prompt. This way

Re: [HACKERS] [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)

2016-08-18 16:33 GMT+02:00 Tomas Vondra : > On 08/15/2016 12:23 PM, Pavel Stehule wrote: > >> >> >> 2016-08-15 12:18 GMT+02:00 Aleksander Alekseev >> >: >> >> > The global temporary tables has

Re: [HACKERS] regexp_match() returning text

Emre Hasegeli writes: >> I did *not* push the hunk in citext.sgml, since that was alleging support >> that doesn't actually exist in this patch. To make this work for citext, >> we need to add wrapper functions similar to citext's wrappers for >> regexp_matches. And that in

Re: [HACKERS] Pluggable storage

On Tue, Aug 16, 2016 at 9:46 PM, Andres Freund wrote: > On 2016-08-15 12:02:18 -0400, Robert Haas wrote: >> I am somewhat inclined to >> believe that we need to restructure the executor in a bigger way so >> that it passes around datums instead of tuples; I'm inclined to >>

Re: [HACKERS] [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)

On 08/15/2016 12:23 PM, Pavel Stehule wrote: 2016-08-15 12:18 GMT+02:00 Aleksander Alekseev >: > The global temporary tables has persistent rows in the catalogue. The > mapping to files can be marked as special and real

Re: [HACKERS] [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)

On 08/17/2016 11:50 AM, Aleksander Alekseev wrote: That doesn't really solve the problem, because OTHER backends won't be able to see them. So, if I create a fast temporary table in one session that depends on a permanent object, some other session can drop the permanent object. If there were

Re: [HACKERS] Anyone want to update our Windows timezone map?

On Thu, Aug 18, 2016 at 3:30 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane wrote: > >> If we got this done in the next couple weeks, any resulting changes > >> could go out in 9.6rc1.

Re: [HACKERS] Anyone want to update our Windows timezone map?

Magnus Hagander writes: > Done. I skipped 9.1 given it's status and that the backpatch didn't apply > cleanly there (we moved code around). I think the same code exists in a different file in 9.1, but I concur that it's probably not worth a lot of effort.

Re: [HACKERS] Anyone want to update our Windows timezone map?

On Thu, Aug 18, 2016 at 3:34 PM, Magnus Hagander wrote: > > > On Thu, Aug 18, 2016 at 3:30 PM, Tom Lane wrote: > >> Magnus Hagander writes: >> > On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane wrote: >> >> If we got

Re: [HACKERS] Anyone want to update our Windows timezone map?

Magnus Hagander writes: > On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane wrote: >> If we got this done in the next couple weeks, any resulting changes >> could go out in 9.6rc1. Given that we've not done this routinely, >> that seems like a better plan than

Re: [HACKERS] PATCH: Exclude additional directories in pg_basebackup

On 8/17/16 7:56 PM, Michael Paquier wrote: > On Thu, Aug 18, 2016 at 1:35 AM, Alvaro Herrera > wrote: >> I don't remember how pg_snapshot works, but it's probably fine >> to start with an empty subdir (is it possible to export a snapshot from >> a prepared transaction?)

Re: [HACKERS] Anyone want to update our Windows timezone map?

On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Thu, Aug 18, 2016 at 7:06 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> OK, so after re-running that on my Win10 station and a newly updated > >> Win7

Re: [HACKERS] Anyone want to update our Windows timezone map?

Magnus Hagander writes: > On Thu, Aug 18, 2016 at 7:06 AM, Michael Paquier > wrote: >> OK, so after re-running that on my Win10 station and a newly updated >> Win7 station I am finishing with the attached that combines all the >> changes. >

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

On Thu, Aug 18, 2016 at 9:28 PM, Heikki Linnakangas wrote: >> # This makefile generates two outputs: >> # >> # libpgcommon.a - contains object files with FRONTEND defined, >> # for use by client application and libraries >> # >> # libpgcommon_srv.a -

Re: [HACKERS] [Patch] New psql prompt substitution %r (m = master, r = replica)

Hello, Alvaro. > ... this is terrible. Not only because it's a lot of code dependent > on an external tool which will be rather heavyhanded for something > that should probably be very lightweight, but also because the code > itself is (no offense) an unreadable mess. > > I think your general

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

On 07/22/2016 03:02 AM, Tom Lane wrote: Michael Paquier writes: On Fri, Jul 22, 2016 at 8:48 AM, Tom Lane wrote: I'm confused. We need that code in both libpq and backend, no? src/common is the place for stuff of that description. Not

Re: [HACKERS] Anyone want to update our Windows timezone map?

On Thu, Aug 18, 2016 at 7:38 PM, Magnus Hagander wrote: > Thanks, pushed for master and 9.6. Cool. Thanks for the commit. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] [Patch] New psql prompt substitution %r (m = master, r = replica)

Aleksander Alekseev wrote: > $ cat ~/.psqlrc > select (case when pg_is_in_recovery() then 'r' else 'm' end) as mor > \gset > > \set PROMPT1 '%p (%:mor:) =# ' Okay, this seems moderately reasonable, but ... > Besides I figured out that replica promotion case could also be properly > handled

Re: [HACKERS] Pluggable storage

On Wed, Aug 17, 2016 at 10:33 PM, Alvaro Herrera wrote: > Anastasia Lubennikova wrote: >> >> Except these, there are some pretty strange and unrelated functions in >> src/backend/catalog. >> I'm willing to fix them, but I'd like to synchronize our efforts. > > I very

Re: [HACKERS] Pluggable storage

On Thu, Aug 18, 2016 at 10:58 AM, Simon Riggs wrote: > On 16 August 2016 at 19:46, Andres Freund wrote: > > On 2016-08-15 12:02:18 -0400, Robert Haas wrote: > >> Thanks for taking a stab at this. I'd like to throw out a few concerns. > >> > >> One,

Re: [HACKERS] [PATCH] Alter or rename enum value

> Emre, I noticed you modified the commitfest entry > (https://commitfest.postgresql.org/10/588/) to be for Andrew's > transactional enum addition patch instead, but didn't change the title. > I'll revert that as soon as it picks up this latest patch. Do you wish > to remain a reviewer for this

Re: [HACKERS] [PATCH] bigint txids vs 'xid' type, new txid_recent(bigint) => xid

On Tue, Aug 16, 2016 at 2:45 PM, Craig Ringer wrote: > Hi all > > While implementing support for traceable transactions (finding out after the > fact whether an xact committed or aborted), I've found that Pg is very > inconsistent with what it considers a transaction ID

Re: [HACKERS] [PATCH] Alter or rename enum value

ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > >> I was bored and thought "how hard could it be?", and a few hours' >> hacking later, I have something that seems to work. It doesn't do IF >> NOT EXISTS yet, and the error messaging

Re: [HACKERS] Anyone want to update our Windows timezone map?

On Thu, Aug 18, 2016 at 7:06 AM, Michael Paquier wrote: > On Tue, Aug 16, 2016 at 6:22 PM, Magnus Hagander > wrote: > > I think what we want is basically the UNION ALL of all the different > active > > versions. If we just use the definitions from

Re: [HACKERS] regexp_match() returning text

> I did *not* push the hunk in citext.sgml, since that was alleging support > that doesn't actually exist in this patch. To make this work for citext, > we need to add wrapper functions similar to citext's wrappers for > regexp_matches. And that in turn means a citext extension version bump, >

Re: [HACKERS] [PATCH] bigint txids vs 'xid' type, new txid_recent(bigint) => xid

On 16 August 2016 at 21:44, Craig Ringer wrote: > On 16 August 2016 at 20:58, Greg Stark wrote: > >> On Tue, Aug 16, 2016 at 10:15 AM, Craig Ringer >> wrote: >> > I'm surprised the 32-bit xid was ever exposed to the user, rather than

Re: [HACKERS] patch proposal

* Venkata B Nagothi (nag1...@gmail.com) wrote: > On Wed, Aug 17, 2016 at 11:27 PM, Stephen Frost wrote: > > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > > Agreed. Additional option like "pause" would. As long as there is an > > option > > > to ensure following happens if

Re: [HACKERS] Fix comment in ATExecValidateConstraint

On 2016/07/25 17:18, Amit Langote wrote: > The comment seems to have been copied from ATExecAddColumn, which says: > > /* > * If we are told not to recurse, there had better not be any > - * child tables; else the addition would put them out of step. > > For ATExecValidateConstraint, it

Re: [HACKERS] Missing checks when malloc returns NULL...

On 06/22/2016 04:41 AM, Michael Paquier wrote: On Tue, Jun 21, 2016 at 10:46 PM, Tom Lane wrote: Michael Paquier writes: - mcxt.c uses that, which is surprising: @@ -704,7 +704,8 @@ MemoryContextCreate(NodeTag tag, Size size, { /*

Re: [HACKERS] Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC]

Thank you for your corrections. Here is the patch with suggestions taken into account, except 6th. >6) I'd rather use alignednewsize here. > +ItemIdSetNormal(tupid, offset + size_diff, newsize); This behavior is accroding to ubiquitous PageAddItem. Best regards, Andrey Borodin, Octonica &

Re: [HACKERS] Pluggable storage

On 16 August 2016 at 19:46, Andres Freund wrote: > On 2016-08-15 12:02:18 -0400, Robert Haas wrote: >> Thanks for taking a stab at this. I'd like to throw out a few concerns. >> >> One, I'm worried that adding an additional layer of pointer-jumping is >> going to slow things

Re: [HACKERS] patch proposal

On Thu, Aug 18, 2016 at 3:37 PM, Michael Paquier wrote: > On Tue, Aug 16, 2016 at 11:06 PM, Stephen Frost > wrote: > > I could see supporting an additional "pause" option that means "pause at > > the end of WAL if you don't reach the recovery

<    1   2