On Sat, Mar 11, 2017 at 9:01 AM, Pavel Stehule
wrote:
> I am sending minor update - cleaning formatting and white spaces, error
> messages + few more tests
>
Thank you very much for your help
> Maybe correspondingClause needs own node type with attached location.
On Sun, Mar 12, 2017 at 8:06 AM, Robert Haas wrote:
> On Sat, Mar 11, 2017 at 12:20 AM, Amit Kapila wrote:
>>> /*
>>> + * Change the shared buffer state in critical section,
>>> + * otherwise any
On Thu, Mar 9, 2017 at 3:11 AM, Robert Haas wrote:
> On Tue, Mar 7, 2017 at 6:41 PM, Robert Haas wrote:
Great, thanks. 0001 looks good to me now, so committed.
>>>
>>> Committed 0002.
>>
>> Here are some initial review thoughts on 0003 based on
On Wed, Mar 8, 2017 at 1:54 AM, Robert Haas wrote:
> There are two places where we currently set CURSOR_OPT_PARALLEL_OK in
> PL/pgsql: exec_stmt_return_query() sets it when calling
> exec_dynquery_with_params(), and exec_run_select() calls it when
> calling
On Mon, Mar 13, 2017 at 4:59 AM, Amit Khandekar wrote:
> I agree that we should preferably have the non-partial plans started
> first. But I am not sure if it is really worth ordering the partial
> plans by cost. The reason we ended up not keeping track of the
>
On Mon, Mar 13, 2017 at 8:33 AM, Masahiko Sawada
wrote:
> Hi,
>
> Attached fixes comment typos in snapbuild.c file.
>
Applied, thanks.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
On 13.03.2017 13:01, Anastasia Lubennikova wrote:
Thanks for catching that.
It was caused by a conflict on applying of the patch.
Updated versions of both patches are attached.
I think the code is good and the patches are small. Documentation is
updated by the patches.
All regression
On Mon, Mar 13, 2017 at 9:24 AM, Nico Williams
wrote:
> On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote:
> > From my day-to-day work I can tell, the date(time) type is the only
> missing
> > piece of JSON to make it perfect for business applications (besides,
On 2017/03/13 19:24, Amit Langote wrote:
> On 2017/03/10 17:57, Amit Langote wrote:
>> On 2017/03/08 22:36, Robert Haas wrote:
>>> On Wed, Mar 8, 2017 at 5:36 AM, Amit Langote wrote:
> -rel = mtstate->resultRelInfo->ri_RelationDesc;
> +nominalRTE = rt_fetch(node->nominalRelation,
On 2017/03/10 17:57, Amit Langote wrote:
> On 2017/03/08 22:36, Robert Haas wrote:
>> On Wed, Mar 8, 2017 at 5:36 AM, Amit Langote wrote:
-rel = mtstate->resultRelInfo->ri_RelationDesc;
+nominalRTE = rt_fetch(node->nominalRelation, estate->es_range_table);
+nominalRel =
On 3 March 2017 at 03:53, Tomas Vondra wrote:
> This time with the attachments
It's been a long while since I looked at this patch, but I'm now taking
another look.
I've made a list of stuff I've found from making my first pass on 0001 and
0002. Some of the
13.03.2017 11:53, Artur Zakirov:
On 15.02.2017 20:54, Anastasia Lubennikova wrote:
Done.
I have gotten the error that AlterUserMappingStmt doesn't have
if_not_exists (in Russian):
gram.y: В функции «base_yyparse»:
gram.y:4918:7: ошибка: «AlterUserMappingStmt {aka struct
Tom Lane writes:
> For the basic build process, we've largely solved that through the
> use of "make -s". But we don't really have a comparable "be quiet"
> option for test runs, especially not the TAP tests. Maybe we need
> to think a bit more globally about what it is
On 12 March 2017 at 19:31, Tels wrote:
> Moin,
>
> On Sat, March 11, 2017 11:29 pm, Robert Haas wrote:
>> On Fri, Mar 10, 2017 at 6:01 AM, Tels
>> wrote:
>>> Just a question for me to understand the implementation details vs. the
>>>
On 10 March 2017 at 22:08, Robert Haas wrote:
> On Fri, Mar 10, 2017 at 12:17 AM, Amit Khandekar
> wrote:
>> I agree that the two-lists approach will consume less memory than
>> bitmapset. Keeping two lists will effectively have an extra pointer
>>
> Will Emre be around to make the required changes to the patch? I see
> it's been a while since it was originally posted.
I am around. I can post an update in a few days. Thank you for
picking this up.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
On 15.02.2017 20:54, Anastasia Lubennikova wrote:
Done.
I have gotten the error that AlterUserMappingStmt doesn't have
if_not_exists (in Russian):
gram.y: В функции «base_yyparse»:
gram.y:4918:7: ошибка: «AlterUserMappingStmt {aka struct AlterUserMappingStmt}»
не содержит элемента с
On 12 March 2017 at 06:51, Joe Conway wrote:
> My opinion is that the user visible aspects of this should be deprecated
> and correct syntax provided. But perhaps that is overkill.
FWIW, in my experience, pretty much nobody understands the pretty
tangled behaviour of "WITH
Hello,
On Mon, Mar 13, 2017 at 1:49 PM, Prabhat Sahu wrote:
> Hi,
>
> 2)Getting "Aborted (core dumped)" error at the time of running
> pg_basebackup , *(this issue is only coming on Linux32 ,not on Linux64)*
> we have double check to confirm it .
>
> Steps to
Hi,
2)Getting "Aborted (core dumped)" error at the time of running
pg_basebackup , *(this issue is only coming on Linux32 ,not on Linux64)*
we have double check to confirm it .
Steps to reproduce on Linux32
> ===
>> fetch the sources
>> apply both the patches
>> ./configure
On Thu, Mar 9, 2017 at 5:28 PM, Thomas Munro
wrote:
> On Wed, Mar 8, 2017 at 12:58 PM, Andres Freund wrote:
> > 0002: Check hash join work_mem usage at the point of chunk allocation.
> >
> > Modify the existing hash join code to detect work_mem
Hi,
Attached fixes comment typos in snapbuild.c file.
Regards,
--
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_small_typo_in_snapbuild.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list
Hi,
I have reviewed this patch further and here are my comments:
1.
Will it be better to use compare_pathkeys() instead of
equal(root->query_pathkeys, pathkeys)?
2.
I think it will be good if we add a simple test-case in postgres_fdw.sql
which shows that LIMIT is passed to remote server. We
On March 12, 2017 11:22:22 PM PDT, Victor Yegorov wrote:
>2016-02-28 11:53 GMT+02:00 Simon Riggs :
>
>> We have various proposals for fixing this, so on consideration here's
>what
>> I think we should do...
>>
>> 1. Ignore my first patch to always set
On Sun, Mar 12, 2017 at 7:51 AM, Joe Conway wrote:
> On 03/09/2017 06:16 PM, Michael Paquier wrote:
>> As discussed here:
>> https://www.postgresql.org/message-id/98cafcd0-5557-0bdf-4837-0f2b7782d...@joeconway.com
>> We are using in documentation and code comments "encryption"
On Sat, Mar 11, 2017 at 7:26 PM, Nikhil Sontakke
wrote:
> Hi David and Michael,
>> It would be great to get this thread closed out after 14 months and many
>> commits.
>
> PFA, latest patch which addresses Michael's comments.
Thanks for the new version. Let's head toward
2017-03-13 7:24 GMT+01:00 Nico Williams :
> On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote:
> > From my day-to-day work I can tell, the date(time) type is the only
> missing
> > piece of JSON to make it perfect for business applications (besides,
> maybe,
> >
On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote:
> From my day-to-day work I can tell, the date(time) type is the only missing
> piece of JSON to make it perfect for business applications (besides, maybe,
> a "currency" type).
And a binary type. And a chunked-string type (to avoid
2016-02-28 11:53 GMT+02:00 Simon Riggs :
> We have various proposals for fixing this, so on consideration here's what
> I think we should do...
>
> 1. Ignore my first patch to always set an xid. Andres thought that this
> may break something else could be true, so is not
On Thu, Mar 09, 2017 at 12:58:55PM -0500, Robert Haas wrote:
> On Thu, Mar 9, 2017 at 12:48 PM, Sven R. Kunze wrote:
> > On 08.03.2017 20:48, Peter van Hardenberg wrote:
> >>
> >> Small point of order: YAML is not strictly a super-set of JSON.
> >
> > I haven't read the whole
2017-03-12 22:26 GMT+01:00 Pavel Stehule :
>
>
> 2017-03-12 21:57 GMT+01:00 Noah Misch :
>
>> On Sun, Mar 12, 2017 at 08:36:58PM +0100, Pavel Stehule wrote:
>> > 2017-03-12 0:56 GMT+01:00 Noah Misch :
>> > > On Mon, Feb 20, 2017 at
On Tue, Mar 07, 2017 at 10:43:16PM +0100, Sven R. Kunze wrote:
> about the datetime issue: as far as I know, JSON does not define a
> serialization format for dates and timestamps.
Use strings in ISO 8601 format, with or without fractional seconds, and
maybe with 5-digit years.
> On the other
Hello,
Thank you testing. I just wanted to confirm few things since I do not have
linux32 setup yet.
On Fri, Mar 10, 2017 at 1:09 PM, tushar
wrote:
> On 03/10/2017 11:23 AM, Beena Emerson wrote:
>
>
>> Thank you for your reviews Kuntal, Jim, Ashutosh
>
> Attached
101 - 133 of 133 matches
Mail list logo