Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors

2017-07-01 Thread Fabien COELHO
Hello Marina, A few comments about the submitted patches. I agree that improving the error handling ability of pgbench is a good thing, although I'm not sure about the implications... About the "retry" discussion: I agree that retry is the relevant option from an application point of view.

[HACKERS] PostgresNode::poll_query_until hacking

2017-07-01 Thread Tom Lane
The attached proposed patch changes the TAP test infrastructure's poll_query_until function in two ways: 1. An optional argument is added to allow specifying the query result value we're waiting for, overriding the normal "t". This allows folding a handwritten delay loop in 007_sync_rep.pl into t

Re: [HACKERS] Code quality issues in ICU patch

2017-07-01 Thread Peter Eisentraut
On 6/30/17 08:13, Peter Eisentraut wrote: > On 6/24/17 11:51, Tom Lane wrote: >> Ah, I was about to suggest the same thing, but I was coming at it from >> the standpoint of not requiring buffers several times larger than >> necessary, which could in itself cause avoidable palloc failures. >> >> I w

[HACKERS] Race-like failure in recovery/t/009_twophase.pl

2017-07-01 Thread Tom Lane
Since I put in that patch to reduce pg_ctl's reaction time, we've seen several buildfarm failures with identical symptoms: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2017-06-30%2012%3A56%3A08 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2017-06-30%20