Re: [HACKERS] APR 1.0 released

2004-09-08 Thread Bruce Momjian
Tom Lane wrote: > "Andrew Dunstan" <[EMAIL PROTECTED]> writes: > > I don't understand most of this patch. What difference does changing the > > preprocessor test order make? > > I think Bruce was mostly trying to make all the similar tests look > alike. Also I agree that "if a && !b" is clearer t

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Tom Lane
Stephan Szabo <[EMAIL PROTECTED]> writes: > Definately. The ~20 byte/row gain for large updates/insert/delete is > worth it. I think it'd actually increase the size for the single row case > since we'd have the pointer to deal with (we could use a flag that tells > us whether this item actually ha

Re: [HACKERS] APR 1.0 released

2004-09-08 Thread Tom Lane
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > I don't understand most of this patch. What difference does changing the > preprocessor test order make? I think Bruce was mostly trying to make all the similar tests look alike. Also I agree that "if a && !b" is clearer than "if !b && a"; the latter

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Stephan Szabo
On Wed, 8 Sep 2004, Tom Lane wrote: > Stephan Szabo <[EMAIL PROTECTED]> writes: > > On Wed, 8 Sep 2004, Tom Lane wrote: > >> As long as we're talking about hack-slash-and-burn on this data > >> structure ... > > > Where the OtherInformation could be shared within the statement (for > > identical e

Re: [HACKERS] APR 1.0 released

2004-09-08 Thread Andrew Dunstan
Bruce Momjian said: > Andrew Dunstan wrote: >> >> >> Reini Urban wrote: >> >> > >> > >> > FYI: WIN32 is also defined because is included. >> > (/usr/incluse/w32api/windef.h) >> > If you want this or that, do proper nesting, and use #else. >> > >> > >> >> Ugh, yes. A little experimentation shows th

[HACKERS] TRIGGER_DEFERRED_HAS_BEFORE ?

2004-09-08 Thread Tom Lane
Anyone know why we are maintaining a TRIGGER_DEFERRED_HAS_BEFORE flag bit in the deferred-trigger event list? It's unused and quite pointless AFAICS. regards, tom lane ---(end of broadcast)--- TIP 8: explain analyze is your

Re: [HACKERS] APR 1.0 released

2004-09-08 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Reini Urban wrote: > > > > > > > FYI: WIN32 is also defined because is included. > > (/usr/incluse/w32api/windef.h) > > If you want this or that, do proper nesting, and use #else. > > > > > > Ugh, yes. A little experimentation shows that __WIN32__ is defined for >

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Michael Glaesemann
On Sep 9, 2004, at 6:27 AM, Tom Lane wrote: David Fetter <[EMAIL PROTECTED]> writes: Lately (past 3 days or so, but I don't know exactly how far back this goes), I've been getting some regression test failures for geometry with CVS HEAD on OS/X. Here is regression.diffs. OS X has been doing that s

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Gaetano Mendola
Andrew Dunstan wrote: David Fetter wrote: Kind people, Lately (past 3 days or so, but I don't know exactly how far back this goes), I've been getting some regression test failures for geometry with CVS HEAD on OS/X. We have seen a number of reports recently of things broken some time in the pa

Re: [HACKERS] FYI: Fujitsu

2004-09-08 Thread Neil Conway
Christopher Kings-Lynne wrote: Out of interest, do you have free reign to code whatever you want, or do you have a specific set of things to do for Fujitsu? Also, will you be working on the open source server, or Fujitsu proprietary extensions? I'll be working on a bit of everything; my initial

Re: [HACKERS] SELECT FOR UPDATE NOWAIT and PostgreSQL 8.0

2004-09-08 Thread Simon Riggs
DB2 8.2 now supports NOWAIT also... Best Regards, Simon Riggs > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] Behalf Of Devrim GUNDUZ > Sent: 08 September 2004 23:57 > To: [EMAIL PROTECTED] > Subject: [HACKERS] SELECT FOR UPDATE NOWAIT and PostgreSQL

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Tom Lane
Stephan Szabo <[EMAIL PROTECTED]> writes: > On Wed, 8 Sep 2004, Tom Lane wrote: >> As long as we're talking about hack-slash-and-burn on this data >> structure ... > Where the OtherInformation could be shared within the statement (for > identical events)? I think it'd be problematic to try sharing

[HACKERS] SELECT FOR UPDATE NOWAIT and PostgreSQL 8.0

2004-09-08 Thread Devrim GUNDUZ
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, AFAIR there was a thread about "SELECT FOR UPDATE NOWAIT" availability in {7.5,8.0}, 7-8 months ago. Now we have LOCK TABLE ... NOWAIT; but I wonder whether we'll have the SELECT ... NOWAIT one. Today I got a request for this; and it was report

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: We have seen a number of reports recently of things broken some time in the past. As I am currently thinking about what I want to do in the next dev cycle, this might be an opportune time for me to raise again my previous suggestion

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > We have seen a number of reports recently of things broken some time in > the past. As I am currently thinking about what I want to do in the next > dev cycle, this might be an opportune time for me to raise again my > previous suggestion of a distrib

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > Lately (past 3 days or so, but I don't know exactly how far back this > goes), I've been getting some regression test failures for geometry > with CVS HEAD on OS/X. Here is regression.diffs. OS X has been doing that since 10.3.something. I've been think

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Tom Lane
Stephan Szabo <[EMAIL PROTECTED]> writes: > On Wed, 8 Sep 2004, Tom Lane wrote: >> I think the main concern here would be the space cost of >> adding still another field to the trigger records ... is it worth it? > Would it be possible to basically alias the space for dte_done_xid to hold > either

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Andrew Dunstan
David Fetter wrote: As I am currently thinking about what I want to do in the next dev cycle, this might be an opportune time for me to raise again my previous suggestion of a distributed build farm, so we get timely and automated warnings of breakage. I started creating a script to do this, but g

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Stephan Szabo
On Wed, 8 Sep 2004, Tom Lane wrote: > Hmm. Here's a slightly off the wall idea: following SET CONSTRAINTS, > scan the pending-triggers list twice. The first time, you determine > which triggers you need to fire, and mark them "in progress" by your > transaction. The second time through, you act

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread David Fetter
On Wed, Sep 08, 2004 at 04:20:11PM -0400, Andrew Dunstan wrote: > > > David Fetter wrote: > > >Kind people, > > > >Lately (past 3 days or so, but I don't know exactly how far back > >this goes), I've been getting some regression test failures for > >geometry with CVS HEAD on OS/X. > > We have

Re: [HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread Andrew Dunstan
David Fetter wrote: Kind people, Lately (past 3 days or so, but I don't know exactly how far back this goes), I've been getting some regression test failures for geometry with CVS HEAD on OS/X. We have seen a number of reports recently of things broken some time in the past. As I am currentl

[HACKERS] Geometry regression test failure, CVS HEAD, Mac OS/X

2004-09-08 Thread David Fetter
Kind people, Lately (past 3 days or so, but I don't know exactly how far back this goes), I've been getting some regression test failures for geometry with CVS HEAD on OS/X. Here is regression.diffs. *** ./expected/geometry.out Fri Oct 31 19:07:07 2003 --- ./results/geometry.out Wed Sep

Re: [HACKERS] [pgsql-hackers-win32] timezone vs _timezone on Windows

2004-09-08 Thread Bruce Momjian
I just applied a patch to use _timezone on Cygwin consistenly. --- Tom Lane wrote: > I think I see the real issue behind the recent argument about the > datatype of the timezone variable. I don't think the datatype matters,

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Tom Lane
Stephan Szabo <[EMAIL PROTECTED]> writes: > Okay. The former seems odd to me, especially for exception handling since > Trigger D is making Trigger C immediate, but it could receive exceptions > for Trigger B, so it couldn't assume it knows the source of the exception > (C or something done due to

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Stephan Szabo
On Wed, 8 Sep 2004, Tom Lane wrote: > Stephan Szabo <[EMAIL PROTECTED]> writes: > > Right, but if we search the entire trigger queue from the beginning > > looking for all triggers now immediate and fire them in the EndQuery of > > the set constraints statement contained in D, we'd potentially ge

Re: [HACKERS] Indexed views?

2004-09-08 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Hm. Just thinking aloud here. But what if there was an option to store the > visibility information separately from the heap entirely. There would still > only be one copy of the visibility information and it wouldn't increase > storage or i/o requirements.

Re: [HACKERS] FYI: Fujitsu

2004-09-08 Thread David Fetter
On Wed, Sep 08, 2004 at 03:58:28PM +1000, Neil Conway wrote: > I've accepted an offer from Fujitsu Australia Software Technologies > to work on PostgreSQL full-time for them for the next twelve months > in Sydney, Australia. I'll be working with Gavin Sherry and two > other full-time developers fro

Re: [HACKERS] Making AFTER triggers act properly in PL functions

2004-09-08 Thread Tom Lane
Stephan Szabo <[EMAIL PROTECTED]> writes: > Right, but if we search the entire trigger queue from the beginning > looking for all triggers now immediate and fire them in the EndQuery of > the set constraints statement contained in D, we'd potentially get an > ordering like: > Trigger A start > Tr

Re: [HACKERS] APR 1.0 released

2004-09-08 Thread Reini Urban
Bruce Momjian schrieb: OK, care to submit a patch. As I remember the fix for rename/unlink also includes how the file is opened with flags. Anyway, we spent a lot of time on this so you will have to go back in the archvies to find it and determine how it can be improved. Your track record for Cyg

Re: [HACKERS] FYI: Fujitsu

2004-09-08 Thread David Garamond
Neil Conway wrote: I've accepted an offer from Fujitsu Australia Software Technologies to work on PostgreSQL full-time for them for the next twelve months in Sydney, Australia. I'll be working with Gavin Sherry and two other full-time developers from FAST. I'm grateful to Fujitsu for giving me

Re: [HACKERS] APR 1.0 released

2004-09-08 Thread Bruce Momjian
OK, care to submit a patch. As I remember the fix for rename/unlink also includes how the file is opened with flags. Anyway, we spent a lot of time on this so you will have to go back in the archvies to find it and determine how it can be improved. Your track record for Cygwin diagnosis isn't 1

Re: [HACKERS] FYI: Fujitsu

2004-09-08 Thread Christopher Kings-Lynne
I've accepted an offer from Fujitsu Australia Software Technologies to work on PostgreSQL full-time for them for the next twelve months in Sydney, Australia. I'll be working with Gavin Sherry and two other full-time developers from FAST. I'm grateful to Fujitsu for giving me the opportunity to

Re: [HACKERS] FYI: Fujitsu

2004-09-08 Thread Gaetano Mendola
Neil Conway wrote: I've accepted an offer from Fujitsu Australia Software Technologies to work on PostgreSQL full-time for them for the next twelve months in Sydney, Australia. I'll be working with Gavin Sherry and two other full-time developers from FAST. I'm grateful to Fujitsu for giving me