Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can ;-) I don't think it is good practice to ship

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Robert Treat said: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: Magnus Hagander wrote: 4) Can we ship linked with readline in the installer? If not, can we ship a readline-linked binary at all, or just the source? Considering readline drags along the GPL, and not just the LGPL.

Re: [HACKERS] psql readline win32

2006-01-02 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Andrew Dunstan Sent: Sun 1/1/2006 11:51 PM To: Magnus Hagander Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] psql readline win32 4) Can we ship linked with readline in the installer? If not, can we ship a

Re: [HACKERS] psql readline win32

2006-01-02 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Tom Lane Sent: Mon 1/2/2006 3:30 AM To: Robert Treat Cc: pgsql-hackers@postgresql.org; Andrew Dunstan; Magnus Hagander Subject: Re: [HACKERS] psql readline win32 (Of course, you could also treat the Windows installer as being

Re: [HACKERS] Why don't we allow DNS names in pg_hba.conf?

2006-01-02 Thread pmagnoli
Yes, it would be good to implement this. A warning about security and (possible) slow connections due to name resolution issues should be placed in the docs. Regards paolo elein [EMAIL PROTECTED] ha scritto I also support this change. My clients have tended to move machines and networks

Re: [HACKERS] psql readline win32

2006-01-02 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Magnus Hagander Sent: Mon 1/2/2006 8:08 AM To: Tom Lane; Robert Treat Cc: pgsql-hackers@postgresql.org; Andrew Dunstan Subject: Re: [HACKERS] psql readline win32 Though we do ship GPL stuff in it already - postgis to be

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
I don't think it is good practice to ship packaged software that is statically linked to a gpl library and then claim that your package is bsd licensed. If I were trying to use the windows installer in a commercial application, I sure wouldn't want that liability. Why should

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
Anyone for trying to port BSD libedit to work on Windows? Maybe just let it be on Windows is acceptable. I am currently happy with my psql without readline support on Windows, but on Unix that's hard. If Windows users want more advanced client, there are a bunch of GUI tools. Well,

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
2) Should we ship a file of standard bindings. We're not going to get it complete, but we could get some of the most common ones in europe at least (in sweden, this would for example include [EMAIL PROTECTED]|). Which would help people a lot. Yes we should, at least for Windows -

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andreas Seltenreich
Magnus Hagander writes: 2) Should we ship a file of standard bindings. We're not going to get it complete, but we could get some of the most common ones in europe at least (in sweden, this would for example include [EMAIL PROTECTED]|). Which would help people a lot. Yes we should,

Re: [HACKERS] EINTR error in SunOS

2006-01-02 Thread Doug Royer
Doug McNaught wrote: c) treat EINTR as an I/O error (I don't know how easy this would be) So then at this point - it is detected, so problem solved? If a LOCAL hard drive fails to reply, you hang. Same with hard,intr NFS file system. bytesRead = read(fd, buffer, requestedBytes);

Re: [HACKERS] [PATCHES] default resource limits

2006-01-02 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: That's easily fixed, I think. We just need to remember what we have proved works. I can apply the attached patch if you think that's worth doing. If you like; but if so, remove the comment saying that there's a

[HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Tom Lane
Is there any way to find out $subject? I see that several of the buildfarm machines are choking on a patch I committed yesterday: guc-file.l: In function `ProcessConfigFile': guc-file.l:162: error: `YY_FLUSH_BUFFER' undeclared (first use in this function) guc-file.l:162: error: (Each undeclared

Re: [HACKERS] Why don't we allow DNS names in pg_hba.conf?

2006-01-02 Thread Jon Jensen
On Sun, 1 Jan 2006, Andreas Pflug wrote: While I haven't tried it, I suspect that allowing a DNS host name would take little work (basically removing the AI_NUMERICHOST flag passed to getaddrinfo in hba.c). There was once a good reason not to allow it: slow DNS lookups would lock up the

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Andrew Dunstan
Tom Lane said: Is there any way to find out $subject? I see that several of the buildfarm machines are choking on a patch I committed yesterday: guc-file.l: In function `ProcessConfigFile': guc-file.l:162: error: `YY_FLUSH_BUFFER' undeclared (first use in this function) guc-file.l:162:

Re: [HACKERS] Why don't we allow DNS names in pg_hba.conf?

2006-01-02 Thread Mike Rylander
On 1/2/06, Jon Jensen [EMAIL PROTECTED] wrote: On Sun, 1 Jan 2006, Andreas Pflug wrote: While I haven't tried it, I suspect that allowing a DNS host name would take little work (basically removing the AI_NUMERICHOST flag passed to getaddrinfo in hba.c). There was once a good reason not

Re: [HACKERS] Why don't we allow DNS names in pg_hba.conf?

2006-01-02 Thread Tom Lane
Jon Jensen [EMAIL PROTECTED] writes: (1) What Tom proposed is that we store the hostname and do a new DNS lookup for every connection. That could be useful in certain situations, but I wouldn't use it for a busy production server. The additional time for DNS lookups (even with a fast local

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Stefan Kaltenbrunner
Tom Lane wrote: Is there any way to find out $subject? I see that several of the buildfarm machines are choking on a patch I committed yesterday: guc-file.l: In function `ProcessConfigFile': guc-file.l:162: error: `YY_FLUSH_BUFFER' undeclared (first use in this function) guc-file.l:162:

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: configure doesn't actually report the bison version, but it does complain if the version is less than 1.875, and I don't see that on rook. Sigh, I haven't woken up entirely today :-( ... of course, this is a flex macro we are talking about, not bison.

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Tom Lane
Stefan Kaltenbrunner [EMAIL PROTECTED] writes: I just verified that -HEAD is broken on Debian Sarge 3.1 (nearly all of the failing buildfarm members are Debian Sarge 3.1 boxes) - and I just verified the Problem exists on i386 too. What flex version are they using?

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Stefan Kaltenbrunner
Tom Lane wrote: Stefan Kaltenbrunner [EMAIL PROTECTED] writes: I just verified that -HEAD is broken on Debian Sarge 3.1 (nearly all of the failing buildfarm members are Debian Sarge 3.1 boxes) - and I just verified the Problem exists on i386 too. What flex version are they using? flex

Re: [HACKERS] Why don't we allow DNS names in pg_hba.conf?

2006-01-02 Thread Jon Jensen
On Mon, 2 Jan 2006, Tom Lane wrote: (1) What Tom proposed is that we store the hostname and do a new DNS lookup for every connection. That could be useful in certain situations, but I wouldn't use it for a busy production server. The additional time for DNS lookups (even with a fast local

Re: [HACKERS] EINTR error in SunOS

2006-01-02 Thread Martijn van Oosterhout
On Mon, Jan 02, 2006 at 08:55:47AM -0700, Doug Royer wrote: Doug McNaught wrote: c) treat EINTR as an I/O error (I don't know how easy this would be) So then at this point - it is detected, so problem solved? If a LOCAL hard drive fails to reply, you hang. Same with hard,intr NFS

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Joshua D. Drake
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: configure doesn't actually report the bison version, but it does complain if the version is less than 1.875, and I don't see that on rook. Sigh, I haven't woken up entirely today :-( ... of course, this is a flex macro we are

Re: [HACKERS] Why don't we allow DNS names in pg_hba.conf?

2006-01-02 Thread Tom Lane
Jon Jensen [EMAIL PROTECTED] writes: On Mon, 2 Jan 2006, Tom Lane wrote: Can you demonstrate that this is actually a serious concern next to the total time spent launching a backend? I can't measure any real change in total time for psql -l when log_hostname is enabled, which should be a

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Tom Lane
Joshua D. Drake [EMAIL PROTECTED] writes: Not that hard to believe. 2.5.4 is what the major distributions are shipping. Even FC4 comes with 2.5.4a. The only reason I can see for this is that Flex is now considered a NON-GNU project. No, the major reason for it is that flex 2.5.31 is

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Jim Buttafuoco
Tom, On corgi (debian sarge) raq:~# bison -V bison (GNU Bison) 1.875a -- Original Message --- From: Tom Lane [EMAIL PROTECTED] To: pgsql-hackers@postgresql.org Sent: Mon, 02 Jan 2006 12:54:42 -0500 Subject: [HACKERS] What bison versions are installed on buildfarm machines?

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Stefan Kaltenbrunner
Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Not that hard to believe. 2.5.4 is what the major distributions are shipping. Even FC4 comes with 2.5.4a. The only reason I can see for this is that Flex is now considered a NON-GNU project. No, the major reason for it is that flex

Re: [HACKERS] psql readline win32

2006-01-02 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can ;-) I don't

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Stefan Kaltenbrunner
Stefan Kaltenbrunner wrote: Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Not that hard to believe. 2.5.4 is what the major distributions are shipping. Even FC4 comes with 2.5.4a. The only reason I can see for this is that Flex is now considered a NON-GNU project. No, the major

Re: [HACKERS] What bison versions are installed on buildfarm machines?

2006-01-02 Thread Tom Lane
Stefan Kaltenbrunner [EMAIL PROTECTED] writes: sorry for the false alarm, actually i can confirm that 2.5.31 (which is the default flex on Sarge) is broken and 2.5.4 (available as flex-old) DOES work. Using yyrestart() seems to work with both versions --- fix committed.

Re: [HACKERS] Stats collector performance improvement

2006-01-02 Thread Tom Lane
[ moving to -hackers ] Bruce Momjian pgman@candle.pha.pa.us writes: I did some research on this because the numbers Tom quotes indicate there is something wrong in the way we process stats_command_string statistics. [ ... proposed patch that seems pretty klugy to me ... ] I wonder whether we

Re: [HACKERS] Stats collector performance improvement

2006-01-02 Thread Qingqing Zhou
Tom Lane [EMAIL PROTECTED] wrote I wonder whether we shouldn't consider something more drastic, like getting rid of the intermediate stats buffer process entirely. The original design for the stats communication code was based on the premise that it's better to drop data than to make

Re: [HACKERS] Stats collector performance improvement

2006-01-02 Thread Hannu Krosing
Ühel kenal päeval, E, 2006-01-02 kell 15:20, kirjutas Tom Lane: [ moving to -hackers ] Bruce Momjian pgman@candle.pha.pa.us writes: I did some research on this because the numbers Tom quotes indicate there is something wrong in the way we process stats_command_string statistics. [ ...

Re: [HACKERS] Stats collector performance improvement

2006-01-02 Thread Tom Lane
Qingqing Zhou [EMAIL PROTECTED] writes: AFAICS if we can maintain the stats counts solid, then it may hurt performance dramatically. Think if we maintain pgstat_count_heap_insert()/pgstat_count_heap_delete() pretty well, then we get a replacement of count(*). Not at all. For one thing,

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Greg Stark said: Tom Lane [EMAIL PROTECTED] writes: Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can

Re: [HACKERS] psql readline win32

2006-01-02 Thread D'Arcy J.M. Cain
On Mon, 2 Jan 2006 16:27:48 -0600 (CST) Andrew Dunstan [EMAIL PROTECTED] wrote: Our BSD license is recognised as a GPL-compatible license. Recognized by who? The only two entities that I can think of that matter would be GNU itself or the courts. -- D'Arcy J.M. Cain darcy@druid.net |

Re: [HACKERS] psql readline win32

2006-01-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: The readline home page at http://cnswww.cns.cwru.edu/~chet/readline/rltop.html says: Readline is free software, distributed under the terms of the GNU General Public License, version 2. This means that if you want to use Readline in a program that you

Re: [HACKERS] psql readline win32

2006-01-02 Thread Qingqing Zhou
Magnus Hagander [EMAIL PROTECTED] wrote Well, we should *at least* provide it from the source build. Since it does work (with a small kludge, but it does work). Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell.

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Tom Lane said: Andrew Dunstan [EMAIL PROTECTED] writes: The readline home page at http://cnswww.cns.cwru.edu/~chet/readline/rltop.html says: Readline is free software, distributed under the terms of the GNU General Public License, version 2. This means that if you want to use Readline in a

Re: [HACKERS] psql readline win32

2006-01-02 Thread Robert Treat
On Monday 02 January 2006 18:21, Andrew Dunstan wrote: Tom Lane said: Andrew Dunstan [EMAIL PROTECTED] writes: The readline home page at http://cnswww.cns.cwru.edu/~chet/readline/rltop.html says: Readline is free software, distributed under the terms of the GNU General Public License,

Re: [HACKERS] psql readline win32

2006-01-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: The page links to this: http://www.gnu.org/licenses/license-list.html which lists the BSD licence without the advertising clause as a GPL-compatible free software license, of which it says: This means you can combine a module which was released under

Re: [HACKERS] EINTR error in SunOS

2006-01-02 Thread Doug McNaught
Martijn van Oosterhout kleptog@svana.org writes: I would vote for the kernel, if the server didn't respond within 5 seconds, to simply return EIO. At least we know how to handle that... You can do this now by mounting 'soft' and setting the timeout appropriately. Whether it's really the best

Re: [HACKERS] EINTR error in SunOS

2006-01-02 Thread Greg Stark
Martijn van Oosterhout kleptog@svana.org writes: The kernel is trying to be helpful by returning EINTR to say ok, it didn't complete. There's no error yet but it may yet work. Well it only returns EINTR if a signal was received. With local hard drives if they don't respond, you assume

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: The page links to this: http://www.gnu.org/licenses/license-list.html which lists the BSD licence without the advertising clause as a GPL-compatible free software license, of which it says: This means you can combine a module which

Re: [HACKERS] Stats collector performance improvement

2006-01-02 Thread Jan Wieck
On 1/2/2006 3:20 PM, Tom Lane wrote: [ moving to -hackers ] Bruce Momjian pgman@candle.pha.pa.us writes: I did some research on this because the numbers Tom quotes indicate there is something wrong in the way we process stats_command_string statistics. [ ... proposed patch that seems pretty

Re: [HACKERS] EINTR error in SunOS

2006-01-02 Thread Doug Royer
Greg Stark wrote: I would vote for the kernel, if the server didn't respond within 5 seconds, to simply return EIO. At least we know how to handle that... How do you handle it? By having Postgres shut down? And then the NFS server comes back and then what? Log the error if you can.