Re: [HACKERS] Subtransaction commits and Hot Standby

2008-10-06 Thread Simon Riggs
On Sun, 2008-10-05 at 14:51 -0400, Alvaro Herrera wrote: Simon Riggs wrote: OK, spent long time testing various batching scenarios for this using a custom test harness to simulate various spreads of xids in transaction trees. All looks fine now. I had a look and was mostly rephrasing

Re: [HACKERS] pgsql: Add relation fork support to pg_relation_size() function.

2008-10-06 Thread Heikki Linnakangas
Tom Lane wrote: I don't believe for a moment that EDB, or anyone else competent enough to put in a private fork definition, can't manage to add it to enum ForkNumber. They'd probably be well advised to operate with a private setting of catversion anyway, which would ensure that installations

Re: [HACKERS] pgsql: Add relation fork support to pg_relation_size() function.

2008-10-06 Thread Magnus Hagander
Heikki Linnakangas wrote: Tom Lane wrote: I don't believe for a moment that EDB, or anyone else competent enough to put in a private fork definition, can't manage to add it to enum ForkNumber. They'd probably be well advised to operate with a private setting of catversion anyway, which would

[HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1081)

2008-10-06 Thread KaiGai Kohei
The latest version of SE-PostgreSQL patches are here: [1/5] http://sepgsql.googlecode.com/files/sepostgresql-sepgsql-8.4devel-3-r1081.patch [2/5] http://sepgsql.googlecode.com/files/sepostgresql-pg_dump-8.4devel-3-r1081.patch [3/5]

[HACKERS] About postgresql8.3.3 build in MS VS2005

2008-10-06 Thread iihero
When I build pgsql via perl after run the command line env of VS2005, there are lots of following error: e:\learn\db_research\postgresql\source\postgresql-8.3.3\src\include\port .h(83): error C2146: syntax error : missing ')' before identifier 'hProcess'

Re: [HACKERS] pgsql: Add relation fork support to pg_relation_size() function.

2008-10-06 Thread Gregory Stark
Magnus Hagander [EMAIL PROTECTED] writes: Heikki Linnakangas wrote: If we go with the .fsm extension, we'll get 12345.fsm.1 when the FSM grows large enough to be segmented. Does anyone have a problem with a filename with two dots? Shouldn't be a problem, I guess. We could also just do

Re: [HACKERS] pgsql: Add relation fork support to pg_relation_size() function.

2008-10-06 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: On the other hand if they do have a problem with multiple periods they won't find out until they have a pretty big database already and are kind of stuck. And our regression tests won't test it at all. Yeah. +1 for the _fsm approach, just in case.

Re: [HACKERS] About postgresql8.3.3 build in MS VS2005

2008-10-06 Thread iihero
Thanks Magnus, I've installed vs2005 standard edition. Do you mean the include order of Platform SDK possibly influenced the build result? 2008/10/6 Magnus Hagander [EMAIL PROTECTED] Are you building with MS VS2005 Express? If so, it sounds like you have not managed to install the Platform

Re: [HACKERS] About postgresql8.3.3 build in MS VS2005

2008-10-06 Thread Magnus Hagander
Are you building with MS VS2005 Express? If so, it sounds like you have not managed to install the Platform SDK properly. //Magnus iihero wrote: When I build pgsql via perl after run the command line env of VS2005, there are lots of following error:

Re: [HACKERS] pgsql: Add relation fork support to pg_relation_size() function.

2008-10-06 Thread Heikki Linnakangas
Gregory Stark wrote: Magnus Hagander [EMAIL PROTECTED] writes: Heikki Linnakangas wrote: If we go with the .fsm extension, we'll get 12345.fsm.1 when the FSM grows large enough to be segmented. Does anyone have a problem with a filename with two dots? Shouldn't be a problem, I guess. We

Re: [HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Heikki Linnakangas
Guillaume Lelarge wrote: db1=# alter table t1 set tablespace ts1; ALTER TABLE /opt/postgresql-8.3/data/base/74472/74475 db1=# \! ls -l /home/guillaume/ts1/74472/74475 -rw--- 1 guillaume guillaume 8192 Oct 6 11:00 /home/guillaume/ts1/74472/74475 My table moved to my own tablespace. db1=#

Re: [HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: The trivial fix is to just force a checkpoint in ALTER TABLE SET TABLESPACE. Can we do better than that? Perhaps only force a checkpoint when we find that the file already exists. If ALTER TABLE SET TABLESPACE is assuming that it can always use

Re: [HACKERS] About postgresql8.3.3 build in MS VS2005

2008-10-06 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Do you mean the include order of Platform SDK possibly influenced the build result? it could be. At first look ISTM that the error comes from not finding the definition of HANDLE, which is certainly very central to the Platform SDK. You should be

[HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Guillaume Lelarge
Hi, I just found a weird behaviour with this statement. Here is a complete log of my session with a 8.3(.4) server: [EMAIL PROTECTED] mkdir /home/guillaume/ts1 [EMAIL PROTECTED] createdb db1 [EMAIL PROTECTED] LANG=C psql db1 Welcome to psql 8.3.4, the PostgreSQL interactive terminal. Type:

Re: [HACKERS] pgsql: Add relation fork support to pg_relation_size() function.

2008-10-06 Thread Greg Stark
On Mon, Oct 6, 2008 at 11:32 AM, Heikki Linnakangas [EMAIL PROTECTED] wrote: FWIW, with the defaults of 8k block size and 1GB segments, the table needs to be over 4TB in size until the FSM file needs to be segmented. Hm, so on the one hand people will just have 12345.1, 12345.2, ... and

Re: [HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Guillaume Lelarge
Tom Lane a écrit : Heikki Linnakangas [EMAIL PROTECTED] writes: The trivial fix is to just force a checkpoint in ALTER TABLE SET TABLESPACE. Can we do better than that? Perhaps only force a checkpoint when we find that the file already exists. If ALTER TABLE SET TABLESPACE is assuming

Re: [HACKERS] About postgresql8.3.3 build in MS VS2005

2008-10-06 Thread Magnus Hagander
it could be. At first look ISTM that the error comes from not finding the definition of HANDLE, which is certainly very central to the Platform SDK. //Magnus iihero wrote: Thanks Magnus, I've installed vs2005 standard edition. Do you mean the include order of Platform SDK possibly

Re: [HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Heikki Linnakangas
Guillaume Lelarge wrote: Tom Lane a écrit : Heikki Linnakangas [EMAIL PROTECTED] writes: The trivial fix is to just force a checkpoint in ALTER TABLE SET TABLESPACE. Can we do better than that? Perhaps only force a checkpoint when we find that the file already exists. If ALTER TABLE SET

Re: [HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: Yeah, seems like we need to allocate a new relfilenode in the new tablespace. I looked into tablecmds.c and verified that ATExecSetTableSpace doesn't worry about selecting a new relfilenode. I'm also noticing a number of permissions-type checks

Re: [HACKERS] Add default_val to pg_settings

2008-10-06 Thread Magnus Hagander
Greg Smith wrote: On Thu, 25 Sep 2008, Simon Riggs wrote: So it would be useful to have a column that meant if I run the RESET command it would return me to this value. Patch v3 attached that exposes boot_val and reset_val. The docs for the latter link to the RESET command page for

[HACKERS] ctelevelsup is kind of a pain in the neck

2008-10-06 Thread Tom Lane
I noticed this perfectly valid query doesn't work in CVS HEAD: regression=# with q(x) as (select 1) select * from q where 1 in (select q.x); ERROR: could not find CTE q The failure occurs while markTargetListOrigin is trying to process the select q.x sub-select's targetlist: it correctly finds

[HACKERS] Monitoring postgres

2008-10-06 Thread Kellyton Campos Feitosa - GYN
Dears, I need monitor a postgres database, but I don't know which tool to use. The tool need perform the below actions 1. show transactions pendents 2. show the statistics per session actives 3. show the statistics per database 4. show metrics

[HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Tom Lane
Currently, pg_settings.enumvals presents a list of strings formatted in an ad-hoc manner. Shouldn't we be presenting this as text[], so that clients don't need special-purpose code to break it apart? Another possible argument is that the values ought to be separated by newlines instead of , ,

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Magnus Hagander
Tom Lane wrote: Currently, pg_settings.enumvals presents a list of strings formatted in an ad-hoc manner. Shouldn't we be presenting this as text[], so that clients don't need special-purpose code to break it apart? Another possible argument is that the values ought to be separated by

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Agreed, it can certainly be bettered. text[] seems to be the cleanest, but then we still have the issue with wide output in psql, no? But should we really design the view around the single use-case of psql? You can still just omit that column from the

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Alvaro Herrera
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Agreed, it can certainly be bettered. text[] seems to be the cleanest, but then we still have the issue with wide output in psql, no? But should we really design the view around the single use-case of psql? You can still just omit

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Magnus Hagander
Alvaro Herrera wrote: Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Agreed, it can certainly be bettered. text[] seems to be the cleanest, but then we still have the issue with wide output in psql, no? But should we really design the view around the single use-case of psql? You

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Alvaro Herrera
Magnus Hagander wrote: Alvaro Herrera wrote: Let's have it as text[] and have psql apply array_to_string() over it. Eh, how can psql do this? You access the view with a simple SELECT * FROM pg_settings, no? Hmm, I was thinking in some \-command ... -- Alvaro Herrera

Re: [HACKERS] Monitoring postgres

2008-10-06 Thread Steve Crawford
Kellyton Campos Feitosa - GYN wrote: Dears, I need monitor a postgres database, but I don’t know which tool to use. The tool need perform the below actions 1. show transactions pendents 2. show the statistics per session actives 3. show the statistics per database 4. show metrics

[HACKERS] Displaying references to fields of record variables

2008-10-06 Thread Tom Lane
I mentioned the other day that ruleutils.c fails for cases like this: explain select * from (select x from (values(1,2),(3,4)) as x(c1,c2) offset 0) ss where (x).c2 0; ERROR: record type has not been registered The problem is that the rewriter/planner expands the intermediate sub-select's

[HACKERS] subcribe

2008-10-06 Thread bull
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Greg Smith
On Mon, 6 Oct 2008, Magnus Hagander wrote: Alvaro Herrera wrote: Let's have it as text[] and have psql apply array_to_string() over it. Eh, how can psql do this? You access the view with a simple SELECT * FROM pg_settings, no? The pg_settings view is a thin wrapper over what comes out of

Re: [HACKERS] Add default_val to pg_settings

2008-10-06 Thread Decibel!
On Oct 5, 2008, at 8:50 PM, Greg Smith wrote: Patch v3 attached that exposes boot_val and reset_val. The docs for the latter link to the RESET command page for details. nitpickIs it really that important that we save 2 characters on each field name?/nitpick -- Decibel!, aka Jim C. Nasby,

Re: [HACKERS] Common Table Expressions applied; some issues remain

2008-10-06 Thread Decibel!
On Oct 5, 2008, at 1:11 AM, Peter Eisentraut wrote: I don't think we should overload syntax choices with optimization hints. We don't really know why or how people will be using this syntax, and labeling it from the start as will have unusual performance behavior isn't a good sell. As a

Re: [HACKERS] FSM rewrite committed, loose ends

2008-10-06 Thread Decibel!
On Oct 2, 2008, at 10:32 AM, Robert Treat wrote: select pg_relation_size(tablename) from pg_tables; since pg_tables is presented as a more user-friendly option to something like pg_class this might be something more widely used, plus we don't have the easy way out of just telling them to

Re: [HACKERS] Bad error message

2008-10-06 Thread Decibel!
On Oct 1, 2008, at 12:12 AM, Gurjeet Singh wrote: On Wed, Oct 1, 2008 at 9:39 AM, Tom Lane [EMAIL PROTECTED] wrote: Gurjeet Singh [EMAIL PROTECTED] writes: On Wed, Oct 1, 2008 at 3:07 AM, Decibel! [EMAIL PROTECTED] wrote: ERROR: aggregates not allowed in WHERE clause No, the real issue

Re: [HACKERS] Ad-hoc table type?

2008-10-06 Thread Decibel!
On Sep 29, 2008, at 6:16 AM, [EMAIL PROTECTED] wrote: The hstore module, as I said, looks really cool, I've contemplated something like it. I have a module provides a set of accessors for an XML text column that works similarly, but it parses the XML on each access and the application has to

Re: [HACKERS] Foreign key constraint for array-field?

2008-10-06 Thread Decibel!
On Sep 21, 2008, at 4:18 AM, Simon Riggs wrote: On Sun, 2008-09-21 at 04:38 +0400, Dmitry Koterov wrote: Is it possible to create a foreign key constraint for ALL elements of an array field? CREATE TABLE a(id INTEGER); CREATE TABLE b(id INTEGER, a_ids INTEGER[]); Field b.a_ids contains a

Re: [HACKERS] Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement

2008-10-06 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: Yeah, seems like we need to allocate a new relfilenode in the new tablespace. I looked into tablecmds.c and verified that ATExecSetTableSpace doesn't worry about selecting a new relfilenode. I'm also noticing a number of

Re: [HACKERS] Common Table Expressions applied; some issues remain

2008-10-06 Thread Robert Haas
Agreed. It's already horrible that we suggest people use OFFSET 0, only because we don't want to define formal optimizer hints (and that's *exactly* what OFFSET 0 is). Yes, especially since TFM says: OFFSET 0 is the same as omitting the OFFSET clause. Unless I'm looking at the wrong part of

[HACKERS] query path, and rules

2008-10-06 Thread Grzegorz Jaskiewicz
Hey folks, I would like to learn more about execution path for a simple query, that is going to be changed by a rule. I want to find out, why output of 'affected rows' isn't always altered properly in rules rewriting inserts and updates. Can someone give me simple guide on where should I

[HACKERS] Transactions and temp tables

2008-10-06 Thread Emmanuel Cecchet
Hi, I had the same problem as John with could not open relation 1663/16384/16584: No such file or directory in a specific combination of transactions with temp tables (http://archives.postgresql.org/pgsql-hackers/2008-02/msg01260.php). As Heikki mentioned

[HACKERS] problems with initdb after last cvs up

2008-10-06 Thread Grzegorz Jaskiewicz
http://pastebin.com/d39eb7643 never had problems on mac os x with head, for last 4 years or so. PGP.sig Description: This is a digitally signed message part

Re: [HACKERS] Reducing some DDL Locks to ShareLock

2008-10-06 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: It seems possible to change some DDL commands/subcommands to use a ShareLock rather than an AccessExclusiveLock. Enclosed patch implements this reduction for CREATE TRIGGER, CREATE RULE and ALTER TABLE. What happens when two transactions try to do one of

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Tom Lane
Greg Smith [EMAIL PROTECTED] writes: When I was looking at this code for the first time recently I thought the same thing Tom did here--that this was kind of odd and it should give a text array back instead. I would even volunteer to take a stab at writing that change myself just to get

Re: [HACKERS] Common Table Expressions applied; some issues remain

2008-10-06 Thread Tom Lane
[ back to the when-to-inline-WITHs discussion ] Gregory Stark [EMAIL PROTECTED] writes: Tom Lane wrote: Any thoughts on what to do? One possibility is to flatten only if the subquery doesn't contain any volatile functions. I think we should always inline the view if there's a single call

Re: [HACKERS] Common Table Expressions applied; some issues remain

2008-10-06 Thread Robert Haas
If the planner chooses to do this as a nestloop with table2 on the inside, then expensive_function() can get evaluated multiple times on the same row of table2. We really don't make very many guarantees about what will happen with functions inside inlined views, even with offset 0 as an

Re: [HACKERS] Shouldn't pg_settings.enumvals be array of text?

2008-10-06 Thread Greg Smith
On Mon, 6 Oct 2008, Tom Lane wrote: Fine with me, but let's be sure this doesn't slide off the radar screen. If we forget about it and release 8.4 with the current definition of the column, it'll be too late to change it. Agreed and understood. I hope to have some basic postgresql.conf