Re: [HACKERS] FSM search modes

2009-09-18 Thread Simon Riggs
On Fri, 2009-09-18 at 10:47 +0900, Itagaki Takahiro wrote: Simon Riggs si...@2ndquadrant.com wrote: * compact - page selection specifically attempts to find the lowest numbered blocks, so that the table will naturally shrink over time. We cannot shrink the table if one tuple remains at

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-18 Thread Michael Paquier
You really should be returning a value at the point since the function signature defines a return type. If not the function should be void, which it cannot be in this context since it is used for boolean tests elsewhere. The returns in question are all part of error blocks and should return

Re: [HACKERS] [patch] pg_ctl init extension

2009-09-18 Thread Zdenek Kotala
Peter Eisentraut píše v čt 17. 09. 2009 v 23:00 +0300: On tor, 2009-09-17 at 21:43 +0200, Zdenek Kotala wrote: Attached patch extends pg_ctl command with init option. pg_ctl -D /var/lib/postgres [-s] init This should replace usage of initdb command which has problematic name as we

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Simon Riggs
On Thu, 2009-09-17 at 19:01 -0400, Robert Haas wrote: I'm going to put the index-only scans aside for now to focus on hot standby and streaming replication. Both are big patches, so there's plenty of work in those two alone, and not only for me. What is the best way to attack this?

Re: [HACKERS] Feedback on getting rid of VACUUM FULL

2009-09-18 Thread Albe Laurenz
Tom Lane wrote: I don't see any reason why not breaking the user visible behavior of tuples CTID between any two major releases, Am I completely wet here? Completely. This is a user-visible behavior that we have encouraged people to rely on, and for which there is no easy substitute.

Re: [HACKERS] Feedback on getting rid of VACUUM FULL

2009-09-18 Thread Simon Riggs
On Thu, 2009-09-17 at 17:44 -0400, Tom Lane wrote: Dimitri Fontaine dfonta...@hi-media.com writes: I don't see any reason why not breaking the user visible behavior of tuples CTID between any two major releases, Am I completely wet here? Completely. This is a user-visible behavior

Re: [HACKERS] FSM search modes

2009-09-18 Thread decibel
On Sep 18, 2009, at 1:09 AM, Simon Riggs wrote: On Fri, 2009-09-18 at 10:47 +0900, Itagaki Takahiro wrote: Simon Riggs si...@2ndquadrant.com wrote: * compact - page selection specifically attempts to find the lowest numbered blocks, so that the table will naturally shrink over time. We

Re: [HACKERS] Streaming Replication patch for CommitFest 2009-09

2009-09-18 Thread Heikki Linnakangas
Heikki Linnakangas wrote: Heikki Linnakangas wrote: I'm thinking that walreceiver should be a stand-alone program that the startup process launches, similar to how it invokes restore_command in PITR recovery. Instead of using system(), though, it would use fork+exec, and a pipe to

Re: [HACKERS] ECPG patchset

2009-09-18 Thread Boszormenyi Zoltan
New patch - two decimal-related memory leak fixes. Happens on 8.4 and 8.5, maybe on older trees as well. One of the two chunks was in the SQLDA patch originally. This is independent from any other patches. -- Bible has answers for everything. Proof: But let your communication be, Yea, yea; Nay,

Re: [HACKERS] Feedback on getting rid of VACUUM FULL

2009-09-18 Thread Simon Riggs
On Fri, 2009-09-18 at 08:50 +0200, Albe Laurenz wrote: Tom Lane wrote: I don't see any reason why not breaking the user visible behavior of tuples CTID between any two major releases, Am I completely wet here? Completely. This is a user-visible behavior that we have encouraged

Re: [HACKERS] Feedback on getting rid of VACUUM FULL

2009-09-18 Thread marcin mank
Exactly.  The application is typically going to throw a concurrent update type of error when this happens, and we don't want magic background operations to cause that. I`d give up the possibility of using CTIDs in the way You explained for an auto-debloater without blinking an eye. Maybe we

Re: [HACKERS] Feedback on getting rid of VACUUM FULL

2009-09-18 Thread Heikki Linnakangas
Simon Riggs wrote: CTIDs don't help with optimistic locking, though it seems they can. If you don't hold open the transaction then someone else can update the row. That sounds good, but because of HOT it is possible that the same CTID with the same PK value occupies that exact CTID value

[HACKERS] numeric_to_number() function skipping some digits

2009-09-18 Thread Jeevan Chalke
Hi, With PG84, I have tried something like this which seem incorrect to me. # SELECT '' AS to_number_2, to_number('-347,58', '99G999'); to_number_2 | to_number -+--- | -3458 (1 row) After browsing the code (numeric_to_number), I have found that number

Re: [HACKERS] Streaming Replication patch for CommitFest 2009-09

2009-09-18 Thread Fujii Masao
Hi, On Fri, Sep 18, 2009 at 2:47 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Heikki Linnakangas wrote: I'm thinking that walreceiver should be a stand-alone program that the startup process launches, similar to how it invokes restore_command in PITR recovery. Instead of

Re: [HACKERS] Streaming Replication patch for CommitFest 2009-09

2009-09-18 Thread Heikki Linnakangas
Fujii Masao wrote: Hi, On Fri, Sep 18, 2009 at 2:47 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Heikki Linnakangas wrote: I'm thinking that walreceiver should be a stand-alone program that the startup process launches, similar to how it invokes restore_command in

Re: [HACKERS] Streaming Replication patch for CommitFest 2009-09

2009-09-18 Thread Fujii Masao
Hi, On Thu, Sep 17, 2009 at 5:08 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I'm thinking that walreceiver should be a stand-alone program that the startup process launches, similar to how it invokes restore_command in PITR recovery. Instead of using system(), though, it

[HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Hans-Juergen Schoenig -- PostgreSQL
Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. Best regards, Hans-Jürgen Schönig + team -- Cybertec Schoenig Schoenig GmbH Reyergasse 9 / 2 A-2700 Wiener

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread A. Kretschmer
In response to Hans-Juergen Schoenig -- PostgreSQL : Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. +1 -- Andreas Kretschmer Kontakt: Heynitz: 035242/47150,

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Devrim GÜNDÜZ
On Fri, 2009-09-18 at 13:04 +0200, Hans-Juergen Schoenig -- PostgreSQL wrote: On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. Assuming that we have only one Tom Lane (i.e.,

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Bill Moran
Hans-Juergen Schoenig -- PostgreSQL postg...@cybertec.at wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. Alright, Tom ... I'm in the area, when/where's the

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-18 Thread Jan Urbański
Petr Jelinek wrote: So I've been working on solution with which I am happy with (does not mean anybody else will be also though). Hi Petr, I'm reviewing this patch and after reading it I have some comments. Unfortunately, when I got to the compiling part, it turned out that the attached patch

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Andrew Chernow
Hans-Juergen Schoenig -- PostgreSQL wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. Best regards, Hans-Jürgen Schönig + team Happy 30th Tom ;) --

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Khee Chin
Happy birthday Tom, from the sunny island of Singapore. :-) Regards, Khee Chin. On Fri, Sep 18, 2009 at 7:04 PM, Hans-Juergen Schoenig -- PostgreSQL postg...@cybertec.at wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Merlin Moncure
On Fri, Sep 18, 2009 at 8:09 AM, Andrew Chernow a...@esilo.com wrote: Hans-Juergen Schoenig -- PostgreSQL wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come.  

Re: [HACKERS] Rename StrNCpy to avoid conflictions on win32

2009-09-18 Thread Bruce Momjian
Peter Eisentraut wrote: On Mon, 2009-09-07 at 11:36 +0200, Magnus Hagander wrote: On Mon, Sep 7, 2009 at 04:40, Itagaki Takahiroitagaki.takah...@oss.ntt.co.jp wrote: There might be some places to replace it to strlcpy() instead. Can't comment on that without looking at the code, but

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Robert Haas
On Fri, Sep 18, 2009 at 7:11 AM, A. Kretschmer andreas.kretsch...@schollglas.com wrote: In response to Hans-Juergen Schoenig -- PostgreSQL : Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL

Re: [HACKERS] [COMMITTERS] pgsql: Easier to translate psql help Instead of requiring translators

2009-09-18 Thread Tom Lane
pet...@postgresql.org (Peter Eisentraut) writes: Log Message: --- Easier to translate psql help Looks like this broke the msvc build ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: Also, stepping back from me personally, should we try to assign some additional reviewers to these patches? Is there some way we can divide up review tasks among multiple people so that we're not repeating each others work? Thoughts appreciated,

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Jeff Janes
On Tue, Sep 15, 2009 at 2:41 PM, Simon Riggs si...@2ndquadrant.com wrote: OK, here is the latest version of the Hot Standby patchset. This is about version 30+ by now, but we should regard this as 0.2.1 Patch against CVS HEAD (now): clean apply, compile, no known bugs. Hi Simon, Is there

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Dimitri Fontaine
Hans-Juergen Schoenig -- PostgreSQL postg...@cybertec.at writes: Tom, happy birthday. +1 from me :) Regards, -- dim -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Marcelo Costa
Happy nice birthday Tom Lane On Fri, Sep 18, 2009 at 10:36 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 18, 2009 at 7:11 AM, A. Kretschmer andreas.kretsch...@schollglas.com wrote: In response to Hans-Juergen Schoenig -- PostgreSQL : Tom, On behalf of the entire PostgreSQL

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Simon Riggs
On Fri, 2009-09-18 at 07:23 -0700, Jeff Janes wrote: On Tue, Sep 15, 2009 at 2:41 PM, Simon Riggs si...@2ndquadrant.com wrote: OK, here is the latest version of the Hot Standby patchset. This is about version 30+ by now, but we should regard this as 0.2.1

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Selena Deckelmann
On Fri, Sep 18, 2009 at 4:04 AM, Hans-Juergen Schoenig -- PostgreSQL postg...@cybertec.at wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. In short, +1 from me.

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Fri, 2009-09-18 at 07:23 -0700, Jeff Janes wrote: Is there a reason that you remove the WAL_DEBUG shown below? WAL_DEBUG is not removed by the patch, though that section of code is removed, as you observe. I recall an earlier bug report by

Re: [HACKERS] numeric_to_number() function skipping some digits

2009-09-18 Thread Tom Lane
Jeevan Chalke jeevan.cha...@enterprisedb.com writes: With PG84, I have tried something like this which seem incorrect to me. # SELECT '' AS to_number_2, to_number('-347,58', '99G999'); Well, the input doesn't actually match the format, so I'm not totally excited about this. You do get sane

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Simon Riggs
On Fri, 2009-09-18 at 11:14 -0400, Tom Lane wrote: Simon Riggs si...@2ndquadrant.com writes: On Fri, 2009-09-18 at 07:23 -0700, Jeff Janes wrote: Is there a reason that you remove the WAL_DEBUG shown below? WAL_DEBUG is not removed by the patch, though that section of code is removed,

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-18 Thread Dan Colish
On Fri, Sep 18, 2009 at 03:10:14PM +0900, Michael Paquier wrote: You really should be returning a value at the point since the function signature defines a return type. If not the function should be void, which it cannot be in this context since it is used for boolean tests elsewhere.

Re: [HACKERS] Schedule for 8.5 Development

2009-09-18 Thread Josh Berkus
Bruce, CF1 7/15 to 8/14 Alpha1 by 8/20 CF2 9/15 to 10/14 Alpha2 by 10/20 CF3 11/15 to 12/14 Alpha3 by 11/20 CF4 1/15 to 2/14 Alpha4 by 2/20 Beta1est. 3/1 to 3/7 Release June, depending on bugs I think that June release date is realistic. Are we ready

Re: [HACKERS] generic copy options

2009-09-18 Thread Josh Berkus
On 9/17/09 3:54 PM, Greg Smith wrote: On Thu, 17 Sep 2009, Dan Colish wrote: - Performance appears to be the same although I don't have a good way for testing this at the moment Here's what I do to generate simple COPY performance test cases: Is there any reason to think that

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Sep 17, 2009 at 4:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: You're the committer; I'm not.  But I completely disagree.  There isn't any reason at all to duplicate this logic in two separate places, let

Re: [HACKERS] generic copy options

2009-09-18 Thread Dan Colish
On Fri, Sep 18, 2009 at 10:21:08AM -0700, Josh Berkus wrote: On 9/17/09 3:54 PM, Greg Smith wrote: On Thu, 17 Sep 2009, Dan Colish wrote: - Performance appears to be the same although I don't have a good way for testing this at the moment Here's what I do to generate

Re: [HACKERS] generic copy options

2009-09-18 Thread Josh Berkus
Nope, but it was on the checklist and I was being thorough. That's a good thing. I was just seeing if I needed to get involved in performance testing. -- Josh Berkus PostgreSQL Experts Inc. www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Draft for organized beta testing

2009-09-18 Thread Josh Berkus
Please comment on the draft if you see anything I'm missing; otherwise I'll start the call for testers as soon as Alpha2 comes out. Would help if I had a link, eh? http://wiki.postgresql.org/wiki/HowToBetaTest -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Schedule for 8.5 Development

2009-09-18 Thread Bruce Momjian
Josh Berkus wrote: Bruce, CF17/15 to 8/14 Alpha1 by 8/20 CF29/15 to 10/14 Alpha2 by 10/20 CF311/15 to 12/14 Alpha3 by 11/20 CF41/15 to 2/14 Alpha4 by 2/20 Beta1 est. 3/1 to 3/7 Release June, depending on bugs I think

Re: [HACKERS] generic copy options

2009-09-18 Thread Dan Colish
On Fri, Sep 18, 2009 at 10:31:21AM -0700, Josh Berkus wrote: Nope, but it was on the checklist and I was being thorough. That's a good thing. I was just seeing if I needed to get involved in performance testing. -- Josh Berkus PostgreSQL Experts Inc. www.pgexperts.com I always

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Robert Haas
On Fri, Sep 18, 2009 at 1:26 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Sep 17, 2009 at 4:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: You're the committer; I'm not.  But I completely disagree.  There isn't

Re: [HACKERS] generic copy options

2009-09-18 Thread Emmanuel Cecchet
Josh Berkus wrote: Nope, but it was on the checklist and I was being thorough. That's a good thing. I was just seeing if I needed to get involved in performance testing. That would be good to have more people test the autopartitioning feature in COPY. If you want to be involved in

Re: [HACKERS] updated hstore patch

2009-09-18 Thread David E. Wheeler
On Sep 15, 2009, at 8:31 PM, Andrew Gierth wrote: Gah. rerolled to fix a missing file. includes the docs too this time. Yay, thank you Andrew! Here are my review notes. Testing === Here's what I did to try out the patch, paying special attention to in- place upgrading: * I built a

Re: [HACKERS] Draft for organized beta testing

2009-09-18 Thread Josh Berkus
Would help if I had a link, eh? http://wiki.postgresql.org/wiki/HowToBetaTest It would also help if the mail servers cleared my original e-mail. Gr. Here's what I posted originally, which our servers have decided to eat: I'm about to launch on a program of organized alpha and beta

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Mmm, I like that. Putting that bunch of hairy logic in a subroutine instead of repeating it in several places definitely seems better. I don't really like the name clause_matches_join, though. It's more like clause has well-defined sides, and mark

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Robert Haas
On Fri, Sep 18, 2009 at 1:58 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Mmm, I like that.  Putting that bunch of hairy logic in a subroutine instead of repeating it in several places definitely seems better.  I don't really like the name

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-18 Thread Selena Deckelmann
Hi! Below is from Brad Slinger. I'm just forwarding his message so that the review will be in the thread for the archives. (Sorry, Brad that I missed this earlier.. I thought you'd already replied to the list for some reason.) Brad says: Please forgive my top posting. Below is my patch

Re: [HACKERS] Lock Wait Statistics (next commitfest)

2009-09-18 Thread Pierre Frédéric Caillau d
I have this patch, if you're interested. LWLock Instrumentation Patch - counts locks and waits in shared and exclusive mode - for selected locks, measures wait and hold times - for selected locks, displays a histogram of wait and hold times - information is printed at backend exit

Re: [HACKERS] Lock Wait Statistics (next commitfest)

2009-09-18 Thread Josh Berkus
Pierre, Configurable by #define's in lwlock.c Given that we already have dtrace/systemtap probes around the lwlocks, is there some way you could use those instead of extra #defines? -- Josh Berkus PostgreSQL Experts Inc. www.pgexperts.com -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Join optimization for inheritance tables

2009-09-18 Thread Tom Lane
Herodotos Herodotou herodotos.herodo...@asterdata.com writes: This patch extends the query optimizer to consider joins between child tables when hierarchies are joined together. I looked over this patch a bit. I am of the opinion that this is a lot of work towards a dead-end direction :-(.

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Sep 18, 2009 at 1:58 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Mmm, I like that.  Putting that bunch of hairy logic in a subroutine instead of repeating it in several places definitely seems better.  I

Re: [HACKERS] FSM search modes

2009-09-18 Thread Hannu Krosing
On Thu, 2009-09-17 at 16:26 +0100, Simon Riggs wrote: Just been looking again at the way FSM works. In fsm_search_avail() we essentially have just a single way for working out how to search the tree. Seems like it would be good to abstract this so that we can implement a number of FSM

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Hannu Krosing
On Fri, 2009-09-18 at 16:24 +0200, Dimitri Fontaine wrote: Hans-Juergen Schoenig -- PostgreSQL postg...@cybertec.at writes: Tom, happy birthday. +1 from me :) +1 from me too :D Regards, -- dim -- Hannu Krosing http://www.2ndQuadrant.com PostgreSQL Scalability and Availability

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Robert Haas
On Fri, Sep 18, 2009 at 3:06 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Sep 18, 2009 at 1:58 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Mmm, I like that.  Putting that bunch of hairy logic in a subroutine

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: The clauses are well-defined, but they don't have well-defined sides. I see now what you're going for with clause_matches_join, but matches is a pretty broad term, IMO. clause_sides_match_join? regards, tom lane -- Sent via

Re: [HACKERS] TODO item: Allow more complex user/database default GUC settings

2009-09-18 Thread Bernd Helmle
--On 25. August 2009 22:17:38 -0400 Alvaro Herrera alvhe...@commandprompt.com wrote: I'm just posting in case somebody has thoughts on the UI part of it. Other things that need fixed: - need to figure out locking for roles; this stuff must be synchronized with role drop - pg_shadow and

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread daveg
On Fri, Sep 18, 2009 at 01:04:23PM +0200, Hans-Juergen Schoenig -- PostgreSQL wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. Best regards,

Re: Anonymous code blocks (was: Re: [HACKERS] GRANT ON ALL IN schema)

2009-09-18 Thread Brendan Jurd
Hi Dimitri, The commitfest app has you listed as the reviewer for this patch. Any progress on your review? Cheers, BJ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: Anonymous code blocks (was: Re: [HACKERS] GRANT ON ALL IN schema)

2009-09-18 Thread Dimitri Fontaine
Brendan Jurd dire...@gmail.com writes: The commitfest app has you listed as the reviewer for this patch. Any progress on your review? Funny I just sent a mail to rrr explaining I don't think I'll be able to complete my review until next Thursday. Feel free to steal me the patch if you want to,

Re: [HACKERS] numeric_to_number() function skipping some digits

2009-09-18 Thread Brendan Jurd
2009/9/19 Tom Lane t...@sss.pgh.pa.us: Should we have it throw an error if the input corresponding to a G symbol doesn't match the expected group separator?  I'm concerned that that would break applications that work okay today. It would be a substantial change to the behaviour, and to do it

Re: [HACKERS] updated join removal patch

2009-09-18 Thread Robert Haas
On Fri, Sep 18, 2009 at 3:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: The clauses are well-defined, but they don't have well-defined sides. I see now what you're going for with clause_matches_join, but matches is a pretty broad term, IMO.

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Joe Conway
daveg wrote: On Fri, Sep 18, 2009 at 01:04:23PM +0200, Hans-Juergen Schoenig -- PostgreSQL wrote: Tom, On behalf of the entire PostgreSQL team here in Austria I want to wish you a happy birthday. We hope that you fill be a vital part of PostgreSQL for many years to come. Best regards,

Re: [HACKERS] patch: Review handling of MOVE and FETCH (ToDo)

2009-09-18 Thread Pavel Stehule
Hello 2009/9/18 Selena Deckelmann selenama...@gmail.com: Hi! John Naylor and I reviewed this patch. John created two test cases to demonstrated issues described later in this email.  I've attached those for reference. On Thu, Aug 27, 2009 at 8:04 PM, Pavel Stehule pavel.steh...@gmail.com

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-18 Thread Petr Jelinek
Jan Urbański napsal(a): Petr Jelinek wrote: So I've been working on solution with which I am happy with (does not mean anybody else will be also though). Hi Petr, I'm reviewing this patch and after reading it I have some comments. Unfortunately, when I got to the compiling part, it

Re: [HACKERS] Hot Standby 0.2.1

2009-09-18 Thread Marcos Luis Ortiz Valmaseda
I want to help on this area, but I need a mentor for this. For example, Heikki will be a excellent mentor for me. Following the theme, I think that we have to wide all questions for the process of the acceptance of a patch on the same way that you Simon. We could write new requirements with all

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Paul Matthews
happy_birthday++; -- Fools ignore complexity. Pragmatists suffer it. Some can avoid it. Geniuses remove it. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] happy birthday Tom Lane ...

2009-09-18 Thread Robert Creager
On Sep 18, 2009, at 5:18 PM, Paul Matthews wrote: happy_birthday++; SELECT count( happy ) FROM birthday WHERE name ~ 'Tom Lane'; WARNING : condition stack overflow: INF Sigh, Rob smime.p7s Description: S/MIME cryptographic signature

Re: [HACKERS] SELECT ... FOR UPDATE [WAIT integer | NOWAIT] for 8.5

2009-09-18 Thread Jeff Janes
On Thu, Sep 3, 2009 at 6:47 AM, Boszormenyi Zoltan z...@cybertec.at wrote: Boszormenyi Zoltan írta: Okay, we implemented only the lock_timeout GUC. Patch attached, hopefully in an acceptable form. Documentation included in the patch, lock_timeout works the same way as

[HACKERS] Draft for organized beta testing

2009-09-18 Thread Josh Berkus
Hackers, I'm about to launch on a program of organized alpha and beta testing by volunteers from our community. Initially, tests will be logged either by e-mail parsing on the pgsql-testers mailing list, or by a web-based Radix interface if I can get one up. Please comment on the draft if you

[HACKERS] Crypto

2009-09-18 Thread David Fetter
Folks, Here's what came out for Mozilla, which, I hope you'll pardon my saying so, is a teensy tad more widely used than PostgreSQL has any plans to become. http://www.internetnews.com/government/article.php/3839831/Mozilla+Firefox+Cleared+of+US+Export+Rules.htm I suggest that we start by

Re: [HACKERS] updated hstore patch

2009-09-18 Thread Andrew Gierth
David == David E Wheeler da...@kineticode.com writes: David * I ran the following to update the SQL functions in my simple database: Davidpsql -d try --set hstore_xact='--' -f hstore.sql DavidThe use of `--set hstore_xact='--' was on Andrew's advice Davidvia IRC, because

Re: [HACKERS] [PATCH] Largeobject access controls

2009-09-18 Thread Stephen Frost
Jamie, * Robert Haas (robertmh...@gmail.com) wrote: Jaime Casanova jcasa...@systemguards.com.ec - Largeobject access controls How is the review for this coming? Do you have any thoughts regarding the new GUC? Thanks, Stephen signature.asc Description: Digital

Re: [HACKERS] [PATCH] Largeobject access controls

2009-09-18 Thread Jaime Casanova
On Fri, Sep 18, 2009 at 8:29 PM, Stephen Frost sfr...@snowman.net wrote: Jamie, How is the review for this coming?  Do you have any thoughts regarding the new GUC? Hi, sorry... these have been hard days... i'm just starting reviewing -- Atentamente, Jaime Casanova Soporte y capacitación de

Re: [HACKERS] [COMMITTERS] pgsql: Easier to translate psql help Instead of requiring translators

2009-09-18 Thread Josh Williams
On Fri, 2009-09-18 at 09:46 -0400, Tom Lane wrote: pet...@postgresql.org (Peter Eisentraut) writes: Log Message: --- Easier to translate psql help Looks like this broke the msvc build ... Yep, one of create_help.pl's arguments changed to not include the file extension, but msvc

Re: [HACKERS] Crypto

2009-09-18 Thread Marcos Luis Ortiz Valmaseda
David Do you can comment this altertatives or choices that we have? We can support us in Bruce Schneier[1], Chief Security Technology Officer, BT (schne...@schneier.com) who is one of the person that knows many topics about security in the world. Is a very nice person and allways is to able to