Re: [HACKERS] Issues for named/mixed function notation patch

2010-02-23 Thread Pavel Stehule
2010/2/23 Bruce Momjian br...@momjian.us: Can someone work on a patch to implement the document changes suggested below? This patch is useless now. There are no this issue now, because we have integrated true SQL parser. Regards Pavel

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-23 Thread Albe Laurenz
Tom Lane wrote: One way to deal with it would be to expose the whole renegotiation setting as a user configuratble option. So they can set *when* we renegotiate, which would also let them turn it off completely. Well, that might be a reasonable thing to do, because it's not just a temporary

[HACKERS] SR/libpq - outbound interface/ipaddress binding

2010-02-23 Thread Stefan Kaltenbrunner
While playing with SR/HS in a more complex datacenter environment I immediatly hit the need to being able to specify the ipaddress(or interface) that the backend(or libpq) uses to connect to the master. There are a few reasons for being able to do so like: * we are now suddenly in a situation

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-23 Thread Greg Stark
On Tue, Feb 23, 2010 at 5:37 AM, Tom Lane t...@sss.pgh.pa.us wrote: So the problem is that fsync_fname is trying to fsync a file it's opened O_RDONLY.  I don't know whether Windows is similarly picky, but we'll soon find out. Argh, now I feel silly. I had actually found that in my searches

Re: [HACKERS] synchronous commit in dump

2010-02-23 Thread Magnus Hagander
2010/2/23 Jaime Casanova jcasa...@systemguards.com.ec: Hi, it's safe to set synchrounous_commit to off in a pg_dump generated script? if yes, would this help to the performance of restore a database? It might help if you're dumping as individual inserts and not COPY, but if you're doing that

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-23 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Alvaro Herrera alvhe...@commandprompt.com writes: Regarding hooks or events, I think postmaster should be kept simple: launch at start, reset at crash recovery, kill at stop. This is exactly why I think the whole proposal is a nonstarter. It is

Re: [HACKERS] SR/libpq - outbound interface/ipaddress binding

2010-02-23 Thread Magnus Hagander
2010/2/23 Stefan Kaltenbrunner ste...@kaltenbrunner.cc: While playing with SR/HS in a more complex datacenter environment I immediatly hit the need to being able to specify the ipaddress(or interface) that the backend(or libpq) uses to connect to the master. There are a few reasons for

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-23 Thread Magnus Hagander
2010/2/22 Tom Lane t...@sss.pgh.pa.us: Magnus Hagander mag...@hagander.net writes: 2010/2/22 Tom Lane t...@sss.pgh.pa.us: You'd still have to turn it off on the server side if you have a *single* client that has the broken patch, but that's still a lot better than nothing. Well, if it's a

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-23 Thread Magnus Hagander
2010/2/23 Albe Laurenz laurenz.a...@wien.gv.at: Tom Lane wrote: One way to deal with it would be to expose the whole renegotiation setting as a user configuratble option. So they can set *when* we renegotiate, which would also let them turn it off completely. Well, that might be a reasonable

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Gokulakannan Somasundaram
On Tue, Feb 23, 2010 at 10:42 AM, Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Instead, how about excluding columns in primary keys from table data? How will you implement select * from mytable ? Or even select * from mytable where

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-23 Thread Tom Lane
I wrote: Any theories about what is happening? Hah --- the AIX failures, at least, are explained at http://publib.boulder.ibm.com/infocenter/aix/v6r1/index.jsp?topic=/com.ibm.aix.basetechref/doc/basetrf1/fsync.htm which says Error Codes The fsync or fsync_range subroutine is unsuccessful if

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Csaba Nagy
Hi all, On Mon, 2010-02-22 at 10:29 +, Greg Stark wrote: On Mon, Feb 22, 2010 at 8:18 AM, Gokulakannan Somasundaram gokul...@gmail.com wrote: a) IOT has both table and index in one structure. So no duplication of data b) With visibility maps, we have three structures a) Table b) Index

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-23 Thread Alvaro Herrera
Dimitri Fontaine wrote: Tom Lane t...@sss.pgh.pa.us writes: Alvaro Herrera alvhe...@commandprompt.com writes: Regarding hooks or events, I think postmaster should be kept simple: launch at start, reset at crash recovery, kill at stop. This is exactly why I think the whole proposal is a

Re: [HACKERS] Issues for named/mixed function notation patch

2010-02-23 Thread Bruce Momjian
Pavel Stehule wrote: 2010/2/23 Bruce Momjian br...@momjian.us: Can someone work on a patch to implement the document changes suggested below? This patch is useless now. There are no this issue now, because we have integrated true SQL parser. Great, thanks. -- Bruce Momjian

Re: [HACKERS] function side effects

2010-02-23 Thread Alvaro Herrera
Tatsuo Ishii wrote: Hi, I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. This is neccessary for pgpool to decide if a qeury should to be sent to all of databases or not. If a query includes functions which do writes to database, it should send the

[HACKERS] Assertion failure in walreceiver

2010-02-23 Thread Greg Stark
I tried to set up a simple master/slave setup and immediately ran into this assertion failure. The slave is just a cold copy of the database immediately after initdb. The first WAL segment hasn't been archived yet. It sees that the first archive fail hasn't been archived yet, starts up walreceiver

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Simon Riggs
On Mon, 2010-02-22 at 08:51 +0200, Heikki Linnakangas wrote: Gokulakannan Somasundaram wrote: May i get a little clarification on this issue? Will we be supporting the IOT feature in postgres in future? What seems like the best path to achieve the kind of performance benefits that

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-23 Thread Simon Riggs
On Tue, 2010-02-23 at 00:02 -0500, Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Regarding hooks or events, I think postmaster should be kept simple: launch at start, reset at crash recovery, kill at stop. Salt and pepper allowed but that's about it -- more complex

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Andrew Dunstan
Gokulakannan Somasundaram wrote: I looked at the postgres nbtree code. From my analysis(which might be wrong!), we can implement IOTs, provided we make a decision on broken data types issue. I am not familiar with this term broken data types, and I just looked for it in the

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-23 Thread Alvaro Herrera
Simon Riggs wrote: What is wanted is a means to integrate parts of a solution that are already intimately tied to Postgres. Non-integration makes the whole Postgres-based solution less reliable and harder to operate. Postgres should not assume that it is the only aspect of the server: in

Re: [HACKERS] function side effects

2010-02-23 Thread Tatsuo Ishii
I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. This is neccessary for pgpool to decide if a qeury should to be sent to all of databases or not. If a query includes functions which do writes to database, it should send the query to all of

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Heikki Linnakangas
Simon Riggs wrote: On Mon, 2010-02-22 at 08:51 +0200, Heikki Linnakangas wrote: Gokulakannan Somasundaram wrote: May i get a little clarification on this issue? Will we be supporting the IOT feature in postgres in future? What seems like the best path to achieve the kind of performance

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Heikki Linnakangas
Andrew Dunstan wrote: Gokulakannan Somasundaram wrote: I looked at the postgres nbtree code. From my analysis(which might be wrong!), we can implement IOTs, provided we make a decision on broken data types issue. I am not familiar with this term broken data types, and I just looked

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Kevin Grittner
Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-02-22 at 08:51 +0200, Heikki Linnakangas wrote: Gokulakannan Somasundaram wrote: May i get a little clarification on this issue? Will we be supporting the IOT feature in postgres in future? What seems like the best path to achieve

Re: [HACKERS] A thought on Index Organized Tables

2010-02-23 Thread Simon Riggs
On Tue, 2010-02-23 at 17:08 +0200, Heikki Linnakangas wrote: Simon Riggs wrote: On Mon, 2010-02-22 at 08:51 +0200, Heikki Linnakangas wrote: Gokulakannan Somasundaram wrote: May i get a little clarification on this issue? Will we be supporting the IOT feature in postgres in future?

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-23 Thread Tom Lane
Greg Stark st...@mit.edu writes: I don't like using configure tests for this because I fear someone could compile Postgres on a system with one set of behaviour and then switch to a different kernel version with a different set of behaviour. In the worst case it could be filesystem dependent

Re: [HACKERS] function side effects

2010-02-23 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Those classifications are meant as planner directives; they are NOT meant to be bulletproof. Hanging database integrity guarantees on whether a non volatile function changes anything is entirely unsafe. To give just one illustration of the problems, a

Re: [HACKERS] pretty print viewdefs

2010-02-23 Thread Andrew Dunstan
Bruce Momjian wrote: What happened to this? I didn't see it applied. I got puzzled by some delphic comments, and then I got pulled into work of a higher priority, so it slipped down my list. Maybe we can pick it up again in 9.1. cheers andrew -- Sent via pgsql-hackers mailing

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-23 Thread Steve Atkins
On Feb 22, 2010, at 9:02 PM, Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Regarding hooks or events, I think postmaster should be kept simple: launch at start, reset at crash recovery, kill at stop. Salt and pepper allowed but that's about it -- more complex ingredients

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-23 Thread Alvaro Herrera
Steve Atkins wrote: Would having a higher level process manager be adequate - one that spawns the postmaster and a list of associated processes (queue manager, job scheduler, random user daemons that are used for database application maintenance). It sounds like something like that would be

Re: [HACKERS] function side effects

2010-02-23 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: Those classifications are meant as planner directives; they are NOT meant to be bulletproof. Hanging database integrity guarantees on whether a non volatile function changes anything is entirely unsafe. To

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-23 Thread Tom Lane
I wrote: BTW, I notice that after allegedly fixing things, we are now seeing fsync failures during CREATE DATABASE in the installcheck phase of buildfarm runs on (apparently) all the Windows critters, plus a couple of other platforms too. This mystifies me. I could believe that there was

Re: [HACKERS] to_char(HH12) with intervals

2010-02-23 Thread Bruce Momjian
Bruce Momjian wrote: bruce wrote: bruce wrote: Dave Page wrote: This was posted as a documentation comment: to_char(interval '0d 0h 12m 44s', 'DD HH MI SS'); with HH and HH12 will return 12 instead of 0. Testing on 8.4.1, it does seem to be the case that you get 00

Re: [HACKERS] pretty print viewdefs

2010-02-23 Thread Bruce Momjian
Andrew Dunstan wrote: Bruce Momjian wrote: What happened to this? I didn't see it applied. I got puzzled by some delphic comments, and then I got pulled into work of a higher priority, so it slipped down my list. Maybe we can pick it up again in 9.1. OK, should it be

Re: [HACKERS] function side effects

2010-02-23 Thread Tatsuo Ishii
I was talking about this to someone in Cuba and one conclusion we reached was that this was a fairly difficult task -- consider that someone may choose to define an innocent-looking operator using a volatile function. If you only examine things that look like functions in the query you

Re: [HACKERS] pretty print viewdefs

2010-02-23 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Bruce Momjian wrote: What happened to this? I didn't see it applied. I got puzzled by some delphic comments, and then I got pulled into work of a higher priority, so it slipped down my list. Maybe we can pick it up again in

[HACKERS] Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores

2010-02-23 Thread Bruce Momjian
Oleg, Teodor, can you look at this? I tried to fix it in wparser_def.c, but couldn't figure out how. Thanks. --- Dan O'Hara wrote: The following bug has been logged online: Bug reference: 5021 Logged by:

Re: [HACKERS] function side effects

2010-02-23 Thread Jaime Casanova
On Tue, Feb 23, 2010 at 11:08 AM, Tom Lane t...@sss.pgh.pa.us wrote: It's *not an error* for a nonvolatile function to call a volatile one. it should be considered an error i think, someone think there is a use cas for calling volatile functions inside stable ones but i can see what that reason

Re: [HACKERS] Resjunk sort columns, Heikki's index-only quals patch, and bug #5000

2010-02-23 Thread Bruce Momjian
Is this a TODO? --- Heikki Linnakangas wrote: Robert Haas wrote: Since you previously stated that you were going to put this patch aside to work on HS and SR[1], I'm going to move this to Returned with Feedback for

Re: [HACKERS] function side effects

2010-02-23 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: throw an error on any attempt to call a volatile function or modify the database? It's *not an error* for a nonvolatile function to call a volatile one. Right, we all know it currently doesn't throw an

Re: [HACKERS] Index-only quals

2010-02-23 Thread Bruce Momjian
I added this URL to the existing TODO item. --- Heikki Linnakangas wrote: Here is an updated version of my patch to return data from b-tree indexes, and use it to satisfy quals. I added a new column 'amregurgitate' to

[HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Josh Berkus
Simon, Fujii, All: While demoing HS/SR at SCALE, I ran into a problem which is likely to be a commonly encountered bug when people first setup HS/SR. Here's the sequence: 1) Set up a brand new master with an archive-commmand and archive=on. 2) Start the master 3) Do a pg_start_backup() 4)

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Josh Berkus
This issue is 100% reproduceable. Oh, btw, this is on Alpha4. --Josh Berkus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Joshua D. Drake
On Tue, 2010-02-23 at 09:45 -0800, Josh Berkus wrote: Simon, Fujii, All: While demoing HS/SR at SCALE, I ran into a problem which is likely to be a commonly encountered bug when people first setup HS/SR. Here's the sequence: 1) Set up a brand new master with an archive-commmand and

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Kevin Grittner
Joshua D. Drake j...@commandprompt.com wrote: If I issue a shutdown, PostgreSQL should do whatever it needs to do to shutdown; including issuing a pg_stop_backup. Should we have a pg_fail_backup function, so that it doesn't put out a file which suggests that we have a complete backup?

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Robert Haas
On Mon, Feb 22, 2010 at 8:55 PM, Bruce Momjian br...@momjian.us wrote: What happened to this patch? I don't see any objections, but it was not applied. I think that the patch author never added it to the open CommitFest and nobody else thought it was important enough to pick up. It looks

Re: [HACKERS] function side effects

2010-02-23 Thread Greg Stark
On Tue, Feb 23, 2010 at 4:52 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Right, we all know it currently doesn't throw an error, but I can't think of anywhere I'd like to have someone do that in a database for which I have any responsibility.  Does anyone have a sane use case for a

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Robert Haas
On Mon, Feb 22, 2010 at 9:35 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Jeremy Kerr j...@ozlabs.org writes: Stephen, If the updated function is always faster when the overall string is at least, say, 16 characters long, But that's not the case - the cost of the function

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Josh Berkus
On 2/23/10 10:14 AM, Robert Haas wrote: On Mon, Feb 22, 2010 at 8:55 PM, Bruce Momjian br...@momjian.us wrote: What happened to this patch? I don't see any objections, but it was not applied. I think that the patch author never added it to the open CommitFest and nobody else thought it was

Re: [HACKERS] More robust pg_hba.conf parsing/error logging

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 12:22 AM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Andrew Dunstan wrote: It will affect any dbname or username in mixed or upper case, not just ALL, won't it? No, I am suggesting to change only the

Re: [HACKERS] Adding \ev view editor?

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 12:43 AM, Bruce Momjian br...@momjian.us wrote: Is this a TODO? Sounds good to me. It doesn't seem like it would be that difficult to add a view editor as \ev. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Alvaro Herrera
Robert Haas escribió: On Mon, Feb 22, 2010 at 9:35 PM, Bruce Momjian br...@momjian.us wrote: What ever happened to this patch? I think it's unclear that all of the best and worst cases have been sufficiently tested and that the results are satisfactory. We have everything from massive

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: On 2/23/10 10:14 AM, Robert Haas wrote: On Mon, Feb 22, 2010 at 8:55 PM, Bruce Momjian br...@momjian.us wrote: What happened to this patch? I don't see any objections, but it was not applied. I think that the patch author never added it to the open

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Stefan Kaltenbrunner
Alvaro Herrera wrote: Robert Haas escribió: On Mon, Feb 22, 2010 at 9:35 PM, Bruce Momjian br...@momjian.us wrote: What ever happened to this patch? I think it's unclear that all of the best and worst cases have been sufficiently tested and that the results are satisfactory. We have

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Alvaro Herrera
Tom Lane escribió: Josh Berkus j...@agliodbs.com writes: On 2/23/10 10:14 AM, Robert Haas wrote: On Mon, Feb 22, 2010 at 8:55 PM, Bruce Momjian br...@momjian.us wrote: What happened to this patch? I don't see any objections, but it was not applied. I think that the patch author never

Re: [HACKERS] Adding \ev view editor?

2010-02-23 Thread Andrew Dunstan
Robert Haas wrote: On Tue, Feb 23, 2010 at 12:43 AM, Bruce Momjian br...@momjian.us wrote: Is this a TODO? Sounds good to me. I think it would be useful if we put line breaks in the column list it gets, otherwise not so much for any view with more than a handful of columns.

Re: [HACKERS] function side effects

2010-02-23 Thread Kevin Grittner
Greg Stark gsst...@mit.edu wrote: Kevin Grittner kevin.gritt...@wicourts.gov wrote: Does anyone have a sane use case for a non-volatile function to call a volatile one or to update the database? So consider for example a function which explicitly sets the timezone and then uses

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Tom Lane
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm I tend to disagree, this patch was specifically done to address a hotspot I noticed under a given workload and it helped a lot for that workload(like getting 6000qps more is pretty neat imho). While people might not use fixed width

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Stefan Kaltenbrunner
Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm I tend to disagree, this patch was specifically done to address a hotspot I noticed under a given workload and it helped a lot for that workload(like getting 6000qps more is pretty neat imho). While people might not use

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane escribió: That would be an argument for sticking this in the next CF, not for applying it now --- it was submitted after the close of the last CF no? Sep. 29 2009? Oh, I was thinking it had just come in recently, but looking back

Re: [HACKERS] function side effects

2010-02-23 Thread Greg Stark
On Tue, Feb 23, 2010 at 6:39 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Or somebody who uses the tsearch functions because they're planning to not change their dictionaries. I didn't realize tsearch functions were volatile.  Should they really be so? Uhm, my mistake. They're

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Tom Lane
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: Tom Lane wrote: Nobody suggested dismissing it. The point was that it hasn't been tested adequately to justify applying it now. not sure what testing people want to get done though (there are a fair amount of results and profiles in the

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Simon Riggs
On Tue, 2010-02-23 at 09:45 -0800, Josh Berkus wrote: 1) Set up a brand new master with an archive-commmand and archive=on. 2) Start the master 3) Do a pg_start_backup() 4) Realize, based on log error messages, that I've misconfigured the archive_command. 5) Attempt to shut down the

Re: [HACKERS] function side effects

2010-02-23 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: On Tue, Feb 23, 2010 at 6:39 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: I didn't realize tsearch functions were volatile.  Should they really be so? Uhm, my mistake. They're stable. IMMUTABLE/STABLE/VOLATILE is not really about side effects, it

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 1:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane escribió: That would be an argument for sticking this in the next CF, not for applying it now --- it was submitted after the close of the last CF no? Sep. 29 2009?

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Joshua D. Drake
On Tue, 2010-02-23 at 18:58 +, Simon Riggs wrote: On Tue, 2010-02-23 at 09:45 -0800, Josh Berkus wrote: This issue is 100% reproduceable. IMHO there in no problem in that behaviour. If somebody requests a backup then we should wait for it to complete. Kevin's suggestion of

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Kevin Grittner
Simon Riggs si...@2ndquadrant.com wrote: The correct resolution is to put in an archive_command that works. One really should ensure that WAL files (or should I now say data? ;-) are flowing before issuing running the pg_start_backup() function. The documentation has always been pretty

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread David Fetter
On Tue, Feb 23, 2010 at 06:58:22PM +, Simon Riggs wrote: On Tue, 2010-02-23 at 09:45 -0800, Josh Berkus wrote: 1) Set up a brand new master with an archive-commmand and archive=on. 2) Start the master 3) Do a pg_start_backup() 4) Realize, based on log error messages, that

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Simon Riggs
On Tue, 2010-02-23 at 11:24 -0800, Joshua D. Drake wrote: This will bite us if we release like this. No it won't. The current behaviour was put there by user request a few releases back. This isn't a 9.0 issue, and as I've said its addressing something that we now longer see as mainstream going

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 12:52 PM, Joshua D. Drake j...@commandprompt.com wrote: On Tue, 2010-02-23 at 09:45 -0800, Josh Berkus wrote: Simon, Fujii, All: While demoing HS/SR at SCALE, I ran into a problem which is likely to be a commonly encountered bug when people first setup HS/SR.  Here's

Re: [HACKERS] function side effects

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 2:02 PM, Tom Lane t...@sss.pgh.pa.us wrote: There may be some value in inventing a has no side effects marker, but that should not be confused with IMMUTABLE/STABLE. Yeah, that's what I was thinking, too ...Robert -- Sent via pgsql-hackers mailing list

Re: [HACKERS] function side effects

2010-02-23 Thread Kevin Grittner
Greg Stark gsst...@mit.edu wrote: Kevin Grittner kevin.gritt...@wicourts.gov wrote: Thanks for the examples. They did make me consider a real-life type of process which isn't currently implemented as a PostgreSQL function, but conceivably could be -- randomizing a pool of jurors to

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Joshua D. Drake
On Tue, 2010-02-23 at 14:49 -0500, Robert Haas wrote: If I issue a shutdown, PostgreSQL should do whatever it needs to do to shutdown; including issuing a pg_stop_backup. Maybe. But for sure, if it doesn't, and instead tells the user to issue pg_stop_backup(), then pg_stop_backup() had

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 3:09 PM, Joshua D. Drake j...@commandprompt.com wrote: On Tue, 2010-02-23 at 14:49 -0500, Robert Haas wrote: If I issue a shutdown, PostgreSQL should do whatever it needs to do to shutdown; including issuing a pg_stop_backup. Maybe.  But for sure, if it doesn't, and

Re: [HACKERS] phypot - Pygmy Hippotause ?

2010-02-23 Thread Kevin Grittner
Bruce Momjian br...@momjian.us wrote: I assume this is not something we are supposed to apply. While it appears to improve conformance with the IEEE Std 1003.1 and expand the range of numbers which are correctly handled, it does more calculations. I wouldn't want to see it get in without

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-23 Thread Bruce Momjian
Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: Tom Lane wrote: Nobody suggested dismissing it. The point was that it hasn't been tested adequately to justify applying it now. not sure what testing people want to get done though (there are a fair amount of

Re: [HACKERS] More robust pg_hba.conf parsing/error logging

2010-02-23 Thread Bruce Momjian
Robert Haas wrote: On Tue, Feb 23, 2010 at 12:22 AM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Andrew Dunstan wrote: It will affect any dbname or username in mixed or upper case, not just ALL, won't it? No, I am

Re: [HACKERS] Adding \ev view editor?

2010-02-23 Thread Bruce Momjian
Andrew Dunstan wrote: Robert Haas wrote: On Tue, Feb 23, 2010 at 12:43 AM, Bruce Momjian br...@momjian.us wrote: Is this a TODO? Sounds good to me. I think it would be useful if we put line breaks in the column list it gets, otherwise not so much for any view

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Bruce Momjian
Robert Haas wrote: On Tue, Feb 23, 2010 at 1:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane escribi?: That would be an argument for sticking this in the next CF, not for applying it now --- it was submitted after the close of the last

Re: [HACKERS] function side effects

2010-02-23 Thread Jaime Casanova
On Tue, Feb 23, 2010 at 2:02 PM, Tom Lane t...@sss.pgh.pa.us wrote: There may be some value in inventing a has no side effects marker, but that should not be confused with IMMUTABLE/STABLE. a READONLY function? -- Atentamente, Jaime Casanova Soporte y capacitación de PostgreSQL Asesoría y

Re: [HACKERS] phypot - Pygmy Hippotause ?

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 4:03 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Bruce Momjian br...@momjian.us wrote: I assume this is not something we are supposed to apply. While it appears to improve conformance with the IEEE Std 1003.1 and expand the range of numbers which are

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Feb 23, 2010 at 1:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: However, has the patch actually been reviewed?  pg_dump is a piece of code where it is notoriously easy for novices to do things wrong, and this is especially true for adding output

[HACKERS] Pika buildfarm member failure on pgcrypto/test sha2

2010-02-23 Thread Rémi Zara
Hi, Pika, which has been upgraded to NetBSD/mips 5.0.2, failed twice in a row pgcrypto/test sha2 because of the following warning (identical each time) : ** /home/pgbuildfarm/workdir/HEAD/pgsql.12374/contrib/pgcrypto/expected/sha2.out Tue Feb 23 13:14:03 2010 ---

Re: [HACKERS] Linux start script updates

2010-02-23 Thread Bruce Momjian
Kevin Grittner wrote: Due to a thread about the neglect of the sample start scripts I took a look at the current Linux file. There's certainly room for several improvements, but some of them might require discussion. Attached are a couple small changes which seem to me to be pretty tame.

Re: [HACKERS] function side effects

2010-02-23 Thread Simon Riggs
On Mon, 2010-02-22 at 23:49 -0500, Tom Lane wrote: Tatsuo Ishii is...@postgresql.org writes: I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. Currently we have three properties of functions: IMMUTABLE, STABLE and VOLATILE. According to docs

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-23 Thread Bruce Momjian
Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Feb 23, 2010 at 1:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: However, has the patch actually been reviewed? ?pg_dump is a piece of code where it is notoriously easy for novices to do things wrong, and this is especially true

Re: [HACKERS] auto_explain log_verbose causes regression failure

2010-02-23 Thread Bruce Momjian
Uh, I don't see this patch as applied. Was it not necessary? --- Itagaki Takahiro wrote: Robert Haas robertmh...@gmail.com wrote: It looks like this is enough to reproduce the cache lookup failure: The cache

Re: [HACKERS] function side effects

2010-02-23 Thread Simon Riggs
On Tue, 2010-02-23 at 12:51 +0900, Tatsuo Ishii wrote: I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. This is neccessary for pgpool to decide if a qeury should to be sent to all of databases or not. If a query includes functions which do writes to

Re: [HACKERS] phypot - Pygmy Hippotause ?

2010-02-23 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Perhaps we should add it to the next CommitFest? Sounds like the right course of action to me. If nobody objects or beats me to it, I'll do that. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] opportunistic tuple freezing

2010-02-23 Thread Bruce Momjian
I assume no progress has been made on testing the performance of this patch. --- Jeff Davis wrote: Attached is a patch to implement the idea discussed here:

Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-02-23 Thread Simon Riggs
On Thu, 2010-01-28 at 10:28 +0200, Heikki Linnakangas wrote: Fujii Masao wrote: In relation to the functions added recently, I found an annoying problem; pg_xlogfile_name(pg_last_xlog_receive/replay_location()) might report the wrong name because pg_xlogfile_name() always uses the current

Re: [HACKERS] opportunistic tuple freezing

2010-02-23 Thread Jeff Davis
On Tue, 2010-02-23 at 17:49 -0500, Bruce Momjian wrote: I assume no progress has been made on testing the performance of this patch. That's correct. As of right now, the potential benefits of the patch do not seem to justify the performance testing effort. Others are welcome to try, of

Re: [HACKERS] function side effects

2010-02-23 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: So wrongly marking a function as something other than volatile *is* a data integrity issue. Why is that OK? ISTM that this should work the way Tatsuo wants it to work. Please read the rest of the thread. regards, tom lane --

Re: [HACKERS] SR/libpq - outbound interface/ipaddress binding

2010-02-23 Thread Simon Riggs
On Tue, 2010-02-23 at 10:00 +0100, Stefan Kaltenbrunner wrote: While playing with SR/HS in a more complex datacenter environment I immediatly hit the need to being able to specify the ipaddress(or interface) that the backend(or libpq) uses to connect to the master. There are a few reasons

[HACKERS] Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.

2010-02-23 Thread Simon Riggs
On Mon, 2010-02-22 at 11:47 +, Heikki Linnakangas wrote: Log Message: --- Move documentation of all recovery.conf option to a new chapter. They used to be scattered between the backup and restore and streaming replication chapters. It's just taken me 15 minutes to locate the

Re: [HACKERS] Issues for named/mixed function notation patch

2010-02-23 Thread Jeff Davis
On Tue, 2010-02-23 at 09:34 -0500, Bruce Momjian wrote: Pavel Stehule wrote: 2010/2/23 Bruce Momjian br...@momjian.us: Can someone work on a patch to implement the document changes suggested below? This patch is useless now. There are no this issue now, because we have

Re: [HACKERS] synchronous commit in dump

2010-02-23 Thread Jaime Casanova
On Tue, Feb 23, 2010 at 4:40 AM, Magnus Hagander mag...@hagander.net wrote: 2010/2/23 Jaime Casanova jcasa...@systemguards.com.ec: Hi, it's safe to set synchrounous_commit to off in a pg_dump generated script? if yes, would this help to the performance of restore a database? It might help

Re: [HACKERS] Pika buildfarm member failure on pgcrypto/test sha2

2010-02-23 Thread Marko Kreen
On 2/24/10, Rémi Zara remi_z...@mac.com wrote: Pika, which has been upgraded to NetBSD/mips 5.0.2, failed twice in a row pgcrypto/test sha2 because of the following warning (identical each time) : Anything I should try ? Please try --without-openssl. -- marko -- Sent via pgsql-hackers

Re: [HACKERS] pg_stop_backup does not complete

2010-02-23 Thread Fujii Masao
On Wed, Feb 24, 2010 at 4:49 AM, Robert Haas robertmh...@gmail.com wrote: Maybe.  But for sure, if it doesn't, and instead tells the user to issue pg_stop_backup(), then pg_stop_backup() had better WORK when the user tries to execute it.  I gather that the problem is that it has to finish all

Re: [HACKERS] function side effects

2010-02-23 Thread Tatsuo Ishii
I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. This is neccessary for pgpool to decide if a qeury should to be sent to all of databases or not. If a query includes functions which do writes to database, it should send the query to all of

  1   2   >