Re: [HACKERS] Per-column collation, work in progress

2010-09-24 Thread Peter Eisentraut
On tor, 2010-09-23 at 11:55 +0200, Pavel Stehule wrote: select to_char(current_date,'tmday' collate cs_CZ.utf8); I am thinking, collates can be used for this purpose too. I see some impacts - this syntax changes a stable function to immutable and it cannot be simple to solve. I don't

Re: [HACKERS] pg_comments

2010-09-24 Thread KaiGai Kohei
Robert, I noticed a problem at the definition of the view. : +UNION ALL +SELECT + d.objoid, d.classoid, d.objsubid, + 'large object'::text AS objtype, + NULL::oid AS objnamespace, + d.objoid::text AS objname, + d.description +FROM + pg_description d +

Re: [HACKERS] Per-column collation, work in progress

2010-09-24 Thread Pavel Stehule
2010/9/24 Peter Eisentraut pete...@gmx.net: On tor, 2010-09-23 at 11:55 +0200, Pavel Stehule wrote: select to_char(current_date,'tmday' collate cs_CZ.utf8); I am thinking, collates can be used for this purpose too. I see some impacts - this syntax changes a stable function to immutable and

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Markus Wanner
On 09/23/2010 10:09 PM, Robert Haas wrote: I think maybe you missed Tom's point, or else you just didn't respond to it. If the master is wedged because it is waiting for a standby, then you cannot commit transactions on the master. Therefore you cannot update the system catalog which you

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Markus Wanner
Simon, On 09/24/2010 12:11 AM, Simon Riggs wrote: As I keep pointing out, waiting for an acknowledgement from something that isn't there might just take a while. The only guarantee that provides is that you will wait a long time. Is my data more safe? No. By now I agree that waiting for

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 01:11, Simon Riggs wrote: But that's not what I call synchronous replication, it doesn't give you the guarantees that textbook synchronous replication does. Which textbook? I was using that word metaphorically, but for example: Wikipedia

Re: [HACKERS] ask for review of MERGE

2010-09-24 Thread Greg Smith
Finding time for a review as large as this one is a bit tough, but I've managed to set aside a couple of days for it over the next week. I'm delivering a large project tonight and intend to start in on the review work tomorrow onced that's cleared up. If you're ever not sure who is working

Re: [HACKERS] snapshot generation broken

2010-09-24 Thread Magnus Hagander
On Fri, Sep 24, 2010 at 07:15, Peter Eisentraut pete...@gmx.net wrote: On tor, 2010-09-23 at 11:07 +0300, Peter Eisentraut wrote: On ons, 2010-09-22 at 12:29 +0300, Peter Eisentraut wrote: On ons, 2010-09-22 at 10:33 +0200, Stefan Kaltenbrunner wrote: It seems that the git move has broken

[HACKERS] Enable logging requires restart

2010-09-24 Thread Thom Brown
At the moment, to enable logging, a service restart is required. Is there any way to remove this requirement or is there a fundamental reason why it must always be like that? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 -- Sent via pgsql-hackers

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 01:11, Simon Riggs wrote: On Thu, 2010-09-23 at 20:42 +0300, Heikki Linnakangas wrote: If you want the behavior where the master doesn't acknowledge a commit to the client until the standby (or all standbys, or one of them etc.) acknowledges it, even if the standby is not currently

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 06:26, Itagaki Takahiro wrote: On Fri, Sep 24, 2010 at 12:08 PM, Robert Haasrobertmh...@gmail.com wrote: I think we need to further discuss how this is eventually going to get integrated with the query planner and the executor before we commit anything. The syntax support by

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-09-24 Thread Itagaki Takahiro
On Fri, Sep 24, 2010 at 6:12 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: It's not that the design is bad, it's that it's non-existent. I haven't seen any design on how this integrates with the planner. In my understanding, the DDL part is independent from planner

[HACKERS] Name column

2010-09-24 Thread Vlad Arkhipov
I have just come across a weird thing. It works for any table and seems to be not documented. SELECT c.name FROM (VALUES(1, 'A', true)) c; SELECT c.name FROM pg_class c; And it does not work in these cases: SELECT name FROM (VALUES(1, 'A', true)); SELECT name FROM pg_class; PostgreSQL 8.4.2

Re: [HACKERS] Name column

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 13:02, Vlad Arkhipov wrote: I have just come across a weird thing. It works for any table and seems to be not documented. SELECT c.name FROM (VALUES(1, 'A', true)) c; SELECT c.name FROM pg_class c; And it does not work in these cases: SELECT name FROM (VALUES(1, 'A', true));

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Simon Riggs
On Thu, 2010-09-23 at 14:26 +0200, Csaba Nagy wrote: Unfortunately it was quite long time ago we last tried, and I don't remember exactly what was bottlenecked. Our application is quite write-intensive, the ratio of writes to reads which actually reaches the disk is about 50-200% (according to

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Simon Riggs
On Thu, 2010-09-23 at 16:09 -0400, Robert Haas wrote: On Thu, Sep 23, 2010 at 3:46 PM, Simon Riggs si...@2ndquadrant.com wrote: Well, its not at all hard to see how that could be configured, because I already proposed a simple way of implementing parameters that doesn't suffer from those

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Oh, I thought part of the objective here was to try to centralize that stuff. If we're assuming that slaves will still have local replication configuration files, then I think we should just add any necessary info to those files and drop this entire

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Dimitri Fontaine
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: If you want the behavior where the master doesn't acknowledge a commit to the client until the standby (or all standbys, or one of them etc.) acknowledges it, even if the standby is not currently connected, the master needs to know

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Simon Riggs
On Fri, 2010-09-24 at 11:08 +0300, Heikki Linnakangas wrote: On 24/09/10 01:11, Simon Riggs wrote: But that's not what I call synchronous replication, it doesn't give you the guarantees that textbook synchronous replication does. Which textbook? I was using that word metaphorically,

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Simon Riggs
On Fri, 2010-09-24 at 11:43 +0300, Heikki Linnakangas wrote: To get zero data loss *and* continuous availability, you need two standbys offering sync rep and reply-to-first behaviour. Yes, that is a good point. I'm starting to understand what your proposal was all about. It makes sense

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: I think maybe you missed Tom's point, or else you just didn't respond to it. If the master is wedged because it is waiting for a standby, then you cannot commit transactions on the master. Therefore you cannot update the system catalog which you must

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 13:57, Simon Riggs wrote: If you want high availability you need N+1 redundancy. If you want a standby server that is N=1. If you want a highly available standby configuration then N+1 = 2. Yep. Synchronous replication with one standby gives you zero data loss. When you add a 2nd

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Simon Riggs
On Fri, 2010-09-24 at 14:12 +0300, Heikki Linnakangas wrote: What I'm saying is that in a two standby situation, if you're willing to continue operation as usual in the master even if the standby is down, you're not doing synchronous replication. Oracle and I disagree with you on that point,

Re: [HACKERS] security label support, revised

2010-09-24 Thread Robert Haas
2010/9/23 KaiGai Kohei kai...@ak.jp.nec.com: Please see http://archives.postgresql.org/pgsql-hackers/2010-09/msg01080.php OK, I'll emulate this approach at first. Don't worry about this part - I will do this myself. If you can just fix the pg_dump stuff, I think we will be in pretty good

Re: [HACKERS] pg_comments

2010-09-24 Thread Robert Haas
2010/9/24 KaiGai Kohei kai...@ak.jp.nec.com: If and when user create a table named 'pg_largeobject' on anywhere except for the 'pg_catalog' schema, the (SELECT oid FROM pg_class WHERE relname = 'pg_largeobject') may not return 2613. Oh, dear, how embarassing. Perhaps it should be written as:

Re: [HACKERS] Name column

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 6:35 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: For historical reasons PostgreSQL supports calling a function with a single argument like column.function, in addition to function(column). There is a function name(text) that casts the input to the

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-09-24 Thread Robert Haas
On Thu, Sep 23, 2010 at 11:26 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: There are no active discussions :-(  I think the author tried his best, so if other developers think it's a bad design, alternate plan must be proposed. Also, if the syntax change is trivial, that's why we

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 5:56 AM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: I think there are two type of FDWs. One is a simple flat file wrapper used by COPY FROM now, that doesn't require any planner hooks. Another is a connector to an external database, like as dblink, that should

Re: [HACKERS] Enable logging requires restart

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 4:33 AM, Thom Brown t...@linux.com wrote: At the moment, to enable logging, a service restart is required.  Is there any way to remove this requirement or is there a fundamental reason why it must always be like that? Are you speaking of the logging_collector GUC? I

Re: [HACKERS] Enable logging requires restart

2010-09-24 Thread Thom Brown
On 24 September 2010 13:17, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 24, 2010 at 4:33 AM, Thom Brown t...@linux.com wrote: At the moment, to enable logging, a service restart is required.  Is there any way to remove this requirement or is there a fundamental reason why it must

Re: [HACKERS] Enable logging requires restart

2010-09-24 Thread Thom Brown
On 24 September 2010 13:22, Thom Brown t...@linux.com wrote: On 24 September 2010 13:17, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 24, 2010 at 4:33 AM, Thom Brown t...@linux.com wrote: At the moment, to enable logging, a service restart is required.  Is there any way to remove this

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 6:37 AM, Simon Riggs si...@2ndquadrant.com wrote: Earlier you argued that centralizing parameters would make this nice and simple. Now you're pointing out that we aren't centralizing this at all, and it won't be simple. We'll have to have a standby.conf set up that is

Re: [HACKERS] Enable logging requires restart

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 8:31 AM, Thom Brown t...@linux.com wrote: On 24 September 2010 13:22, Thom Brown t...@linux.com wrote: On 24 September 2010 13:17, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 24, 2010 at 4:33 AM, Thom Brown t...@linux.com wrote: At the moment, to enable

Re: [HACKERS] security label support, revised

2010-09-24 Thread KaiGai Kohei
(2010/09/24 20:56), Robert Haas wrote: 2010/9/23 KaiGai Koheikai...@ak.jp.nec.com: Please see http://archives.postgresql.org/pgsql-hackers/2010-09/msg01080.php OK, I'll emulate this approach at first. Don't worry about this part - I will do this myself. If you can just fix the pg_dump

Re: [HACKERS] security label support, revised

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 8:54 AM, KaiGai Kohei kai...@kaigai.gr.jp wrote: (2010/09/24 20:56), Robert Haas wrote: 2010/9/23 KaiGai Koheikai...@ak.jp.nec.com: Please see http://archives.postgresql.org/pgsql-hackers/2010-09/msg01080.php OK, I'll emulate this approach at first. Don't worry

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Aidan Van Dyk
On Fri, Sep 24, 2010 at 7:47 AM, Simon Riggs si...@2ndquadrant.com wrote: On Fri, 2010-09-24 at 14:12 +0300, Heikki Linnakangas wrote: What I'm saying is that in a two standby situation, if you're willing to continue operation as usual in the master even if the standby is down, you're not

[HACKERS] Large objects.

2010-09-24 Thread Dmitriy Igrishin
Hey all, Here is simple test case of LOB usage, please, note the comments: #include libpq-fe.h #include libpq/libpq-fs.h int main(int argc, char* argv[]) { PGconn* c = PQconnectdb(password=test); PGresult* r = PQexec(c, BEGIN); PQclear(r); const unsigned int id = lo_create(c, 0);

[HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Magnus Hagander
On Fri, Sep 17, 2010 at 05:51, Ashesh Vashi ashesh.va...@enterprisedb.com wrote: Hi Mark, On of my college (Sujeet) has found a way to reproduce the same behaviour. 1. Installed PG 9.0 on Win XP SP3 2. Stop the Postgresql-9.0 service from service manager console 3. Create pgpass.conf in

Re: [HACKERS] pg_comments

2010-09-24 Thread Tom Lane
KaiGai Kohei kai...@ak.jp.nec.com writes: It seems to me the query should be fixed up as follows: : WHERE d.classoid = (SELECT oid FROM pg_class WHERE relname = 'pg_largeobject' AND relnamespace = (SELECT oid FROM pg_namespace

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 14:47, Simon Riggs wrote: On Fri, 2010-09-24 at 14:12 +0300, Heikki Linnakangas wrote: What I'm saying is that in a two standby situation, if you're willing to continue operation as usual in the master even if the standby is down, you're not doing synchronous replication. Oracle

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Dimitri Fontaine
Hi, Defending my ideas as not to be put in the bag you're wanting to put away. We have more than 2 proposals lying around here. I'm one of the guys with a proposal and no code, but still trying to be clear. Robert Haas robertmh...@gmail.com writes: The reason I think that we should centralize

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: I took a quick look at the code, and from what I can tell this is because PQconnectionNeedsPassword() always returns false if a pgpass.conf has been used. There is no handling the case where pgpass is used, but has an incorrect password. Why should

Re: [HACKERS] Standby registration

2010-09-24 Thread Dimitri Fontaine
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: There's two separate concepts here: 1. Automatic registration. When a standby connects, its information gets permanently added to standby.conf file 2. Unregistered standbys. A standby connects, and its information is not in

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Simon Riggs
On Fri, 2010-09-24 at 16:01 +0200, Dimitri Fontaine wrote: I'd like that we now follow Josh Berkus (and some other) advice now, and start a new thread to decide what we mean by synchronous replication, what kind of normal behaviour we want and what responses to errors we expect to be able to

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Magnus Hagander
On Fri, Sep 24, 2010 at 16:04, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: I took a quick look at the code, and from what I can tell this is because PQconnectionNeedsPassword() always returns false if a pgpass.conf has been used. There is no handling the case

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Heikki Linnakangas
On 24/09/10 17:13, Simon Riggs wrote: On Fri, 2010-09-24 at 16:01 +0200, Dimitri Fontaine wrote: I'd like that we now follow Josh Berkus (and some other) advice now, and start a new thread to decide what we mean by synchronous replication, what kind of normal behaviour we want and what

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Andrew Dunstan
On 09/24/2010 10:15 AM, Magnus Hagander wrote: On Fri, Sep 24, 2010 at 16:04, Tom Lanet...@sss.pgh.pa.us wrote: Magnus Hagandermag...@hagander.net writes: I took a quick look at the code, and from what I can tell this is because PQconnectionNeedsPassword() always returns false if a

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 09/24/2010 10:15 AM, Magnus Hagander wrote: In that case, we should probably teach pg_ctl about this case, no? Since it clearly gives an incorrect message to the user now... pg_ctl decides that the server is running iff it can connect to it. Do

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Dave Page
On Fri, Sep 24, 2010 at 4:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: (Of course, a pg_ping utility would be a better answer, but nobody's gotten around to that in more than ten years, so I'm not holding my breath.) Hmm, that sounded like it could be my 9.1 mini project - then Google showed me

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-24 Thread Tom Lane
I wrote: Apparently somebody's confused between local and GMT time somewhere in there. For the archives' sake: this turns out to be a portability issue not handled by the git code. If you are running on a platform old enough to have gmtime_r returning int rather than struct tm *, you need this

Re: [HACKERS] Name column

2010-09-24 Thread André Fernandes
Date: Fri, 24 Sep 2010 08:01:35 -0400 Subject: Re: [HACKERS] Name column From: robertmh...@gmail.com To: heikki.linnakan...@enterprisedb.com CC: arhi...@dc.baikal.ru; pgsql-hackers@postgresql.org On Fri, Sep 24, 2010 at 6:35 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com

Re: [HACKERS] Configuring synchronous replication

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 10:01 AM, Dimitri Fontaine dfonta...@hi-media.com wrote:  Configuring whether the master will retain WAL for a disconnected slave on the slave is outright byzantine. Again, I can't remember having proposed such a thing. No one has, but I keep hearing we don't need the

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Tom Lane
Dave Page dp...@pgadmin.org writes: On Fri, Sep 24, 2010 at 4:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: (Of course, a pg_ping utility would be a better answer, but nobody's gotten around to that in more than ten years, so I'm not holding my breath.) Hmm, that sounded like it could be my 9.1

Re: [HACKERS] Name column

2010-09-24 Thread Tom Lane
=?iso-8859-1?B?QW5kcukgRmVybmFuZGVz?= andre.de.camargo.fernan...@hotmail.com writes: On Fri, Sep 24, 2010 at 6:35 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I'm starting to wonder if we should think about deprecating this behavior. It is awfully confusing and

Re: [HACKERS] Name column

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 11:43 AM, Tom Lane t...@sss.pgh.pa.us wrote: =?iso-8859-1?B?QW5kcukgRmVybmFuZGVz?= andre.de.camargo.fernan...@hotmail.com writes: On Fri, Sep 24, 2010 at 6:35 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I'm starting to wonder if we should think

Re: [HACKERS] Enable logging requires restart

2010-09-24 Thread Andrew Dunstan
On 09/24/2010 08:22 AM, Thom Brown wrote: On 24 September 2010 13:17, Robert Haasrobertmh...@gmail.com wrote: On Fri, Sep 24, 2010 at 4:33 AM, Thom Brownt...@linux.com wrote: At the moment, to enable logging, a service restart is required. Is there any way to remove this requirement or is

Re: [HACKERS] Name column

2010-09-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Sep 24, 2010 at 11:43 AM, Tom Lane t...@sss.pgh.pa.us wrote: -1.  There's nothing wrong with the function-as-a-computed-column feature, and it seems likely that taking it away will break applications. ... What evidence do we have that anyone

Re: [HACKERS] Enable logging requires restart

2010-09-24 Thread Thom Brown
On 24 September 2010 16:52, Andrew Dunstan and...@dunslane.net wrote: On 09/24/2010 08:22 AM, Thom Brown wrote: On 24 September 2010 13:17, Robert Haasrobertmh...@gmail.com  wrote: On Fri, Sep 24, 2010 at 4:33 AM, Thom Brownt...@linux.com  wrote: At the moment, to enable logging, a

Re: [HACKERS] Name column

2010-09-24 Thread Pavel Stehule
2010/9/24 André Fernandes andre.de.camargo.fernan...@hotmail.com: Date: Fri, 24 Sep 2010 08:01:35 -0400 Subject: Re: [HACKERS] Name column From: robertmh...@gmail.com To: heikki.linnakan...@enterprisedb.com CC: arhi...@dc.baikal.ru; pgsql-hackers@postgresql.org On Fri, Sep 24, 2010 at

Re: [HACKERS] Name column

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 11:55 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Sep 24, 2010 at 11:43 AM, Tom Lane t...@sss.pgh.pa.us wrote: -1.  There's nothing wrong with the function-as-a-computed-column feature, and it seems likely that taking it away

Re: [HACKERS] Name column

2010-09-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Sep 24, 2010 at 11:55 AM, Tom Lane t...@sss.pgh.pa.us wrote: So?  There are lots of surprising things in SQL.  And *of course* the only complaints come from people who didn't know about it, not from satisfied users. I guess that's true, but

Re: [HACKERS] Name column

2010-09-24 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: I dislike this feature too. It is breaking other ANSI SQL feature - constructors, because it has same syntax tablename(field1, field2, ). Uh, that's nonsense. What we're talking about is tablename.functionname.

Re: [HACKERS] Name column

2010-09-24 Thread Pavel Stehule
2010/9/24 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: On Fri, Sep 24, 2010 at 11:43 AM, Tom Lane t...@sss.pgh.pa.us wrote: -1.  There's nothing wrong with the function-as-a-computed-column feature, and it seems likely that taking it away will break applications.

Re: [HACKERS] Serializable Snapshot Isolation

2010-09-24 Thread Kevin Grittner
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: My aim is still to put an upper bound on the amount of shared memory required, regardless of the number of committed but still interesting transactions. That maps nicely to a SLRU table Well, that didn't take as long to get my

[HACKERS] Magnus? Is that you?

2010-09-24 Thread Greg Stark
Some voter in Sweden has an interesting sense of humour http://alicebobandmallory.com/articles/2010/09/23/did-little-bobby-tables-migrate-to-sweden -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Easy way to verify gitignore files?

2010-09-24 Thread Tom Lane
Dimitri Fontaine dfonta...@hi-media.com writes: Tom Lane t...@sss.pgh.pa.us writes: However, it seems that git isn't so willing to tell you about gitignore patterns that cover too much, i.e. match files that are already in the repository. It seems to me that git-ls-files is what you want

Re: [HACKERS] Magnus? Is that you?

2010-09-24 Thread Magnus Hagander
On Fri, Sep 24, 2010 at 18:17, Greg Stark st...@mit.edu wrote: Some voter in Sweden has an interesting sense of humour http://alicebobandmallory.com/articles/2010/09/23/did-little-bobby-tables-migrate-to-sweden Ahem. No comment. --  Magnus Hagander  Me: http://www.hagander.net/  Work:

Re: [HACKERS] Magnus? Is that you?

2010-09-24 Thread Thom Brown
On 24 September 2010 17:46, Magnus Hagander mag...@hagander.net wrote: On Fri, Sep 24, 2010 at 18:17, Greg Stark st...@mit.edu wrote: Some voter in Sweden has an interesting sense of humour http://alicebobandmallory.com/articles/2010/09/23/did-little-bobby-tables-migrate-to-sweden Ahem.

Re: [HACKERS] Serializable Snapshot Isolation

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 12:17 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Thoughts? Premature optimization is the root of all evil. I'm not convinced that we should tinker with any of this before committing it and getting some real-world experience. It's not going to be perfect in

Re: [HACKERS] Serializable Snapshot Isolation

2010-09-24 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 24, 2010 at 12:17 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Thoughts? Premature optimization is the root of all evil. I'm not convinced that we should tinker with any of this before committing it and getting some real-world

Re: [HACKERS] Serializable Snapshot Isolation

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 1:35 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 24, 2010 at 12:17 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Thoughts? Premature optimization is the root of all evil.  I'm not convinced that

[HACKERS] History for 8.3.6 tag is a little strange

2010-09-24 Thread Jeff Davis
Doing git log tags/REL8_3_6 I see two commits after the one labeled tag for 8.3.6. The other tags I checked all seem to match what I would expect. I'm not suggesting that anything be done, I just wanted to point this out in case something strange happened. Regards, Jeff Davis -- Sent

Re: [HACKERS] psql's \dn versus temp schemas

2010-09-24 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On sön, 2010-09-19 at 13:51 -0400, Tom Lane wrote: Hmm. If we had a \dnS option, what I would sorta expect it to do is show the system schemas pg_catalog and information_schema. The toast and temp schemas seem like a different category somehow. On

Re: [HACKERS] History for 8.3.6 tag is a little strange

2010-09-24 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: Doing git log tags/REL8_3_6 I see two commits after the one labeled tag for 8.3.6. The other tags I checked all seem to match what I would expect. I'm not suggesting that anything be done, I just wanted to point this out in case something strange

Re: [HACKERS] Serializable Snapshot Isolation

2010-09-24 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: I think the only changes we should make now are things that we're sure are improvements. In that vein, anyone who is considering reviewing the patch should check the latest from the git repo or request an incremental patch. I've committed a few

Re: [HACKERS] What happened to the is_type family of functions proposal?

2010-09-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Sep 21, 2010 at 7:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: There are many rules that you could possibly make for type input functions.  But you cannot throw an error is not one of them --- or at least, not one that you can usefully expect to

Re: [HACKERS] snapshot generation broken

2010-09-24 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Fri, Sep 24, 2010 at 07:15, Peter Eisentraut pete...@gmx.net wrote: And NLS is also fixed. Great. Thanks - that takes one more thing off the cvs requirement ;) Yeah. Maybe we don't need a cvsserver after all. Would it make more sense to help

Re: [HACKERS] snapshot generation broken

2010-09-24 Thread Andrew Dunstan
On 09/24/2010 03:47 PM, Tom Lane wrote: Yeah. Maybe we don't need a cvsserver after all. Would it make more sense to help Stefan get git running on his BSD boxes? If Bruce and I could get it to work on our pet dinosaurs, I think it likely can be gotten to work on spoonbill too. Yeah, I

Re: [HACKERS] levenshtein_less_equal (was: multibyte charater set in levenshtein function)

2010-09-24 Thread Robert Haas
On Sat, Aug 28, 2010 at 8:34 AM, Alexander Korotkov aekorot...@gmail.com wrote: Here is the patch which adds levenshtein_less_equal function. I'm going to add it to current commitfest. There are some minor stylistic issues with this patch - e.g. lines ending in whitespace, cuddled elses - but

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-09-24 Thread Andrew Dunstan
On 09/24/2010 11:11 AM, Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: On 09/24/2010 10:15 AM, Magnus Hagander wrote: In that case, we should probably teach pg_ctl about this case, no? Since it clearly gives an incorrect message to the user now... pg_ctl decides that the server

Re: [HACKERS] Path question

2010-09-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: FIXME #1 and FIXME #2 were much harder to trigger. In fact, barring significant further lobotimization of the code, I couldn't. It's not that hard if you just tweak equivclass.c to make the order of equivalence-class lists different, viz diff --git

Re: [HACKERS] Review: Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-09-24 Thread Kevin Grittner
Kevin Grittner gri...@gmail.com wrote: This now compiles and passes regression tests. I still need to re-run all the other tests which Florian and I previously used to test the patch. I don't have any reason to expect that they will now fail, but one need to be thorough. Once that is

Re: [HACKERS] psql's \dn versus temp schemas

2010-09-24 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: In that case, in a fresh database you would *only* see public. I'm not sure that I like this though. Comments? I sure like it! I can't count how many time I would have wanted a cleaned out \dn output. Regards, -- dim -- Sent via pgsql-hackers mailing

Re: [HACKERS] snapshot generation broken

2010-09-24 Thread Stefan Kaltenbrunner
On 09/24/2010 09:54 PM, Andrew Dunstan wrote: On 09/24/2010 03:47 PM, Tom Lane wrote: Yeah. Maybe we don't need a cvsserver after all. Would it make more sense to help Stefan get git running on his BSD boxes? If Bruce and I could get it to work on our pet dinosaurs, I think it likely can be

Re: [HACKERS] trailing whitespace in psql table output

2010-09-24 Thread Roger Leigh
On Tue, Sep 21, 2010 at 09:28:07PM +0300, Peter Eisentraut wrote: Everyone using git diff in color mode will already or soon be aware that psql, for what I can only think is an implementation oversight, produces trailing whitespace in the table headers, like this: two | f1 $

[HACKERS] Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.

2010-09-24 Thread Gurjeet Singh
On Fri, Sep 24, 2010 at 6:09 PM, Alvaro Herrera alvhe...@commandprompt.comwrote: Excerpts from Tom Lane's message of vie sep 24 17:36:59 -0400 2010: Robert Haas robertmh...@gmail.com writes: On Sep 24, 2010, at 3:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: BTW ... I don't especially care

Re: [HACKERS] Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.

2010-09-24 Thread Andrew Dunstan
On 09/24/2010 06:53 PM, Gurjeet Singh wrote: If it resembles cvs2cl then why not name it git2cl? Or git_changelog. +1 for git_changelog cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 6:53 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: Since it doesn't do anything specific to Postgres' git, lets not have any pg in there. Assuming you discount the hard-coded list of our active branch heads, of course. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Path question

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 5:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: It's not that hard if you just tweak equivclass.c to make the order of equivalence-class lists different, viz [...] Since the order of equivalence-class member lists isn't supposed to be semantically significant, I claim that

Re: [HACKERS] [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.

2010-09-24 Thread Alvaro Herrera
Excerpts from Robert Haas's message of vie sep 24 22:20:54 -0400 2010: On Fri, Sep 24, 2010 at 6:53 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: Since it doesn't do anything specific to Postgres' git, lets not have any pg in there. Assuming you discount the hard-coded list of our

Re: [HACKERS] What happened to the is_type family of functions proposal?

2010-09-24 Thread Robert Haas
On Fri, Sep 24, 2010 at 3:41 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Sep 21, 2010 at 7:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: There are many rules that you could possibly make for type input functions.  But you cannot throw an error is not

Re: [HACKERS] BUG #5661: The character encoding in logfile is confusing.

2010-09-24 Thread Craig Ringer
On 09/22/2010 09:55 PM, Tom Lane wrote: Peter Eisentrautpete...@gmx.net writes: On ons, 2010-09-22 at 19:25 +0800, Craig Ringer wrote: I still wonder if, rather than making this configurable, the right choice is to force logging to UTF-8 (with BOM) across the board, I don't think this

Re: [HACKERS] What happened to the is_type family of functions proposal?

2010-09-24 Thread Darren Duncan
Colin 't Hart wrote: The fact that this wraps would seem to me to make the implementation of is_date() difficult. Having separate is_foo() syntax per type is a bad design idea, same as having a different equality test like eq_int() or assignment syntax like assign_str() per type. There