Re: [HACKERS] recovery.conf location

2010-09-27 Thread Fujii Masao
On Mon, Sep 27, 2010 at 9:35 AM, Jaime Casanova ja...@2ndquadrant.com wrote: Maybe i'm missing something but this would be a problem if we put a trigger file and the recovery.conf gets renamed to recovery.done, no? at least that would be a problem for the standbys that still need to be

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-09-27 Thread SAKAMOTO Masahiko
sorry for my slow response. (2010/09/24 21:13), Robert Haas wrote: This is a good point. On the one hand, I do agree that the API for simple things like processing CSV files shouldn't be overly complex. So perhaps we could start with a simple API and extend it later. On the other hand,

Re: [HACKERS] recovery.conf location

2010-09-27 Thread Fujii Masao
On Mon, Sep 27, 2010 at 10:55 AM, Robert Haas robertmh...@gmail.com wrote: Again, I think the real question is how to handle values that need to be maintained PER SLAVE from values of which there is only one copy. Yep. One idea is to support something like pg_ctl standby and pg_ctl pitr. If we

Re: [HACKERS] forming tuple as an attribute inside another tuple in c function

2010-09-27 Thread Marios Vodas
OK but what is the recommended way to get TupleDesc for p_type? I am aware of RelationNameGetTupleDesc but I shouldn't use it since it is deprecated. However by using it the code would look something like this (I tested it and it works as expected): Datum demo(PG_FUNCTION_ARGS) { float8 xi =

Re: [HACKERS] TODO: You can alter it, but you can't view it

2010-09-27 Thread Josh Berkus
Can you use pg_options_to_table() for your purpose? Yes, thanks. What version did that get added in? Even for 9.0, that function doesn't seem to appear in the docs. -- -- Josh Berkus PostgreSQL Experts Inc.

Re: [HACKERS] TODO: You can alter it, but you can't view it

2010-09-27 Thread Itagaki Takahiro
On Mon, Sep 27, 2010 at 4:39 PM, Josh Berkus j...@agliodbs.com wrote: Can you use pg_options_to_table() for your purpose? Yes, thanks.  What version did that get added in?  Even for 9.0, that function doesn't seem to appear in the docs. I found it in 8.4 and newer versions. It might be an

Re: [HACKERS] recovery.conf location

2010-09-27 Thread Josh Berkus
On 09/27/2010 10:08 AM, Robert Haas wrote: The thing about the parameters for synchronous replication that is a little different is that you need a whole set of parameters *for each standby*. There's not a terribly clean way to handle that in postgresql.conf as it exists today, but getting any

Re: [HACKERS] bg worker: general purpose requirements

2010-09-27 Thread Markus Wanner
Greg, On 09/25/2010 08:03 PM, Greg Stark wrote: The dynamic ramp-up is a feature to deal for the default install and for use case where the system has lots of different users with different needs. Thanks for sharing this. From that perspective, neither the current min/max nor the timeout

Re: [HACKERS] security label support, revised

2010-09-27 Thread KaiGai Kohei
(2010/09/27 11:49), Robert Haas wrote: On Sat, Sep 25, 2010 at 7:04 AM, KaiGai Koheikai...@kaigai.gr.jp wrote: * The dummy_esp module and regression test for SECURITY LABEL statement. This module allows only four labels: unclassified, classified, secret and top secret. The later two labels

Re: [HACKERS] recovery.conf location

2010-09-27 Thread Magnus Hagander
On Mon, Sep 27, 2010 at 08:52, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Sep 27, 2010 at 10:55 AM, Robert Haas robertmh...@gmail.com wrote: Again, I think the real question is how to handle values that need to be maintained PER SLAVE from values of which there is only one copy. Yep.

Re: [HACKERS] recovery.conf location

2010-09-27 Thread Magnus Hagander
On Mon, Sep 27, 2010 at 08:34, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Sep 27, 2010 at 9:35 AM, Jaime Casanova ja...@2ndquadrant.com wrote: Maybe i'm missing something but this would be a problem if we put a trigger file and the recovery.conf gets renamed to recovery.done, no? at

Re: [HACKERS] [COMMITTERS] pgsql: Still more tweaking of git_changelog.

2010-09-27 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Author: Tom Lane t...@sss.pgh.pa.us Branch: master Release: REL8_1 [872c1497f] 2005-05-24 18:02:31 + Branch: REL8_0_STABLE Release: REL8_0_4 [a94ace079] 2005-05-24 18:02:55 + Branch: REL7_4_STABLE Release: REL7_4_9 [0a7b3a364] 2005-05-24 18:03:24

Re: [HACKERS] do we want to gitignore regression-test-failure files?

2010-09-27 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I don't find it indecipherable. We're ignoring stuff that can be expected to be present after a normal build and successful make check or make installcheck. As soon as we ignore more than that, I'm going to insist on ignoring *~ ... do you want to open

[HACKERS] gist access methods parameter types

2010-09-27 Thread Marios Vodas
If I have this sql composite type: CREATE TYPE d_type AS ( i integer, e integer, id integer ); and this table: CREATE TABLE my_tab ( d_col d_type NOT NULL ) CREATE INDEX my_tab_d_col_gist ON my_tab USING gist (d_col); I am implementing consistent, union, compress, decompress,

Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-27 Thread Bernd Helmle
--On 26. September 2010 15:50:06 -0400 Tom Lane t...@sss.pgh.pa.us wrote: I think his question was - how do we feel about the massive catalog bloat this patch will create? It's a fair question. I can imagine designing things so that we don't create an explicit pg_constraint row for the

[HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Devrim GÜNDÜZ
Attached is a small patch that adds a few comments for the settings that require restart. Applicable for 9.0+. Regards, -- Devrim GÜNDÜZ PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer PostgreSQL RPM Repository: http://yum.pgrpms.org Community: devrim~PostgreSQL.org,

Re: [HACKERS] TODO: You can alter it, but you can't view it

2010-09-27 Thread Bernd Helmle
--On 27. September 2010 16:54:32 +0900 Itagaki Takahiro itagaki.takah...@gmail.com wrote: I found it in 8.4 and newer versions. It might be an internal API (for pg_dump?), but it'd be better to add documentation for it. Additionally we could extend pg_tables with an additional column?

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread Peter Eisentraut
On fre, 2010-09-24 at 22:38 +0100, Roger Leigh wrote: On Tue, Sep 21, 2010 at 09:28:07PM +0300, Peter Eisentraut wrote: Everyone using git diff in color mode will already or soon be aware that psql, for what I can only think is an implementation oversight, produces trailing whitespace in

[HACKERS] Using streaming replication as log archiving

2010-09-27 Thread Magnus Hagander
As has been previously mentioned a couple of times, it should be perfectly possible to use streaming replication to get around the limitations of archive_command/archive_timeout to do log archiving for PITR (being that you either keep archive_timeout high and risk data loss or you set it very low

Re: [HACKERS] psql's \dn versus temp schemas

2010-09-27 Thread Peter Eisentraut
On fre, 2010-09-24 at 14:42 -0400, Tom Lane wrote: How do we want to define system exactly? My original proposal was for bare \dn to hide the temp and toast schemas. If we consider that what it's hiding is system schemas then there's some merit to the idea that it should hide pg_catalog and

[HACKERS] Git migration deadline for Buildfarm

2010-09-27 Thread Andrew Dunstan
In about a week I propose to have the buildfarm server start to reject results based on snapshots where the newest file is older than the time of the git migration a week ago. That means buildfarm owners need to upgrade to using git. Many have already: see

Re: [HACKERS] [BUGS] BUG #5305: Postgres service stops when closing Windows session

2010-09-27 Thread Dave Page
On Thu, Sep 9, 2010 at 9:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: It's hard to say what the safest option is, I think.  There seem to be basically three proposals on the table: 1. Back-port the dead-man switch, and ignore exit 128. 2. Don't

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Sun, Sep 26, 2010 at 10:15 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: I have been away from Postgres development for quite a while, so would appreciate if someone could tell me if such a patch should be submitted for commitfest (since this is not actually a source patch). By all means

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Robert Haas
2010/9/27 Devrim GÜNDÜZ dev...@gunduz.org: Attached is a small patch that adds a few comments for the settings that require restart. Applicable for 9.0+. I'm not sure this is worth back-patching, but I've committed it to the master branch. -- Robert Haas EnterpriseDB:

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Guillaume Lelarge
Le 27/09/2010 15:18, Robert Haas a écrit : 2010/9/27 Devrim GÜNDÜZ dev...@gunduz.org: Attached is a small patch that adds a few comments for the settings that require restart. Applicable for 9.0+. I'm not sure this is worth back-patching, but I've committed it to the master branch. +1

Re: [HACKERS] gist access methods parameter types

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 4:26 AM, Marios Vodas mvo...@gmail.com wrote: The problem is that some of these methods take as input parameters the d_type and some the struct type that I internally implemented in c (which will be saved to the tree). If I understand correctly consistent and compress

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Robert Haas
2010/9/27 Guillaume Lelarge guilla...@lelarge.info: Le 27/09/2010 15:18, Robert Haas a écrit : 2010/9/27 Devrim GÜNDÜZ dev...@gunduz.org: Attached is a small patch that adds a few comments for the settings that require restart. Applicable for 9.0+. I'm not sure this is worth back-patching,

Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-27 Thread Tom Lane
Bernd Helmle maili...@oopsware.de writes: What i can try is to record the inheritance information only in case of attinhcount 0. This would make maintenance of the pg_constraint records for NOT NULL columns a little complicater though. Another thing we should consider is that Peter's

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Devrim GÜNDÜZ
On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: Actually, I don't see any reason why not to backpatch it. I was wondering if it would cause package management headaches for people who had already modified their postgresql.conf. We don't overwrite .conf files during upgrades. --

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Robert Haas
2010/9/27 Devrim GÜNDÜZ dev...@gunduz.org: On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: Actually, I don't see any reason why not to backpatch it. I was wondering if it would cause package management headaches for people who had already modified their postgresql.conf. We don't

Re: [HACKERS] gist access methods parameter types

2010-09-27 Thread Dimitri Fontaine
Marios Vodas mvo...@gmail.com writes: I am implementing consistent, union, compress, decompress, penalty, picksplit and same. […] The problem is that some of these methods take as input parameters the d_type and some the struct type that I internally implemented in c (which will be saved to

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Gurjeet Singh
On Mon, Sep 27, 2010 at 3:02 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Sep 26, 2010 at 10:15 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: I have been away from Postgres development for quite a while, so would appreciate if someone could tell me if such a patch should be

Re: [HACKERS] forming tuple as an attribute inside another tuple in c function

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 2:52 AM, Marios Vodas mvo...@gmail.com wrote: OK but what is the recommended way to get TupleDesc for p_type? It's mentioned in the documentation... http://www.postgresql.org/docs/current/static/xfunc-c.html#AEN47214 -- Robert Haas EnterpriseDB:

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:09 AM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Mon, Sep 27, 2010 at 3:02 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Sep 26, 2010 at 10:15 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: I have been away from Postgres development for quite a

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Andrew Dunstan
On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL: http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php or the ID: aanlktinw0hl+jqmrtwxc9y2tqhcfhfgfekxyyfygv...@mail.gmail.com The latter. Could this perhaps be

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Gurjeet Singh
On Mon, Sep 27, 2010 at 4:15 PM, Andrew Dunstan and...@dunslane.net wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL: http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php or the ID:

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-09-27 Thread Shigeru HANADA
Hi hackers, On Mon, 27 Sep 2010 15:50:34 +0900 SAKAMOTO Masahiko sakamoto.masah...@oss.ntt.co.jp wrote: Right. In any case, I should clearify what this API could cover by this patch and what could not. # And also how far I and my collaborator can implement.. As Itagaki points out, we have

Re: [HACKERS] Large objects.

2010-09-27 Thread Robert Haas
On Sun, Sep 26, 2010 at 12:21 PM, Dmitriy Igrishin dmit...@gmail.com wrote: Yes, I am sure. I've tested it by test case in my original post. Do you can compile and reproduce it please? I think the reason lo_read is returning 0 is because it's not reading anything. See attached test case,

Re: [HACKERS] gist access methods parameter types

2010-09-27 Thread Marios Vodas
Let me explain better what I want to do. I want to have the types in sql level (composite types) like this: --Spatio-Temporal Position in 3 Dimensions(cartessian x, cartessian y, time) CREATE TYPE pos3d AS ( x double precision, y double precision, t timestamp ); --Spatio-Temporal Delta

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstan and...@dunslane.net wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL: http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php or the ID:

[HACKERS] Heads up: upcoming back-branch releases

2010-09-27 Thread Tom Lane
After some back-and-forth among core and -packagers, we've agreed that we're overdue for update releases for the back branches. Accordingly, we'll be wrapping update tarballs of all active branches on Thursday for public announcement Monday Oct 4. We'll include a 9.0.1 update in this, so as to

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:18 AM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Mon, Sep 27, 2010 at 4:15 PM, Andrew Dunstan and...@dunslane.net wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL:

Re: [HACKERS] Large objects.

2010-09-27 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: According to the documentation, the maximum size of a large object is 2 GB, which may be the reason for this behavior. In principle, since pg_largeobject stores an integer pageno, we could support large objects of up to LOBLKSIZE * 2^31 bytes = 4TB

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Andrew's question seemed to be about the message-ID. I agree the topic thing is confusing, though. I'm wondering if it would be sufficient to do the following - if no topic are available, instead of showing the form, it says something like: No

Re: [HACKERS] gist access methods parameter types

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:37 AM, Marios Vodas mvo...@gmail.com wrote: Let me explain better what I want to do. I want to have the types in sql level (composite types) like this: --Spatio-Temporal Position in 3 Dimensions(cartessian x, cartessian y, time) Have you looked at PostGIS? As you

Re: [HACKERS] Large objects.

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: According to the documentation, the maximum size of a large object is 2 GB, which may be the reason for this behavior. In principle, since pg_largeobject stores an integer pageno, we

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Andrew's question seemed to be about the message-ID.  I agree the topic thing is confusing, though.  I'm wondering if it would be sufficient to do the following - if no topic are

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I liked the idea of pre-populating with the historical set of topics. +1 -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Well, the historical set of topics varies from CommitFest to CommitFest, by design. There are some that recur pretty regularly, of course, like Security, Performance, and Miscellaneous. But not every CF will have a section for ECPG or Refactoring,

Re: [HACKERS] gist access methods parameter types

2010-09-27 Thread Marios Vodas
Have you looked at PostGIS? Yes ofcourse, I also read everything in postgresql official documentation plus http://gist.cs.berkeley.edu/pggist/opcltour.html. Yeah, I still don't think that's the right way to do it. Storing the bounding box seems right, but just do that for all the nodes.

Re: [HACKERS] levenshtein_less_equal (was: multibyte charater set in levenshtein function)

2010-09-27 Thread Alexander Korotkov
I'll try to illustrate different approaches in examples. k i t t e n 0 1 2 3 4 5 6 s 1 1 2 3 4 5 6 i 2 2 1 2 3 4 5 t 3 3 2 1 2 3 4 t 4 4 3 2 1 2 3 i 5 5 4 3 2 2 3 n 6 6 5 4 3 3 2 g 7 7 6 5 4 4 3 The approach mentioned in

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Andrew Dunstan
On 09/27/2010 10:39 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstanand...@dunslane.net wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL:

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:08 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Well, the historical set of topics varies from CommitFest to CommitFest, by design.  There are some that recur pretty regularly, of course, like Security, Performance, and

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:15 AM, Andrew Dunstan and...@dunslane.net wrote: On 09/27/2010 10:39 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstan and...@dunslane.net wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for

Re: [HACKERS] Perf regression in 2.6.32 (Ubuntu 10.04 LTS)

2010-09-27 Thread Robert Haas
On Mon, Sep 13, 2010 at 12:05 PM, Greg Smith g...@2ndquadrant.com wrote: Domas Mituzas wrote: I've been playing around today a lot with sysbench, and observed that 2.6.32 kernel supplied by Ubuntu is having perf regression with PG (which does not affect MySQL), compared to 2.6.28 builds I

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Andrew Dunstan
On 09/27/2010 11:16 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 11:15 AM, Andrew Dunstanand...@dunslane.net wrote: On 09/27/2010 10:39 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstanand...@dunslane.net wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Alvaro Herrera
Excerpts from Gurjeet Singh's message of dom sep 26 22:15:59 -0400 2010: Currently I am seeing a performance improvement of this script by only about 500 ms; say 11.8 seconds vs. 11.3 secs. But I remember distinctly that yesterday I was able to see an improvement of 11% on the same virtual

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of lun sep 27 11:28:33 -0400 2010: Another way to handle this might be to extract it from an http URL if given one. +1 for this approach -- Álvaro Herrera alvhe...@commandprompt.com The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication,

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Alvaro Herrera
Excerpts from Robert Haas's message of lun sep 27 09:45:57 -0400 2010: (Dang this is a lot easier than the old way.) Did you use git cherry-pick? -- Álvaro Herrera alvhe...@commandprompt.com The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom

Re: [HACKERS] gist access methods parameter types

2010-09-27 Thread Marios Vodas
Please can you answer the question of whether entry-key in compress should be of delta3d sql type (composite type) and if not of what it should be since the type I index is different from the type stored in tree? Taking into consideration the types I described before this is my code for compress.

[HACKERS] client socket TIME_WAIT state after PQfinish

2010-09-27 Thread Guillaume Du Pasquier
Dear all, Environement: - OS : Ubuntu 10.04 LTS. - DB: postgresql 8.4. - Connection to postgresql using sslmode = disable Scenario : 1. I use pgadmin to connect/disconnect to the postgresql server on port 5432 or 2. I use a progam using libpq and make PQconnectdb and PQfinish.

Re: [HACKERS] A small update for postgresql.conf.sample

2010-09-27 Thread Robert Haas
2010/9/27 Alvaro Herrera alvhe...@commandprompt.com: Excerpts from Robert Haas's message of lun sep 27 09:45:57 -0400 2010: (Dang this is a lot easier than the old way.) Did you use git cherry-pick? Yes! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres

Re: [HACKERS] client socket TIME_WAIT state after PQfinish

2010-09-27 Thread Nicolas Barbier
2010/9/27 Guillaume Du Pasquier guillaume.dupasqu...@sensometrix.ch: In both cases, the client socket (pgadmin or my program) remains in TIME_WAIT state. I have used wireshark to sniff the TCP protocol. We have at the end of a connection: Client      Server    ---    FIN,ACK 

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread David E. Wheeler
On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote: Um, no. In the meantime, I have arrived at the conclusion that doing this isn't worth it because it will break all regression test output. We can fix the stuff in our tree, but pg_regress is also used externally, and those guys would

Re: [HACKERS] client socket TIME_WAIT state after PQfinish

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 12:22 PM, Nicolas Barbier nicolas.barb...@gmail.com wrote: According to the Two Generals' Problem [1], one of the sides necessarily doesn't know whether the other side has received its last packet. Therefore, TCP lets one of the sides sit in TIME_WAIT status for as long

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:28 AM, Andrew Dunstan and...@dunslane.net wrote: Could this perhaps be made clearer on the page, perhaps with an example? It confused me recently too. Can you suggest something more specific? Well, it could say something like: The Message-ID can be found in the

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:15 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Sep 27, 2010 at 11:08 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Well, the historical set of topics varies from CommitFest to CommitFest, by design.  There are some that

Re: [HACKERS] client socket TIME_WAIT state after PQfinish

2010-09-27 Thread Guillaume Du Pasquier
Dear Nicolas, Dear Robert, Thank you for your quick answers. We do not have such behavior using SSL, how do you explain it ? I suppose that openssl is using the setsockopt SO_LINGER that removes this behavior. Therefore, there is a RST sent to close the socket. We work with an environment that

[HACKERS] PlaceHolderVars versus join ordering

2010-09-27 Thread Tom Lane
I've been looking at the bug reported by Kirill Simonov here: http://archives.postgresql.org/pgsql-bugs/2010-09/msg00265.php This is pretty ugly :-(. What we have is select * from A left join (select some-expressions from B left join C ...) The expressions are not guaranteed

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Gurjeet Singh's message of dom sep 26 22:15:59 -0400 2010: Currently I am seeing a performance improvement of this script by only about 500 ms; say 11.8 seconds vs. 11.3 secs. But I remember distinctly that yesterday I was able to

Re: [HACKERS] PlaceHolderVars versus join ordering

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 1:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: I've been looking at the bug reported by Kirill Simonov here: http://archives.postgresql.org/pgsql-bugs/2010-09/msg00265.php This is pretty ugly :-(.  What we have is        select * from A        left join (select

Re: [HACKERS] client socket TIME_WAIT state after PQfinish

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 12:56 PM, Guillaume Du Pasquier guillaume.dupasqu...@sensometrix.ch wrote: Dear Nicolas, Dear Robert, Thank you for your quick answers. We do not have such behavior using SSL, how do you explain it ? I suppose that openssl is using the setsockopt SO_LINGER that

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread Alvaro Herrera
Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010: On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote: Um, no. In the meantime, I have arrived at the conclusion that doing this isn't worth it because it will break all regression test output. We can fix the

Re: [HACKERS] client socket TIME_WAIT state after PQfinish

2010-09-27 Thread Nicolas Barbier
2010/9/27 Robert Haas robertmh...@gmail.com: On Mon, Sep 27, 2010 at 12:56 PM, Guillaume Du Pasquier guillaume.dupasqu...@sensometrix.ch wrote: Our client runs on the same machine as the postgresql server. Would it be possible to use PF_UNIX sockets ? Yeah, actually that's the default, if

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010: On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote: Um, no. In the meantime, I have arrived at the conclusion that doing this

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread David Fetter
On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote: On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010: On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote: Um, no.

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Gurjeet Singh
On Mon, Sep 27, 2010 at 7:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Gurjeet Singh's message of dom sep 26 22:15:59 -0400 2010: Currently I am seeing a performance improvement of this script by only about 500 ms; say 11.8

Re: [HACKERS] Large objects.

2010-09-27 Thread Dmitriy Igrishin
Hey Robert, Tom Tom, thank you for explanation! Ouch. Letting people write data to where they can't get it back from seems double-plus ungood. Robert, yes, I agree with you. This is exactly what I wanted to say. I've implemented a stream class in C++ and this circumstance makes the code not

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 2:09 PM, David Fetter da...@fetter.org wrote: On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote: On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010: On

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread David Fetter
On Mon, Sep 27, 2010 at 03:11:07PM -0400, Robert Haas wrote: On Mon, Sep 27, 2010 at 2:09 PM, David Fetter da...@fetter.org wrote: On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote: On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Euler Taveira de Oliveira
Itagaki Takahiro escreveu: I had the same problems before, and I wrote some hacks for VC++. Isn't there such a code in core or am i missing something? Is it worth supporting the VC++ standalone projects? -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers

Re: [HACKERS] trailing whitespace in psql table output

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 4:12 PM, David Fetter da...@fetter.org wrote: On Mon, Sep 27, 2010 at 03:11:07PM -0400, Robert Haas wrote: On Mon, Sep 27, 2010 at 2:09 PM, David Fetter da...@fetter.org wrote: On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote: On Mon, Sep 27, 2010 at 1:34

Re: [HACKERS] Large objects.

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 2:25 PM, Dmitriy Igrishin dmit...@gmail.com wrote: Hey Robert, Tom Tom, thank you for explanation! Ouch.  Letting people write data to where they can't get it back from seems double-plus ungood. Robert, yes, I agree with you. This is exactly what I wanted to say.

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Itagaki Takahiro
On Tue, Sep 28, 2010 at 5:13 AM, Euler Taveira de Oliveira eu...@timbira.com wrote: Itagaki Takahiro escreveu: I had the same problems before, and I wrote some hacks for VC++. Isn't there such a code in core or am i missing something? Is it worth supporting the VC++ standalone projects?

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 8:45 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Tue, Sep 28, 2010 at 5:13 AM, Euler Taveira de Oliveira eu...@timbira.com wrote: Itagaki Takahiro escreveu: I had the same problems before, and I wrote some hacks for VC++. Isn't there such a code in core

Re: [HACKERS] security label support, revised

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 4:05 AM, KaiGai Kohei kai...@kaigai.gr.jp wrote: Thanks, this looks like mostly good stuff.  Here's a new version of the patch with some bug fixes, additional regression tests, and other cleanup.  I think this is about ready to commit. Thanks for your reviewing and

Re: [HACKERS] PlaceHolderVars versus join ordering

2010-09-27 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Sep 27, 2010 at 1:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: This is a larger change than I would prefer to back-patch, but the only less-invasive alternative I can see is to lobotomize the PlaceHolderVar mechanism entirely by reverting to

Re: I: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-09-27 Thread Itagaki Takahiro
On Tue, Aug 31, 2010 at 8:04 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: I think the patch is almost ready to commit, but still have some comments for the usability and documentations. I hope native English speakers would help improving docs. I'm checking the latest patch for

Re: [HACKERS] levenshtein_less_equal (was: multibyte charater set in levenshtein function)

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 8:42 AM, Alexander Korotkov aekorot...@gmail.com wrote: The second idea is to make values in matrix possible greater. I analyze what exactly is matrix in this case. It is sum of original matrix, which represent distances between prefixes of strings, and matrix, which

Re: [HACKERS] Hot Standby tuning for btree_xlog_vacuum()

2010-09-27 Thread Robert Haas
On Thu, Apr 29, 2010 at 4:12 PM, Simon Riggs si...@2ndquadrant.com wrote: Simple tuning of btree_xlog_vacuum() using an idea I had a while back, just never implemented. XXX comments removed. Allows us to avoid reading in blocks during VACUUM replay that are only required for correctness of

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Itagaki Takahiro
On Tue, Sep 28, 2010 at 9:51 AM, Robert Haas robertmh...@gmail.com wrote: Since we have PGDLLEXPORT in 9.0, we can mark some of exported functions with it in tutorial codes and maybe contrib modules. If that (a) works and (b) reduces user confusion, +1 from me.  We've gotten this question a

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:09 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Tue, Sep 28, 2010 at 9:51 AM, Robert Haas robertmh...@gmail.com wrote: Since we have PGDLLEXPORT in 9.0, we can mark some of exported functions with it in tutorial codes and maybe contrib modules. If that

Re: [HACKERS] proposal: tsearch dictionary initialization hook

2010-09-27 Thread Robert Haas
On Tue, Sep 7, 2010 at 12:55 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2010/9/7 Teodor Sigaev teo...@sigaev.ru: Hm, what is aim of this hook? It looks like a wrapper of dictionary init method. If I use a mmap for shared dictionary, then I have to prealloc and maybe preread dictionary

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Itagaki Takahiro
On Tue, Sep 28, 2010 at 12:12 PM, Robert Haas robertmh...@gmail.com wrote: If we do so, many PGDLLEXPORT will be added:  *  17 in src/tutorial  * 507 in contrib for each exported PGFunction, _PG_init, and _PG_fini. Oh - I didn't realize this meant marking lots of things in contrib that

Re: [HACKERS] patch: tsearch - some memory diet

2010-09-27 Thread Robert Haas
On Tue, Sep 7, 2010 at 1:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: In the particular case here, the dictionary structures could probably safely use such a context type, but I'm not sure it's worth bothering if the long-term plan is to implement a precompiler.  There would be no need for this

Re: [HACKERS] Help with User-defined function in PostgreSQL with Visual C++

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:26 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Tue, Sep 28, 2010 at 12:12 PM, Robert Haas robertmh...@gmail.com wrote: If we do so, many PGDLLEXPORT will be added:  *  17 in src/tutorial  * 507 in contrib for each exported PGFunction, _PG_init, and

Re: [HACKERS] Perf regression in 2.6.32 (Ubuntu 10.04 LTS)

2010-09-27 Thread Mark Kirkwood
On 28/09/10 04:28, Robert Haas wrote: On Mon, Sep 13, 2010 at 12:05 PM, Greg Smithg...@2ndquadrant.com wrote: Domas Mituzas wrote: I've been playing around today a lot with sysbench, and observed that 2.6.32 kernel supplied by Ubuntu is having perf regression with PG (which does not

Re: [HACKERS] security hook on table creation

2010-09-27 Thread Robert Haas
2010/9/1 KaiGai Kohei kai...@ak.jp.nec.com: This patch allows external security providers to check privileges to create a new relation and to inform the security labels to be assigned on the new one. Review: I took a brief look at this patch tonight and I think it's on the wrong track.

Re: [HACKERS] Perf regression in 2.6.32 (Ubuntu 10.04 LTS)

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:37 PM, Mark Kirkwood mark.kirkw...@catalyst.net.nz wrote: Greg, have you run into any other evidence suggesting a problem with 2.6.32? Not Greg (sorry), but this might be worth a look: http://www.spinics.net/lists/linux-ext4/msg20299.html Oh, interesting. But why

Re: [HACKERS] Perf regression in 2.6.32 (Ubuntu 10.04 LTS)

2010-09-27 Thread Mark Kirkwood
On 28/09/10 16:59, Robert Haas wrote: On Mon, Sep 27, 2010 at 11:37 PM, Mark Kirkwood mark.kirkw...@catalyst.net.nz wrote: Greg, have you run into any other evidence suggesting a problem with 2.6.32? Not Greg (sorry), but this might be worth a look:

  1   2   >