Re: [HACKERS] Issues with two-server Synch Rep

2010-10-14 Thread Dimitri Fontaine
Peter Eisentraut pete...@gmx.net writes: Seems like a reasonable solution, although I've never heard of .emacs.custom; my emacsen have always written their custom settings somewhere in the middle of the .emacs proper. See (info (emacs) Saving Customizations) and add the following to your

Re: [HACKERS] Extensions, this time with a patch

2010-10-14 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@commandprompt.com writes: Does this mean that the control file should contain a version number in the filename? Otherwise, I don't see how you'd have more than one version of the control file. Also, if upgrading is necessary, there will need to be one upgrade control

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: cat postgresql.conf.d/work_mem 16MB This database needs at least such a value. Note it's overridden in some ROLEs setup. With such a format (name is filename, value is first line content's, rest is comments), it's easy to preserve comments

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of mié oct 13 15:32:22 -0300 2010: We have a database specification in .pgpass: hostname:port:database:username:password What is the purpose of 'database' since username/password combinations are global, not per database? I would like to documents

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Alvaro Herrera
Excerpts from Itagaki Takahiro's message of mié oct 13 23:03:16 -0300 2010: On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: [ updated patch, in response to a review from Itagaki

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Radosław Smogura
On Wed, 13 Oct 2010 21:01:06 -0400, Robert Haas robertmh...@gmail.com wrote: Is this a JDBC patch or a PG patch? Are we tracking JDBC patches using the CF app? It is JDBC patch. I will clean it and submit on this site. I didn't know about such application and such process. -- Radosław

Re: [HACKERS] [GENERAL] Text search parser's treatment of URLs and emails

2010-10-14 Thread Christian Ullrich
* Bruce Momjian wrote: Thom Brown wrote: Also: SELECT alias, description, token FROM ts_debug('myname+prior...@gmail.com'); Yields: alias | description | token ---+-+ asciiword | Word, all ASCII | myname blank | Space

[HACKERS] Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread David Newall
On 14/10/10 12:14, Itagaki Takahiro wrote: Which solution is better? Or, another idea? This does seem to be an new bug in previously working code. While any solution that fixes the problem is good, it might pay to look the code that worked before. As reported, it worked for ecpg

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Robert Haas
On Tue, Oct 5, 2010 at 4:57 PM, Bernd Helmle maili...@oopsware.de wrote: --On 30. September 2010 10:12:48 +0200 Bernd Helmle maili...@oopsware.de wrote: Yeah, there where some changes in the meantime to the master which generate some merge failures...will provide a new version along with

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Pavel Stehule
Hello 2010/10/14 Itagaki Takahiro itagaki.takah...@gmail.com: Let's make format support %s, %i, and %l, as well as allowing things like %$3l (meaning, escape the third argument as a literal and interpolate here), and call it good. Your idea is:  % [ $ pos ] format  -- ex. %$3l , %l  

Re: [HACKERS] ECPG FETCH readahead

2010-10-14 Thread Robert Haas
On Thu, Jun 24, 2010 at 8:19 AM, Michael Meskes mes...@postgresql.org wrote: On Thu, Jun 24, 2010 at 12:04:30PM +0300, Heikki Linnakangas wrote: Is there a reason not to enable it by default? I'm a bit worried that it will receive no testing if it's not always on. Yes, there is a reason,

Re: [HACKERS] [COMMITTERS] pgsql: Still more tweaking of git_changelog.

2010-10-14 Thread Bruce Momjian
Tom Lane wrote: I maintain that if someone else whacked around one of your commits the way you whacked this around, you'd bite their head off. I apologize if I offended you. I hadn't believed that there was any particular consensus on how this script ought to behave; I thought it was

Re: [HACKERS] [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 3:52 PM, David Newall postgre...@davidnewall.com wrote: This does seem to be an new bug in previously working code.  While any solution that fixes the problem is good, it might pay to look the code that worked before.  As reported, it worked for ecpg (PostgreSQL 8.3.8)

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Andrew Dunstan
On 10/13/2010 02:32 PM, Bruce Momjian wrote: We have a database specification in .pgpass: hostname:port:database:username:password What is the purpose of 'database' since username/password combinations are global, not per database? I would like to documents its purpose. If you use

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Itagaki Takahiro
Let's make format support %s, %i, and %l, as well as allowing things like %$3l (meaning, escape the third argument as a literal and interpolate here), and call it good. Your idea is: % [ $ pos ] format -- ex. %$3l , %l Escapes: %% = % Just for information, $ and pos are reversed in C

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 10:03 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: [ updated patch, in response to a review from Itagaki

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Andrew Geery
I'll post it sometime tomorrow... Thanks Andrew On Wed, Oct 13, 2010 at 9:25 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Oct 5, 2010 at 4:57 PM, Bernd Helmle maili...@oopsware.de wrote: --On 30. September 2010 10:12:48 +0200 Bernd Helmle maili...@oopsware.de wrote: Yeah, there where

Re: [HACKERS] WIP: extensible enums

2010-10-14 Thread Dean Rasheed
On 13 October 2010 23:17, Robert Haas robertmh...@gmail.com wrote: On Wed, Oct 13, 2010 at 7:33 AM, Andrew Dunstan and...@dunslane.net wrote: Sorry, got distracted. Here's a new patch that fixes the above and also contains some documentation. Someone want to review this and (hopefully) mark

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Greg Stark
On Tue, Oct 12, 2010 at 11:50 PM, Robert Haas robertmh...@gmail.com wrote: There's another problem here we should think about, too.  Suppose you have a master and two standbys.  The master dies.  You promote one of the standbys, which turns out to be behind the other.  You then repoint the

Re: [HACKERS] WIP: extensible enums

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 7:33 AM, Andrew Dunstan and...@dunslane.net wrote: Sorry, got distracted. Here's a new patch that fixes the above and also contains some documentation. Someone want to review this and (hopefully) mark it Ready for Committer? I see that Brendan Jurd is the reviewer of

Re: [HACKERS] wip: functions median and percentile

2010-10-14 Thread Greg Stark
On Wed, Oct 13, 2010 at 5:54 PM, Robert Haas robertmh...@gmail.com wrote: Or to put it more bluntly - what is the problem with planner and hash agg that all of these functions need to solve?  And why does it need a flag in pg_proc?  Why can't't we leave it to the individual functions to

[HACKERS] Bug in writeTimeLineHistory

2010-10-14 Thread Fujii Masao
Hi, -- if (recoveryTarget == RECOVERY_TARGET_XID) snprintf(buffer, sizeof(buffer), %s%u\t%s\t%s transaction %u\n, (srcfd 0) ? : \n, parentTLI,

Re: [HACKERS] duplicate connection failure messages

2010-10-14 Thread Magnus Hagander
On Wed, Oct 13, 2010 at 21:21, Peter Eisentraut pete...@gmx.net wrote: This surprised me: psql -p 5 -h localhost psql: could not connect to server: Connection refused        Is the server running on host localhost and accepting        TCP/IP connections on port 5? could not connect

[HACKERS] signal and startup process

2010-10-14 Thread Fujii Masao
Hi, It takes nonsensically extra several seconds to shut down the standby server. This is because the startup process cannot respond immediately the SIGTERM signal sent by postmaster for the shutdown while it's sleeping on WaitLatch. This delays the shutdown for up to the sleep time on WaitLatch

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Dennis Björklund
We have a database specification in .pgpass: hostname:port:database:username:password What is the purpose of 'database' since username/password combinations are global, not per database? I would like to documents its purpose. There is the GUC parameter db_user_namespace. Just for

Re: [HACKERS] wip: functions median and percentile

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 6:56 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2010/10/13 Pavel Stehule pavel.steh...@gmail.com: 2010/10/13 Peter Eisentraut pete...@gmx.net: On mån, 2010-10-11 at 20:46 +0200, Pavel Stehule wrote: The problem is in interface. The original patch did it, but I

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread Tatsuo Ishii
Ok, it seems impossible to do that by using any public interfaces currently available in PostgreSQL 9.0. I will create a custom C function to be distributed along with pgpool-II. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese: http://www.sraoss.co.jp

[HACKERS] First patch proposal

2010-10-14 Thread Alastair Turner
Hi I am a keen Postgres user and I run my local PUG (JNBPUG in Gauteng, South Africa), but I have found the idea of contributing on a code level daunting. Having read the many warnings along the lines of It's still on the todo because it isn't trivial I have identified what I believe is a

Re: [HACKERS] ECPG FETCH readahead

2010-10-14 Thread Boszormenyi Zoltan
Hi, Robert Haas írta: On Thu, Jun 24, 2010 at 8:19 AM, Michael Meskes mes...@postgresql.org wrote: On Thu, Jun 24, 2010 at 12:04:30PM +0300, Heikki Linnakangas wrote: Is there a reason not to enable it by default? I'm a bit worried that it will receive no testing if it's not always

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Ok, now, some people want to still be able to edit the files by hand I wonder if providing a system function to load some configuration option from a file, using the current parser, would do it: SELECT pg_load_conf('path/to/filename.conf',

Re: [DOCS] [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Brendan Jurd
On 14 October 2010 08:45, Robert Haas robertmh...@gmail.com wrote: Is someone working on a patch? Yes, I will prepare a patch to get us started. Cheers, BJ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 2:27 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Rados*aw Smogurarsmog...@softperience.eu wrote: I updated patch to latets CVS version, I didn't have time to remove some trashes from it. If something will be wrong with patch, give a feedback. I skimmed it

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Pavel Stehule
2010/10/14 Robert Haas robertmh...@gmail.com: On Wed, Oct 13, 2010 at 10:03 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: [

Re: [HACKERS] wip: functions median and percentile

2010-10-14 Thread Pavel Stehule
2010/10/14 Robert Haas robertmh...@gmail.com: On Wed, Oct 13, 2010 at 6:56 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2010/10/13 Pavel Stehule pavel.steh...@gmail.com: 2010/10/13 Peter Eisentraut pete...@gmx.net: On mån, 2010-10-11 at 20:46 +0200, Pavel Stehule wrote: The problem is

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Robert Haas
On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: [ updated patch, in response to a review from Itagaki Takahiro ] This patch appears to be waiting for a second round of review. Itagaki-san, are you planning to do that? -- Robert Haas EnterpriseDB:

Re: [HACKERS] ask for review of MERGE

2010-10-14 Thread Robert Haas
On Wed, Sep 29, 2010 at 2:44 AM, Greg Smith g...@2ndquadrant.com wrote: Starting looking at the latest MERGE patch from Boxuan here tonight. The regression tests pass for me here, good starting sign. I expect to move onto trying to break it more creatively next, then onto performance tests.

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-10-14 Thread Robert Haas
On Tue, Oct 12, 2010 at 2:27 AM, Shigeru HANADA han...@metrosystems.co.jp wrote: Thanks for the review! I'll finish the SQL/MED patch by applying your comments. I think this patch has gotten as much review as we can reasonably give it this CommitFest (which is about to end), so I'm going to

[HACKERS] knngist plans

2010-10-14 Thread Marios Vodas
I would like to ask in which future version of postgresql knngist is planned to be included. Is there any possibility to be included in 9.1?

Re: [HACKERS] Per-column collation, work in progress

2010-10-14 Thread Robert Haas
On Fri, Sep 24, 2010 at 1:57 AM, Peter Eisentraut pete...@gmx.net wrote: On fre, 2010-09-24 at 09:32 +0900, Itagaki Takahiro wrote: On Wed, Sep 22, 2010 at 10:29 PM, Peter Eisentraut pete...@gmx.net wrote: We could support it also on MSVC.

Re: [DOCS] [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Robert Haas
On Tue, Oct 12, 2010 at 8:28 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Oct 9, 2010 at 10:04 AM, Brendan Jurd dire...@gmail.com wrote: Hi folks, I have just set up HS+SR for the first time, and for the most part, the docs were excellent.  The one exception for me was the discussion

[HACKERS] Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Michael Meskes
Am 14.10.2010 08:52, schrieb David Newall: On 14/10/10 12:14, Itagaki Takahiro wrote: Which solution is better? Or, another idea? This does seem to be an new bug in previously working code. While any solution that fixes the problem is good, it might pay to look the code that worked before. As

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 11:10 AM, Tatsuo Ishii is...@postgresql.org wrote: Ok, it seems impossible to do that by using any public interfaces currently available in PostgreSQL 9.0. I will create a custom C function to be distributed along with pgpool-II. Could you submit the function for 9.1?

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 5:22 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Oct 13, 2010 at 3:50 PM, Robert Haas robertmh...@gmail.com wrote: There's another problem here we should think about, too.  Suppose you have a master and two standbys.  The master dies.  You promote one of the

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: [ updated patch, in response to a review from Itagaki Takahiro ] This patch appears to be waiting for a second round of review.

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Fujii Masao
On Thu, Oct 14, 2010 at 11:18 AM, Greg Stark gsst...@mit.edu wrote: Why don't the usual protections kick in here? The new record read from the location the xlog reader is expecting to find it has to have a valid CRC and a correct back pointer to the previous record. Yep. In most cases, those

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Pavel Golub
Hello, Bruce. You wrote: BM We have a database specification in .pgpass: BM hostname:port:database:username:password BM What is the purpose of 'database' since username/password combinations BM are global, not per database? I would like to documents its purpose. BM -- BM Bruce

Re: [HACKERS] wip: functions median and percentile

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 10:37 PM, Greg Stark gsst...@mit.edu wrote: On Wed, Oct 13, 2010 at 5:54 PM, Robert Haas robertmh...@gmail.com wrote: Or to put it more bluntly - what is the problem with planner and hash agg that all of these functions need to solve?  And why does it need a flag in

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 10:18 PM, Greg Stark gsst...@mit.edu wrote: On Tue, Oct 12, 2010 at 11:50 PM, Robert Haas robertmh...@gmail.com wrote: There's another problem here we should think about, too.  Suppose you have a master and two standbys.  The master dies.  You promote one of the

Re: [HACKERS] [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 6:53 AM, Michael Meskes mes...@postgresql.org wrote: Am 14.10.2010 08:52, schrieb David Newall: On 14/10/10 12:14, Itagaki Takahiro wrote: Which solution is better? Or, another idea? This does seem to be an new bug in previously working code. While any solution that

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 2:59 AM, Radosław Smogura rsmog...@softperience.eu wrote: On Wed, 13 Oct 2010 21:01:06 -0400, Robert Haas robertmh...@gmail.com wrote: Is this a JDBC patch or a PG patch?  Are we tracking JDBC patches using the CF app? It is JDBC patch. I will clean it and submit on

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 2:25 AM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: Let's make format support %s, %i, and %l, as well as allowing things like %$3l (meaning, escape the third argument as a literal and interpolate here), and call it good. Your idea is:  % [ $ pos ] format  --

Re: [HACKERS] [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Itagaki Takahiro
On Mon, Oct 11, 2010 at 7:42 AM, David Newall postgre...@davidnewall.com wrote: Trivial program to demonstrate problem: main() {    ECPGdebug(1,stderr);    exec sql connect to postgres;    exec sql set autocommit to off;    exec sql start transaction;    exec sql savepoint s;    exec sql

Re: [HACKERS] string function - format function proposal

2010-10-14 Thread Andrew Dunstan
On 10/14/2010 08:25 AM, Robert Haas wrote: IMHO, I like {} syntax as like as C# because the format strings are extensible. { pos [ : format ] } -- ex {3:l}, {3} (, and {l} could be also supported) Escapes: {{ = {, }} = } My personal preference (and Pavel's, I guess) is to use the

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Kevin Grittner
Robert Haas wrote: Is this a JDBC patch or a PG patch? Are we tracking JDBC patches using the CF app? If this were the only patch for setQueryTimeout in front of us I probably wouldn't have suggested that, but this thread started with a patch proposal to implement the same JDBC feature

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Andrew Geery
Below is my review of the latest iteration of the Extend NOT NULL Representation to pg_constraint patch found here: http://archives.postgresql.org/message-id/e57a252dfd60c1fca9173...@amenophis Thanks Andrew

Re: [HACKERS] First patch proposal

2010-10-14 Thread Hitoshi Harada
2010/10/14 Alastair Turner b...@ctrlf5.co.za: I am proposing altering psql to raise certain errors and exit before prompting for a password. These errors would have to be on items which didn't leak any information, my current list is:  - Does the input file (-f) exist and is it readable  - Do

Re: [HACKERS] ask for review of MERGE

2010-10-14 Thread Greg Smith
Robert Haas wrote: Greg, are you still working on a review of this patch? Yes, just had more distractions while coming to speed up on this area than I'd hoped. I'll get a second round of looking at this done by the weekend. -- Greg Smith, 2ndQuadrant US g...@2ndquadrant.com Baltimore,

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Allow me to insist on this some more, because there's something important going on here. The other proposal (.auto) have a major failure mode that I don't think is acceptable. SET PERMANENT work_mem TO '8 MB'; select pg_reload_conf();

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Kenneth Marshall
On Thu, Oct 14, 2010 at 06:09:35AM +0200, Dennis Bj??rklund wrote: We have a database specification in .pgpass: hostname:port:database:username:password What is the purpose of 'database' since username/password combinations are global, not per database? I would like to documents

Re: [HACKERS] First patch proposal

2010-10-14 Thread Tom Lane
Alastair Turner b...@ctrlf5.co.za writes: I am proposing altering psql to raise certain errors and exit before prompting for a password. These errors would have to be on items which didn't leak any information, my current list is: - Does the input file (-f) exist and is it readable - Do

Re: [HACKERS] First patch proposal

2010-10-14 Thread Alastair Turner
On Thu, Oct 14, 2010 at 4:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alastair Turner b...@ctrlf5.co.za writes: I am proposing altering psql to raise certain errors and exit before prompting for a password. These errors would have to be on items which didn't leak any information, my current list

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: I wonder if providing a system function to load some configuration option from a file, using the current parser, would do it: SELECT pg_load_conf('path/to/filename.conf', permament = true); That seems like a pretty bizarre idea. The settings

[HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Hitoshi Harada
I found PostgreSQL accepts UNION DISTINCT but documents don't mention it. http://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-UNION select_statement UNION [ ALL ] select_statement UNION DISTINCT is nothing more than UNION itself, but gram.y definitely accept it and the SQL standard

[HACKERS] Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread David Newall
On Thu, Oct 14, 2010 at 6:53 AM, Michael Meskesmes...@postgresql.org wrote: You seem to be answering to an email that I didn't see and couldn't find in the archive either. Was it send in private or to the list? If it went to the list I might be lagging behind. On 14/10/10 22:51, Robert

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Um, other than show work_mem or select from pg_settings? The fact is that you cannot know the active value anyway without checking, because what you did with SET PERMANENT might be overridden in various session-local ways. The proposal for hand-edited

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: SELECT pg_load_conf('path/to/filename.conf', permament = true); That seems like a pretty bizarre idea. The settings wouldn't be persistent would they? Or are you proposing this as a substitute way of providing input for SET PERMANENT? If so what's the

Re: [HACKERS] First patch proposal

2010-10-14 Thread Alastair Turner
Excerpt from Hitoshi Harada umi.tan...@gmail.com - Thu, Oct 14, 2010 at 4:32 PM: Just for information, did you pick this topic from TODO list? If so, could you attach links to the entry or to some related former thread? And in general it is encouraged that you'd better send one feature per a

Re: [HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Tom Lane
Hitoshi Harada umi.tan...@gmail.com writes: UNION DISTINCT is nothing more than UNION itself, but gram.y definitely accept it and the SQL standard describes it as well. Should we add DISTINCT to docs? I think it'd be hard to describe without confusing people, because while DISTINCT is a noise

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: I understand that. I just think there are already too many sources for GUCs and would welcome that there's a single possible source file with a complete remote editing feature. [ shrug... ] So don't use the option of hand-editing

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: [ shrug... ] So don't use the option of hand-editing postgresql.conf. You're not being forced to do that, and on the other side of the coin, you shouldn't think that you get to force people who'd rather hand-edit to change their habits. Sure. I just lose

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread Tatsuo Ishii
On Thu, Oct 14, 2010 at 11:10 AM, Tatsuo Ishii is...@postgresql.org wrote: Ok, it seems impossible to do that by using any public interfaces currently available in PostgreSQL 9.0. I will create a custom C function to be distributed along with pgpool-II. Could you submit the function for

Re: [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Brendan Jurd
On 12 October 2010 23:28, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Oct 9, 2010 at 10:04 AM, Brendan Jurd dire...@gmail.com wrote: I have just set up HS+SR for the first time, and for the most part, the docs were excellent.  The one exception for me was the discussion of

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 8:55 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas  wrote: Is this a JDBC patch or a PG patch? Are we tracking JDBC patches using the CF app? If this were the only patch for setQueryTimeout in front of us I probably wouldn't have suggested that,

Re: [HACKERS] Path question

2010-10-14 Thread Tom Lane
I wrote: I rather wonder if we don't want two separate execution-time node types anyway, since what Append does seems significantly different from Merge (and MergeAppend would be just a misnomer). I've been working on this patch, and have gotten the executor side split out as a new node type.

Re: [HACKERS] Path question

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 11:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I rather wonder if we don't want two separate execution-time node types anyway, since what Append does seems significantly different from Merge (and MergeAppend would be just a misnomer). I've been working on this

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread David Fetter
On Thu, Oct 14, 2010 at 08:22:21AM -0400, Robert Haas wrote: On Thu, Oct 14, 2010 at 2:59 AM, Radosław Smogura rsmog...@softperience.eu wrote: On Wed, 13 Oct 2010 21:01:06 -0400, Robert Haas robertmh...@gmail.com wrote: Is this a JDBC patch or a PG patch?  Are we tracking JDBC patches

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 10:02 AM, Andrew Geery andrew.ge...@gmail.com wrote: I didn’t have much time to look at the code.  The only thing I’ll mention is that there are a couple of XXX TODO items that should be cleared up. [...] Since this patch actually makes inheritance behave in a more

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread David Fetter
What new public interfaces do you think are needed for 9.1 in this regard? Cheers, David. On Thu, Oct 14, 2010 at 11:10:14AM +0900, Tatsuo Ishii wrote: Ok, it seems impossible to do that by using any public interfaces currently available in PostgreSQL 9.0. I will create a custom C function to

Re: [HACKERS] Path question

2010-10-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Oct 14, 2010 at 11:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: Anybody have a strong feeling about what to call these things? At the moment I'm leaning to sticking with MergeAppend, but if we decide to rename it it'd probably be better to do so

Re: [HACKERS] Extensions, this time with a patch

2010-10-14 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of mié oct 13 18:11:21 -0300 2010: I like both ideas. I'd like to propose that we get back to this part of the feature later, after the first patch is in. After all, the main goal is to support dumprestore of extensions. Let's do that first. Okay. I

Re: [HACKERS] duplicate connection failure messages

2010-10-14 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of jue oct 14 02:30:36 -0300 2010: And I agree it's not very friendly in this specific case - I wonder if we should log it as localhost (127.0.0.1) and localhost (::1) (and similar for any other case that returns more than one address). +1 -- Álvaro

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread Bruce Momjian
David Boreham wrote: As far as I can see there is no pre-built pg_filedump binary for the PDGD yum repository (8.3.11 for RHEL5). Before I embark on building it from source I figured I'd ask here if I'm correct that there is no binary hidden somewhere in the packages. [ CC to hackers.]

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Dean Rasheed
On 14 October 2010 16:42, Robert Haas robertmh...@gmail.com wrote: In view of the fact that we are out of time for this CommitFest, ... When is the official end of this commitfest? I remember talk at the start, that the end would be postponed (by a week?) due to time spent on the git migration.

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Josh Berkus
Sure. I just lose comments. I'll live with that. Actually, as part of this scheme, it would be nice if pg_settings had a comment column, which would be optionally set with SET PERMANENT. Not required, but nice to have. If we had that, I suspect that a lot fewer people would want a

Re: [HACKERS] Per-column collation, work in progress

2010-10-14 Thread Peter Eisentraut
On ons, 2010-10-13 at 19:15 -0400, Robert Haas wrote: What's the status of this patch? I would appreciate some more review of the basic architecture. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] duplicate connection failure messages

2010-10-14 Thread Peter Eisentraut
On tor, 2010-10-14 at 07:30 +0200, Magnus Hagander wrote: And I agree it's not very friendly in this specific case - I wonder if we should log it as localhost (127.0.0.1) and localhost (::1) (and similar for any other case that returns more than one address). That looks good. -- Sent via

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Bernd Helmle
--On 14. Oktober 2010 11:42:27 -0400 Robert Haas robertmh...@gmail.com wrote: I did a sanity make clean make make check before applying the patch and all the tests passed.  After applying the patch and doing make clean make make check, I got a number of failures of the form “FAILED

Re: [HACKERS] A small update for postgresql.conf.sample

2010-10-14 Thread Bruce Momjian
Robert Haas wrote: 2010/9/27 Devrim G?ND?Z dev...@gunduz.org: On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: Actually, I don't see any reason why not to backpatch it. I was wondering if it would cause package management headaches for people who had already modified their

[HACKERS] commitfest timing

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:44 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: On 14 October 2010 16:42, Robert Haas robertmh...@gmail.com wrote: In view of the fact that we are out of time for this CommitFest, ... When is the official end of this commitfest? I remember talk at the start,

Re: [HACKERS] A small update for postgresql.conf.sample

2010-10-14 Thread Robert Haas
2010/10/14 Bruce Momjian br...@momjian.us: Robert Haas wrote: 2010/9/27 Devrim G?ND?Z dev...@gunduz.org: On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: Actually, I don't see any reason why not to backpatch it. I was wondering if it would cause package management headaches for

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:41 PM, Bruce Momjian br...@momjian.us wrote: David Boreham wrote: As far as I can see there is no pre-built pg_filedump binary for the PDGD yum repository (8.3.11 for RHEL5). Before I embark on building it from source I figured I'd ask here if I'm correct that there

Re: [HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 10:37 AM, Hitoshi Harada umi.tan...@gmail.com wrote: I found PostgreSQL accepts UNION DISTINCT but documents don't mention it. http://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-UNION select_statement UNION [ ALL ] select_statement UNION DISTINCT is

Re: [HACKERS] A small update for postgresql.conf.sample

2010-10-14 Thread Bruce Momjian
Robert Haas wrote: 2010/10/14 Bruce Momjian br...@momjian.us: Robert Haas wrote: 2010/9/27 Devrim G?ND?Z dev...@gunduz.org: On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: Actually, I don't see any reason why not to backpatch it. I was wondering if it would cause package

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:40 PM, Josh Berkus j...@agliodbs.com wrote: Sure. I just lose comments. I'll live with that. Actually, as part of this scheme, it would be nice if pg_settings had a comment column, which would be optionally set with SET PERMANENT.  Not required, but nice to have.

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Kevin Grittner
Robert Haas wrote: Kevin Grittner wrote: I thought we had decided on the client-side approach, but maybe I'm confused. I don't have a position one way or the other, just trying to understand the state of the conversation. Well, I've been pretty vocal on supporting a client-side solution,

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 9:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: The fact is that you cannot know the active value anyway without checking, because what you did with SET PERMANENT might be overridden in various session-local ways.  The proposal for hand-edited versus machine-edited files

[HACKERS] Foreign Visual Studio builds

2010-10-14 Thread Greg Smith
We got an interesting documentation document left by Christian Freund recently, in regards to http://www.postgresql.org/docs/9.0/interactive/install-windows-full.html ; it says: Regarding 16.1.3 - perl mkvcbuild.pl In case you use a German version of VC change line 69 in Solution.pm to:

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Bernd Helmle
--On 14. Oktober 2010 10:02:12 -0400 Andrew Geery andrew.ge...@gmail.com wrote: The first failure I get is in the inherit tests (tail of /src/test/regress/results/inherit.out): alter table a alter column aa type integer using bit_length(aa); server closed the connection unexpectedly

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Dean Rasheed
On 14 October 2010 17:40, Bernd Helmle maili...@oopsware.de wrote: --On 14. Oktober 2010 11:42:27 -0400 Robert Haas robertmh...@gmail.com wrote: I did a sanity make clean make make check before applying the patch and all the tests passed.  After applying the patch and doing make clean

Re: [HACKERS] Bug in writeTimeLineHistory

2010-10-14 Thread Simon Riggs
Agreed, committed and backpatched. On Thu, 2010-10-14 at 14:11 +0900, Fujii Masao wrote: Hi, -- if (recoveryTarget == RECOVERY_TARGET_XID) snprintf(buffer, sizeof(buffer), %s%u\t%s\t%s transaction %u\n,

  1   2   >