Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Markus Wanner
Dimitri, On 02/12/2011 11:18 PM, Dimitri Fontaine wrote: Magnus Hagander mag...@hagander.net writes: Are you volunteering? ;) Once upon a time, I started such an approach, see packages.bluegap.ch. However, I didn't upgrade these packages for quite some time, because I didn't need them anymore

Re: [HACKERS] Replication server timeout patch

2011-02-14 Thread Fujii Masao
On Sat, Feb 12, 2011 at 8:58 AM, Daniel Farina dan...@heroku.com wrote: Context diff equivalent attached. Thanks for the patch! As I said before, the timeout which this patch provides doesn't work well when the walsender gets blocked in sending WAL. At first, we would need to implement a

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011 01:27 AM, Tom Lane wrote: Magnus Hagandermag...@hagander.net  writes: Unfortunately, one of the worst-case scenarios appears to have happened - a machine did not come back up after a reboot. ...

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Dimitri Fontaine
Markus Wanner mar...@bluegap.ch writes: Once upon a time, I started such an approach, see packages.bluegap.ch. However, I didn't upgrade these packages for quite some time, because I didn't need them anymore for my day job. I received at least two mails thanking me for this service. (And

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Stefan Kaltenbrunner
On 02/14/2011 10:09 AM, Magnus Hagander wrote: On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011 01:27 AM, Tom Lane wrote: Magnus Hagandermag...@hagander.net writes: Unfortunately, one of the worst-case scenarios appears to have happened - a

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Markus Wanner
On 02/14/2011 10:23 AM, Dimitri Fontaine wrote: Hey, wanna join the fun? That'd be awesome :) Sure, I'll try to help. Don't be surprised if that's not too often, though. I currently cannot promise to provide packaging in any kind of timely fashion. :-( Well in fact if you install a

Re: [HACKERS] SSI bug?

2011-02-14 Thread Heikki Linnakangas
Looking at the prior/next version chaining, aside from the looping issue, isn't it broken by lock promotion too? There's a check in RemoveTargetIfNoLongerUsed() so that we don't release a lock target if its priorVersionOfRow is set, but what if the tuple lock is promoted to a page level lock

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Cédric Villemain
2011/2/14 Stefan Kaltenbrunner ste...@kaltenbrunner.cc: On 02/14/2011 10:09 AM, Magnus Hagander wrote: On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011 01:27 AM, Tom Lane wrote: Magnus Hagandermag...@hagander.net  writes: Unfortunately, one

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 11:46, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 2011/2/14 Stefan Kaltenbrunner ste...@kaltenbrunner.cc: On 02/14/2011 10:09 AM, Magnus Hagander wrote: On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Cédric Villemain
2011/2/14 Markus Wanner mar...@bluegap.ch: On 02/14/2011 10:23 AM, Dimitri Fontaine wrote: Hey, wanna join the fun?  That'd be awesome :) Sure, I'll try to help.  Don't be surprised if that's not too often, though.  I currently cannot promise to provide packaging in any kind of timely

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Cédric Villemain
2011/2/14 Magnus Hagander mag...@hagander.net: On Mon, Feb 14, 2011 at 11:46, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 2011/2/14 Stefan Kaltenbrunner ste...@kaltenbrunner.cc: On 02/14/2011 10:09 AM, Magnus Hagander wrote: On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner

Re: [HACKERS] Add support for logging the current role

2011-02-14 Thread Itagaki Takahiro
On Mon, Feb 14, 2011 at 11:51, Stephen Frost sfr...@snowman.net wrote: It would be awfully nice if we could inject something into the csvlog output format that would let client programs know which fields are present.  This would be especially useful for people writing tools that are intended

Re: [HACKERS] Extension versus module

2011-02-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Appendix F (contrib.sgml and its subsidiary files) is pretty consistent about using module to refer to a contrib, uh, module. I'm now thinking in those terms: the module is the shared object library that the backend needs to dlopen(). The extension is the

[HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-02-14 Thread Torello Querci
Hi, this is the first time that I post here, so if I wrong please don't kill me ... I see that pg_terminate_backend and pg_cancel_backend can be execute only by admin users. This approach seems to be too restrictive in a lots of real situation. In dept, I have a situation where it is created

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Markus Wanner
Cédric, thanks for taking a step back and bringing in the bigger picture. On 02/14/2011 11:57 AM, Cédric Villemain wrote: one way might be to suggest apt-preferences here, I believe. Agreed, might be the cleanest way from a technical POV. Is debian.postgresql.org to host and distribute the

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Markus Wanner
Hi, On 02/10/2011 11:34 PM, Joshua D. Drake wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 It seems we may have a problem to consider. As far as I know, we are the only major platform that supports libedit but our default is readline. Unfortunately readline is not compatible

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 13:37, Markus Wanner mar...@bluegap.ch wrote: Hi, On 02/10/2011 11:34 PM, Joshua D. Drake wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 It seems we may have a problem to consider. As far as I know, we are the only major platform that supports libedit

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Noah Misch
On Sun, Feb 13, 2011 at 02:53:07PM -0500, Robert Haas wrote: On Sun, Feb 13, 2011 at 6:50 AM, Noah Misch n...@leadboat.com wrote: Yikes. ?I didn't like that Assert much, but maybe we need it, because this is scary. Can you elaborate on the fear-inducing aspect? ?I don't mind re-adding

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Cédric Villemain
2011/2/14 Magnus Hagander mag...@hagander.net: On Mon, Feb 14, 2011 at 13:37, Markus Wanner mar...@bluegap.ch wrote: Hi, On 02/10/2011 11:34 PM, Joshua D. Drake wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 It seems we may have a problem to consider. As far as I know, we

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Devrim GÜNDÜZ
On Mon, 2011-02-14 at 13:52 +0100, Cédric Villemain wrote: Consider providing debian packages at debian.postgresql.org apt.postgresql.org, please. :) -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer Community:

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Cédric Villemain
2011/2/14 Devrim GÜNDÜZ dev...@gunduz.org: On Mon, 2011-02-14 at 13:52 +0100, Cédric Villemain wrote: Consider providing debian packages at debian.postgresql.org apt.postgresql.org, please. :) sure !!! -- Cédric Villemain               2ndQuadrant http://2ndQuadrant.fr/     PostgreSQL :

Re: [HACKERS] SQL/MED - file_fdw

2011-02-14 Thread Noah Misch
On Sun, Feb 13, 2011 at 12:41:11PM -0600, Kevin Grittner wrote: Unpatched: real17m24.171s real16m52.892s real16m40.624s real16m41.700s Patched: real15m56.249s real15m47.001s real15m3.018s real17m16.157s Since you said that a cursory test, or no test

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Martin Pitt
Hello all, thanks Markus for CC'ing me, I'm not on -hackers@. Markus Wanner [2011-02-14 13:37 +0100]: On 02/10/2011 11:34 PM, Joshua D. Drake wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 Note that the recent discussions happened on bug 608442, in particular

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Markus Wanner
Martin, On 02/14/2011 02:08 PM, Martin Pitt wrote: thanks Markus for CC'ing me, I'm not on -hackers@. Sure. Note that the recent discussions happened on bug 608442, in particular http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=608442#30 Thanks for this pointer. Markus Wanner

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Marko Kreen
On Mon, Feb 14, 2011 at 3:08 PM, Martin Pitt mp...@debian.org wrote: thanks Markus for CC'ing me, I'm not on -hackers@. Markus Wanner [2011-02-14 13:37 +0100]: On 02/10/2011 11:34 PM, Joshua D. Drake wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 Note that the recent

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Greg Smith
Markus Wanner wrote: Anybody realized that this Debian bug (and several others) got closed in the mean time (Sunday)? According to the changelog [1], Martin Pitt (which I'm CC'ing here, as he might not be aware of this thread, yet) worked around this issue by pre-loading readline via LD_PRELOAD

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Marko Kreen
On Fri, Feb 11, 2011 at 1:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: Andrew Dunstan and...@dunslane.net writes: I'll be happy if you do, but why haven't I haven't noticed, say, RedHat taking this line? Less narrow-minded interpretation of GPL requirements, perhaps. (And yes, we have real

Re: [HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-02-14 Thread Anssi Kääriäinen
On 02/14/2011 02:10 PM, Torello Querci wrote: I suppose that give the right to the owner db user to terminate or cancel other session connected to the database which it is owner is a good thing. I not see any security problem because this user can cancel or terminate only the session related

[HACKERS] why two dashes in extension load files

2011-02-14 Thread Peter Eisentraut
Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SQL/MED - file_fdw

2011-02-14 Thread Itagaki Takahiro
On Mon, Feb 14, 2011 at 22:06, Noah Misch n...@leadboat.com wrote: On Sun, Feb 13, 2011 at 12:41:11PM -0600, Kevin Grittner wrote: Unpatched: real    17m24.171s real    16m52.892s real    16m40.624s real    16m41.700s Patched: real    15m56.249s real    15m47.001s real    15m3.018s

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Andrew Dunstan
On 02/14/2011 08:27 AM, Greg Smith wrote: Markus Wanner wrote: Anybody realized that this Debian bug (and several others) got closed in the mean time (Sunday)? According to the changelog [1], Martin Pitt (which I'm CC'ing here, as he might not be aware of this thread, yet) worked around this

Re: [HACKERS] Add support for logging the current role

2011-02-14 Thread Stephen Frost
Itagaki, * Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: We need to design csvlog_header more carefully. csvlog_header won't work if log_filename is low-resolution, ex. log-per-day. This isn't any different a problem to the issue of someone changing the csvlog_fields GUC but not

[HACKERS] using a lot of maintenance_work_mem

2011-02-14 Thread Frederik Ramm
Hi, I am (ab)using a PostgreSQL database (with PostGIS extension) in a large data processing job - each day, I load several GB of data, run a lot of analyses on it, and then throw everything away again. Loading, running, and dumping the results takes about 18 hours every day. The job

Re: [HACKERS] using a lot of maintenance_work_mem

2011-02-14 Thread Tom Lane
Frederik Ramm frede...@remote.org writes: Now I assume that there are reasons that you're doing this. memutils.h has the (for me) cryptic comment about MaxAllocSize: XXX This is deliberately chosen to correspond to the limiting size of varlena objects under TOAST. See VARATT_MASK_SIZE in

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? Because we'd have to forbid dashes in extension name and version strings. This was judged to be a less annoying solution. See yesterday's discussion.

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 10:39, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011 10:09 AM, Magnus Hagander wrote: On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011 01:27 AM, Tom Lane wrote: Magnus Hagandermag...@hagander.net  

Re: [HACKERS] Extension versus module

2011-02-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Appendix F (contrib.sgml and its subsidiary files) is pretty consistent about using module to refer to a contrib, uh, module. I'm now thinking in those terms: the module is the shared object library that the

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Kohei Kaigai
Sorry for the late responding, because of my relocation. It would be good to have some buildfarm coverage of this code. Can we find anyone brave enough to set up a buildfarm critter using --with-selinux? Although I don't have an account on the buildfarm, I'll set up an environment for daily

Re: [HACKERS] mingw64

2011-02-14 Thread Peter Rosin
Den 2011-02-12 11:10 skrev Ralf Wildenhues: Hello, and sorry for the delay, * Peter Rosin wrote on Sat, Jan 29, 2011 at 02:26:24PM CET: Or is plain 'ar' used somewhere instead of 'x86_64-w64-mingw32-ar'? Automake outputs 'AR = ar' in Makefile.in for rules creating old libraries iff

Re: [HACKERS] Range Types: empty ranges

2011-02-14 Thread Jan Wieck
On 2/11/2011 1:50 PM, Kevin Grittner wrote: Josh Berkusj...@agliodbs.com wrote: if I, in one of my applications, accidentally defined something as having the range '('15:15:00','15:15:00')', I would *want* the database to through an error and not accept it. I can agree with that, but I

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Also, I've been looking at the pg_available_extensions issue a bit. I don't yet have a proposal for exactly how we ought to redefine it, but I did notice that the existing code is terribly confused by

Re: [HACKERS] Range Types: empty ranges

2011-02-14 Thread Kevin Grittner
Jan Wieck janwi...@yahoo.com wrote: Does ['15:15:00','15:15:00') make any more sense? Doesn't this essentially mean = '15:15:00' '15:15:00' which again doesn't include a single point on the time line? It defines a position in time with zero duration. Some of the graphics

Re: [HACKERS] Extension versus module

2011-02-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Hmm ... but what of contrib modules that don't build shared libraries at all --- pgbench and pg_upgrade for example? I think shared library is a perfectly fine term for that kind of object, and we don't need an alias for it anyway. In my view, if there's

[HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Robert Haas
Here's where I think we are with this CommitFest. We have committed 45 patches and returned with feedback or rejected 23. There are 30 remaining patches, every single one of which has been reviewed. 20 of those are marked Ready for Committer; 5 are marked Waiting on Author; 5 are marked Needs

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Stephen Frost
KaiGai, * Kohei Kaigai (kohei.kai...@eu.nec.com) wrote: It would be good to have some buildfarm coverage of this code. Can we find anyone brave enough to set up a buildfarm critter using --with-selinux? Although I don't have an account on the buildfarm, I'll set up an environment for

Re: [HACKERS] Extension versus module

2011-02-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Another concern has to do with PLs. We said that with the dependency mechanism it would be good to have PLs be EXTENSIONs. But those are core provided extensions, one of them installed by default. If we make PLs extensions, we might also want

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Thinking about this some more ... it seems like we now need two separate views, because there is some information that could change per-version, and some that really only makes sense at the per-extension level. Makes sense. For instance, we could have

Re: [HACKERS] using a lot of maintenance_work_mem

2011-02-14 Thread Kevin Grittner
Frederik Ramm frede...@remote.org wrote: I am (ab)using a PostgreSQL database (with PostGIS extension) in a large data processing job - each day, I load several GB of data, run a lot of analyses on it, and then throw everything away again. Loading, running, and dumping the results takes

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Peter Eisentraut
On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? Because we'd have to forbid dashes in extension name and version strings. This was judged to be a less

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Here's where I think we are with this CommitFest. Subject: Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04 I'm gonna go out on a limb and hope you meant '2011-02-14' there. :) So there are two basic difficulties with wrapping the CommitFest up.

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: and pg_available_extension_versions that produces a row per install script, with columns name version ((name, version) is primary key) comment requires relocatable schema where

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? Because we'd have to forbid dashes in extension name and version

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Marko Kreen
On Mon, Feb 14, 2011 at 6:49 PM, Peter Eisentraut pete...@gmx.net wrote: On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? Because we'd have to forbid dashes

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I intentionally left out columns that seem like extension implementation details rather than things users of the extension need to know. Hence, no directory, encoding, or module_pathname. There's no fundamental reason not to include these, I guess,

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 8:54 AM, Tom Lane wrote: I'm not convinced. There was nothing in that discussion why any particular character would have to be allowed in a version number. Well, there's already a counterexample in the current contrib stuff: uuid-ossp. We could rename that to uuid_ossp

Re: [HACKERS] pg_ctl failover Re: Latches, signals, and waiting

2011-02-14 Thread Stephen Frost
Fujii, * Fujii Masao (masao.fu...@gmail.com) wrote: Yeah, I rebased the patch to the current git master and attached it. Reviewing this, I just had a couple of comments and questions. Overall, I think it looks good and hence will be marking it 'Ready for Committer'. * You removed

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Feb 14, 2011, at 8:54 AM, Tom Lane wrote: I'm not convinced. There was nothing in that discussion why any particular character would have to be allowed in a version number. Well, there's already a counterexample in the current contrib stuff:

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 9:14 AM, Tom Lane wrote: Commas do not seem like an improvement to me at all --- they are widely used as list separators. Fair enough. I guess the real question is what's Peter's concrete objection to the double-dash method? Hey, I know, a double-dash between the

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: [ about omitting rows for which there is no update path ] Yeah, possibly. I'm a bit concerned about cases where the author meant to provide an update path and forgot: it would be fairly obvious in this

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Florian Weimer
* Stephen Frost: * Greg Smith (g...@2ndquadrant.com) wrote: -GNU libreadine is certainly never going to add an OpenSSL exemption I really wish they would, that's just them being obnoxious- it's already LGPL, after all.. Source? I've only seen GPLed copies. We wouldn't face this issue with

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Stephen Frost
* Florian Weimer (fwei...@bfk.de) wrote: Source? I've only seen GPLed copies. We wouldn't face this issue with LGPL code. Yeah, Greg corrected me on this already. So we have both FSF folks *and* OpenSSL people being foolish. Sigh. Stephen signature.asc Description: Digital

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I don't really think that's a behavior we want to encourage. ISTM the cases that are going to be trouble are paths you failed to think about, and therefore what you want to do is look over the whole output set to see if there are any surprising paths...

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Kohei Kaigai
We really need to get a buildfarm which is building with this. To that end, would you mind providing directions so someone else could set up a buildfarm member to test it..? It seems to me not difficult to describe a direction to build, install and run regression test. Do we have any Fedora

Re: [HACKERS] SSI bug?

2011-02-14 Thread Kevin Grittner
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Looking at the prior/next version chaining, aside from the looping issue, isn't it broken by lock promotion too? There's a check in RemoveTargetIfNoLongerUsed() so that we don't release a lock target if its priorVersionOfRow is

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Stephen Frost
Noah, I'm even less familiar w/ this code than Robert, but figured I'd give a shot at reviewing this anyway. I definitely like avoiding table rewrites if I can get away with it. :) First question is- why do you use #ifdef USE_ASSERT_CHECKING ..? assert_enabled exists and will work the way you

Re: [HACKERS] pika failing since the per-column collation patch

2011-02-14 Thread Rémi Zara
Le 12 févr. 2011 à 18:51, Peter Eisentraut a écrit : On lör, 2011-02-12 at 13:34 +0100, Rémi Zara wrote: Since the per-column collation patch went in, pika (NetBSD 5.1/mips) started failing consistently with this diff: ***

Re: [HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-02-14 Thread Kevin Grittner
Torello Querci tque...@gmail.com wrote: I attach a path for this It's too late in the release cycle to consider this for version 9.1. Please add it to the open CommitFest for consideration for 9.2: https://commitfest.postgresql.org/action/commitfest_view/open -Kevin -- Sent via

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Alvaro Herrera
Excerpts from Kohei Kaigai's message of lun feb 14 13:47:58 -0300 2011: We really need to get a buildfarm which is building with this. To that end, would you mind providing directions so someone else could set up a buildfarm member to test it..? It seems to me not difficult to describe a

Re: [HACKERS] SSI bug?

2011-02-14 Thread Kevin Grittner
YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: Did you notice whether the loop involved multiple tuples within a single page? if i understand correctly, yes. the following is a snippet of my debug code (dump targets when triggerCheckTargetForConflictsIn loops 1000 times) and its

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Andrew Dunstan
On 02/14/2011 11:47 AM, Kohei Kaigai wrote: We really need to get a buildfarm which is building with this. To that end, would you mind providing directions so someone else could set up a buildfarm member to test it..? It seems to me not difficult to describe a direction to build, install and

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Noah Misch
Hi Stephen, Thanks for jumping in on this one. On Mon, Feb 14, 2011 at 01:12:21PM -0500, Stephen Frost wrote: First question is- why do you use #ifdef USE_ASSERT_CHECKING ..? The other six code sites checking assert_enabled directly do the same. assert_enabled exists and will work the way

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Cédric Villemain
2011/2/14 Tom Lane t...@sss.pgh.pa.us: David E. Wheeler da...@kineticode.com writes: On Feb 14, 2011, at 8:54 AM, Tom Lane wrote: I'm not convinced.  There was nothing in that discussion why any particular character would have to be allowed in a version number. Well, there's already a

[HACKERS] pageinspect's infomask and infomask2 as smallint

2011-02-14 Thread Alvaro Herrera
Thanks to Noah Misch's review of the keylock patch I noticed that pageinspect's heap_page_items(bytea) function returns infomask and infomask2 as smallint (signed). But the fields in the tuple header are 16 bits unsigned, so if the high (16th) bit is set, it returns negative values which seem

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: We have committed 45 patches and returned with feedback or rejected 23. There are 30 remaining patches, every single one of which has been reviewed. 20 of those are marked Ready for Committer; 5 are marked Waiting on Author; 5 are marked Needs

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Peter Eisentraut
On ons, 2011-02-09 at 10:02 +0100, Jan Urbański wrote: On 09/02/11 04:52, Hitoshi Harada wrote: 2010/12/31 Jan Urbański wulc...@wulczer.org: (continuing the flurry of patches) Here's a patch that stops PL/Python from removing the function's arguments from its globals dict after calling

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
=?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: why do we care if there is a dash in the middle of a text where there are no numbers ? Umm ... we are not requiring version names to be numbers. regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Cédric Villemain
2011/2/14 Tom Lane t...@sss.pgh.pa.us: =?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: why do we care if there is a dash in the middle of a text where there are no numbers ? Umm ... we are not requiring version names to be numbers. good point I was

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Chris Browne
t...@sss.pgh.pa.us (Tom Lane) writes: Peter Eisentraut pete...@gmx.net writes: On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? Because we'd have to forbid

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-14 Thread Alvaro Herrera
Excerpts from Noah Misch's message of vie feb 11 04:13:22 -0300 2011: I observe visibility breakage with this test case: [ ... ] The problem seems to be that funny t_cid (2249). Tracing through heap_update, the new code is not setting t_cid during this test case. So I can fix this

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: On Mon, Feb 14, 2011 at 01:12:21PM -0500, Stephen Frost wrote: First question is- why do you use #ifdef USE_ASSERT_CHECKING ..? The other six code sites checking assert_enabled directly do the same. Wow, I could have sworn that I looked at what others

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Jan Urbański
On 14/02/11 21:06, Peter Eisentraut wrote: On ons, 2011-02-09 at 10:02 +0100, Jan Urbański wrote: On 09/02/11 04:52, Hitoshi Harada wrote: 2010/12/31 Jan Urbański wulc...@wulczer.org: (continuing the flurry of patches) Here's a patch that stops PL/Python from removing the function's

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Jan Urbański
On 14/02/11 22:13, Jan Urbański wrote: On 14/02/11 21:06, Peter Eisentraut wrote: On ons, 2011-02-09 at 10:02 +0100, Jan Urbański wrote: On 09/02/11 04:52, Hitoshi Harada wrote: 2010/12/31 Jan Urbański wulc...@wulczer.org: (continuing the flurry of patches) Here's a patch that stops

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Thew makefile still has this bogosity: sepgsql-regtest.pp: sepgsql-regtest.te $(MAKE) -f $(DESTDIR)/usr/share/selinux/devel/Makefile $@ We need to fix that up before we even think of trying to get buildfarm coverage. The presence and

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 16:15, Magnus Hagander mag...@hagander.net wrote: On Mon, Feb 14, 2011 at 10:39, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/14/2011 10:09 AM, Magnus Hagander wrote: On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On

Re: [HACKERS] Replication server timeout patch

2011-02-14 Thread Daniel Farina
On Mon, Feb 14, 2011 at 12:48 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Feb 12, 2011 at 8:58 AM, Daniel Farina dan...@heroku.com wrote: Context diff equivalent attached. Thanks for the patch! As I said before, the timeout which this patch provides doesn't work well when the

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Andrew Dunstan
On 02/14/2011 04:21 PM, Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: Thew makefile still has this bogosity: sepgsql-regtest.pp: sepgsql-regtest.te $(MAKE) -f $(DESTDIR)/usr/share/selinux/devel/Makefile $@ We need to fix that up before we even think of trying to

[HACKERS] tsearch Parser Hacking

2011-02-14 Thread David E. Wheeler
Hackers, Is it possible to modify the default tsearch parser so that / doesn't get lexed as a file token? That is, instead of this: try=# select * from ts_debug('simple'::regconfig, 'w/d'); alias │description│ token │ dictionaries │ dictionary │ lexemes

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-14 Thread Marti Raudsepp
On Fri, Feb 11, 2011 at 09:13, Noah Misch n...@leadboat.com wrote: The patch had a trivial conflict in planner.c, plus plenty of offsets.  I've attached the rebased patch that I used for review.  For anyone following along, all the interesting hunks touch heapam.c; the rest is largely

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 11:49 AM, Stephen Frost sfr...@snowman.net wrote: I have to say that I've always been a bit suprised by the idea that the CommitFest is intended to be done and all patches *committed* at the end of the month.  It's been working really rather well, which is due in great

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-14 Thread Alvaro Herrera
Excerpts from Marti Raudsepp's message of lun feb 14 19:39:25 -0300 2011: On Fri, Feb 11, 2011 at 09:13, Noah Misch n...@leadboat.com wrote: The patch had a trivial conflict in planner.c, plus plenty of offsets.  I've attached the rebased patch that I used for review.  For anyone following

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Robert Haas
Sorry for the previous, content-free reply. On Mon, Feb 14, 2011 at 11:49 AM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: Here's where I think we are with this CommitFest.  Subject: Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04 I'm gonna go out

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: Is it possible to modify the default tsearch parser so that / doesn't get lexed as a file token? There is zero, none, nada, provision for modifying the behavior of the default parser, other than by changing its compiled-in state transition tables.

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 10:13 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? Because we'd have to forbid dashes in extension name and version strings.  This was judged

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Thom Brown
On 14 February 2011 23:57, Tom Lane t...@sss.pgh.pa.us wrote: David E. Wheeler da...@kineticode.com writes: Is it possible to modify the default tsearch parser so that / doesn't get lexed as a file token? There is zero, none, nada, provision for modifying the behavior of the default parser,

[HACKERS] Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

2011-02-14 Thread Simon Riggs
On Wed, 2011-02-09 at 15:22 +0900, Fujii Masao wrote: On the second thought, I think it's useful to emit the NOTICE message when recovery reaches the pause point, as follows. NOTICE: Recovery will not complete until pg_xlog_replay_resume() is called. I'm OK with adding a message, but

Re: [HACKERS] .gitignore patch for coverage builds

2011-02-14 Thread Jeff Janes
On Wed, Jan 26, 2011 at 2:41 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Tom Lane's message of mié ene 26 19:20:52 -0300 2011: Robert Haas robertmh...@gmail.com writes: On Wed, Jan 26, 2011 at 4:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: Ick. That's an awful lot of

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Are we deparsing the names of the SQL files to infer the set of version numbers we have to worry about? It seems to me that if there's a list of known version numbers somewhere, we can use dash as the separator without any special restricton. The

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: But the trickiest part of this whole process is that, on the one hand, it's not fair for committers to ignore other people's patches, but on the other hand, it's not fair to expect committers to sacrifice getting their own projects done to get

Re: [HACKERS] Replication server timeout patch

2011-02-14 Thread Simon Riggs
On Mon, 2011-02-14 at 14:13 -0800, Daniel Farina wrote: On Mon, Feb 14, 2011 at 12:48 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Feb 12, 2011 at 8:58 AM, Daniel Farina dan...@heroku.com wrote: Context diff equivalent attached. Thanks for the patch! As I said before, the

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Yeah. The next thing I hit was this: [andrew@aurelia sepgsql]$ make -f /usr/share/selinux/devel/Makefile sepgsql-regtest.pp cat: /selinux/mls: No such file or directory make: *** No rule to make target `sepgsql-regtest.pp'. Stop.

  1   2   >