Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

2011-03-08 Thread Heikki Linnakangas
On 08.03.2011 04:07, Greg Stark wrote: Well from that log you definitely have OldestXmin going backwards. And not by a little bit either. at 6:33 it set the all_visible flag and then at 7:01 it was almost 1.3 million transactions earlier. In fact to precisely the same value that was in use for a

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Martijn van Oosterhout
On Mon, Mar 07, 2011 at 07:15:28PM -0500, Tom Lane wrote: Only if the expression-to-be-sorted does not already fully specify the collation, which so far as I can tell (either from the code or your description above) it does. I think that the explicit representation of collation as part of the

Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

2011-03-08 Thread Heikki Linnakangas
On 08.03.2011 10:00, Heikki Linnakangas wrote: Another idea is to give up on the warning when it appears that oldestxmin has moved backwards, and assume that it's actually fine. We could still warn in other cases where the flag appears to be incorrectly set, like if there is a deleted tuple on

Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

2011-03-08 Thread daveg
On Tue, Mar 08, 2011 at 10:00:01AM +0200, Heikki Linnakangas wrote: On 08.03.2011 04:07, Greg Stark wrote: Well from that log you definitely have OldestXmin going backwards. And not by a little bit either. at 6:33 it set the all_visible flag and then at 7:01 it was almost 1.3 million

Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

2011-03-08 Thread daveg
On Tue, Mar 08, 2011 at 10:37:24AM +0200, Heikki Linnakangas wrote: On 08.03.2011 10:00, Heikki Linnakangas wrote: Another idea is to give up on the warning when it appears that oldestxmin has moved backwards, and assume that it's actually fine. We could still warn in other cases where the

Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

2011-03-08 Thread Heikki Linnakangas
On 08.03.2011 10:38, daveg wrote: I read this to mean that it is safe to ignore this warning and that these databases are not at risk for data corruption or wrong results so long as the warning is due to oldestxmin. Please correct me if I have misunderstood. Yes, that's correct. -- Heikki

[HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Adrian von Bidder
Heyho! I'm poking around a bit in PostgreSQL's source for curiosity's sake. Is there a short howto on how to start / debug postgres from within the unpacked/compiled tar? Are there scripts that set up linker paths and Postgres' environment? thanks in advance -- vbi -- This statement is

Re: [HACKERS] pl/python tracebacks

2011-03-08 Thread Jan Urbański
On 07/03/11 22:55, Peter Eisentraut wrote: On mån, 2011-03-07 at 14:19 +0100, Jan Urbański wrote: On 07/03/11 14:01, Jan Urbański wrote: On 07/03/11 13:53, Peter Eisentraut wrote: On sön, 2011-03-06 at 13:14 +0100, Jan Urbański wrote: But fixing raise plpy.Fatal() to actually cause a FATAL

Re: [HACKERS] Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

2011-03-08 Thread Fujii Masao
On Tue, Mar 8, 2011 at 12:04 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Feb 9, 2011 at 5:12 PM, Magnus Hagander mag...@hagander.net wrote: I was also worried about the non-hot-standby case, but I see that the patch makes sure you can't enable pause when not in hot standby mode. Which

Re: [HACKERS] Sync Rep v19

2011-03-08 Thread Fujii Masao
On Mon, Mar 7, 2011 at 4:54 AM, Robert Haas robertmh...@gmail.com wrote: On Mar 6, 2011, at 9:44 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Mar 6, 2011 at 5:02 PM, Yeb Havinga yebhavi...@gmail.com wrote: On Sun, Mar 6, 2011 at 8:58 AM, Fujii Masao masao.fu...@gmail.com wrote: If

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Robert Haas
On Mon, Mar 7, 2011 at 10:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I think what is happening here is that make launches concurrent sub-jobs to do make install in each of interfaces/libpq and interfaces/ecpg, and the latter launches a sub-sub-job to do make all in interfaces/libpq,

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Andrew Dunstan
On 03/07/2011 10:28 PM, Tom Lane wrote: I wrote: I think what is happening here is that make launches concurrent sub-jobs to do make install in each of interfaces/libpq and interfaces/ecpg, and the latter launches a sub-sub-job to do make all in interfaces/libpq, and make has no idea that

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mar mar 08 10:38:29 -0300 2011: On Mon, Mar 7, 2011 at 10:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I think what is happening here is that make launches concurrent sub-jobs to do make install in each of interfaces/libpq and interfaces/ecpg,

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Robert Haas
On Tue, Mar 8, 2011 at 9:07 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: The bit I looked at, at the time, was src/backend/mb/conversion_procs, because that was where the biggest hit on parallelization was taken (a single lib at a time -- the real time CPU usage chart clearly showed the

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Kevin Grittner
Adrian von Bidder avbid...@fortytwo.ch wrote: Is there a short howto on how to start / debug postgres from within the unpacked/compiled tar? Are there scripts that set up linker paths and Postgres' environment? You should probably start by reading the developer FAQ page:

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Susanne Ebrecht
On 07.03.2011 17:43, Tom Lane wrote: because two expressions that are equal() must necessarily have the same collation property. Peter, Tom, I am not able to see this. If 'abc' == 'abc' is not collation depending at all. It is only encoding depending. Collation is only needed for upper(),

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Where it doesn't work is in the other subdirs, c.f. the current problem with interfaces/libpq and interfaces/ecpg. It would be a lot more difficult to fix there, I think, but maybe I'm wrong. Right, it's specifically the interdependence

Re: [HACKERS] [DOCS] Sync rep doc corrections

2011-03-08 Thread Thom Brown
On 8 March 2011 01:08, David Fetter da...@fetter.org wrote: On Mon, Mar 07, 2011 at 02:31:18PM -0500, Robert Haas wrote: On Mon, Mar 7, 2011 at 2:07 PM, David Fetter da...@fetter.org wrote: Re: docs, I'd actually like to see that list gone, as the separation of docs from code is one that's

[HACKERS] How should the waiting backends behave in sync rep?

2011-03-08 Thread Fujii Masao
Hi, How should the backends waiting for replication behave when synchrnous_standby_names is set to '' and the configuration file is reloaded? Now they keep waiting for the ACK from the standby. But I think that it's more natural for them to get out of the wait state and complete the transaction

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Tom Lane
Susanne Ebrecht susa...@2ndquadrant.com writes: On 07.03.2011 17:43, Tom Lane wrote: because two expressions that are equal() must necessarily have the same collation property. Peter, Tom, I am not able to see this. If 'abc' == 'abc' is not collation depending at all. It is only

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Adrian von Bidder
Hi, On Tuesday 08 March 2011 15.39:56 Kevin Grittner wrote: http://wiki.postgresql.org/wiki/Developer_FAQ thanks If you still have questions, be sure to mention your OS. Sorry, forgot. Linux. The Basic system testing item is where I'm kinda stuck. You advise to perform run time testing

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Tom Lane
Martijn van Oosterhout klep...@svana.org writes: This phase of processing happens in the parse analysis, the end result being that every expression should have a collation set, and every operator where it matters has consistant collation information for its arguments. So at this point the

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Merlin Moncure
On Tue, Mar 8, 2011 at 9:17 AM, Adrian von Bidder avbid...@fortytwo.ch wrote: Hi, On Tuesday 08 March 2011 15.39:56 Kevin Grittner wrote: http://wiki.postgresql.org/wiki/Developer_FAQ thanks If you still have questions, be sure to mention your OS. Sorry, forgot.  Linux. The Basic

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Kevin Grittner
Adrian von Bidder avbid...@fortytwo.ch wrote: Or do you advise to just make install and test from there? Pretty much. For development you will want to specify a few options in the ./configure step. At a minimum I recommend: --prefix= --enable-debug --enable-cassert --enable-depend See

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Jehan-Guillaume (ioguix) de Rorthais
On 08/03/2011 07:44, Selena Deckelmann wrote: Hi! PostgreSQL is applying for GSoC again this year. We're looking for: * Mentors Ready to mentor again this year for phpPgAdmin * Project ideas Would you like to mentor? Please let me know! Our application closes on Friday, so please contact

[HACKERS] #PgEast Schedule is up

2011-03-08 Thread Joshua D. Drake
Hey, The schedule for #PgEast is up. It can be found here: https://www.postgresqlconference.org/files/east_2011_schedule.html As usually we have a increasingly wide selection of content. Sincerely, JD -- PostgreSQL.org Major Contributor Command Prompt, Inc: http://www.commandprompt.com/ -

Re: [HACKERS] Sync Rep v19

2011-03-08 Thread Robert Haas
On Tue, Mar 8, 2011 at 7:05 AM, Fujii Masao masao.fu...@gmail.com wrote: Yeah, let's think about how shutdown should work. I'd like to propose the following. Thought? * Smart shutdown Smart shutdown should wait for all the waiting backends to be acked, and should not cause them to forcibly

Re: [HACKERS] wrap alpha4 tomorrow ~9am Eastern (was: Alpha4 release blockers)

2011-03-08 Thread Robert Haas
On Mon, Mar 7, 2011 at 5:03 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Mar 7, 2011 at 4:59 PM, Peter Eisentraut pete...@gmx.net wrote: On mån, 2011-03-07 at 15:19 -0500, Robert Haas wrote: Sorry, you're right.  Still, as happy as I am that we've made so much progress with PL/python

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Peter Eisentraut
On tis, 2011-03-08 at 16:17 +0100, Adrian von Bidder wrote: Aagain, my question: are there wrappers/helpers to do this easily from the source/compile tree? Like: set up PATH, LD_LIBRARY_PATH, PG_WHATEVER, call initdb, ... Many developers have their own wrapper scripts, mainly to handle

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Adrian von Bidder
Hi, On Tuesday 08 March 2011 16.58:58 Kevin Grittner wrote: Adrian von Bidder avbid...@fortytwo.ch wrote: Or do you advise to just make install and test from there? Pretty much. Thanks for all your answers. I was just a bit confused because when I write stuff for myself I usually set

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Tom Lane
Adrian von Bidder avbid...@fortytwo.ch writes: Thanks for all your answers. I was just a bit confused because when I write stuff for myself I usually set up stuff to run directly in the build environment, so I was expecting something like that to be available. But make install into ~/pg

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: As Peter mentioned, most of us have scripts to set up a preferred working environment of this sort. I think I've published mine at least once That reminds me -- Greg Smith put something together which might make it easier to get started:

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Greg Stark
On Tue, Mar 8, 2011 at 3:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Not so right.  A path key contains an expression tree, plus whatever *additional* information is needed to fully specify the sort ordering. If the collation is already fully determined by the expression tree, there is no need

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: On Tue, Mar 8, 2011 at 3:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Not so right.  A path key contains an expression tree, plus whatever *additional* information is needed to fully specify the sort ordering. If the collation is already fully determined by the

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Andrew Dunstan
On 03/08/2011 01:04 PM, Kevin Grittner wrote: Tom Lanet...@sss.pgh.pa.us wrote: As Peter mentioned, most of us have scripts to set up a preferred working environment of this sort. I think I've published mine at least once That reminds me -- Greg Smith put something together which might

Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum

2011-03-08 Thread Heikki Linnakangas
On 08.03.2011 10:49, daveg wrote: On Tue, Mar 08, 2011 at 10:37:24AM +0200, Heikki Linnakangas wrote: On 08.03.2011 10:00, Heikki Linnakangas wrote: Another idea is to give up on the warning when it appears that oldestxmin has moved backwards, and assume that it's actually fine. We could still

Re: [HACKERS] Fwd: psql include file using relative path

2011-03-08 Thread Ibrar Ahmed
Gurjeet! What about tab completion, like in \i command? On Fri, Feb 25, 2011 at 5:07 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Feb 24, 2011 at 6:21 PM, Gurjeet Singh singh.gurj...@gmail.com wrote:     psql has the ability to execute commands from a file, but if one wishes to

Re: [HACKERS] .gitignore patch for coverage builds

2011-03-08 Thread Peter Eisentraut
On ons, 2011-01-26 at 15:38 -0600, Kevin Grittner wrote: Kevin Grittner kevin.gritt...@wicourts.gov wrote: Patch attached. The coverage directory belongs under Local excludes in root directory. Version 2. I have committed a simplified version of this, except the coverage/ directory,

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Adrian von Bidder
Heyho again! Now this kind of stuff is what I was after :-) On Tuesday 08 March 2011 19.04:53 Kevin Grittner wrote: That reminds me -- Greg Smith put something together which might make it easier to get started: https://github.com/gregs1104/peg/ Since you don't allow anonymous editing of

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Alexander Korotkov
Hello! I've following project proposal. Currently GiST index don't have any bulk load functionality. It have to create new index by entry insertion one by one. This makes new index creation relatively slow. There are various works in computer science about bulk operation on R-tree. Since gist in

Re: [HACKERS] Fwd: psql include file using relative path

2011-03-08 Thread Gurjeet Singh
Attached patch implements tab completion. It also introduces the long-form alternative \include_relative for \ir Regards, On Tue, Mar 8, 2011 at 2:18 PM, Ibrar Ahmed ibrar.ah...@gmail.com wrote: Gurjeet! What about tab completion, like in \i command? On Fri, Feb 25, 2011 at 5:07 AM, Robert

Re: [HACKERS] Beginner question: Hacking environment?

2011-03-08 Thread Andres Freund
Hi, On Tuesday 08 March 2011 21:12:53 Adrian von Bidder wrote: Since you don't allow anonymous editing of the wiki, nor have an obvious create account, I leave it to you to add this: Its linked on the mainpage: http://www.postgresql.org/community/signup Andres -- Sent via pgsql-hackers

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Oleg Bartunov
Yes, this would be very interesting project. It's not just about bulk load (CREATE INDEX) but also about bulk insert, which is important for update operations. As it adds two additional internal GiST methods, there should be no problem with compatibility. Oleg On Tue, 8 Mar 2011, Alexander

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Peter Eisentraut
On mån, 2011-03-07 at 13:51 -0800, Jeff Davis wrote: On Sat, 2011-03-05 at 18:33 -0500, Bruce Momjian wrote: I am seeing the following compile problem with gmake -j2: For what it's worth, I'm still seeing this problem too:

Re: [HACKERS] Parallel make problem with git master

2011-03-08 Thread Peter Eisentraut
On mån, 2011-03-07 at 22:28 -0500, Tom Lane wrote: BTW, how many people here have read Recursive Make Considered Harmful? http://aegis.sourceforge.net/auug97.pdf Because what we're presently doing looks mighty similar to what he's saying doesn't work and can't be made to work. Yes,

Re: [HACKERS] Alpha4 release blockers (was Re: wrapping up this CommitFest)

2011-03-08 Thread Peter Eisentraut
On mån, 2011-03-07 at 12:40 -0500, Tom Lane wrote: Fair enough, but throwing in fmgr_info_collation(DEFAULT_COLLATION) anytime we have a problem seems to me to introduce the exact same issue. Who's to say that that's really the appropriate value to use? It normally isn't the appropriate value

Re: [HACKERS] Alpha4 release blockers (was Re: wrapping up this CommitFest)

2011-03-08 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On mån, 2011-03-07 at 12:40 -0500, Tom Lane wrote: Fair enough, but throwing in fmgr_info_collation(DEFAULT_COLLATION) anytime we have a problem seems to me to introduce the exact same issue. Who's to say that that's really the appropriate value to

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Peter Eisentraut
On mån, 2011-03-07 at 12:52 -0500, Tom Lane wrote: It looks like indcollation is acting as a substitute for including a CollateClause in the index key expression, which doesn't seem like a particularly good tradeoff considering all the overhead you must introduce into the default case.

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Peter Eisentraut
On mån, 2011-03-07 at 19:15 -0500, Tom Lane wrote: Or, to put it another way: the properties that define a sort order are the sort comparison operator, the collation, the ASC/DESC bit, and the NULLS FIRST/LAST bit. Given the way that the SQL committee has constructed the language, the

Re: [HACKERS] Alpha4 release blockers (was Re: wrapping up this CommitFest)

2011-03-08 Thread Peter Eisentraut
On tis, 2011-03-08 at 17:43 -0500, Tom Lane wrote: Mph. Well, I guess in the case of the pg_statistic stats we can declare by fiat that we calculate the stats according to the default collation. They'll be a bit off when used for a query that is comparing according to some other collation,

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On mån, 2011-03-07 at 12:52 -0500, Tom Lane wrote: It looks like indcollation is acting as a substitute for including a CollateClause in the index key expression, which doesn't seem like a particularly good tradeoff considering all the overhead you

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Selena Deckelmann
Hi Alexander, On Tue, Mar 8, 2011 at 12:13 PM, Alexander Korotkov aekorot...@gmail.com wrote: I've following project proposal. Thanks for getting a head start! One warning - we haven't been accepted into GSoC yet. :) I'll be sure to contact you if we are accepted! Currently GiST index don't

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Tatsuo Ishii
Hi! PostgreSQL is applying for GSoC again this year. We're looking for: * Mentors Can I be a metor for pgpool-II? -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese: http://www.sraoss.co.jp * Project ideas Would you like to mentor? Please let me

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Selena Deckelmann
On Tue, Mar 8, 2011 at 3:52 PM, Tatsuo Ishii is...@postgresql.org wrote: Hi! PostgreSQL is applying for GSoC again this year. We're looking for: * Mentors Can I be a metor for pgpool-II? Yes! I can't guarantee that we will get student proposals for it. But, we will have a greater chance of

Re: [HACKERS] GSoC 2011 - Mentors? Projects?

2011-03-08 Thread Tatsuo Ishii
Can I be a metor for pgpool-II? Yes! I can't guarantee that we will get student proposals for it. But, we will have a greater chance of student proposals for things if we specifically list out projects that you'd like a student to tackle. Could you add a few items to the wiki page for

Re: [HACKERS] Theory of operation of collation patch

2011-03-08 Thread Tom Lane
Another interesting item ... I see that you added a collation field to TypeName, apparently on the grounds that the SQL spec includes collation in data type. However, it seems to me that that is nonsense up with which we should not put. data type is basically only used in CAST and column

[HACKERS] Fix for pg_upgrade discriptor leaks

2011-03-08 Thread Bruce Momjian
I have applied the attached patch to fix pg_upgrade file descriptor leaks in error paths. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + diff --git

Re: [HACKERS] Fix for pg_upgrade discriptor leaks

2011-03-08 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I have applied the attached patch to fix pg_upgrade file descriptor leaks in error paths. It seems rather pointless to spend code closing descriptors immediately before a fatal exit. regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] Fix for pg_upgrade discriptor leaks

2011-03-08 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I have applied the attached patch to fix pg_upgrade file descriptor leaks in error paths. It seems rather pointless to spend code closing descriptors immediately before a fatal exit. Well, it is not before a fatal but rather before

Re: [HACKERS] Sync Rep v19

2011-03-08 Thread Jaime Casanova
On Tue, Mar 8, 2011 at 11:58 AM, Robert Haas robertmh...@gmail.com wrote: The fast shutdown handling seems fine, but why not just handle smart shutdown the same way? currently, smart shutdown means no new connections, wait until existing ones close normally. for consistency, it should behave

Sync Rep and shutdown Re: [HACKERS] Sync Rep v19

2011-03-08 Thread Fujii Masao
On Wed, Mar 9, 2011 at 2:14 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Tue, Mar 8, 2011 at 11:58 AM, Robert Haas robertmh...@gmail.com wrote: The fast shutdown handling seems fine, but why not just handle smart shutdown the same way? currently, smart shutdown means no new