Re: [HACKERS] (PATCH) Adding CORRESPONDING to Set Operations

2011-11-17 Thread Hitoshi Harada
On Mon, Nov 14, 2011 at 6:09 AM, Kerem Kat kerem...@gmail.com wrote: On Mon, Nov 14, 2011 at 15:32, Tom Lane t...@sss.pgh.pa.us wrote: Kerem Kat kerem...@gmail.com writes: Corresponding is currently implemented in the parse/analyze phase. If it were to be implemented in the planning phase,

Re: [HACKERS] WIP: Join push-down for foreign tables

2011-11-17 Thread Heikki Linnakangas
On 15.11.2011 19:16, Shigeru Hanada wrote: This is the second effort for $SUBJECT. Attached patch requires pgsql_fdw patches[1] to be applied previously. This patch provides: * Changes for backend * Add new planner node ForeignJoinPath and related routines. In current design, planner

Re: [HACKERS] Disable OpenSSL compression

2011-11-17 Thread Albe Laurenz
I wrote: Here it is. I'll add it to the November commitfest. Here is the second version. I realized that it is better to set the option on the SSL object and not on the SSL context so that it is possible to change it per connection. I also improved the documentation. Yours, Laurenz Albe

[HACKERS] Removing postgres -f command line option

2011-11-17 Thread Heikki Linnakangas
While looking at Shigeru Hanada's foreign join pushdown patch, I noticed a command line option that I didn't know to exist: $ postgres --help ... Developer options: -f s|i|n|m|hforbid use of some plan types That doesn't include all the options we support, the documentation lists:

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-17 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: What you've got here could be useful to people who use emacs and understand they've got to hand-check the results. I'm not sure how much further it'd be useful to go. Agreed. That's the reason why I'm proposing src/tools/editors in the first place. I find

Re: [HACKERS] Removing postgres -f command line option

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 4:19 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: While looking at Shigeru Hanada's foreign join pushdown patch, I noticed a command line option that I didn't know to exist: $ postgres --help ... Developer options:  -f s|i|n|m|h    forbid use of

Re: [HACKERS] Removing postgres -f command line option

2011-11-17 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue nov 17 10:14:21 -0300 2011: On Thu, Nov 17, 2011 at 4:19 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: While looking at Shigeru Hanada's foreign join pushdown patch, I noticed a command line option that I didn't know to exist:

Re: [HACKERS] Configuration include directory

2011-11-17 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié nov 16 22:52:35 -0300 2011: (Do we guard against recursive inclusion via plain old include? If not, maybe this isn't worth worrying about.) Yes, we do FATAL: could not open configuration file foo.conf: maximum nesting depth exceeded -- Álvaro

Re: [HACKERS] SQLDA fix for ECPG

2011-11-17 Thread Michael Meskes
On Mon, Nov 14, 2011 at 09:06:30AM +0100, Boszormenyi Zoltan wrote: Yes, you are right. For timestamp and interval, the safe alignment is int64. Patch is attached. Applied, thanks. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at

Re: [HACKERS] Removing postgres -f command line option

2011-11-17 Thread Susanne Ebrecht
Heikki, On 17.11.2011 10:19, Heikki Linnakangas wrote: $ postgres --help ... Developer options: -f s|i|n|m|hforbid use of some plan types That doesn't include all the options we support, the documentation lists: s|i|o|b|t|n|m|h. These are aliases for enable_* planner options, e.g -fs

Re: [HACKERS] WIP: Join push-down for foreign tables

2011-11-17 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: When the FDW recognizes it's being asked to join a ForeignJoinPath and a ForeignPath, or two ForeignJoinPaths, it throws away the old SQL it constructed to do the two-way join, and builds a new one to join all three tables. It

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-17 Thread Peter Geoghegan
On 17 November 2011 03:54, Tom Lane t...@sss.pgh.pa.us wrote:  It's not reasonable to suppose that nobody is using it today. I didn't suppose that no one is using it, but that those that are using it are unaware of the risks with prefix validation, and that there will be a rude awakening for

Re: [HACKERS] Removing postgres -f command line option

2011-11-17 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: While looking at Shigeru Hanada's foreign join pushdown patch, I noticed a command line option that I didn't know to exist: $ postgres --help ... Developer options: -f s|i|n|m|hforbid use of some plan types Hmm, I

Re: [HACKERS] Configuration include directory

2011-11-17 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of mié nov 16 22:52:35 -0300 2011: (Do we guard against recursive inclusion via plain old include? If not, maybe this isn't worth worrying about.) Yes, we do FATAL: could not open configuration file

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Tue, Nov 15, 2011 at 4:43 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: Part-1) DROP statement refactoring It is a remaining portion of what I submitted in the last commit fest. It allows object types that didn't used DropStmt in gram.y to go through RemoveObjects(), instead of individual

Re: [HACKERS] IDLE in transaction introspection

2011-11-17 Thread Scott Mead
On Wed, Nov 16, 2011 at 4:09 PM, Scott Mead sco...@openscg.com wrote: On Tue, Nov 15, 2011 at 1:18 PM, Robert Treat r...@xzilla.net wrote: On Tue, Nov 15, 2011 at 12:00 PM, Greg Smith g...@2ndquadrant.com wrote: On 11/15/2011 09:44 AM, Scott Mead wrote: Fell off the map last week,

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 10:44 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: I think that's it's rather unlikely that removing hyphenation and prefix validation would adversely affect anyone, provided that it was well documented and wasn't applied to stable branches. If it were up to me, I

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: At the same time, I still think we should push this out to PGXN or pgfoundry or something. The fact that it's useful to some people does not mean that it's a good example for other people to follow, or that we want the core distribution to be in the

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: It also eliminates the NOTICE when removing a built-in function, which I think is OK because you don't actually get that far: There are paths that can reach that notice --- I think what you have to do is create a new function that references a built-in

Re: [HACKERS] Are range_before and range_after commutator operators?

2011-11-17 Thread Jeff Davis
, but it is escaping me now. What edge cases did you have in mind? Regards, Jeff Davis cmp-bounds-2017.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] declarations of range-vs-element @ and @

2011-11-17 Thread Jeff Davis
On Wed, 2011-11-16 at 16:41 -0500, Tom Lane wrote: But what surprises me about this example is that I'd have expected the heuristic assume the unknown is of the same type as the other input to resolve it. Looking more closely, I see that we apply that heuristic in such a way that it works

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 1:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: It also eliminates the NOTICE when removing a built-in function, which I think is OK because you don't actually get that far: There are paths that can reach that notice --- I think

Re: [HACKERS] Core Extensions relocation

2011-11-17 Thread Peter Eisentraut
On mån, 2011-11-14 at 20:44 -0500, Greg Smith wrote: The very specific problem I was most concerned about eliminating was people discovering they needed an extension to troubleshoot performance or corruption issues, only to discover it wasn't available--because they hadn't installed the

Re: [HACKERS] declarations of range-vs-element @ and @

2011-11-17 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On Wed, 2011-11-16 at 16:41 -0500, Tom Lane wrote: I propose adding a step to func_select_candidate that tries to resolve things that way, ie, if all the known-type inputs have the same type, then try assuming that the unknown-type ones are of that type,

[HACKERS] RangeVarGetRelid()

2011-11-17 Thread Robert Haas
In commit 4240e429d0c2d889d0cda23c618f94e12c13ade7, we modified RangeVarGetRelid() so that it acquires a lock on the target relation atomically with respect to the name lookup. Since we lock OIDs, not names, that's not possible, strictly speaking, but the idea is that we detect whether any

Re: [HACKERS] RangeVarGetRelid()

2011-11-17 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue nov 17 17:51:06 -0300 2011: The trouble is, I'm not quite sure how to do that. It seems like permissions checks and lock-the-heap-for-this-index should be done in RangeVarGetRelid() just after the block that says if (retry) and just before the

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue nov 17 16:25:03 -0300 2011: On Thu, Nov 17, 2011 at 1:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: - For some reason, we have code that causes procedural language names to be downcased before use. I

Re: [HACKERS] Are range_before and range_after commutator operators?

2011-11-17 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: Yikes! While commenting the code, it turns out that I missed the case where the values match and they are both exclusive; but one is upper and the other lower. Worse than that, there were apparently some bogus test results that expected the wrong output.

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 4:26 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So the buildfarm broke due to this change, because citext does Thanks for fixing it. Should we revert the original change? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [HACKERS] how to get tuple

2011-11-17 Thread Robert Haas
On Wed, Nov 16, 2011 at 9:38 AM, Rudyar rudyar.cor...@gmail.com wrote: Hello, I'm new in postgreSQL programming. I try to print a tuple from tupleTableSlot structure.. for example.. outerTupleSlot = ExecHashJoinOuterGetTuple(outerNode,                                                        

Re: [HACKERS] how to get tuple

2011-11-17 Thread Rudyar
On 17/11/11 19:16, Robert Haas wrote: On Wed, Nov 16, 2011 at 9:38 AM, Rudyarrudyar.cor...@gmail.com wrote: Hello, I'm new in postgreSQL programming. I try to print a tuple from tupleTableSlot structure.. for example.. outerTupleSlot = ExecHashJoinOuterGetTuple(outerNode,

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Nov 17, 2011 at 4:26 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So the buildfarm broke due to this change, because citext does Thanks for fixing it. Should we revert the original change? I still think it's reasonable to remove the

[HACKERS] Re: psql + libedit command history truncation (was: psql history vs. dearmor (pgcrypto))

2011-11-17 Thread Josh Kupershmidt
On Mon, Nov 14, 2011 at 7:04 PM, Josh Kupershmidt schmi...@gmail.com wrote: But it reminded me of another issue. With OS X 10.6.8, and otool -L reporting that psql depends on libedit version 2.11.0, the up-arrow recall of Tomas' query gets truncated around here:  5I0/NTm+fFkB0McY9E2fAA [rest

Re: [HACKERS] [PATCH] Unremovable tuple monitoring

2011-11-17 Thread Royce Ausburn
On 17/11/2011, at 1:47 AM, Robert Haas wrote: On Wed, Nov 16, 2011 at 9:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Not sure about the log line, but allowing pgstattuple to distinguish between recently-dead and quite-thoroughly-dead seems useful.

Re: [HACKERS] [PATCH] Unremovable tuple monitoring

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 5:49 PM, Royce Ausburn royce...@inomial.com wrote: Thanks for the discussion so far all.  Would it be worthwhile to make another patch that addresses the points from Yeb's reviews?  It's not sounding like this unremovable tuple count is something that postgres wants,

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 5:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Nov 17, 2011 at 4:26 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So the buildfarm broke due to this change, because citext does Thanks for fixing it.  Should we

Re: [HACKERS] [PATCH] Unremovable tuple monitoring

2011-11-17 Thread Royce Ausburn
On 18/11/2011, at 10:44 AM, Robert Haas wrote: On Thu, Nov 17, 2011 at 5:49 PM, Royce Ausburn royce...@inomial.com wrote: Thanks for the discussion so far all. Would it be worthwhile to make another patch that addresses the points from Yeb's reviews? It's not sounding like this

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Nov 17, 2011 at 5:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: I still think it's reasonable to remove the extra downcasing step, but we'll have to document it as a change. So, should we add a note to all the LANGUAGE command pages in the

Re: [HACKERS] RangeVarGetRelid()

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 4:12 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of jue nov 17 17:51:06 -0300 2011: The trouble is, I'm not quite sure how to do that.  It seems like permissions checks and lock-the-heap-for-this-index should be done in

[HACKERS] Schedule for upcoming back-branch releases

2011-11-17 Thread Tom Lane
The core and packagers lists have agreed to the schedule that was proposed towards the end of last week's discussion: http://archives.postgresql.org/pgsql-hackers/2011-11/msg00578.php That is, we'll wrap tarballs on Thursday Dec 1 for public announcement Monday Dec 5. Since the announced EOL date

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 11:21 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 15, 2011 at 4:43 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: Part-1) DROP statement refactoring It is a remaining portion of what I submitted in the last commit fest. It allows object types that didn't used

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Tue, Nov 15, 2011 at 4:43 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: Part-2) Groundworks on objectaddress.c This patch adds necessary groundworks for Part-3 and Part-4. It adds ObjectPropertyType of objectaddress.c index-oid and cache-id for name lookup and attribute number of object name;

Re: [HACKERS] RangeVarGetRelid()

2011-11-17 Thread Noah Misch
On Thu, Nov 17, 2011 at 08:59:58PM -0500, Robert Haas wrote: On Thu, Nov 17, 2011 at 4:12 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of jue nov 17 17:51:06 -0300 2011: The trouble is, I'm not quite sure how to do that. ?It seems like

Re: [HACKERS] Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

2011-11-17 Thread Robert Haas
On Tue, Nov 15, 2011 at 4:43 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: Part-2) Groundworks on objectaddress.c This patch adds necessary groundworks for Part-3 and Part-4. It adds ObjectPropertyType of objectaddress.c index-oid and cache-id for name lookup and attribute number of object name;

[HACKERS] vpath builds and verbose error messages

2011-11-17 Thread Peter Eisentraut
When using verbose error messages (psql \set VERBOSITY verbose) with a vpath build, you get this sort of thing: ERROR: 42703: column foo does not exist LINE 1: select foo; ^ LOCATION: transformColumnRef,

Re: [HACKERS] RangeVarGetRelid()

2011-11-17 Thread Robert Haas
On Thu, Nov 17, 2011 at 10:48 PM, Noah Misch n...@leadboat.com wrote: On Thu, Nov 17, 2011 at 08:59:58PM -0500, Robert Haas wrote: On Thu, Nov 17, 2011 at 4:12 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of jue nov 17 17:51:06 -0300 2011: The

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-17 Thread Robert Haas
On Sun, Sep 25, 2011 at 10:12 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: I've produced something much neater than my first patch, attached, although I still consider this to be at the POC stage, not least since I'm not exactly sure how I should be selecting the right specialisation in

Re: [HACKERS] WIP: Collecting statistics on CSV file data

2011-11-17 Thread Etsuro Fujita
(2011/11/07 20:26), Shigeru Hanada wrote: (2011/10/20 18:56), Etsuro Fujita wrote: I revised the patch according to Hanada-san's comments. Attached is the updated version of the patch. Changes: * pull up of logging analyzing foo.bar * new vac_update_relstats always called *