[HACKERS] Adding XSLT support to PostgreSQL core?

2011-12-06 Thread Volker Grabsch
Dear PostgreSQL hackers, [ please CC to me as I'm not subscribed to the list ] For my projects, I find it very handy to apply XSLT transformations directly on database side. Unfortunately, this is only available in contrib/xml2 with an unpleasant interface. The documentation of contrib/xml2 of

Re: [HACKERS] xlog location arithmetic

2011-12-06 Thread Magnus Hagander
On Tue, Dec 6, 2011 at 05:19, Euler Taveira de Oliveira eu...@timbira.com wrote: Hi, A while ago when blogging about WAL [1], I noticed a function to deal with xlog location arithmetic is wanted. I remembered Depez [2] mentioning it and after some questions during trainings and conferences I

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Nicolas Barbier
2011/12/5 Tom Lane t...@sss.pgh.pa.us: What is bothering me is that this approach is going to cause substantial bloat of the executable code, and such bloat has got distributed costs, which we don't have any really good way to measure but for sure micro-benchmarks addressing only sort speed

Re: [HACKERS] IDLE in transaction introspection

2011-12-06 Thread Magnus Hagander
On Sat, Nov 19, 2011 at 02:55, Scott Mead sco...@openscg.com wrote: On Thu, Nov 17, 2011 at 11:58 AM, Scott Mead sco...@openscg.com wrote: On Wed, Nov 16, 2011 at 4:09 PM, Scott Mead sco...@openscg.com wrote: On Tue, Nov 15, 2011 at 1:18 PM, Robert Treat r...@xzilla.net wrote: On Tue,

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-12-06 Thread Magnus Hagander
On Thu, Oct 13, 2011 at 14:25, Robert Haas robertmh...@gmail.com wrote: On Tue, Oct 4, 2011 at 9:15 AM, Simon Riggs si...@2ndquadrant.com wrote: Simon, could you? If your proposal turns out to be better than mine, I'd be happy to agree to drop my patch and adopt yours. Yes, will do. Simon,

Re: [HACKERS] pg_upgrade if 'postgres' database is dropped

2011-12-06 Thread Magnus Hagander
On Thu, Nov 3, 2011 at 11:20, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Wed, Nov 2, 2011 at 8:31 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: If nobody objects, I'll go do that. ?Hopefully that should be enough to put this problem to bed more or less

Re: [HACKERS] pg_cancel_backend by non-superuser

2011-12-06 Thread Magnus Hagander
On Sun, Oct 2, 2011 at 23:32, Tom Lane t...@sss.pgh.pa.us wrote: Noah Misch n...@leadboat.com writes: On Sun, Oct 02, 2011 at 06:55:51AM -0400, Robert Haas wrote: On Sat, Oct 1, 2011 at 10:11 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: I see. What about passing this decision to

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2011-12-06 Thread Florian Weimer
* Robert Haas: I tried whacking out the call to GetPageWithFreeSpace() in RelationGetBufferForTuple(), and also with the unpatched code, but the run-to-run randomness was way more than any difference the change made. Is there a better test case? I think that if you want to exercise file

Re: [HACKERS] pg_upgrade if 'postgres' database is dropped

2011-12-06 Thread Bruce Momjian
Magnus Hagander wrote: On Thu, Nov 3, 2011 at 11:20, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Wed, Nov 2, 2011 at 8:31 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: If nobody objects, I'll go do that. ?Hopefully that should be enough to put

Re: [HACKERS] pg_upgrade if 'postgres' database is dropped

2011-12-06 Thread Bruce Momjian
Magnus Hagander wrote: On Thu, Nov 3, 2011 at 11:20, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Wed, Nov 2, 2011 at 8:31 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: If nobody objects, I'll go do that. ?Hopefully that should be enough to put

Re: [HACKERS] pg_upgrade if 'postgres' database is dropped

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 7:00 AM, Magnus Hagander mag...@hagander.net wrote: Seems reasonably clean to me. Not sure what would be unclean about it? Based on this feedback, I went ahead and committed my previous patch. This means that if pg_upgrade wants to accept a --maintenance-db option, it will

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Magnus Hagander
On Sun, Dec 4, 2011 at 18:07, Tom Lane t...@sss.pgh.pa.us wrote: Andrew Dunstan and...@dunslane.net writes: On 12/04/2011 11:41 AM, Tom Lane wrote: Hm, how portable is symlink-reading?  If we can actually do that without big headaches, then +1. I wondered that, specifically about Windows

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: + snprintf(sourcepath, sizeof(sourcepath), pg_tblspc/%d, tablespaceOid); %u for an OID, please. Otherwise seems reasonably sane on first glance. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: AFAICT, it should be as simple as the attached. Oh, one other thought is that the function body has to be conditionalized on HAVE_READLINK (the fact that you forgot that somewhere else isn't an excuse for not doing it here). IIRC, only the two

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Magnus Hagander
On Tue, Dec 6, 2011 at 16:12, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: AFAICT, it should be as simple as the attached. Oh, one other thought is that the function body has to be conditionalized on HAVE_READLINK (the fact that you forgot that somewhere

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: Throwing an error seems a lot more safe in this case than just returning NULL. Since it's a situtation that really shouldn't happen. Maybe an assert, but I think a regular ereport(ERROR) would be the best. Not an assert, since it's trivially

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Magnus Hagander
On Tue, Dec 6, 2011 at 16:17, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Throwing an error seems a lot more safe in this case than just returning NULL. Since it's a situtation that really shouldn't happen. Maybe an assert, but I think a regular

Re: [HACKERS] pull_up_simple_subquery

2011-12-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: While working on KaiGai's leaky views patch, I found myself scrutinizing the behavior of the function named in the subject line; and specifically the retest of is_simple_subquery(). I've been unable to make that fail. It might be that the

Re: [HACKERS] [DOCS] Moving tablespaces

2011-12-06 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: There is some nice precedent in the CREATE TABLESPACE command (though dependent on HAVE_SYMLINK and not HAVE_READLINK), so I'm just going to copy the error message from there. Fair enough. Looking at the existing readlink use in port/exec.c, it

[HACKERS] Recover data....

2011-12-06 Thread Azghar Hussain
Hi, Sorry, I am resending this email.. there was spelling mistake in earlier email... Please help me. Due to some unknown reason all contents of PostGresql data folder ( D:\Program Files\PostgreSQL\8.4\data) got deleted except base and global folder. Please let me If I can recover my

Re: [HACKERS] xlog location arithmetic

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 5:14 AM, Magnus Hagander mag...@hagander.net wrote: I've been considering similar things, as you can find in the archives, but what I was thinking of was converting the number to just a plain bigint, then letting the user apply whatever arithmetic wanted at the SQL

Re: [HACKERS] Recover data....

2011-12-06 Thread Kevin Grittner
Azghar Hussain azghar.huss...@rmsi.com wrote: Due to some unknown reason all contents of PostGresql data folder (D:\Program Files\PostgreSQL\8.4\data) got deleted except base and global folder. Please let me If I can recover my whole data.. Several of the other folders contain information

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Robert Haas
On Sun, Dec 4, 2011 at 2:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: * I invented a SortKey struct that replaces ScanKey for tuplesort's purposes.  Right now that's local in tuplesort.c, but we're more than likely going to need it elsewhere as well.  Should we just define it in sortsupport.h?  

Re: [HACKERS] [REVIEW] Patch for cursor calling with named parameters

2011-12-06 Thread Kevin Grittner
Kevin Grittner kgri...@wicourts.gov wrote: Yeb Havinga yebhavi...@gmail.com wrote: I personally tend to believe it doesn't even need to be an error. There is no technical reason not to allow it. All the user needs to do is make sure that the combination of named parameters and the

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Dec 4, 2011 at 2:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: * We're going to want to expose PrepareSortSupportComparisonShim for use outside tuplesort.c too, and possibly refactor tuplesort_begin_heap so that the SortKey setup logic inside it

Re: [HACKERS] xlog location arithmetic

2011-12-06 Thread Euler Taveira de Oliveira
On 06-12-2011 07:14, Magnus Hagander wrote: On Tue, Dec 6, 2011 at 05:19, Euler Taveira de Oliveira eu...@timbira.com wrote: Hi, A while ago when blogging about WAL [1], I noticed a function to deal with xlog location arithmetic is wanted. I remembered Depez [2] mentioning it and after some

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 12:06 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Dec 4, 2011 at 2:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: * We're going to want to expose PrepareSortSupportComparisonShim for use outside tuplesort.c too, and possibly

Re: [HACKERS] xlog location arithmetic

2011-12-06 Thread Euler Taveira de Oliveira
On 06-12-2011 13:11, Robert Haas wrote: On Tue, Dec 6, 2011 at 5:14 AM, Magnus Hagander mag...@hagander.net wrote: I've been considering similar things, as you can find in the archives, but what I was thinking of was converting the number to just a plain bigint, then letting the user apply

Re: [HACKERS] xlog location arithmetic

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 1:00 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: On 06-12-2011 13:11, Robert Haas wrote: On Tue, Dec 6, 2011 at 5:14 AM, Magnus Hagander mag...@hagander.net wrote: I've been considering similar things, as you can find in the archives, but what I was thinking

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: OK. Well, then pushing it out to a separate file probably makes sense. Do you want to do that or shall I have a crack at it? If the latter, what do you think about using the name SortKey for everything rather than SortSupport? I'll take another

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 1:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: OK.  Well, then pushing it out to a separate file probably makes sense.  Do you want to do that or shall I have a crack at it?  If the latter, what do you think about using the name

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Ben Hockey
i know its been over a year without any activity on this thread but did anything ever come of this? i'd really like to be able to get dates to match the format specified for date time strings in ecmascript 5. a generic way to specify the format would be ideal if it can be done securely. has

Re: [HACKERS] [COMMITTERS] pgsql: plpython: Add SPI cursor support

2011-12-06 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: plpython: Add SPI cursor support Buildfarm member narwhal does not like this patch. It looks like PyObject_SelfIter is not a compile-time constant on its version of python (2.5, apparently). regards, tom lane -- Sent via

Re: [HACKERS] [COMMITTERS] pgsql: plpython: Add SPI cursor support

2011-12-06 Thread Jan Urbański
On 06/12/11 19:23, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: plpython: Add SPI cursor support Buildfarm member narwhal does not like this patch. It looks like PyObject_SelfIter is not a compile-time constant on its version of python (2.5, apparently). Hm, I quickly tried

[HACKERS] should Makefile.custom be in source tree or in build tree?

2011-12-06 Thread Peter Eisentraut
Makefile.custom is currently looked for in the source directory. This tripped me up recently when doing a vpath build. Should it be looked for in the build tree instead? Or both? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] should Makefile.custom be in source tree or in build tree?

2011-12-06 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of mar dic 06 16:06:57 -0300 2011: Makefile.custom is currently looked for in the source directory. This tripped me up recently when doing a vpath build. Should it be looked for in the build tree instead? Or both? Hmm, interesting question. When I

Re: [HACKERS] should Makefile.custom be in source tree or in build tree?

2011-12-06 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Peter Eisentraut's message of mar dic 06 16:06:57 -0300 2011: Makefile.custom is currently looked for in the source directory. This tripped me up recently when doing a vpath build. Should it be looked for in the build tree

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 7:12 AM, Florian Weimer fwei...@bfk.de wrote: * Robert Haas: I tried whacking out the call to GetPageWithFreeSpace() in RelationGetBufferForTuple(), and also with the unpatched code, but the run-to-run randomness was way more than any difference the change made.  Is

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 1:11 PM, Ben Hockey neonstalw...@gmail.com wrote: i know its been over a year without any activity on this thread but did anything ever come of this?  i'd really like to be able to get dates to match the format specified for date time strings in ecmascript 5.  a generic

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Dec 6, 2011 at 1:11 PM, Ben Hockey neonstalw...@gmail.com wrote: i know its been over a year without any activity on this thread but did anything ever come of this?  i'd really like to be able to get dates to match the format specified for date

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Pavel Stehule
2011/12/6 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: On Tue, Dec 6, 2011 at 1:11 PM, Ben Hockey neonstalw...@gmail.com wrote: i know its been over a year without any activity on this thread but did anything ever come of this?  i'd really like to be able to get dates

Re: [HACKERS] WIP: SP-GiST, Space-Partitioned GiST

2011-12-06 Thread Tom Lane
Oleg Bartunov o...@sai.msu.su writes: There is one annoying problem under MAC OS (Linux, FreeBSD have no problem), we just can't figure out how to find it, since we are not familiar with MAC OS - it fails to restart after 'kill -9' backend, but only if sources were compiled with -O2

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread ben hockey
On 12/6/2011 3:20 PM, Pavel Stehule wrote: I am for ECMA datestyle it is there but just is not public, if I remember well Theoretically some custom output/input transform routine can be very interesting - for domains, for boolean type - but on second hand - the usage of this feature is

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Pavel Stehule
2011/12/6 ben hockey neonstalw...@gmail.com: On 12/6/2011 3:20 PM, Pavel Stehule wrote: I am for ECMA datestyle it is there but just is not public, if I remember well Theoretically some custom output/input transform routine can be very interesting - for domains, for boolean type - but on

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Pavel Stehule
2011/12/6 ben hockey neonstalw...@gmail.com: On 12/6/2011 3:20 PM, Pavel Stehule wrote: I am for ECMA datestyle it is there but just is not public, if I remember well Theoretically some custom output/input transform routine can be very interesting - for domains, for boolean type - but on

Re: [HACKERS] RangeVarGetRelid()

2011-12-06 Thread Robert Haas
On Mon, Dec 5, 2011 at 2:09 AM, Noah Misch n...@leadboat.com wrote: Your committed patch looks great overall.  A few cosmetic points: Thanks for the review. That last sentence needs a word around might things. Fixed.               AcceptInvalidationMessages(); The above call can go away,

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread ben hockey
On 12/6/2011 3:53 PM, Pavel Stehule wrote: I am not sure, if this patch is 100% correct but it does something the name is not ECMA but XSD - I hope, so both formats are same that format works for me. in fact a simple test to see if it would do what i hope for would be to open the

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Pavel Stehule
2011/12/6 ben hockey neonstalw...@gmail.com: On 12/6/2011 3:53 PM, Pavel Stehule wrote: I am not sure, if this patch is 100% correct but it does something the name is not ECMA but XSD - I hope, so both formats are same that format works for me.  in fact a simple test to see if it would

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Dec 6, 2011 at 1:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'll take another crack at it. I'm not entirely sold yet on merging the two structs; I think first we'd better look and see what the needs are in the other potential callers I

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread ben hockey
On 12/6/2011 4:19 PM, Pavel Stehule wrote: it can be in 9.2 (if will be accepted) - it will be release at summer 2012 http://wiki.postgresql.org/wiki/Submitting_a_Patch Regards Pavel Stehule ok, so i assume your patch is now considered submitted and is waiting to be reviewed. i'll wait

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Pavel Stehule
2011/12/6 ben hockey neonstalw...@gmail.com: On 12/6/2011 4:19 PM, Pavel Stehule wrote: it can be in 9.2 (if will be accepted) - it will be release at summer 2012 http://wiki.postgresql.org/wiki/Submitting_a_Patch Regards Pavel Stehule ok, so i assume your patch is now considered

[HACKERS] PostgreSQL 9.1 poster picture ?

2011-12-06 Thread Oleg Bartunov
Hi there, I'm looking for the picture of PostgreSQL 9.1 poster, which we all signed at Developers Meeting. Anybody knows where it's now ? Regards, Oleg _ Oleg Bartunov, Research Scientist, Head of AstroNet

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread ben hockey
i may have spoken a little too soon about the format being right... i just took a look at the postgres source code and it would need one more change to completely meet my needs. EncodeDateTime should put a 'Z' for UTC timezone rather than '+0'. with this being the case, do you think there

Re: [HACKERS] ecmascript 5 DATESTYLE

2011-12-06 Thread Pavel Stehule
Hello 2011/12/6 ben hockey neonstalw...@gmail.com: i may have spoken a little too soon about the format being right...  i just took a look at the postgres source code and it would need one more change to completely meet my needs.  EncodeDateTime should put a 'Z' for UTC timezone rather than

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 4:23 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Dec 6, 2011 at 1:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'll take another crack at it.  I'm not entirely sold yet on merging the two structs; I think first we'd better look

Re: [HACKERS] pg_upgrade and relkind filtering

2011-12-06 Thread Robert Haas
On Mon, Dec 5, 2011 at 5:06 PM, Bruce Momjian br...@momjian.us wrote: Pg_upgrade has the following check to make sure the cluster is safe for upgrading:        res = executeQueryOrDie(conn,                                SELECT n.nspname, c.relname, a.attname                                

Re: [HACKERS] pg_upgrade and relkind filtering

2011-12-06 Thread Bruce Momjian
Robert Haas wrote: On Mon, Dec 5, 2011 at 5:06 PM, Bruce Momjian br...@momjian.us wrote: Pg_upgrade has the following check to make sure the cluster is safe for upgrading: ? ? ? ?res = executeQueryOrDie(conn, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?SELECT n.nspname, c.relname, a.attname ? ?

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2011-12-06 Thread Andres Freund
On Tuesday, December 06, 2011 08:53:42 PM Robert Haas wrote: On Tue, Dec 6, 2011 at 7:12 AM, Florian Weimer fwei...@bfk.de wrote: * Robert Haas: I tried whacking out the call to GetPageWithFreeSpace() in RelationGetBufferForTuple(), and also with the unpatched code, but the run-to-run

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Peter Geoghegan
On 7 December 2011 00:18, Robert Haas robertmh...@gmail.com wrote: Works for me.  I think we should go ahead and get this part committed first, and then we can look at the inlining stuff as a further optimization for certain cases... Do you mean just inlining, or inlining and the numerous

Re: [HACKERS] pg_stat_statements with query tree based normalization

2011-12-06 Thread Peter Geoghegan
On 14 November 2011 04:42, Greg Smith g...@2ndquadrant.com wrote: The approach Peter used adds a single integer to the Const structure in order to have enough information to substitute ? in place of those.  Adding and maintaining that is the only change outside of the extension made here, and

[HACKERS] Timing overhead and Linux clock sources

2011-12-06 Thread Greg Smith
Over in the add timing of buffer I/O requests thread I mentioned having a system where EXPLAIN ANALYZE of a modest COUNT(*) takes 10X as long as just executing the statement. Attached is a bit of SQL and a script that runs it multiple times that demonstrate the problem on systems that have

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 8:12 PM, Andres Freund and...@anarazel.de wrote: On Tuesday, December 06, 2011 08:53:42 PM Robert Haas wrote: On Tue, Dec 6, 2011 at 7:12 AM, Florian Weimer fwei...@bfk.de wrote: * Robert Haas: I tried whacking out the call to GetPageWithFreeSpace() in

Re: [HACKERS] Timing overhead and Linux clock sources

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 9:58 PM, Greg Smith g...@2ndquadrant.com wrote: -If you have a system with a working TSC clock source (timing data is pulled right from the CPU), timing overhead is reasonable enough that you might turn it on even for things that happen frequently, such as the buffer I/O

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Robert Haas
On Tue, Dec 6, 2011 at 8:13 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 7 December 2011 00:18, Robert Haas robertmh...@gmail.com wrote: Works for me.  I think we should go ahead and get this part committed first, and then we can look at the inlining stuff as a further optimization for

Re: [HACKERS] pg_upgrade and relkind filtering

2011-12-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Dec 5, 2011 at 5:06 PM, Bruce Momjian br...@momjian.us wrote: Pg_upgrade has the following check to make sure the cluster is safe for upgrading: What types, other than views, can we skip in this query? It's not obvious to me that anything

Re: [HACKERS] pgsql_fdw, FDW for PostgreSQL server

2011-12-06 Thread Shigeru Hanada
Sorry for delayed response. 2011/11/29 Albe Laurenz laurenz.a...@wien.gv.at: I think that this is not always safe even from PostgreSQL to PostgreSQL. If two databases have different collation, on strings will behave differently. Indeed.  I think that only the owner of foreign table can keep

Re: [HACKERS] Timing overhead and Linux clock sources

2011-12-06 Thread Greg Smith
On 12/06/2011 10:20 PM, Robert Haas wrote: EXPLAIN ANALYZE is extremely expensive mostly because it's timing entry and exit into every plan node, and the way our executor works, those are very frequent operations. The plan for the query I was timing looks like this: Aggregate