Re: [HACKERS] [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

2012-07-04 Thread Amit Kapila
From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Tuesday, July 03, 2012 9:43 PM On Mon, Jul 2, 2012 at 8:08 AM, Amit Kapila amit.kap...@huawei.com wrote: Suggestions? I suggest you add this to the next CommitFest. :-) https://commitfest.postgresql.org/action/commitfest_view?id=14

[HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-04 Thread Joel Jacobson
I have received positive feedback on the pg_dump --split option I suggested, but it depends on pg_dump dumping objects in a deterministic order. I'm committed to fixing this. The first problem I've spotted is overloaded functions. This patch adds a new element to DumpableObject: char *proargs

Re: [HACKERS] pgfoundry references in docs

2012-07-04 Thread Magnus Hagander
On Wed, Jul 4, 2012 at 4:21 PM, David E. Wheeler da...@justatheory.com wrote: On Jul 4, 2012, at 9:15 AM, Magnus Hagander wrote: Not really. We have nowhere else to recommend, since we don't run a replacement for it. And we really don't want to get involved in listing all the different third

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-04 Thread Alvaro Herrera
Excerpts from Boszormenyi Zoltan's message of mié jul 04 06:32:46 -0400 2012: 2012-07-04 12:09 keltezéssel, Boszormenyi Zoltan írta: You just broke initdb with this cleanup. :-) Ouch. initdb starts postgres --single, that doesn't do BackendInitialize(), only PostgresMain(). So, you need

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-04 Thread Alvaro Herrera
Excerpts from Boszormenyi Zoltan's message of mié jul 04 07:03:44 -0400 2012: 2012-07-03 23:38 keltezéssel, Alvaro Herrera írta: I don't understand why PGSemaphoreTimedLock() is not broken. I mean surely you need a bool return to let the caller know whether the acquisition succeeded

Re: [HACKERS] enhanced error fields

2012-07-04 Thread Alvaro Herrera
Excerpts from Pavel Stehule's message of mié jul 04 05:33:48 -0400 2012: Hello 2012/7/3 Matthew Woodcraft matt...@woodcraft.me.uk: Peter Geoghegan pe...@2ndquadrant.com writes: So I took a look at the patch eelog-2012-05-09.diff today. All of the following remarks apply to it alone.

[HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-04 Thread Joel Jacobson
I renamed the new element to DumpableObject from proargs to the more general name sortkey. This way this element can be used by any object types in the future, which might require sorting by additional information than type, namespace and name. Currently, it's only set for functions/aggregates

[HACKERS] waitpid in pg_basebackup

2012-07-04 Thread Fujii Masao
Hi, waitpid() is used with #ifdef HAVE_WAITPID in reaper(), but NOT in BaseBackup(). Why not? We can ensure that all platforms which PostgreSQL supports have waitpid()? If so, can we get rid of #ifdef HAVE_WAITPID in reaper()? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-04 Thread Boszormenyi Zoltan
2012-07-04 17:25 keltezéssel, Alvaro Herrera írta: Excerpts from Boszormenyi Zoltan's message of mié jul 04 07:03:44 -0400 2012: 2012-07-03 23:38 keltezéssel, Alvaro Herrera írta: I don't understand why PGSemaphoreTimedLock() is not broken. I mean surely you need a bool return to let the

Re: [HACKERS] enhanced error fields

2012-07-04 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: I think if you don't have a true constraint name to use here, you shouldn't use anything. Yeah, I agree. Don't invent a value, just omit the field. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] waitpid in pg_basebackup

2012-07-04 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: waitpid() is used with #ifdef HAVE_WAITPID in reaper(), but NOT in BaseBackup(). Why not? We can ensure that all platforms which PostgreSQL supports have waitpid()? If so, can we get rid of #ifdef HAVE_WAITPID in reaper()? The Single Unix Spec V2

Re: [HACKERS] enhanced error fields

2012-07-04 Thread Pavel Stehule
2012/7/4 Tom Lane t...@sss.pgh.pa.us: Alvaro Herrera alvhe...@commandprompt.com writes: I think if you don't have a true constraint name to use here, you shouldn't use anything. Yeah, I agree.  Don't invent a value, just omit the field. ok Pavel                         regards, tom lane

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-04 Thread Robert Haas
On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila amit.kap...@huawei.com wrote: Hi Shigeru/Robert, The way fixing oid2name and pgbench seems reasonable, so applying it to vacuumlo (as Peter mentioned) would be enough for this issue. Shall I consider following 2 points to update the patch: 1.

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-04 Thread Robert Haas
On Tue, Jul 3, 2012 at 12:46 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: My point is that it seems like a bug that the secContext gets restored in one case and not the other, depending on which user ID was specified in SET SESSION AUTHORIZATION. Sorry, the above description mention about a

Re: [HACKERS] Posix Shared Mem patch

2012-07-04 Thread Robert Haas
On Tue, Jul 3, 2012 at 1:46 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Tue, Jul 3, 2012 at 6:57 AM, Robert Haas robertmh...@gmail.com wrote: Here's a patch that attempts to begin the work of adjusting the documentation for this brave new world. I am guessing that there may be other

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-04 Thread Kohei KaiGai
2012/7/4 Robert Haas robertmh...@gmail.com: On Tue, Jul 3, 2012 at 12:46 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: My point is that it seems like a bug that the secContext gets restored in one case and not the other, depending on which user ID was specified in SET SESSION AUTHORIZATION.

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-04 Thread Robert Haas
On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov aekorot...@gmail.com wrote: [ new patch ] With the improved comments in pg_wchar.h, it seemed clear what needed to be done here, so I fixed up the MULE conversion and committed this. I'd appreciate it if someone would check my work, but I think

Re: [HACKERS] Oracle porting sample instr function

2012-07-04 Thread Robert Haas
On Wed, Jul 4, 2012 at 3:50 AM, Albe Laurenz laurenz.a...@wien.gv.at wrote: Robert Haas wrote: I can confirm that Oracle returns 0 if the third argument to INSTR is 0. Can someone provide a suitable doc patch? Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

Re: [HACKERS] Pg default's verbosity?

2012-07-04 Thread Robert Haas
On Mon, Jul 2, 2012 at 3:47 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jun 29, 2012 at 3:07 AM, Bruce Momjian br...@momjian.us wrote: Personally, I'd have no problem with flat-out dropping (not demoting) both of those two specific messages. I seem to recall that Bruce has lobbied

Re: [HACKERS] Schema version management

2012-07-04 Thread Robert Haas
On Wed, Jul 4, 2012 at 9:02 AM, Joel Jacobson j...@trustly.com wrote: On Tue, Jul 3, 2012 at 7:49 PM, Peter Eisentraut pete...@gmx.net wrote: I think this idea has merit. Prepare a patch and put it into the next commit fest. Glad to hear, I'm on it! I see the problem that since the dump

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-04 Thread Tatsuo Ishii
On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov aekorot...@gmail.com wrote: [ new patch ] With the improved comments in pg_wchar.h, it seemed clear what needed to be done here, so I fixed up the MULE conversion and committed this. I'd appreciate it if someone would check my work, but

Re: [HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-07-04 Thread Bruce Momjian
On Tue, Jun 12, 2012 at 02:40:09PM -0400, Robert Haas wrote: On Tue, Jun 12, 2012 at 2:02 PM, Bruce Momjian br...@momjian.us wrote: On Tue, Jun 12, 2012 at 01:50:48PM -0400, Noah Misch wrote: On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: What about something like this in

Re: [HACKERS] embedded list v2

2012-07-04 Thread Peter Geoghegan
On 28 June 2012 19:20, Andres Freund and...@2ndquadrant.com wrote: 0001-Add-embedded-list-interface.patch Looks good now? I have a few gripes. + * there isn't much we can test in a single linked list except that its There are numerous references to single linked lists, where, I believe,

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-07-04 Thread Amit Kapila
From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Friday, June 22, 2012 8:59 PM On Fri, Jun 22, 2012 at 5:25 AM, Amit Kapila amit.kap...@huawei.com wrote: Based on the discussion and suggestions in this mail chain, following features can be implemented: 1. To compute the value of max LSN

[HACKERS] Query from VMWare re use of PostgreSQL in new TPC-V benchmark

2012-07-04 Thread Craig Ringer
Heya Just in case someone missed it on -perform and is interested, a couple of questions have come in from VMWare, who want to use PostgreSQL as the default reference implementation for a new TPC benchmark, TPC-V.

Re: [HACKERS] proof concept - access to session variables on client side

2012-07-04 Thread Dimitri Fontaine
Le 3 juil. 2012 à 19:53, Peter Eisentraut pete...@gmx.net a écrit : I think it would be better if DO could be extended into some kind of lambda, taking parameters and returning a value. Then you can use existing infrastructure for passing values and saving the return. It would also extend

Re: [HACKERS] pgfoundry references in docs

2012-07-04 Thread Magnus Hagander
On Tue, Jul 3, 2012 at 10:32 PM, Dave Page dp...@pgadmin.org wrote: On Tuesday, July 3, 2012, Peter Geoghegan wrote: On 3 July 2012 20:20, Magnus Hagander mag...@hagander.net wrote: The second one removes the reference to pgfoundry completely. As a step in the deprecation. I'd prefer

Re: [HACKERS] pgfoundry references in docs

2012-07-04 Thread Magnus Hagander
On Tue, Jul 3, 2012 at 10:01 PM, David E. Wheeler da...@justatheory.com wrote: On Jul 3, 2012, at 9:20 PM, Magnus Hagander wrote: The smaller one, pgfoundry_1.diff, removes the suggestion to apply for new projects on pgfoundry. The reason for this being that pgfoundry doesn't *accept* new

Re: [HACKERS] Solaris docs

2012-07-04 Thread Magnus Hagander
On Tue, Jul 3, 2012 at 9:58 PM, Bjorn Munch bjorn.mu...@oracle.com wrote: On 03/07 21.24, Magnus Hagander wrote: Our documentation still refers to PostgreSQL bundled in solaris, and references downloads to the pgfoundry project. Oh! I wasn't aware of that. Attached patch removes all those

Re: [HACKERS] pgfoundry references in docs

2012-07-04 Thread Albe Laurenz
Magnus Hagander wrote: Attached are two patches, one of which I'd like to apply. Open for discussion on which one. The smaller one, pgfoundry_1.diff, removes the suggestion to apply for new projects on pgfoundry. The reason for this being that pgfoundry doesn't *accept* new projects

Re: [HACKERS] pgfoundry references in docs

2012-07-04 Thread Magnus Hagander
On Wed, Jul 4, 2012 at 9:18 AM, Albe Laurenz laurenz.a...@wien.gv.at wrote: Magnus Hagander wrote: Attached are two patches, one of which I'd like to apply. Open for discussion on which one. The smaller one, pgfoundry_1.diff, removes the suggestion to apply for new projects on pgfoundry. The

Re: [HACKERS] Oracle porting sample instr function

2012-07-04 Thread Albe Laurenz
Robert Haas wrote: I can confirm that Oracle returns 0 if the third argument to INSTR is 0. Can someone provide a suitable doc patch? Here you are. Yours, Laurenz Albe instr-doc.patch Description: instr-doc.patch -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Bug #6593, extensions, and proposed new patch policy

2012-07-04 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@commandprompt.com writes: Applied to master, 9.2 and 9.1. Thank you! Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] enhanced error fields

2012-07-04 Thread Pavel Stehule
Hello 2012/7/3 Matthew Woodcraft matt...@woodcraft.me.uk: Peter Geoghegan pe...@2ndquadrant.com writes: So I took a look at the patch eelog-2012-05-09.diff today. All of the following remarks apply to it alone. I've been trying out this patch for my own interest (I'm very pleased to see

Re: [HACKERS] pgsql_fdw in contrib

2012-07-04 Thread Shigeru HANADA
Hi Kaigai-san, Sorry for delayed reply. On Tue, Jun 26, 2012 at 10:50 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: * It seems to me expected results of the regression test is not attached, even though test cases were included. Please add it. AFAICS the patch I posted contains both test

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-04 Thread Boszormenyi Zoltan
2012-07-03 23:31 keltezéssel, Alvaro Herrera írta: Excerpts from Boszormenyi Zoltan's message of vie jun 29 14:30:28 -0400 2012: Does anyone have a little time to look at the latest timeout framework with the registration interface and the 2nd patch too? I am at work until Friday next week,

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-04 Thread Boszormenyi Zoltan
2012-07-04 12:09 keltezéssel, Boszormenyi Zoltan írta: 2012-07-03 23:31 keltezéssel, Alvaro Herrera írta: Excerpts from Boszormenyi Zoltan's message of vie jun 29 14:30:28 -0400 2012: Does anyone have a little time to look at the latest timeout framework with the registration interface and

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-04 Thread Boszormenyi Zoltan
2012-07-03 23:38 keltezéssel, Alvaro Herrera írta: I don't understand why PGSemaphoreTimedLock() is not broken. I mean surely you need a bool return to let the caller know whether the acquisition succeeded or failed? Well, this is the same interface PGSemaphoreTryLock() uses. By this

Re: [HACKERS] plpython issue with Win64 (PG 9.2)

2012-07-04 Thread Asif Naeem
Patch attached. Asif, could you try a few things on a CP1252 database? First verify if your original test case now works and then try this: I have test the patch on Win64. postgres server is working fine now for WIN1252. Thanks. create function enctest() returns text as $$ return

Re: [HACKERS] plpython issue with Win64 (PG 9.2)

2012-07-04 Thread Jan Urbański
On 04/07/12 13:58, Asif Naeem wrote: Patch attached. Asif, could you try a few things on a CP1252 database? First verify if your original test case now works and then try this: I have test the patch on Win64. postgres server is working fine now for WIN1252. Thanks. create function

Re: [HACKERS] Schema version management

2012-07-04 Thread Joel Jacobson
On Tue, Jul 3, 2012 at 7:49 PM, Peter Eisentraut pete...@gmx.net wrote: I think this idea has merit. Prepare a patch and put it into the next commit fest. Glad to hear, I'm on it! I see the problem that since the dump order is in general not deterministic, this will cause random

Re: [HACKERS] [ADMIN] pg_basebackup blocking all queries with horrible performance

2012-07-04 Thread Magnus Hagander
On Mon, Jul 2, 2012 at 8:17 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Jul 2, 2012 at 4:01 AM, Magnus Hagander mag...@hagander.net wrote: On Sun, Jul 1, 2012 at 7:14 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Jun 29, 2012 at 7:22 PM, Magnus Hagander mag...@hagander.net

Re: [HACKERS] pg_receivexlog and feedback message

2012-07-04 Thread Magnus Hagander
On Mon, Jun 11, 2012 at 5:24 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Jun 11, 2012 at 10:04 PM, Magnus Hagander mag...@hagander.net wrote: On Sun, Jun 10, 2012 at 4:02 PM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Jun 10, 2012 at 7:55 PM, Magnus Hagander mag...@hagander.net

Re: [HACKERS] pgfoundry references in docs

2012-07-04 Thread David E. Wheeler
On Jul 4, 2012, at 9:15 AM, Magnus Hagander wrote: Not really. We have nowhere else to recommend, since we don't run a replacement for it. And we really don't want to get involved in listing all the different third party sites out there. (For example, we had a reference to sourceforge.net in