Re: [HACKERS] New WAL code dumps core trivially on replay of bad data

2012-08-20 Thread Heikki Linnakangas
On 18.08.2012 08:52, Amit kapila wrote: Tom Lane Sent: Saturday, August 18, 2012 7:16 AM so it merrily tries to compute a checksum on a gigabyte worth of data, and soon falls off the end of memory. In reality, inspection of the WAL file suggests that this is the end of valid data and what

Re: [HACKERS] State of the on-disk bitmap index

2012-08-20 Thread Albe Laurenz
Daniel Bausch wrote: Hello Jonah, Simon, and the hackers, I am going to implement a simple kind of encoded bitmap indexes (EBI). That is an index type where the bitmap columns may not only contain only a single '1' in the set of bits belonging to a tuple. Instead, an additional mapping

[HACKERS] Primary Key Constraint on inheritance table not getting route to child tables

2012-08-20 Thread Rushabh Lathia
Hi, ALTER TABLE ADD Constraints PRIMARY KEY on inheritance table not getting route to child table. But when we do ALTER TABLE DROP Constraint on the same, it complains about constraint does not exists on child table. Consider the following example psql=# CREATE TABLE measurement ( psql(#

Re: [HACKERS] [PATCH] Docs: Make notes on sequences and rollback more obvious

2012-08-20 Thread Craig Ringer
Trying again with the attachments; the archiver only seemed to see the first patch despite all three being attached. Including patches inline; if you want 'em prettier, see: https://github.com/ringerc/postgres/tree/sequence_documentation_fixes Subject: [PATCH 1/3] Make sure you can't read

Re: [HACKERS] State of the on-disk bitmap index

2012-08-20 Thread Daniel Bausch
Am 20.08.2012 09:40, schrieb Albe Laurenz: Daniel Bausch wrote: Hello Jonah, Simon, and the hackers, I am going to implement a simple kind of encoded bitmap indexes (EBI). That is an index type where the bitmap columns may not only contain only a single '1' in the set of bits belonging to

Re: [HACKERS] State of the on-disk bitmap index

2012-08-20 Thread Daniel Bausch
Am 20.08.2012 11:44, schrieb Daniel Bausch: Actually, I was not involved in writing that paper. I want to use that idea to show something different. I know of a follow up work by Golam Rabilul Alam et al. that uses the query history and data mining on that to optimize for the most common

Re: [HACKERS] enhanced error fields

2012-08-20 Thread Pavel Stehule
Hello here is updated patch - merge comments, docs, formatting, some identifiers from Peter Geoghegan's patch Regards Pavel 2012/7/18 Pavel Stehule pavel.steh...@gmail.com: Hello * renamed erritem to err_generic_string * fixed CSVlog generation * new file /utils/error/relerror.c with

Re: [HACKERS] New WAL code dumps core trivially on replay of bad data

2012-08-20 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 18.08.2012 08:52, Amit kapila wrote: I think that missing check of total length has caused this problem. However now this check will be different. That check still exists, in ValidXLogRecordHeader(). However, we now allocate

Re: [HACKERS] New WAL code dumps core trivially on replay of bad data

2012-08-20 Thread Andres Freund
On Monday, August 20, 2012 04:04:52 PM Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 18.08.2012 08:52, Amit kapila wrote: I think that missing check of total length has caused this problem. However now this check will be different. That check still

[HACKERS] alter enum add value if not exists

2012-08-20 Thread Andrew Dunstan
Here is a patch for this feature, which should alleviate some of the woes caused by adding labels not being transactional (and thus not allowing for the catching of errors). (Also available on the add_enum_ine branch at https://bitbucket.org/adunstan/pgdevel) cheers andrew ***

Re: [HACKERS] New WAL code dumps core trivially on replay of bad data

2012-08-20 Thread Heikki Linnakangas
On 20.08.2012 17:04, Tom Lane wrote: Heikki Linnakangasheikki.linnakan...@enterprisedb.com writes: On 18.08.2012 08:52, Amit kapila wrote: I think that missing check of total length has caused this problem. However now this check will be different. That check still exists, in

Re: [HACKERS] New WAL code dumps core trivially on replay of bad data

2012-08-20 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 20.08.2012 17:04, Tom Lane wrote: Uh, no, you misread it. xl_tot_len is *zero* in this example. The problem is that RecordIsValid believes xl_len (and backup block size) even when it exceeds xl_tot_len. Ah yes, I see that

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-08-20 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On Sat, 2012-07-28 at 17:50 -0400, Tom Lane wrote: which would come back to bite us if we ever try to support index-only scans with SPGiST. I'm confused:

Re: [HACKERS] Avoiding repeated snapshot computation

2012-08-20 Thread Robert Haas
On Thu, Aug 16, 2012 at 9:02 PM, Bruce Momjian br...@momjian.us wrote: Did we ever make a decision on this patch? I committed it as 1fc3d18faa8f4476944bc6854be0f7f6adf4aec8. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers

Re: [HACKERS] Primary Key Constraint on inheritance table not getting route to child tables

2012-08-20 Thread Alvaro Herrera
Excerpts from Rushabh Lathia's message of lun ago 20 02:50:52 -0400 2012: Hi, ALTER TABLE ADD Constraints PRIMARY KEY on inheritance table not getting route to child table. But when we do ALTER TABLE DROP Constraint on the same, it complains about constraint does not exists on child

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Robert Haas
On Thu, Aug 16, 2012 at 12:17 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 16 August 2012 16:56, Bruce Momjian br...@momjian.us wrote: Good to know. We only use pgrminclude very five years or so, and Tom isn't even keen on that. Yeah. Even if this could be made to work well, we'd still

Re: [HACKERS] Primary Key Constraint on inheritance table not getting route to child tables

2012-08-20 Thread Tom Lane
Rushabh Lathia rushabh.lat...@gmail.com writes: ALTER TABLE ADD Constraints PRIMARY KEY on inheritance table not getting route to child table. Right. But when we do ALTER TABLE DROP Constraint on the same, it complains about constraint does not exists on child table. Works for me in HEAD.

Re: [HACKERS] Unexpected plperl difference between 8.4 and 9.1

2012-08-20 Thread Alex Hunsaker
On Sun, Aug 19, 2012 at 2:26 PM, Joel Jacobson j...@trustly.com wrote: After upgrading from 8.4 to 9.1, one of my plperl functions stopped working properly. For some reason, when matching a string using a regex, the $1 variable cannot be returned directly using return_next() but must be set

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Alvaro Herrera
Excerpts from Robert Haas's message of lun ago 20 11:43:44 -0400 2012: I actually think we'd probably be better off running pgrminclude once per release cycle rather than any less often. When the number of changes gets into the hundreds or thousands of lines it becomes much more difficult to

Re: [HACKERS] bug of pg_trgm?

2012-08-20 Thread Fujii Masao
On Sat, Aug 11, 2012 at 8:15 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: No. ISTM that in_wildcard_meta must be reset before the second loop. Because the meaning of that flag in the first loop is different from that in the second loop. The former and the

Re: [HACKERS] Unexpected plperl difference between 8.4 and 9.1

2012-08-20 Thread Alvaro Herrera
Excerpts from Alex Hunsaker's message of lun ago 20 12:03:11 -0400 2012: On Sun, Aug 19, 2012 at 2:26 PM, Joel Jacobson j...@trustly.com wrote: After upgrading from 8.4 to 9.1, one of my plperl functions stopped working properly. For some reason, when matching a string using a regex,

Re: [HACKERS] New WAL code dumps core trivially on replay of bad data

2012-08-20 Thread Heikki Linnakangas
On 20.08.2012 18:25, Tom Lane wrote: Heikki Linnakangasheikki.linnakan...@enterprisedb.com writes: I was thinking that we might read gigabytes worth of bogus WAL into the memory buffer, if xl_tot_len is bogus and large, e.g 0x. But now that I look closer, the xlog record is validated

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Aug 16, 2012 at 12:17 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: Yeah. Even if this could be made to work well, we'd still have to do something like get an absolute consensus from all build farm animals, if we expected to have an

Re: [HACKERS] Unexpected plperl difference between 8.4 and 9.1

2012-08-20 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Excerpts from Alex Hunsaker's message of lun ago 20 12:03:11 -0400 2012: Hrm seems to work for me. What version of perl is this? $ perl -V Summary of my perl5 (revision 5 version 16 subversion 0) configuration: I can reproduce the failure with

Re: [HACKERS] Primary Key Constraint on inheritance table not getting route to child tables

2012-08-20 Thread Rushabh Lathia
On Mon, Aug 20, 2012 at 9:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: Rushabh Lathia rushabh.lat...@gmail.com writes: ALTER TABLE ADD Constraints PRIMARY KEY on inheritance table not getting route to child table. Right. But when we do ALTER TABLE DROP Constraint on the same, it complains

Re: [HACKERS] gistchoose vs. bloat

2012-08-20 Thread Alexander Korotkov
On Mon, Aug 20, 2012 at 7:13 AM, Jeff Davis pg...@j-davis.com wrote: I took a look at this patch. The surrounding code is pretty messy (not necessarily because of your patch). A few comments would go a long way. The 'which_grow' array is initialized as it goes, first using pointer notations

Re: [HACKERS] bug of pg_trgm?

2012-08-20 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: OK. Attached patch fixes the problem as you suggested, i.e., it backs up endword if the second loop exits in an escape pair. Applied with a bit of further adjustment of the comments. Thanks! regards, tom lane -- Sent via

Re: [HACKERS] Rules and WITH and LATERAL

2012-08-20 Thread Martijn van Oosterhout
On Sun, Aug 19, 2012 at 12:06:30PM -0400, Tom Lane wrote: While thinking about this I wondered whether it might be possible to clean up the implementation of rules, and perhaps also get rid of some of their semantic issues, by making the rule rewriter rely on WITH and/or LATERAL, neither of

Re: [HACKERS] SERIAL columns in foreign tables

2012-08-20 Thread Robert Haas
On Fri, Aug 17, 2012 at 10:53 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: However I'm wondering if it'd be better to tweak the code to explicitely check for SERIAL/BIGSERIAL instead of letting it error out in internal conditions. The way it currently is, it seems a bit user-unfriendly

Re: [HACKERS] TRUE/FALSE vs true/false

2012-08-20 Thread Robert Haas
On Thu, Aug 16, 2012 at 3:32 PM, Bruce Momjian br...@momjian.us wrote: On Thu, Aug 16, 2012 at 02:21:12PM -0500, Kevin Grittner wrote: Bruce Momjian br...@momjian.us wrote: So what do we want to do with this? I am a little concerned that we are sacrificing code clarity for backpatching

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Josh Berkus
On 8/15/12 6:48 AM, Tom Lane wrote: The argument against moving crypto code into core remains the same as it was, ie export regulations. I don't see that that situation has changed at all. Actually, I believe that it has, based on my experience getting an export certificate for Sun Postgres

Re: [HACKERS] Timing overhead and Linux clock sources

2012-08-20 Thread Robert Haas
On Thu, Aug 16, 2012 at 10:28 PM, Bruce Momjian br...@momjian.us wrote: FYI, I am planning to go ahead and package this tool in /contrib for PG 9.3. Isn't this exactly what we already did, in 9.2, in the form of contrib/pg_test_timing? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2012-08-20 Thread Robert Haas
On Thu, Aug 16, 2012 at 9:05 PM, Bruce Momjian br...@momjian.us wrote: A TODO for this? You mean this part? On the other hand, the problem of the FSM taking up 24kB for an 8kB table seems clearly worth fixing, but I don't think I have the cycles for it at present. Maybe a TODO is in order.

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Robert Haas
On Mon, Aug 20, 2012 at 12:03 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Excerpts from Robert Haas's message of lun ago 20 11:43:44 -0400 2012: I actually think we'd probably be better off running pgrminclude once per release cycle rather than any less often. When the number of

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Andrew Dunstan
On 08/20/2012 03:10 PM, Josh Berkus wrote: On 8/15/12 6:48 AM, Tom Lane wrote: The argument against moving crypto code into core remains the same as it was, ie export regulations. I don't see that that situation has changed at all. Actually, I believe that it has, based on my experience

Re: [HACKERS] NOT NULL constraints in foreign tables

2012-08-20 Thread Robert Haas
On Fri, Aug 17, 2012 at 4:08 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Excerpts from Robert Haas's message of vie ago 17 15:44:29 -0400 2012: On Fri, Aug 17, 2012 at 2:58 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I mean, what are NOT NULL in foreign tables for? Are they

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Robert Haas
On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to change the output of a boolean value in psql much like you can do with NULL. A client requested this feature and we thought it may appeal to someone else in the community. The patch

Re: [HACKERS] NOT NULL constraints in foreign tables

2012-08-20 Thread Jeff Davis
On Fri, 2012-08-17 at 15:44 -0400, Robert Haas wrote: On Fri, Aug 17, 2012 at 2:58 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I mean, what are NOT NULL in foreign tables for? Are they harmed or helped by having pg_constraint rows? As I've mentioned when this has come up before, I

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Josh Berkus
I don't think US export regulations are the only issue. Some other countries (mostly the usual suspects) forbid the use of crypto software. If we build more crypto functions into the core we make it harder to use Postgres legally in those places. Again, that sounds like we need an actual

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Joshua D. Drake
On 08/20/2012 01:21 PM, Josh Berkus wrote: I don't think US export regulations are the only issue. Some other countries (mostly the usual suspects) forbid the use of crypto software. If we build more crypto functions into the core we make it harder to use Postgres legally in those places.

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2012-08-20 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On the other hand, the problem of the FSM taking up 24kB for an 8kB table seems clearly worth fixing, but I don't think I have the cycles for it at present. Maybe a TODO is in order. I certainly think that'd be worth a TODO. Whether the rest of this

Re: [HACKERS] Tab completion for DROP CONSTRAINT

2012-08-20 Thread Robert Haas
On Sun, Aug 19, 2012 at 4:43 PM, Jeff Janes jeff.ja...@gmail.com wrote: Interactively dropping primary key constraints has been annoying me. I believe this patch fixes that, hopefully for other kinds of cataloged constraints as well. Committed, thanks. -- Robert Haas EnterpriseDB:

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Andrew Dunstan
On 08/20/2012 04:26 PM, Joshua D. Drake wrote: On 08/20/2012 01:21 PM, Josh Berkus wrote: I don't think US export regulations are the only issue. Some other countries (mostly the usual suspects) forbid the use of crypto software. If we build more crypto functions into the core we make it

Re: [HACKERS] CLUSTER VERBOSE tab completion

2012-08-20 Thread Robert Haas
On Sun, Aug 19, 2012 at 4:55 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Fri, Aug 17, 2012 at 7:18 PM, Jeff Janes jeff.ja...@gmail.com wrote: tab completion will add USING after CLUSTER VERBOSE, as if VERBOSE were the name of a table. Instead of just making it not do the wrong thing, I

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2012-08-20 Thread Robert Haas
On Mon, Aug 20, 2012 at 4:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On the other hand, the problem of the FSM taking up 24kB for an 8kB table seems clearly worth fixing, but I don't think I have the cycles for it at present. Maybe a TODO is in order.

Re: [HACKERS] NOT NULL constraints in foreign tables

2012-08-20 Thread Robert Haas
On Mon, Aug 20, 2012 at 3:56 PM, Jeff Davis pg...@j-davis.com wrote: On Fri, 2012-08-17 at 15:44 -0400, Robert Haas wrote: On Fri, Aug 17, 2012 at 2:58 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I mean, what are NOT NULL in foreign tables for? Are they harmed or helped by having

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Joshua D. Drake
On 08/20/2012 01:33 PM, Andrew Dunstan wrote: But there is absolutely no evidence that we are making it less useful. Postgres is designed top be extensible and we've just enhanced that. pgcrypto makes use of that. If we cen leverage that to make Postgres available to more people then why would

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Peter Geoghegan
On 20 August 2012 21:26, Joshua D. Drake j...@commandprompt.com wrote: On 08/20/2012 01:21 PM, Josh Berkus wrote: I don't think US export regulations are the only issue. Some other countries (mostly the usual suspects) forbid the use of crypto software. If we build more crypto functions

Re: [HACKERS] temporal support patch

2012-08-20 Thread Robert Haas
On Sun, Aug 19, 2012 at 6:28 PM, Jeff Davis pg...@j-davis.com wrote: The other issue is how to handle multiple changes of the same record within the transaction. Should they be stored or not? In a typical audit log, I don't see any reason to. The internals of a transaction should be

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Pavel Stehule
2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to change the output of a boolean value in psql much like you can do with NULL. A client requested this feature and we thought it may appeal to

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Aug 20, 2012 5:11 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to change the output of a boolean value in psql much like you can do

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Aug 20, 2012 5:19 PM, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:11 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Thom Brown
On 20 August 2012 22:10, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to change the output of a boolean value in psql much like you can do with

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Thom Brown
On 20 August 2012 22:31, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:19 PM, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:11 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Pavel Stehule
2012/8/20 Thom Brown t...@linux.com: On 20 August 2012 22:10, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to change the output of a boolean

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Aug 20, 2012 5:56 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 22:31, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:19 PM, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:11 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Thom Brown
On 20 August 2012 23:06, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:56 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 22:31, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:19 PM, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:11 PM, Pavel Stehule

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Gurjeet Singh
On Mon, Aug 20, 2012 at 5:54 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 22:10, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/20 Robert Haas robertmh...@gmail.com: On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber p...@omniti.com wrote: I am providing a patch to allow you to

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Aug 20, 2012 6:08 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 23:06, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:56 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 22:31, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:19 PM, Phil Sorber

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Kevin Grittner
Gurjeet Singh singh.gurj...@gmail.com wrote: On occasions I have wanted psql to emit the full 'True'/'False' words instead of cryptic one-letter t/f, which can get lost on long rows that get wrapped around on screen. Writing long-winded CASE expressions to get the effect is too much for

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Thom Brown
On 20 August 2012 23:16, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 6:08 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 23:06, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:56 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 22:31, Phil Sorber

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Aug 20, 2012 6:28 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Gurjeet Singh singh.gurj...@gmail.com wrote: On occasions I have wanted psql to emit the full 'True'/'False' words instead of cryptic one-letter t/f, which can get lost on long rows that get wrapped around on

Re: [HACKERS] Large number of open(2) calls with bulk INSERT into empty table

2012-08-20 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Aug 20, 2012 at 4:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Surely we could just prevent creation of the FSM until the table has reached at least, say, 10 blocks. Any threshold beyond one block would mean potential space wastage, but it's

[HACKERS] Outdated Japanse developers FAQ

2012-08-20 Thread Tatsuo Ishii
Please let me know if this is not the right place to ask this kind of queston. PostgreSQL Developers FAQ in Japanese: http://wiki.postgresql.org/wiki/Developer_FAQ/ja looks pretty outdated. It was last updated on 7 November 2010 (English FAQ was last updated on 27 September 2011). Even it says

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 If the hacker has access to the salt, then it will only slow him/her down somewhat because the search will be have to be restarted for each password. This. Further, anyone using MD5 or SHA* or any hash function for any serious storage of

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Aug 20, 2012 6:31 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 23:16, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 6:08 PM, Thom Brown t...@linux.com wrote: On 20 August 2012 23:06, Phil Sorber p...@omniti.com wrote: On Aug 20, 2012 5:56 PM, Thom Brown

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On 08/20/2012 01:33 PM, Andrew Dunstan wrote: But there is absolutely no evidence that we are making it less useful. Postgres is designed top be extensible and we've just enhanced that. pgcrypto makes use of that. If we cen leverage that to make

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Tatsuo Ishii
On Aug 20, 2012 6:28 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Gurjeet Singh singh.gurj...@gmail.com wrote: On occasions I have wanted psql to emit the full 'True'/'False' words instead of cryptic one-letter t/f, which can get lost on long rows that get wrapped around on

Re: [HACKERS] temporal support patch

2012-08-20 Thread David Johnston
-Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers- ow...@postgresql.org] On Behalf Of Robert Haas Sent: Monday, August 20, 2012 5:04 PM To: Jeff Davis Cc: Vlad Arkhipov; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] temporal support patch On

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: The type itself does output true/false; it's just psql that uses t/f. No, 't'/'f' is what boolout() returns. The 'true'/'false' results from casting bool to text are intentionally different --- IIRC, Peter E. argued successfully that this cast

Re: [HACKERS] temporal support patch

2012-08-20 Thread Josh Berkus
On 8/20/12 4:17 PM, David Johnston wrote: The issue with adding the PostgreSQL role to the database in this way is that you now can never delete that role or reassign it to another entity. I guess with temporal you could do so and basically have the identity-role relationship define over

Re: [HACKERS] Outdated Japanse developers FAQ

2012-08-20 Thread Fujii Masao
On Tue, Aug 21, 2012 at 7:49 AM, Tatsuo Ishii is...@postgresql.org wrote: Please let me know if this is not the right place to ask this kind of queston. PostgreSQL Developers FAQ in Japanese: http://wiki.postgresql.org/wiki/Developer_FAQ/ja looks pretty outdated. It was last updated on 7

Re: [HACKERS] Outdated Japanse developers FAQ

2012-08-20 Thread Tatsuo Ishii
On Tue, Aug 21, 2012 at 7:49 AM, Tatsuo Ishii is...@postgresql.org wrote: Please let me know if this is not the right place to ask this kind of queston. PostgreSQL Developers FAQ in Japanese: http://wiki.postgresql.org/wiki/Developer_FAQ/ja looks pretty outdated. It was last updated on 7

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Andrew Dunstan
On 08/20/2012 07:08 PM, Tom Lane wrote: Moreover, as Josh just mentioned, anybody who thinks it might be insufficiently secure for their purposes has got plenty of alternatives available today (SSL certificates, PAM backed by whatever-you-want, etc). Yeah, I think we need to emphasize this

Re: [HACKERS] temporal support patch

2012-08-20 Thread Kevin Grittner
Josh Berkus j...@agliodbs.com wrote: This is sounding like a completely runaway spec on what should be a simple feature. I hate to contribute to scope creep (or in this case scope screaming down the tracks at full steam), but I've been watching this with a queasy feeling about interaction

Re: [HACKERS] sha1, sha2 functions into core?

2012-08-20 Thread Joshua D. Drake
On 08/20/2012 05:12 PM, Andrew Dunstan wrote: On 08/20/2012 07:08 PM, Tom Lane wrote: Moreover, as Josh just mentioned, anybody who thinks it might be insufficiently secure for their purposes has got plenty of alternatives available today (SSL certificates, PAM backed by whatever-you-want,

[HACKERS] TODO

2012-08-20 Thread Tatsuo Ishii
I found this in https://wiki.postgresql.org/wiki/Todo : Improve ability to display optimizer analysis using OPTIMIZER_DEBUG What does this actually mean? Add GUC switch to enable optimizer debug on/off? More fancy/useful info should be printed? If so, what kind of information is required? --

Re: [HACKERS] PATCH: psql boolean display

2012-08-20 Thread Phil Sorber
On Mon, Aug 20, 2012 at 7:19 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: The type itself does output true/false; it's just psql that uses t/f. No, 't'/'f' is what boolout() returns. The 'true'/'false' results from casting bool to text are

Re: [HACKERS] temporal support patch

2012-08-20 Thread Jeff Davis
On Mon, 2012-08-20 at 17:04 -0400, Robert Haas wrote: On Sun, Aug 19, 2012 at 6:28 PM, Jeff Davis pg...@j-davis.com wrote: The other issue is how to handle multiple changes of the same record within the transaction. Should they be stored or not? In a typical audit log, I don't see any

Re: [HACKERS] temporal support patch

2012-08-20 Thread Jeff Davis
On Mon, 2012-08-20 at 19:17 -0400, David Johnston wrote: Ideally the decision of whether to do so could be a client decision. Not storing intra-transaction changes is easier than storing all changes. At worse you could stage up all changed then simply fail to store all intermediate results

Re: [HACKERS] temporal support patch

2012-08-20 Thread Jeff Davis
On Mon, 2012-08-20 at 16:32 -0700, Josh Berkus wrote: This is sounding like a completely runaway spec on what should be a simple feature. My feeling as well. However, we will eventually want to coalesce around some best practices and make it easy and robust for typical cases. Personally, I

Re: [HACKERS] temporal support patch

2012-08-20 Thread Jeff Davis
On Mon, 2012-08-20 at 19:32 -0500, Kevin Grittner wrote: Josh Berkus j...@agliodbs.com wrote: This is sounding like a completely runaway spec on what should be a simple feature. I hate to contribute to scope creep (or in this case scope screaming down the tracks at full steam), but

Re: [HACKERS] temporal support patch

2012-08-20 Thread Craig Ringer
On 08/21/2012 12:52 PM, Jeff Davis wrote: On Mon, 2012-08-20 at 16:32 -0700, Josh Berkus wrote: This is sounding like a completely runaway spec on what should be a simple feature. My feeling as well. However, we will eventually want to coalesce around some best practices and make it easy and

Re: [HACKERS] NOT NULL constraints in foreign tables

2012-08-20 Thread Jeff Davis
On Mon, 2012-08-20 at 16:50 -0400, Robert Haas wrote: #3 for foreign tables. I'm skeptical of that approach for two reasons: (1) It will be hard to inform users which constraints are enforced and which aren't. (2) It will be hard for users to understand the planner benefits or the consequences

Re: [HACKERS] temporal support patch

2012-08-20 Thread Craig Ringer
On 08/21/2012 12:52 PM, Jeff Davis wrote: On Mon, 2012-08-20 at 16:32 -0700, Josh Berkus wrote: This is sounding like a completely runaway spec on what should be a simple feature. My feeling as well. However, we will eventually want to coalesce around some best practices and make it easy and