[HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-09-15 Thread Amit kapila
On Sunday, September 16, 2012 12:14 AM Fujii Masao wrote: On Sat, Sep 15, 2012 at 4:26 PM, Amit kapila wrote: > On Saturday, September 15, 2012 11:27 AM Fujii Masao wrote: > On Fri, Sep 14, 2012 at 10:01 PM, Amit kapila wrote: >> >> On Thursday, September 13, 2012 10:57 PM Fujii Masao >> On Thu,

Re: [HACKERS] _FORTIFY_SOURCE by default?

2012-09-15 Thread Tom Lane
Peter Eisentraut writes: > _FORTIFY_SOURCE=2 appears to be the default for package building on many > Linux distributions now, as part of harding or security options. But we > often hear about problems related to this only when we hand the source > over to the packagers. So I think we might as w

Re: [HACKERS] Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries.

2012-09-15 Thread Tom Lane
Robert Haas writes: > On Sep 15, 2012, at 11:29 AM, Tom Lane wrote: >> This is only an issue on standby slaves or when doing a PITR recovery, no? >> As far as I can tell from the discussion, it would *not* affect crash >> recovery, because we don't do restartpoints during crash recovery. > No, I

Re: [HACKERS] Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries.

2012-09-15 Thread Robert Haas
On Sep 15, 2012, at 11:29 AM, Tom Lane wrote: > Robert Haas writes: >> Definitions aside, I think it's a pretty scary issue. It basically means >> that if you have a recovery (crash or archive) during which you read a >> buffer into memory, the buffer won't be checkpointed. So if, before the

[HACKERS] _FORTIFY_SOURCE by default?

2012-09-15 Thread Peter Eisentraut
_FORTIFY_SOURCE=2 appears to be the default for package building on many Linux distributions now, as part of harding or security options. But we often hear about problems related to this only when we hand the source over to the packagers. So I think we might as well add this to our standard compi

Re: [HACKERS] [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries.

2012-09-15 Thread Andres Freund
On Saturday, September 15, 2012 06:29:25 PM Tom Lane wrote: > Robert Haas writes: > > Definitions aside, I think it's a pretty scary issue. It basically means > > that if you have a recovery (crash or archive) during which you read a > > buffer into memory, the buffer won't be checkpointed. So if

Re: [HACKERS] [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-09-15 Thread Fujii Masao
On Sat, Sep 15, 2012 at 4:26 PM, Amit kapila wrote: > On Saturday, September 15, 2012 11:27 AM Fujii Masao wrote: > On Fri, Sep 14, 2012 at 10:01 PM, Amit kapila wrote: >> >> On Thursday, September 13, 2012 10:57 PM Fujii Masao >> On Thu, Sep 13, 2012 at 1:22 PM, Amit Kapila wrote: >>> On Wednes

Re: [HACKERS] embedded list v2

2012-09-15 Thread Tom Lane
Andres Freund writes: > On Saturday, September 15, 2012 07:32:45 AM Tom Lane wrote: >> Well, actually, that just brings us to the main point which is: I do not >> believe that circular links are a good design choice here. > I think I have talked about the reasoning on the list before, but here it

Re: [HACKERS] Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries.

2012-09-15 Thread Tom Lane
Robert Haas writes: > Definitions aside, I think it's a pretty scary issue. It basically means that > if you have a recovery (crash or archive) during which you read a buffer into > memory, the buffer won't be checkpointed. So if, before the buffer is next > evicted, you have a crash, and if a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries.

2012-09-15 Thread Robert Haas
On Sep 14, 2012, at 12:17 PM, Simon Riggs wrote: > The bug itself is not major, but the extent and user impact is serious. I don't think I understand how you're using the word major there. I seem to recall some previous disputation between you and I about the use of that term, so maybe it woul

Re: [HACKERS] git tree

2012-09-15 Thread Andres Freund
On Saturday, September 15, 2012 03:14:32 AM Andres Freund wrote: > That branch will be regularly rebased to a new master,fixes/new features, > and a pgindent run over the new files... I fixed up the formatting of the new stuff (xlogreader, ilist are submitted separately, no point in doing anything

Re: [HACKERS] embedded list v2

2012-09-15 Thread Andres Freund
Hi Tom, On Saturday, September 15, 2012 07:32:45 AM Tom Lane wrote: > Andres Freund writes: > > On Friday, September 14, 2012 10:48:35 PM Tom Lane wrote: > >> Instead let's provide a macro for an empty list value, so that you can > >> do something like > >> static ilist_d_head DatabaseList = EMPT

FW: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2012-09-15 Thread Amit kapila
Sorry, earlier sent below mail on hackers instead of bugs list. Just forwarding the same here. From: pgsql-hackers-ow...@postgresql.org [pgsql-hackers-ow...@postgresql.org] on behalf of Amit kapila [amit.kap...@huawei.com] Sent: Friday, September 14, 201

[HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-09-15 Thread Amit kapila
On Saturday, September 15, 2012 11:27 AM Fujii Masao wrote: On Fri, Sep 14, 2012 at 10:01 PM, Amit kapila wrote: > > On Thursday, September 13, 2012 10:57 PM Fujii Masao > On Thu, Sep 13, 2012 at 1:22 PM, Amit Kapila wrote: >> On Wednesday, September 12, 2012 10:15 PM Fujii Masao >> On Wed, Sep 1