[HACKERS] Check if trigger was fired deferred

2013-02-27 Thread Miroslav Šimulčík
Hi all, how can I check inside C trigger function if it was fired deferred? Thank you. Regards, Miro

Re: [HACKERS] Check if trigger was fired deferred

2013-02-27 Thread Szymon Guz
On 27 February 2013 10:20, Miroslav Šimulčík simulcik.m...@gmail.comwrote: Hi all, how can I check inside C trigger function if it was fired deferred? Thank you. Regards, Miro I'd try tgdeferrable from Trigger struct: http://www.postgresql.org/docs/9.2/static/trigger-interface.html

Re: [HACKERS] Review : Add hooks for pre- and post-processor executables for COPY and \copy

2013-02-27 Thread Etsuro Fujita
Hi, Thank you for the work! From: Amit Kapila [mailto:amit.kap...@huawei.com] On Wednesday, February 27, 2013 12:41 AM Heikki Linnakangas wrote: There's one oddity in the psql \copy syntax. This is actually present in earlier versions too, but I think we should fix it now that we

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Boszormenyi Zoltan
2013-02-27 04:06 keltezéssel, Stephen Frost írta: Zoltan, * Boszormenyi Zoltan (z...@cybertec.at) wrote: attached is v30, I hope with everything fixed. Making progress, certainly. Given the hack to the API of enable_timeout_after() and the need for timeout_reset_base_time(), I'm just going

Re: [HACKERS] Check if trigger was fired deferred

2013-02-27 Thread Miroslav Šimulčík
I think tgdeferrable only tells if trigger can be deferred, not if it was actually fired deferred. Miro 2013/2/27 Szymon Guz mabew...@gmail.com On 27 February 2013 10:20, Miroslav Šimulčík simulcik.m...@gmail.comwrote: Hi all, how can I check inside C trigger function if it was fired

Re: [HACKERS] pg_xlogdump compiler warning

2013-02-27 Thread Andres Freund
On 2013-02-26 15:52:01 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote: compat.c: In function ‘timestamptz_to_str’: compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror]

Re: [HACKERS] backup.sgml patch that adds information on custom format backups

2013-02-27 Thread Ivan Lezhnjov IV
Alright gentlemen here we go, take two. backup.sgml-cmd-v002.patch addresses your feedback and offers a better worded statements that avoid implying that some features are being deprecated when it isn't the case. We also spent some more time polishing other details, like making adjustments to

Re: [HACKERS] COPY foo FROM STDOUT and ecpg

2013-02-27 Thread Michael Meskes
On Tue, Feb 26, 2013 at 07:24:44PM +0200, Heikki Linnakangas wrote: IIRC this check was added because the check for COPY FROM STDIN had to added anyway. Since you left that one in, the patch is fine by me, although I still don't see a reason for it. Just less code to maintain. And it's

[HACKERS] Re: [COMMITTERS] pgsql: Fix pg_dumpall with database names containing =

2013-02-27 Thread Heikki Linnakangas
On 27.02.2013 11:52, Thom Brown wrote: Once I'm in that database, I can't switch user from within psql: 8=8=# \c - moo invalid connection option 8 Previous connection kept Hmm, true. Also, any other connection options you specified in the original connection string are lost. For example, if

Re: [HACKERS] Review : Add hooks for pre- and post-processor executables for COPY and \copy

2013-02-27 Thread Heikki Linnakangas
On 27.02.2013 08:32, Amit Kapila wrote: If there is semicolon at end, it takes it into account for creating filename. \copy foo to c:\data\foo.out; This problem was fixed in previous patch, but I think handling of quotes has changed this behavior. This is existing behavior, that creates a file

[HACKERS] Broken link in contrib/fuzzystrmatch/dmetaphone.c

2013-02-27 Thread Albe Laurenz
The comment says: [...] and the original article describing it can be found at http://www.cuj.com/documents/s=8038/cuj0006philips/ This link does not work any more. I tried a web search for a replacement and came up with this: http://drdobbs.com/184401251 If that link points to the same

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: this is not hard task, hard task is correct identification related function see FuncnameGetCandidates() function We're not limited to writing C code here though and I think we've already solved it, though I admit it wasn't where I

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Stephen Frost
* Boszormenyi Zoltan (z...@cybertec.at) wrote: But unlike statement_timeout, with lock_timeout_stmt the statement can still finish after this limit as it does useful work besides waiting for locks. It's still entirely possible to get 99% done and then hit that last tuple that you need a lock

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Pavel Stehule
2013/2/27 Stephen Frost sfr...@snowman.net: Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: this is not hard task, hard task is correct identification related function see FuncnameGetCandidates() function We're not limited to writing C code here though and I think we've already

Re: [HACKERS] Review : Add hooks for pre- and post-processor executables for COPY and \copy

2013-02-27 Thread Heikki Linnakangas
On 27.02.2013 11:38, Etsuro Fujita wrote: Agreed. ISTM that the comment on parse_slash_copy() needs to be changed: * table name can be double-quoted and can have a schema part. * column names can be double-quoted. * filename can be single-quoted like SQL literals. * command can be

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: this autocomplete routine doesn't know type synonyms so you cannot use int, varchar, ... :( Yes, I covered that and it's perfectly fine, imv. Results from tab-completion and from \df output should work just fine. '\df myfunc(int)'

[HACKERS] Typo in usage of pg_xlogdump

2013-02-27 Thread Fujii Masao
Hi, The attached patch fixes the typo in help message of pg_xlogdump. Regards, -- Fujii Masao pg_xlogdump_usage_typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Pavel Stehule
2013/2/27 Stephen Frost sfr...@snowman.net: Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: this autocomplete routine doesn't know type synonyms so you cannot use int, varchar, ... :( Yes, I covered that and it's perfectly fine, imv. Results from tab-completion and from \df

Re: [HACKERS] pg_basebackup caused FailedAssertion

2013-02-27 Thread Heikki Linnakangas
On 26.02.2013 19:42, Tom Lane wrote: Fujii Masaomasao.fu...@gmail.com writes: In HEAD, when I ran pg_basebackup -D hoge -X stream, I got the following FailedAssertion error: TRAP: FailedAssertion(!((wakeEvents ((1 1) | (1 2))) != (1 2)), File: pg_latch.c, Line: 234) This error happens

[HACKERS] isolation test problem with MSVC (VC2012) / Windows 8

2013-02-27 Thread Andrew Dunstan
My VC2012 / Windows 8 buildfarm member bowerbird is having frequent problems with running the isolation tests. The symptom is that one or more output files don't seem to be flushed properly to disk. The odd thing is that the Mingw buildfarm member jacana I have on the same machine is having

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Stephen Frost
* Pavel Stehule (pavel.steh...@gmail.com) wrote: we cannot use autocomplete or if we use, then more precious code is on server side still - everywhere where function autocomplete is used, then function signature is reparesed again on server side. This doesn't make any sense to me. We should

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: Tom, can you comment on your thoughts around this notion of an aggregate time constraint for waiting on locks? As mentioned upthread, I like the idea of having an upper-limit on waiting for relation-level locks, but once you're past that, I'm not sure

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Pavel Stehule
2013/2/27 Stephen Frost sfr...@snowman.net: * Pavel Stehule (pavel.steh...@gmail.com) wrote: we cannot use autocomplete or if we use, then more precious code is on server side still - everywhere where function autocomplete is used, then function signature is reparesed again on server side.

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: I think anything that makes this patch simpler is a good idea. I don't like any of the accum_time stuff: it complicates the timeout API unreasonably and slows down existing use cases. Right, I think we're on the same page there- I had just commented to

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Stephen Frost
* Pavel Stehule (pavel.steh...@gmail.com) wrote: autocomplete send a SQL query in every iteration to server - so it is not any new overhead. And if we should to write some smarted routine, then I prefer server side due better reusability and better exception processing than psql environment -

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Pavel Stehule
2013/2/27 Stephen Frost sfr...@snowman.net: * Pavel Stehule (pavel.steh...@gmail.com) wrote: autocomplete send a SQL query in every iteration to server - so it is not any new overhead. And if we should to write some smarted routine, then I prefer server side due better reusability and better

Re: [HACKERS] isolation test problem with MSVC (VC2012) / Windows 8

2013-02-27 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: My VC2012 / Windows 8 buildfarm member bowerbird is having frequent problems with running the isolation tests. I've been wondering what's going on there. The symptom is that one or more output files don't seem to be flushed properly to disk. The

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Boszormenyi Zoltan
2013-02-27 19:07 keltezéssel, Tom Lane írta: Stephen Frost sfr...@snowman.net writes: Tom, can you comment on your thoughts around this notion of an aggregate time constraint for waiting on locks? As mentioned upthread, I like the idea of having an upper-limit on waiting for relation-level

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Stephen Frost
Zoltan, * Boszormenyi Zoltan (z...@cybertec.at) wrote: If we get rid of the per-statement variant, there is no need for that either. For my 2c, I didn't see Tom's comments as saying that we shouldn't have that capability, just that the implementation was ugly. :) That said, perhaps we should

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-27 Thread Stephen Frost
* Pavel Stehule (pavel.steh...@gmail.com) wrote: I don't agree so it works well - you cannot use short type names is significant issue This is for psql. In what use-case do you see that being a serious limitation? I might support having psql be able to fall-back to checking if the function

Re: [HACKERS] Typo in usage of pg_xlogdump

2013-02-27 Thread Heikki Linnakangas
On 27.02.2013 19:23, Fujii Masao wrote: Hi, The attached patch fixes the typo in help message of pg_xlogdump. Thanks, applied. There was a similar typo in the parse error message of -s, fixed that too. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-02-27 Thread Boszormenyi Zoltan
2013-02-27 20:06 keltezéssel, Stephen Frost írta: Zoltan, * Boszormenyi Zoltan (z...@cybertec.at) wrote: If we get rid of the per-statement variant, there is no need for that either. For my 2c, I didn't see Tom's comments as saying that we shouldn't have that capability, just that the

[HACKERS] Database system identifier via SELECT

2013-02-27 Thread Craig Ringer
Regarding these prior threads: http://www.postgresql.org/message-id/cac2surjlmtkyvcs6dbxdyurhy+wke-94cbugnwcxag914cw...@mail.gmail.com http://www.postgresql.org/message-id/200707101624.47885.pete...@gmx.net It's somewhat less than pretty, but you *can* simply: select

[HACKERS] issue with cpluspluscheck and systemtap

2013-02-27 Thread Peter Eisentraut
Newer versions of systemtap have some C++ code in their sys/sdt.h header file (guarded by #ifdef __cpluplus). cpluspluscheck ends up wrapping all of that into extern C { ... }, which ultimately results in In file included from ./src/include/utils/probes.h:9:0, from

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-27 Thread Michael Paquier
Andres, Masao, do you need an extra round or review or do you think this is ready to be marked as committer? On my side I have nothing more to add to the existing patches. Thanks, -- Michael

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-27 Thread anara...@anarazel.de
Hi, Michael Paquier michael.paqu...@gmail.com schrieb: Andres, Masao, do you need an extra round or review or do you think this is ready to be marked as committer? On my side I have nothing more to add to the existing patches. I think they do need review before that - I won't be able to do