Re: [HACKERS] stored procedures

2013-04-16 Thread aasat
Is stored procedures planned in future? I think is a most missing future today in Postgres. Using a dblink to emulate commit in transaction is very complicated -- View this message in context: http://postgresql.1045698.n5.nabble.com/stored-procedures-tp4331060p5752274.html Sent from the

Re: [HACKERS] stored procedures

2013-04-16 Thread Pavel Stehule
Hello 2013/4/16 aasat satri...@veranet.pl Is stored procedures planned in future? I think is a most missing future today in Postgres. It is in ToDo, but nobody working on this feature in this moment, probably. Using a dblink to emulate commit in transaction is very complicated

[HACKERS] [PATCH] Add \ns command to psql

2013-04-16 Thread Colin 't Hart
Hi, Here's a new version of a small patch to psql I'm using locally. It adds a command \ns to psql which is a shortcut to set the SEARCH_PATH variable. I'd like to make a case for including this patch as it makes use of schemas/namespaces much easier. There was resistance to including this

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Simon Riggs
On 15 April 2013 21:53, Simon Riggs si...@2ndquadrant.com wrote: So I'll treat this as two separate cases: * add special case for sequences Patch attached. * use the NO SQL mechanism, as described, which implies no reads or writes of database state. We could test that, but its somewhat

Re: [HACKERS] event trigger API documentation?

2013-04-16 Thread Robert Haas
On Mon, Apr 15, 2013 at 11:57 PM, Peter Eisentraut pete...@gmx.net wrote: I'm having trouble finding documentation about how to write event triggers. The chapter in the documentation http://www.postgresql.org/docs/devel/static/event-triggers.html says they can be written in C or supported

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Heikki Linnakangas
On 16.04.2013 14:38, Simon Riggs wrote: On 15 April 2013 21:53, Simon Riggssi...@2ndquadrant.com wrote: So I'll treat this as two separate cases: * add special case for sequences Patch attached. + if (IsA(node, FuncExpr)) + { + FuncExpr *expr = (FuncExpr *)

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Simon Riggs
On 16 April 2013 13:57, Heikki Linnakangas hlinnakan...@vmware.com wrote: You still need to check the args, if the function is nextval, otherwise you incorrectly perform the optimization for something like nextval(myvolatilefunc()). Guess so. At least its an easy change. Thanks for checking.

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Bruce Momjian
On Tue, Apr 16, 2013 at 02:37:33PM +0100, Simon Riggs wrote: On 16 April 2013 13:57, Heikki Linnakangas hlinnakan...@vmware.com wrote: You still need to check the args, if the function is nextval, otherwise you incorrectly perform the optimization for something like

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Simon Riggs
On 9 April 2013 03:35, Ants Aasma a...@cybertec.at wrote: On Fri, Apr 5, 2013 at 9:39 PM, Ants Aasma a...@cybertec.at wrote: Unless somebody tells me not to waste my time I'll go ahead and come up with a workable patch by Monday. And here you go. I decided to be verbose with the comments as

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I found Simon's nextval()/COPY timings without this patch sobering. I assume he can apply this for 9.3, right? I believe it is a fix for a new 9.3 feature. It is not a fix, it is not for a 9.3 feature (the multi-insert thing went in in 9.2), and

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Bruce Momjian
On Tue, Apr 16, 2013 at 10:07:07AM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I found Simon's nextval()/COPY timings without this patch sobering. I assume he can apply this for 9.3, right? I believe it is a fix for a new 9.3 feature. It is not a fix, it is not for a

Re: [HACKERS] COPY and Volatile default expressions

2013-04-16 Thread Simon Riggs
On 16 April 2013 15:07, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: I found Simon's nextval()/COPY timings without this patch sobering. I assume he can apply this for 9.3, right? I believe it is a fix for a new 9.3 feature. It is not a fix, it is not for a 9.3

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Greg Stark
On Fri, Apr 12, 2013 at 9:42 PM, Simon Riggs si...@2ndquadrant.com wrote: * WAL checksum is not used as the sole basis for end-of-WAL discovery. We reuse the WAL files, so the prev field in each WAL record shows what the previous end of WAL was. Hence if the WAL checksums give a false positive

Re: [HACKERS] event trigger API documentation?

2013-04-16 Thread Peter Eisentraut
On 4/16/13 7:49 AM, Robert Haas wrote: On Mon, Apr 15, 2013 at 11:57 PM, Peter Eisentraut pete...@gmx.net wrote: I'm having trouble finding documentation about how to write event triggers. The chapter in the documentation http://www.postgresql.org/docs/devel/static/event-triggers.html says

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Tom Lane
Greg Stark st...@mit.edu writes: On Fri, Apr 12, 2013 at 9:42 PM, Simon Riggs si...@2ndquadrant.com wrote: * WAL checksum is not used as the sole basis for end-of-WAL discovery. We reuse the WAL files, so the prev field in each WAL record shows what the previous end of WAL was. Hence if the

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Simon Riggs
On 16 April 2013 20:27, Tom Lane t...@sss.pgh.pa.us wrote: Greg Stark st...@mit.edu writes: On Fri, Apr 12, 2013 at 9:42 PM, Simon Riggs si...@2ndquadrant.com wrote: * WAL checksum is not used as the sole basis for end-of-WAL discovery. We reuse the WAL files, so the prev field in each WAL

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Florian Pflug
On Apr13, 2013, at 17:14 , Ants Aasma a...@cybertec.at wrote: Based on current analysis, it is particularly good at detecting single bit errors, as good at detecting burst errors as can be expected from 16 bits and not horrible at detecting burst writes of zeroes. It is quite bad at detecting

Re: [HACKERS] [GENERAL] currval and DISCARD ALL

2013-04-16 Thread Bruce Momjian
On Tue, Apr 16, 2013 at 12:13:48PM -0700, Adrian Klaver wrote: On 04/16/2013 08:07 AM, Nigel Heron wrote: On 04/15/2013 05:57 PM, Adrian Klaver wrote: On 04/15/2013 02:42 PM, Nigel Heron wrote: Hi, is there a way to clear the session state of sequence values fetched by currval(regclass)?

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Ants Aasma
On Tue, Apr 16, 2013 at 5:05 PM, Simon Riggs si...@2ndquadrant.com wrote: On 9 April 2013 03:35, Ants Aasma a...@cybertec.at wrote: On Fri, Apr 5, 2013 at 9:39 PM, Ants Aasma a...@cybertec.at wrote: Unless somebody tells me not to waste my time I'll go ahead and come up with a workable patch

Re: [HACKERS] [GENERAL] currval and DISCARD ALL

2013-04-16 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I think his point is why don't we clear currval() on DISCARD ALL? I can't think of a good reason we don't. Because we'd have to invent a new suboperation DISCARD SEQUENCES, for one thing, in order to be consistent. I'd rather ask why it's important that

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Tom Lane
Ants Aasma a...@cybertec.at writes: On Tue, Apr 16, 2013 at 5:05 PM, Simon Riggs si...@2ndquadrant.com wrote: My only review comments are to ask for some explanation of the magic numbers... The specific values used are mostly magic to me too. As mentioned in a short sentence in the patch,

Re: [HACKERS] [GENERAL] currval and DISCARD ALL

2013-04-16 Thread Fabrízio de Royes Mello
On Tue, Apr 16, 2013 at 6:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: [...] Or, if you'd rather a more direct answer: wanting this sounds like evidence of bad application design. Why is your app dependent on getting failures from currval, and isn't there a better way to do it? The sequence

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Ants Aasma
On Tue, Apr 16, 2013 at 11:20 PM, Florian Pflug f...@phlo.org wrote: On Apr13, 2013, at 17:14 , Ants Aasma a...@cybertec.at wrote: Based on current analysis, it is particularly good at detecting single bit errors, as good at detecting burst errors as can be expected from 16 bits and not

Re: [HACKERS] PROPOSAL: tracking aggregated numbers from pg_stat_database

2013-04-16 Thread Greg Smith
On 4/13/13 12:44 PM, Tomas Vondra wrote: I'm currently struggling with (quite uncommon) deployments where databases are created/dropped regularly (not to mention tables and indexes), and it's surprisingly difficult to process such stats to get reasonable values. Yes, it's a pain. If you

[HACKERS] Change to pg_test_fsync output

2013-04-16 Thread Bruce Momjian
I propose the attached patch to change pg_test_fsync's output from microsecs to usecs, which is the designation we use in other places. Also remove parentheses, e.g. 1 * 16kB open_sync write8012.933 ops/sec 125 usecs/op 2 * 8kB open_sync writes 5399.901

Re: [HACKERS] Enabling Checksums

2013-04-16 Thread Florian Pflug
On Apr16, 2013, at 23:41 , Ants Aasma a...@cybertec.at wrote: On Tue, Apr 16, 2013 at 11:20 PM, Florian Pflug f...@phlo.org wrote: On Apr13, 2013, at 17:14 , Ants Aasma a...@cybertec.at wrote: Based on current analysis, it is particularly good at detecting single bit errors, as good at

[HACKERS] ancient sequence point bug

2013-04-16 Thread Peter Eisentraut
This code in bootstrap.c contains a sequence point violation (or whatever that is really called): while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL) { (*app)-am_oid = HeapTupleGetOid(tup); memmove((char *) (*app++)-am_typ,

Re: [HACKERS] ancient sequence point bug

2013-04-16 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: This code in bootstrap.c contains a sequence point violation (or whatever that is really called): while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL) { (*app)-am_oid = HeapTupleGetOid(tup);

Re: [HACKERS] ancient sequence point bug

2013-04-16 Thread Dann Corbit
-Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tom Lane Sent: Tuesday, April 16, 2013 7:52 PM To: Peter Eisentraut Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] ancient sequence point bug Peter Eisentraut

[HACKERS] TODO links broken?

2013-04-16 Thread Stephen Scheck
Hello, Many of the links in the TODO wiki page result in a page not found error. Is this page up-to-date? Can anything be inferred about the status of these items from the broken link? Thanks. http://wiki.postgresql.org/wiki/Todo